Hi! Some of those patches have been pending for a while sleeping in my branches.
About gdi_handlers, I have no idea why the code was using an extern in the first place. Perhaps because of some weird Windows library reason? The most important changes is the move of ssl verification code in a common/ssl_verify.c. This probably need careful examination before being applied. It has been tested only with subject and host method, since pubkey method is being used only during seamless migration with a protocol > 1. And I can't find a qemu/spice combination that would do that. Happy review, cheers Marc-André Lureau (9): build: make it silent build: require c99 common: RFC: add windows.h where required, make gdi_handlers static common: ring.h should include stddef for NULL usage common: ring.h: define ASSERT if undefined common: spice_memdup could accept NULL common: add ring_get_length() for debugging purposes common: add ssl_verify.c common code client: make use of ssl_verify.c client/application.cpp | 20 ++- client/red_client.cpp | 2 +- client/red_peer.cpp | 374 ++--------------------------------- client/red_peer.h | 17 +-- client/windows/platform.cpp | 1 - common/Makefile.am | 2 + common/canvas_base.h | 3 + common/canvas_utils.c | 2 +- common/canvas_utils.h | 4 + common/mem.c | 4 + common/ring.h | 20 ++ common/ssl_verify.c | 458 +++++++++++++++++++++++++++++++++++++++++++ common/ssl_verify.h | 54 +++++ configure.ac | 6 + 14 files changed, 588 insertions(+), 379 deletions(-) create mode 100644 common/ssl_verify.c create mode 100644 common/ssl_verify.h -- 1.7.3.4 _______________________________________________ Spice-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/spice-devel
