[ovmf test] 184366: all pass - PUSHED

2024-01-15 Thread osstest service owner
flight 184366 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184366/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 682a5ed1a229443a259da2df9f961a0448071e3e baseline version: ovmf 7c2757c298b40f5d7bad8

[linux-linus test] 184359: regressions - FAIL

2024-01-15 Thread osstest service owner
flight 184359 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184359/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd broken in 184351 test-arm64-arm64-xl-credit1 12

Re: [PATCH] x86/xen: Fix some null pointer dereference issues in smp.c

2024-01-15 Thread kernel test robot
-base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kunwu-Chan/x86-xen-Fix-some-null-pointer-dereference-issues-in-smp-c/20240115-180429 base: tip/x86/core patch link: https://lore.ke

Thunderbolt (and other PCI hotplug) isolation

2024-01-15 Thread Marek Marczykowski-Górecki
Hi, A little background: In Qubes OS we try to isolate external (especially hot pluggable) devices as much as possible. For PCI devices, we do PCI passthrough to dedicated domains (sys-net, sys-usb - mostly the latter). The goal is to prevent unauthorized device to compromise the whole system, esp

[xen-unstable test] 184358: tolerable FAIL - PUSHED

2024-01-15 Thread osstest service owner
flight 184358 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184358/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184347 test-amd64-amd64-xl-qemut-win7-amd64

Re: E820 memory allocation issue on Threadripper platforms

2024-01-15 Thread Patrick Plenefisch
I managed to set up serial access and saved the output with the requested flags as the attached logs Patrick On Thu, Jan 11, 2024 at 5:13 AM Juergen Gross wrote: > On 11.01.24 09:37, Jan Beulich wrote: > > On 11.01.2024 03:29, Patrick Plenefisch wrote: > >> Hi, > >> > >> I ran into a memory all

[xen-unstable-smoke test] 184363: tolerable all pass - PUSHED

2024-01-15 Thread osstest service owner
flight 184363 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184363/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 184364: all pass - PUSHED

2024-01-15 Thread osstest service owner
flight 184364 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184364/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7c2757c298b40f5d7bad8da3faff7bb9c47ce2ae baseline version: ovmf 82e149f2bf796a5a0492d

[ovmf test] 184361: all pass - PUSHED

2024-01-15 Thread osstest service owner
flight 184361 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184361/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 82e149f2bf796a5a0492d764897ada261d266653 baseline version: ovmf 195e59bd0c60523caa415

[PATCH v12.2 09/15] vpci/header: program p2m with guest BAR view

2024-01-15 Thread Stewart Hildebrand
From: Oleksandr Andrushchenko Take into account guest's BAR view and program its p2m accordingly: gfn is guest's view of the BAR and mfn is the physical BAR value. This way hardware domain sees physical BAR values and guest sees emulated ones. Hardware domain continues getting the BARs identity

[PATCH v12.2 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-15 Thread Stewart Hildebrand
From: Oleksandr Andrushchenko Use the per-domain PCI read/write lock to protect the presence of the pci device vpci field. This lock can be used (and in a few cases is used right away) so that vpci removal can be performed while holding the lock in write mode. Previously such removal could race w

Re: [PATCH 0/2] xen/arm: head: early printk on 1:1 mapping

2024-01-15 Thread Julien Grall
Hi Michal, On 15/01/2024 12:48, Michal Orzel wrote: This series is a follow up to 1ec3fe1f664f ("xen/arm32: head: Improve logging in head.S"). Michal Orzel (2): xen/arm32: head: Move earlyprintk 'hex' to .rodata.idmap xen/arm64: head: Allow to use early printk while on 1:1 mapping This

Re: [PATCH 2/2] xen/arm64: head: Allow to use early printk while on 1:1 mapping

2024-01-15 Thread Julien Grall
Hi Michal, On 15/01/2024 12:48, Michal Orzel wrote: Take an example from commit 1ec3fe1f664f ("xen/arm32: head: Improve logging in head.S") to add support for printing early boot messages while running on identity mapping: - define PRINT_SECT() macro to be able to specify a section for storing

Re: [PATCH v12 09/15] vpci/header: program p2m with guest BAR view

2024-01-15 Thread Stewart Hildebrand
On 1/15/24 04:07, Jan Beulich wrote: > On 12.01.2024 16:06, Roger Pau Monné wrote: >> On Tue, Jan 09, 2024 at 04:51:24PM -0500, Stewart Hildebrand wrote: >>> From: Oleksandr Andrushchenko >>> +/* >>> + * Make sure that the guest set address has the same page offset >>> + *

Re: [PATCH 1/2] xen/arm32: head: Move earlyprintk 'hex' to .rodata.idmap

2024-01-15 Thread Julien Grall
Hi Michal, On 15/01/2024 12:48, Michal Orzel wrote: Thanks to 1ec3fe1f664f ("xen/arm32: head: Improve logging in head.S"), we can now use PRINT_ID() macro to print messages when running on identity mapping. For that, all the strings need to be part of the first page that is mapped. This is not t

Re: [PATCH v3 22/34] xen/riscv: introduce regs.h

2024-01-15 Thread Jan Beulich
On 22.12.2023 16:13, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko > --- > Changes in V3: > - update the commit message > - add Acked-by: Jan Beulich I see none above the --- marker. Jan

Re: [PATCH v3 14/34] xen/riscv: introduce io.h

2024-01-15 Thread Jan Beulich
On 22.12.2023 16:12, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/io.h > @@ -0,0 +1,142 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * {read,write}{b,w,l,q} based on arch/arm64/include/asm/io.h > + * which was based on arch/arm/include/io.h > + * > + *

Re: HWP vs "xenpm get-cpufreq-..."

2024-01-15 Thread Jan Beulich
On 15.01.2024 17:45, Jason Andryuk wrote: > On Mon, Jan 15, 2024 at 11:04 AM Jan Beulich wrote: >> I thought I'd try hwp on a SapphireRapids system, and of course - short >> of easy other ways of seeing whether it actually has any apparent >> effect - I've looked at "xenpm get-cpufreq-states" outp

Re: HWP vs "xenpm get-cpufreq-..."

2024-01-15 Thread Jason Andryuk
Hi Jan, On Mon, Jan 15, 2024 at 11:04 AM Jan Beulich wrote: > > Jason, > > I thought I'd try hwp on a SapphireRapids system, and of course - short > of easy other ways of seeing whether it actually has any apparent > effect - I've looked at "xenpm get-cpufreq-states" output. Just to find > that a

Re: [PATCH v3 10/34] xen/riscv: introduce bitops.h

2024-01-15 Thread Jan Beulich
On 22.12.2023 16:12, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/bitops.h > @@ -0,0 +1,267 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* Copyright (C) 2012 Regents of the University of California */ > + > +#ifndef _ASM_RISCV_BITOPS_H > +#define _ASM_RISCV_BITOPS_

Re: [PATCH v5 13/13] xen/arm: add cache coloring support for Xen

2024-01-15 Thread Julien Grall
On 15/01/2024 15:43, Carlo Nonato wrote: Hi Julien, Hi Carlo, On Mon, Jan 15, 2024 at 12:18 PM Julien Grall wrote: On 15/01/2024 10:11, Carlo Nonato wrote: I understand what you're talking about, and it seems reasonable to get rid of xen_colored_temp[] and create_llc_coloring_mappings()

Re: [PATCH] cpufreq: finish genapic conversion to altcall

2024-01-15 Thread Andrew Cooper
On 15/01/2024 4:10 pm, Jan Beulich wrote: > Even functions used on infrequently executed paths want converting: This > way all pre-filled struct cpufreq_driver instances can become > __initconst_cf_clobber, thus allowing to eliminate another 15 ENDBR > during the 2nd phase of alternatives patching.

[PATCH] cpufreq: finish genapic conversion to altcall

2024-01-15 Thread Jan Beulich
Even functions used on infrequently executed paths want converting: This way all pre-filled struct cpufreq_driver instances can become __initconst_cf_clobber, thus allowing to eliminate another 15 ENDBR during the 2nd phase of alternatives patching. For acpi-cpufreq's optionally populated .get hoo

Re: [PATCH] x86/APIC: finish genapic conversion to altcall

2024-01-15 Thread Andrew Cooper
On 15/01/2024 4:08 pm, Jan Beulich wrote: > While .probe() doesn't need fiddling with for being run only very early, > init_apic_ldr() wants converting too despite not being on a frequently > executed path: This way all pre-filled struct genapic instances can > become __initconst_cf_clobber, thus a

[PATCH] x86/APIC: finish genapic conversion to altcall

2024-01-15 Thread Jan Beulich
While .probe() doesn't need fiddling with for being run only very early, init_apic_ldr() wants converting too despite not being on a frequently executed path: This way all pre-filled struct genapic instances can become __initconst_cf_clobber, thus allowing to eliminate 15 more ENDBR during the 2nd

HWP vs "xenpm get-cpufreq-..."

2024-01-15 Thread Jan Beulich
Jason, I thought I'd try hwp on a SapphireRapids system, and of course - short of easy other ways of seeing whether it actually has any apparent effect - I've looked at "xenpm get-cpufreq-states" output. Just to find that according to this, the system never enters any of the designated Pn states (

Re: [PATCH v5 13/13] xen/arm: add cache coloring support for Xen

2024-01-15 Thread Carlo Nonato
Hi Julien, On Mon, Jan 15, 2024 at 12:18 PM Julien Grall wrote: > On 15/01/2024 10:11, Carlo Nonato wrote: > > Hi Julien, > > Hi Carlo, > > > On Sun, Jan 14, 2024 at 8:22 PM Julien Grall wrote: > >> > >> Hi Carlo, > >> > >> On 13/01/2024 17:07, Carlo Nonato wrote: > > diff --git a/xen/arch/a

Re: [PATCH v12.1 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-15 Thread Stewart Hildebrand
On 1/15/24 03:58, Jan Beulich wrote: > On 12.01.2024 19:14, Stewart Hildebrand wrote: >> From: Oleksandr Andrushchenko >> >> Use the per-domain PCI read/write lock to protect the presence of the >> pci device vpci field. This lock can be used (and in a few cases is used >> right away) so that vpci

Re: [PATCH v3 00/33] tools: enable xenstore-stubdom to use 9pfs

2024-01-15 Thread Anthony PERARD
On Fri, Jan 05, 2024 at 03:20:11PM +, Andrew Cooper wrote: > On 04/01/2024 9:00 am, Juergen Gross wrote: > > tools: add a new xen logging daemon > > tools/xenlogd: connect to frontend > > tools/xenlogd: add transport layer > > tools/xenlogd: add 9pfs response generation support > > to

Re: [PATCH v3 16/33] tools/libs/light: add backend type for 9pfs PV devices

2024-01-15 Thread Anthony PERARD
On Thu, Jan 04, 2024 at 10:00:38AM +0100, Juergen Gross wrote: > +static void libxl__device_p9_add(libxl__egc *egc, uint32_t domid, > + libxl_device_p9 *p9, > + libxl__ao_device *aodev) > +{ > +int rc; Can you make a copy of `p9`

Re: [PATCH v3 21/33] tools: add 9pfs device to xenstore-stubdom

2024-01-15 Thread Anthony PERARD
On Thu, Jan 04, 2024 at 10:00:43AM +0100, Juergen Gross wrote: > Add a 9pfs device to Xenstore stubdom in order to allow it to do e.g. > logging into a dom0 file. > > Use the following parameters for the new device: > > - tag = "xen" Is it ok to have here tag "xen" when the default tag is "Xen"

Re: [PATCH] osstest: bump /boot partition to 1G

2024-01-15 Thread Roger Pau Monné
On Mon, Jan 15, 2024 at 03:08:19PM +, Anthony PERARD wrote: > On Mon, Jan 15, 2024 at 03:18:37PM +0100, Roger Pau Monne wrote: > > Increase the size of the boot partition, as arm64 initrd is already > > exhausting > > all the space: > > > > update-initramfs: Generating /boot/initrd.img-6.7.0+

Re: [PATCH v3 17/33] tools/xl: support new 9pfs backend xen-9pfsd

2024-01-15 Thread Anthony PERARD
On Thu, Jan 04, 2024 at 10:00:39AM +0100, Juergen Gross wrote: > @@ -2242,6 +2256,28 @@ void parse_config_data(const char *config_source, > > libxl_string_list_dispose(&pairs); > > +if (p9->type == LIBXL_P9_TYPE_UNKNOWN) { > +p9->type = LIBXL_P9_TYPE_QEM

Re: [PATCH v12 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-15 Thread Stewart Hildebrand
On 1/15/24 03:53, Roger Pau Monné wrote: > On Fri, Jan 12, 2024 at 12:54:56PM -0500, Stewart Hildebrand wrote: >> On 1/12/24 08:48, Roger Pau Monné wrote: >>> On Tue, Jan 09, 2024 at 04:51:16PM -0500, Stewart Hildebrand wrote: @@ -202,8 +204,20 @@ static int __init apply_map(struct domain *d,

Re: [PATCH] osstest: bump /boot partition to 1G

2024-01-15 Thread Anthony PERARD
On Mon, Jan 15, 2024 at 03:18:37PM +0100, Roger Pau Monne wrote: > Increase the size of the boot partition, as arm64 initrd is already exhausting > all the space: > > update-initramfs: Generating /boot/initrd.img-6.7.0+ > gzip: stdout: No space left on device > > Reported-by: Jan Beulich > Signe

Re: [PATCH 11/22] x86: add a boot option to enable and disable the direct map

2024-01-15 Thread Elias El Yandouzi
Hi, On 12/01/2024 07:47, Jan Beulich wrote: On 11.01.2024 19:25, Elias El Yandouzi wrote: On 11/01/2024 14:09, Jan Beulich wrote: What about maddr_to_virt()? For instance, in the function xen/arch/x86/dmi_scan.c:dmi_iterate(), we need to access a very low machine address which isn't in the dir

[PATCH v5 8/8] common: honor CONFIG_CC_SPLIT_SECTIONS also for assembly functions

2024-01-15 Thread Jan Beulich
Leverage the new infrastructure in xen/linkage.h to also switch to per- function sections (when configured), deriving the specific name from the "base" section in use at the time FUNC() is invoked. Signed-off-by: Jan Beulich --- TBD: Since we use .subsection in UNLIKELY_START(), a perhaps not rea

[linux-linus test] 184351: regressions - trouble: blocked/broken/fail/pass

2024-01-15 Thread osstest service owner
flight 184351 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/184351/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-vhd broken build-arm64-pvops 6 kernel-bui

[PATCH v5 7/8] tools/binfile: switch to common annotations model

2024-01-15 Thread Jan Beulich
Use DATA() / END() and drop the now redundant .global. No change in generated data; of course the two symbols now properly gain "hidden" binding. Signed-off-by: Jan Beulich Reviewed-by: Julien Grall --- v3: New. --- a/xen/tools/binfile +++ b/xen/tools/binfile @@ -29,15 +29,10 @@ cat <$target

[PATCH v5 6/8] PPC: switch entry point annotations to common model

2024-01-15 Thread Jan Beulich
Use the generic framework in xen/linkage.h. No change in generated code except of course the converted symbols change to be hidden ones. Signed-off-by: Jan Beulich --- v5: Re-base. v4: Also drop #undef-s from linker script. Re-base. v3: New. --- a/xen/arch/ppc/include/asm/asm-defns.h +++ b/xen/a

[PATCH v5 5/8] RISC-V: annotate entry points with type and size

2024-01-15 Thread Jan Beulich
Use the generic framework in xen/linkage.h. No change in generated code except of course the converted symbols change to be hidden ones and gain a valid size. Signed-off-by: Jan Beulich --- Probably count_args_exp() should move to macros.h, but I first wanted to see whether anyone can suggest any

[PATCH v5 4/8] Arm: annotate entry points with type and size

2024-01-15 Thread Jan Beulich
Use the generic framework in xen/linkage.h. No change in generated code except for the changed padding value (noticable when config.gz isn't a multiple of 4 in size). Plus of course the converted symbols change to be hidden ones. Note that ASM_INT() is switched to DATA(), not DATA_LOCAL(), as the

[PATCH v5 3/8] x86: also mark assembler globals hidden

2024-01-15 Thread Jan Beulich
Let's have assembler symbols be consistent with C ones. In principle there are (a few) cases where gas can produce smaller code this way, just that for now there's a gas bug causing smaller code to be emitted even when that shouldn't be the case. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau

[PATCH v5 2/8] x86: annotate entry points with type and size

2024-01-15 Thread Jan Beulich
Use the generic framework in xen/linkage.h. For switch_to_kernel() and restore_all_guest() so far implicit alignment (from being first in their respective sections) is being made explicit (as in: using FUNC() without 2nd argument). Whereas for {,compat}create_bounce_frame() and autogen_entrypoints

[PATCH v5 1/8] common: assembly entry point type/size annotations

2024-01-15 Thread Jan Beulich
Recent gas versions generate minimalistic Dwarf debug info for items annotated as functions and having their sizes specified [1]. Furthermore generating live patches wants items properly annotated. "Borrow" Arm's END() and (remotely) derive other annotation infrastructure from Linux'es, for all arc

[PATCH v5 0/8] annotate entry points with type and size

2024-01-15 Thread Jan Beulich
The model introduced in patch 1 is now arch-agnostic, and all arch-es are being switched at least partly (to at least give examples of how things will look like); PPC and RISC-V are still small enough to switch completely in one go. 1: common: assembly entry point type/size annotations 2: x86: ann

[xen-unstable-smoke test] 184355: tolerable all pass - PUSHED

2024-01-15 Thread osstest service owner
flight 184355 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/184355/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH] osstest: bump /boot partition to 1G

2024-01-15 Thread Roger Pau Monne
Increase the size of the boot partition, as arm64 initrd is already exhausting all the space: update-initramfs: Generating /boot/initrd.img-6.7.0+ gzip: stdout: No space left on device Reported-by: Jan Beulich Signed-off-by: Roger Pau Monné --- Osstest.pm | 2 +- 1 file changed, 1 insertion(+)

[ovmf test] 184356: all pass - PUSHED

2024-01-15 Thread osstest service owner
flight 184356 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184356/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 195e59bd0c60523caa415f429517e46ff7065600 baseline version: ovmf d65b183f92446a3a2855c

[PATCH 0/2] xen/arm: head: early printk on 1:1 mapping

2024-01-15 Thread Michal Orzel
This series is a follow up to 1ec3fe1f664f ("xen/arm32: head: Improve logging in head.S"). Michal Orzel (2): xen/arm32: head: Move earlyprintk 'hex' to .rodata.idmap xen/arm64: head: Allow to use early printk while on 1:1 mapping xen/arch/arm/arm32/head.S | 2 +- xen/arch/arm/

[PATCH 1/2] xen/arm32: head: Move earlyprintk 'hex' to .rodata.idmap

2024-01-15 Thread Michal Orzel
Thanks to 1ec3fe1f664f ("xen/arm32: head: Improve logging in head.S"), we can now use PRINT_ID() macro to print messages when running on identity mapping. For that, all the strings need to be part of the first page that is mapped. This is not the case for a 'hex' string (used by asm_putn when print

[PATCH 2/2] xen/arm64: head: Allow to use early printk while on 1:1 mapping

2024-01-15 Thread Michal Orzel
Take an example from commit 1ec3fe1f664f ("xen/arm32: head: Improve logging in head.S") to add support for printing early boot messages while running on identity mapping: - define PRINT_SECT() macro to be able to specify a section for storing a string. PRINT() will use .rodata.str and PRINT_ID(

Re: [PATCH v2 1/2] xen/x86: io_apic: Introduce a command line option to skip timer check

2024-01-15 Thread Roger Pau Monné
On Thu, Jan 04, 2024 at 09:54:30AM +0100, Jan Beulich wrote: > On 02.01.2024 20:09, Julien Grall wrote: > > Hi Jan, > > > > On 14/12/2023 10:35, Jan Beulich wrote: > >> On 14.12.2023 11:14, Julien Grall wrote: > >>> On 14/12/2023 10:10, Jan Beulich wrote: > On 11.12.2023 13:23, Julien Grall w

[xen-unstable test] 184347: tolerable FAIL

2024-01-15 Thread osstest service owner
flight 184347 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/184347/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 184343 test-amd64-amd64-xl-qemut-win7-amd64

Re: [PATCH] CirrusCI: drop FreeBSD 12

2024-01-15 Thread Roger Pau Monné
On Mon, Jan 15, 2024 at 12:37:39PM +0100, Jan Beulich wrote: > On 15.01.2024 12:20, Roger Pau Monné wrote: > > On Mon, Jan 15, 2024 at 11:01:54AM +, Andrew Cooper wrote: > >> On 15/01/2024 10:27 am, Roger Pau Monne wrote: > >>> Went EOL by the end of December 2023, and the pkg repos have been s

[ovmf test] 184352: all pass - PUSHED

2024-01-15 Thread osstest service owner
flight 184352 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184352/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d65b183f92446a3a2855c1c7dd4a7a1b760af381 baseline version: ovmf 6a01fb2ea5b3b142a98f3

Re: [PATCH v4] x86/intel: ensure Global Performance Counter Control is setup correctly

2024-01-15 Thread Jan Beulich
On 12.01.2024 12:09, Roger Pau Monne wrote: > When Architectural Performance Monitoring is available, the PERF_GLOBAL_CTRL > MSR contains per-counter enable bits that is ANDed with the enable bit in the > counter EVNTSEL MSR in order for a PMC counter to be enabled. > > So far the watchdog code se

Re: [PATCH v12 11/15] vpci: add initial support for virtual PCI bus topology

2024-01-15 Thread George Dunlap
On Fri, Jan 12, 2024 at 1:50 PM Stewart Hildebrand wrote: > > On 1/12/24 06:46, George Dunlap wrote: > > On Tue, Jan 9, 2024 at 9:54 PM Stewart Hildebrand > > wrote: > >> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h > >> index 37f5922f3206..b58a822847be 100644 > >> --- a/xen/inc

Re: [PATCH] CirrusCI: drop FreeBSD 12

2024-01-15 Thread Jan Beulich
On 15.01.2024 12:20, Roger Pau Monné wrote: > On Mon, Jan 15, 2024 at 11:01:54AM +, Andrew Cooper wrote: >> On 15/01/2024 10:27 am, Roger Pau Monne wrote: >>> Went EOL by the end of December 2023, and the pkg repos have been shut down. >>> >>> Reported-by: Andrew Cooper >>> Signed-off-by: Roge

Re: [PATCH] CirrusCI: drop FreeBSD 12

2024-01-15 Thread Roger Pau Monné
On Mon, Jan 15, 2024 at 11:01:54AM +, Andrew Cooper wrote: > On 15/01/2024 10:27 am, Roger Pau Monne wrote: > > Went EOL by the end of December 2023, and the pkg repos have been shut down. > > > > Reported-by: Andrew Cooper > > Signed-off-by: Roger Pau Monné > > Acked-by: Andrew Cooper > >

Re: [PATCH v5 13/13] xen/arm: add cache coloring support for Xen

2024-01-15 Thread Julien Grall
On 15/01/2024 10:11, Carlo Nonato wrote: Hi Julien, Hi Carlo, On Sun, Jan 14, 2024 at 8:22 PM Julien Grall wrote: Hi Carlo, On 13/01/2024 17:07, Carlo Nonato wrote: diff --git a/xen/arch/arm/mmu/setup.c b/xen/arch/arm/mmu/setup.c index 37b6d230ad..66b674eeab 100644 --- a/xen/arch/arm/

Re: [XEN PATCH v2] xen/arm: ffa: reclaim shared memory on guest destroy

2024-01-15 Thread Bertrand Marquis
Hi Jens, Very sorry for the long delay. > On 13 Dec 2023, at 12:25, Jens Wiklander wrote: > > When an FF-A enabled guest is destroyed it may leave behind memory > shared with SPs. This memory must be reclaimed before it's reused or an > SP may make changes to memory used by a new unrelated gues

Re: [PATCH v5 09/13] xen: add cache coloring allocator for domains

2024-01-15 Thread Carlo Nonato
Hi Jan, On Tue, Jan 9, 2024 at 11:28 AM Jan Beulich wrote: > > On 02.01.2024 10:51, Carlo Nonato wrote: > > This commit adds a new memory page allocator that implements the cache > > coloring mechanism. The allocation algorithm enforces equal frequency > > distribution of cache partitions, follow

Re: [PATCH v5 02/13] xen/arm: add cache coloring initialization

2024-01-15 Thread Carlo Nonato
Hi Julien, On Thu, Jan 11, 2024 at 11:44 AM Julien Grall wrote: > On 11/01/2024 10:17, Carlo Nonato wrote: > > Hi Julien, > > Hi Carlo, > > +bool __init llc_coloring_init(void) > +{ > +if ( !llc_way_size && !(llc_way_size = get_llc_way_size()) ) > +{ > +pr

Re: [PATCH] CirrusCI: drop FreeBSD 12

2024-01-15 Thread Andrew Cooper
On 15/01/2024 10:27 am, Roger Pau Monne wrote: > Went EOL by the end of December 2023, and the pkg repos have been shut down. > > Reported-by: Andrew Cooper > Signed-off-by: Roger Pau Monné Acked-by: Andrew Cooper We'll need to backport this, I guess ?

Re: [PATCH v3 21/34] xen/riscv: introduce p2m.h

2024-01-15 Thread Jan Beulich
On 15.01.2024 11:35, Oleksii wrote: > Hi Julien, > > On Fri, 2024-01-12 at 10:39 +, Julien Grall wrote: >> Hi Oleksii, >> >> On 22/12/2023 15:13, Oleksii Kurochko wrote: >>> Signed-off-by: Oleksii Kurochko >>> --- >>> Changes in V3: >>>   - add SPDX >>>   - drop unneeded for now p2m types. >>

[PATCH v3] x86/hvm: don't expose XENFEAT_hvm_pirqs by default

2024-01-15 Thread Roger Pau Monne
The HVM pirq feature allows routing interrupts from both physical and emulated devices over event channels, this was done a performance improvement. However its usage is fully undocumented, and the only reference implementation is in Linux. It defeats the purpose of local APIC hardware virtualiza

Re: [PATCH v3 31/34] xen/riscv: add minimal stuff to mm.h to build full Xen

2024-01-15 Thread Oleksii
On Thu, 2024-01-11 at 17:43 +0100, Jan Beulich wrote: > On 22.12.2023 17:32, Oleksii wrote: > > > +#define PFN_ORDER(_pfn) ((_pfn)->v.free.order) > > I missed saving these changes. It should be _pfn -> pfn_. (Just a > > reminder for me). > > And what purpose would the trailing underscore serve her

Re: [PATCH v3 21/34] xen/riscv: introduce p2m.h

2024-01-15 Thread Oleksii
Hi Julien, On Fri, 2024-01-12 at 10:39 +, Julien Grall wrote: > Hi Oleksii, > > On 22/12/2023 15:13, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V3: > >   - add SPDX > >   - drop unneeded for now p2m types. > >   - return false in all functions implemen

[PATCH] CirrusCI: drop FreeBSD 12

2024-01-15 Thread Roger Pau Monne
Went EOL by the end of December 2023, and the pkg repos have been shut down. Reported-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- .cirrus.yml | 6 -- 1 file changed, 6 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 385618c394ea..d0a9021a77e4 100644 --- a/.cirrus.yml +++

Re: [PATCH v5 13/13] xen/arm: add cache coloring support for Xen

2024-01-15 Thread Carlo Nonato
Hi Julien, On Sun, Jan 14, 2024 at 8:22 PM Julien Grall wrote: > > Hi Carlo, > > On 13/01/2024 17:07, Carlo Nonato wrote: > >>> diff --git a/xen/arch/arm/mmu/setup.c b/xen/arch/arm/mmu/setup.c > >>> index 37b6d230ad..66b674eeab 100644 > >>> --- a/xen/arch/arm/mmu/setup.c > >>> +++ b/xen/arch/arm/

Re: [PATCH v3 21/34] xen/riscv: introduce p2m.h

2024-01-15 Thread Oleksii
On Thu, 2024-01-11 at 17:11 -0600, Shawn Anastasio wrote: > Hi Oleksii, > > On 12/22/23 9:13 AM, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V3: > >  - add SPDX > >  - drop unneeded for now p2m types. > >  - return false in all functions implemented with BUG

Re: [PATCH 2/2] xen/dm: arm: Introduce inject_msi2 DM op

2024-01-15 Thread Jan Beulich
On 14.01.2024 11:01, Mykyta Poturai wrote: > Add the second version of inject_msi DM op, which allows to specify > the source_id of an MSI interrupt. This is needed for correct MSI > injection on ARM. > > It would not be safe to include the source_id in the original inject_msi > in the pad field,

Re: [PATCH v3 12/34] xen/riscv: introduce smp.h

2024-01-15 Thread Oleksii
On Thu, 2024-01-11 at 17:36 +0100, Jan Beulich wrote: > On 22.12.2023 16:12, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V3: > >  - drop cpu_is_offline() as it was moved to xen/smp.h. > > Hmm. > > >  - add SPDX. > >  - drop unnessary #ifdef. > >  - fix "No

Re: [PATCH v3 09/34] xen/riscv: introduce system.h

2024-01-15 Thread Oleksii
On Thu, 2024-01-11 at 17:00 +0100, Jan Beulich wrote: > On 22.12.2023 16:12, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/system.h > > @@ -0,0 +1,90 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > + > > +#ifndef _ASM_RISCV_BARRIER_H > > +#define _ASM_RISCV_

Re: [PATCH v3 05/34] xen/riscv: introduce guest_atomics.h

2024-01-15 Thread Oleksii
On Thu, 2024-01-11 at 16:57 +0100, Jan Beulich wrote: > On 22.12.2023 16:12, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko > > --- > > Changes in V3: > >  - update the commit message > > There (still) is none - what is the above about? Missed something. I'll double check during prov

[ovmf test] 184350: all pass - PUSHED

2024-01-15 Thread osstest service owner
flight 184350 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/184350/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6a01fb2ea5b3b142a98f3649b0947268f038f389 baseline version: ovmf f5b91c60ef24eecf5702e

Re: [linux-linus test] 184346: regressions - FAIL

2024-01-15 Thread Jan Beulich
On 15.01.2024 09:39, osstest service owner wrote: > flight 184346 linux-linus real [real] > flight 184349 linux-linus real-retest [real] > http://logs.test-lab.xenproject.org/osstest/logs/184346/ > http://logs.test-lab.xenproject.org/osstest/logs/184349/ > > Regressions :-( > > Tests which did no

Re: [PATCH v12 09/15] vpci/header: program p2m with guest BAR view

2024-01-15 Thread Jan Beulich
On 12.01.2024 16:06, Roger Pau Monné wrote: > On Tue, Jan 09, 2024 at 04:51:24PM -0500, Stewart Hildebrand wrote: >> From: Oleksandr Andrushchenko >> +/* >> + * Make sure that the guest set address has the same page offset >> + * as the physical address on the host or other

Re: [PATCH v12.1 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-15 Thread Jan Beulich
On 12.01.2024 19:14, Stewart Hildebrand wrote: > From: Oleksandr Andrushchenko > > Use the per-domain PCI read/write lock to protect the presence of the > pci device vpci field. This lock can be used (and in a few cases is used > right away) so that vpci removal can be performed while holding the

Re: [PATCH v12 01/15] vpci: use per-domain PCI lock to protect vpci structure

2024-01-15 Thread Roger Pau Monné
On Fri, Jan 12, 2024 at 12:54:56PM -0500, Stewart Hildebrand wrote: > On 1/12/24 08:48, Roger Pau Monné wrote: > > On Tue, Jan 09, 2024 at 04:51:16PM -0500, Stewart Hildebrand wrote: > >> @@ -202,8 +204,20 @@ static int __init apply_map(struct domain *d, const > >> struct pci_dev *pdev, > >>

Re: [PATCH 6/8] IRQ: drop register parameter from handler functions

2024-01-15 Thread Jan Beulich
On 11.01.2024 19:10, Andrew Cooper wrote: > On 11/01/2024 7:35 am, Jan Beulich wrote: >> It's simply not needed anymore. Note how Linux made this change many >> years ago already, in 2.6.19 (late 2006, see [1]). >> >> Signed-off-by: Jan Beulich >> >> [1] >> https://git.kernel.org/pub/scm/linux/ke

Re: [PATCH 5/8] serial: drop serial_[rt]x_interrupt()'s regs parameter

2024-01-15 Thread Jan Beulich
On 11.01.2024 19:07, Andrew Cooper wrote: > On 11/01/2024 7:34 am, Jan Beulich wrote: >> In the the polling functions (ab)using set_irq_regs() is necessary >> to balance the change. > > I have to admit that I don't know what "balance the change" is supposed > to refer to in this context. Maybe ju

[linux-linus test] 184346: regressions - FAIL

2024-01-15 Thread osstest service owner
flight 184346 linux-linus real [real] flight 184349 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/184346/ http://logs.test-lab.xenproject.org/osstest/logs/184349/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run