RE: [PATCH v3] Use EfiACPIReclaimMemory for ESRT

2022-12-08 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT > > Hi, > > >>> Signed-off-by: Demi Marie Obenour > >> > >> Acked-by: Jan Beulich > >> > >>> Should this be included in 4.17? It is a bug fix for a feature new to > >>> 4.

[xen-4.17-testing test] 175096: tolerable FAIL - PUSHED

2022-12-08 Thread osstest service owner
flight 175096 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/175096/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 175079 test-amd64-i386-xl-qemut-win7-am

[linux-linus test] 175094: regressions - FAIL

2022-12-08 Thread osstest service owner
flight 175094 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175094/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 173462 test-arm64-arm64-ex

Re: [PATCH] xen-netback: Remove set but unused variable 'pending_idx'

2022-12-08 Thread Saeed Mahameed
On 09 Dec 11:40, Jiapeng Chong wrote: Variable pending_idx is not effectively used in the function, so delete it. drivers/net/xen-netback/netback.c:886:7: warning: variable ‘pending_idx’ set but not used. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3399 Reported-by: Abaci Robot Signe

[ovmf test] 175101: all pass - PUSHED

2022-12-08 Thread osstest service owner
flight 175101 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175101/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 54d81d06fc165fcb8eb832acd6a7cf644b029549 baseline version: ovmf 8a485e4bb8b5c5a800d6b

[PATCH] xen-netback: Remove set but unused variable 'pending_idx'

2022-12-08 Thread Jiapeng Chong
Variable pending_idx is not effectively used in the function, so delete it. drivers/net/xen-netback/netback.c:886:7: warning: variable ‘pending_idx’ set but not used. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3399 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/ne

[linux-5.4 test] 175092: regressions - FAIL

2022-12-08 Thread osstest service owner
flight 175092 linux-5.4 real [real] flight 175103 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175092/ http://logs.test-lab.xenproject.org/osstest/logs/175103/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: t

[xen-unstable-smoke test] 175102: tolerable all pass - PUSHED

2022-12-08 Thread osstest service owner
flight 175102 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175102/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH] Relocate the ESRT when booting via multiboot2

2022-12-08 Thread Demi Marie Obenour
This was missed in the initial patchset. Signed-off-by: Demi Marie Obenour --- I consider this to be a bug fix, and would prefer this to be included in the 4.17 release series, even though I understand if this is too late for 4.17 itself. xen/arch/x86/efi/efi-boot.h | 2 + xen/common/efi/boot

MISRA C Rule 20.7 disambiguation

2022-12-08 Thread Stefano Stabellini
Hi all, This patch is to start a discussion in regard to rule 20.7 and its interpretation. During the last MISRA C call we discussed that "our" interpretation of the rule means that the following two cases don't need extra parenthesis: #define M(a, b) func(a, b) #define M(a, b) (a) = b Moreover

[PATCH] xen/arm: efi-boot misra rule 4.1 fix

2022-12-08 Thread Stefano Stabellini
We have 3 violations of MISRA C Rule 4.1 ("Octal and hexadecimal escape sequences shall be terminated") in xen/arch/arm/efi/efi-boot.h. Fix them. Signed-off-by: Stefano Stabellini diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index 43a836c3a7..822c0a1462 100644 --- a/xen

Re: [PATCH V7 1/3] libxl: Add support for generic virtio device

2022-12-08 Thread Viresh Kumar
On 08-12-22, 18:06, Anthony PERARD wrote: > Nit: Something like: > const char check[] = "virtio,device"; > const size_t checkl = sizeof(check) - 1; > ... strncmp(tmp, check, checkl)... > (or just strncmp(tmp, check, sizeof(check)-1)) > would avoid issue with both string "virtio,devi

Re: [XEN v1] xen/Arm: Probe the entry point address of an uImage correctly

2022-12-08 Thread Andrew Cooper
On 08/12/2022 18:42, Ayan Kumar Halder wrote: > On 08/12/2022 16:53, Julien Grall wrote: >> On 08/12/2022 15:24, Michal Orzel wrote: >>> So the first issue with Zephyr is that it does not support zImage >>> protocol for arm32. >>> Volodymyr added support only for Image header for arm64 Zephyr. >>>

Re: [XEN v1] xen/Arm: Probe the entry point address of an uImage correctly

2022-12-08 Thread Stefano Stabellini
On Thu, 8 Dec 2022, Ayan Kumar Halder wrote: > On 08/12/2022 16:53, Julien Grall wrote: > > Hi, > Hi, > > > > On 08/12/2022 15:24, Michal Orzel wrote: > > > On 08/12/2022 14:51, Julien Grall wrote: > > > > Caution: This message originated from an External Source. Use proper > > > > caution when op

[xen-unstable test] 175091: tolerable FAIL - PUSHED

2022-12-08 Thread osstest service owner
flight 175091 xen-unstable real [real] flight 175100 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175091/ http://logs.test-lab.xenproject.org/osstest/logs/175100/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armh

[xen-unstable-smoke test] 175095: tolerable all pass - PUSHED

2022-12-08 Thread osstest service owner
flight 175095 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175095/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 175093: all pass - PUSHED

2022-12-08 Thread osstest service owner
flight 175093 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175093/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8a485e4bb8b5c5a800d6b3e1b8fa80fe27afb274 baseline version: ovmf 1c75bf3c21da79b1bc1d5

[xen-4.16-testing test] 175089: regressions - FAIL

2022-12-08 Thread osstest service owner
flight 175089 xen-4.16-testing real [real] flight 175097 xen-4.16-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175089/ http://logs.test-lab.xenproject.org/osstest/logs/175097/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

Re: [GIT PULL] xen: branch for v6.1-rc9b

2022-12-08 Thread pr-tracker-bot
The pull request you sent on Thu, 8 Dec 2022 07:24:04 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-xsa-6.1-rc9b-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/a4c3a07e5b9ffb525435fedd94b5082c928e56dd Thank you! -- Deet-doot-do

Re: [XEN v1] xen/Arm: Probe the entry point address of an uImage correctly

2022-12-08 Thread Ayan Kumar Halder
On 08/12/2022 16:53, Julien Grall wrote: Hi, Hi, On 08/12/2022 15:24, Michal Orzel wrote: On 08/12/2022 14:51, Julien Grall wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Hi, Title extra NIT:

Re: Xen + linux 6.1.0-rc8, network to guest VM not working after commit ad7f402ae4f466647c3a669b8a6f3e5d4271c84a fixing XSA-423

2022-12-08 Thread Sander Eikelenboom
On 08/12/2022 00:00, Andrew Cooper wrote: On 07/12/2022 21:42, Sander Eikelenboom wrote: Hi Ross / Juergen, I just updated my linux kernel to the latest of Linus his tree which included commit ad7f402ae4f466647c3a669b8a6f3e5d4271c84a fixing XSA-423. Unfortunately when using this kernel I can't

Re: [PATCH V7 1/3] libxl: Add support for generic virtio device

2022-12-08 Thread Anthony PERARD
On Wed, Dec 07, 2022 at 12:50:42PM +0530, Viresh Kumar wrote: > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index fa3d61f1e882..ab3668b3b8a3 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > +static int make_virtio_mmio_node_device(lib

Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT

2022-12-08 Thread Julien Grall
Hi, On 08/12/2022 08:53, Henry Wang wrote: -Original Message- From: Jan Beulich Subject: Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT On 07.12.2022 23:42, Demi Marie Obenour wrote: A previous patch tried to get Linux to use the ESRT under Xen if it is in memory of type EfiRuntimeS

Re: [XEN v1] xen/Arm: Probe the entry point address of an uImage correctly

2022-12-08 Thread Julien Grall
Hi, On 08/12/2022 15:24, Michal Orzel wrote: On 08/12/2022 14:51, Julien Grall wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Hi, Title extra NIT: I have seen it multiple time and so far refrain to

Re: [XEN v1] xen/Arm: Probe the entry point address of an uImage correctly

2022-12-08 Thread Ayan Kumar Halder
On 08/12/2022 15:24, Michal Orzel wrote: Hi, Hi, On 08/12/2022 14:51, Julien Grall wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Hi, Title extra NIT: I have seen it multiple time and so far re

[PATCH linux-next] x86/xen/time: prefer tsc as clocksource when it is invariant

2022-12-08 Thread Krister Johansen
Kvm elects to use tsc instead of kvm-clock when it can detect that the TSC is invariant. (As of commit 7539b174aef4 ("x86: kvmguest: use TSC clocksource if invariant TSC is exposed")). Notable cloud vendors[1] and performance engineers[2] recommend that Xen users preferentially select tsc over xe

[linux-linus test] 175087: regressions - FAIL

2022-12-08 Thread osstest service owner
flight 175087 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175087/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 173462 test-arm64-arm64-ex

Re: Xen Security Advisory 424 v1 (CVE-2022-42328,CVE-2022-42329) - Guests can trigger deadlock in Linux netback driver

2022-12-08 Thread Juergen Gross
On 08.12.22 16:59, Pratyush Yadav wrote: Hi, I noticed one interesting thing about this patch but I'm not familiar enough with the driver to say for sure what the right thing is. On Tue, Dec 06 2022, Xen.org security team wrote: [...] From cfdf8fd81845734b6152b4617746c1127ec52228 Mon Sep 1

Re: Xen Security Advisory 424 v1 (CVE-2022-42328,CVE-2022-42329) - Guests can trigger deadlock in Linux netback driver

2022-12-08 Thread Pratyush Yadav
Hi, I noticed one interesting thing about this patch but I'm not familiar enough with the driver to say for sure what the right thing is. On Tue, Dec 06 2022, Xen.org security team wrote: [...] > > From cfdf8fd81845734b6152b4617746c1127ec52228 Mon Sep 17 00:00:00 2001 > From: Juergen Gross >

[ovmf test] 175090: all pass - PUSHED

2022-12-08 Thread osstest service owner
flight 175090 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175090/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1c75bf3c21da79b1bc1d50cfc593b57f73f2c560 baseline version: ovmf d9e7f6fe49738421c0238

Re: [XEN v1] xen/Arm: Probe the entry point address of an uImage correctly

2022-12-08 Thread Jan Beulich
On 08.12.2022 14:51, Julien Grall wrote: > On 08/12/2022 12:49, Ayan Kumar Halder wrote: >> Currently, kernel_uimage_probe() does not set info->zimage.start. As a >> result, it contains the default value (ie 0). This causes, >> kernel_zimage_place() to treat the binary (contained within uImage) as

Re: [PATCH 1/2] x86/ucode: allow cpu_request_microcode() to skip memory allocation

2022-12-08 Thread Jan Beulich
On 08.12.2022 14:59, Andrew Cooper wrote: > On 08/12/2022 13:26, Sergey Dyasli wrote: >> @@ -240,20 +240,20 @@ static const struct microcode_patch *nmi_patch = >> ZERO_BLOCK_PTR; >> * patch is found and an error occurs during the parsing process. Otherwise >> * return NULL. >> */ >> -static

Re: [XEN v1] xen/Arm: Probe the entry point address of an uImage correctly

2022-12-08 Thread Michal Orzel
Hi, On 08/12/2022 14:51, Julien Grall wrote: > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Hi, > > Title extra NIT: I have seen it multiple time and so far refrain to say > it. Please use 'arm' ra

Re: [XEN v1] xen/Arm: Probe the entry point address of an uImage correctly

2022-12-08 Thread Ayan Kumar Halder
On 08/12/2022 13:51, Julien Grall wrote: Hi, Hi Julien, Title extra NIT: I have seen it multiple time and so far refrain to say it. Please use 'arm' rather than 'Arm'. This is for consistency in the way we name the subsystem in the title. I will take care of it henceforth. On 08/12/2022

Re: [PATCH v2] xsm/flask: misra rule 8.4 fix

2022-12-08 Thread Daniel P. Smith
On 12/7/22 18:24, Stefano Stabellini wrote: Fix several MISRA Issues Rule 8.4 ("A compatible declaration shall be visible when an object or function with external linkage is defined") found by cppcheck affecting xen/xsm/flask. - policydb_loaded_version is not declared; removed it because it is

Feedback on Xen Summit 2023 options

2022-12-08 Thread George Dunlap
Hey all, Here's a quick poll to get feedback on our current choices for Xen Summit 2023, some of which have non-standard parameters. https://cryptpad.fr/form/#/2/form/view/rNLNfq9nWLHN0v7nN3xYygDtk5iMvCkUCQFiM7iEhLA/ The poll will stay open until the next community call, but obviously the earlie

Re: [PATCH] MAINTAINERS: Clarify check-in requirements for mixed-author patches

2022-12-08 Thread George Dunlap
On Thu, Dec 8, 2022 at 1:58 PM Julien Grall wrote: > Hi George, > > On 08/12/2022 10:49, George Dunlap wrote: > > From: George Dunlap > > > > There was a question raised recently about the requriements for > > Typo: s/requriements/requirements/ ... > Typo: s/non-maintiners/maintainers/ > Than

Re: [PATCH 1/2] x86/ucode: allow cpu_request_microcode() to skip memory allocation

2022-12-08 Thread Andrew Cooper
On 08/12/2022 13:26, Sergey Dyasli wrote: > diff --git a/xen/arch/x86/cpu/microcode/core.c > b/xen/arch/x86/cpu/microcode/core.c > index 452a7ca773..924a2bd7b5 100644 > --- a/xen/arch/x86/cpu/microcode/core.c > +++ b/xen/arch/x86/cpu/microcode/core.c > @@ -99,7 +99,7 @@ static bool ucode_in_nmi =

Re: [PATCH] MAINTAINERS: Clarify check-in requirements for mixed-author patches

2022-12-08 Thread Julien Grall
Hi George, On 08/12/2022 10:49, George Dunlap wrote: From: George Dunlap There was a question raised recently about the requriements for Typo: s/requriements/requirements/ checking in a patch which was originally written by one maintainer, then picked up and modified by a second maintainer

i915 and PAT attributes on Xen PV

2022-12-08 Thread Marek Marczykowski-Górecki
Hi, There is an issue with i915 on Xen PV (dom0). The end result is a lot of glitches, like here: https://openqa.qubes-os.org/tests/54748#step/startup/8 (this one is on ADL, Linux 6.1-rc7 as a Xen PV dom0). It's using Xorg with "modesetting" driver. After some iterations of debugging, we narrowed

Re: [XEN v1] xen/Arm: Probe the entry point address of an uImage correctly

2022-12-08 Thread Julien Grall
Hi, Title extra NIT: I have seen it multiple time and so far refrain to say it. Please use 'arm' rather than 'Arm'. This is for consistency in the way we name the subsystem in the title. On 08/12/2022 12:49, Ayan Kumar Halder wrote: Currently, kernel_uimage_probe() does not set info->zimage.

[PATCH 2/2] x86/ucode: load microcode earlier on boot CPU

2022-12-08 Thread Sergey Dyasli
Call early_microcode_init() straight after multiboot modules become accessible. Modify it to load the ucode directly from the blob bypassing populating microcode_cache because xmalloc is still not available at that point during Xen boot. Introduce early_microcode_init_cache() for populating microc

[PATCH 1/2] x86/ucode: allow cpu_request_microcode() to skip memory allocation

2022-12-08 Thread Sergey Dyasli
This is a preparatory step in order to do earlier microcode loading on the boot CPU when the domain heap has not been initialized yet and xmalloc still unavailable. Add make_copy argument which will allow to load microcode directly from the blob bypassing microcode_cache. Add const qualifiers wher

[XEN v1] xen/Arm: Probe the entry point address of an uImage correctly

2022-12-08 Thread Ayan Kumar Halder
Currently, kernel_uimage_probe() does not set info->zimage.start. As a result, it contains the default value (ie 0). This causes, kernel_zimage_place() to treat the binary (contained within uImage) as position independent executable. Thus, it loads it at an incorrect address. The correct approach

Re: [PATCH] MAINTAINERS: Clarify check-in requirements for mixed-author patches

2022-12-08 Thread George Dunlap
On Thu, Dec 8, 2022 at 12:02 PM Andrew Cooper wrote: > On 08/12/2022 10:49, George Dunlap wrote: > > Concerns were raised about two maintainers from the same company > > colluding to get a patch in from their company; but such maintainers > > could already collude, by working on the patch in secr

Re: [PATCH] MAINTAINERS: Clarify check-in requirements for mixed-author patches

2022-12-08 Thread Andrew Cooper
On 08/12/2022 10:49, George Dunlap wrote: > Concerns were raised about two maintainers from the same company > colluding to get a patch in from their company; but such maintainers > could already collude, by working on the patch in secret, and posting > it publicly with only a single author's SoB,

Re: [PATCH] MAINTAINERS: Clarify check-in requirements for mixed-author patches

2022-12-08 Thread George Dunlap
On Thu, Dec 8, 2022 at 11:34 AM Jan Beulich wrote: > On 08.12.2022 11:49, George Dunlap wrote: > > From: George Dunlap > > > > There was a question raised recently about the requriements for > > checking in a patch which was originally written by one maintainer, > > then picked up and modified b

Re: [PATCH] MAINTAINERS: Clarify check-in requirements for mixed-author patches

2022-12-08 Thread Jan Beulich
On 08.12.2022 11:49, George Dunlap wrote: > From: George Dunlap > > There was a question raised recently about the requriements for > checking in a patch which was originally written by one maintainer, > then picked up and modified by a second maintainer, and which they now both > agree should be

[PATCH] x86/SVM: restrict hardware SSBD update upon guest VIRT_SPEC_CTRL write

2022-12-08 Thread Jan Beulich
core_set_legacy_ssbd() counts the number of times SSBD is being enabled via LS_CFG on a core. This assumes that calls there only occur if the state actually changes. While svm_ctxt_switch_{to,from}() conform to this, guest_wrmsr() doesn't: It also calls the function when the bit doesn't actually ch

Re: [PATCH] MAINTAINERS: Clarify check-in requirements for mixed-author patches

2022-12-08 Thread George Dunlap
On Thu, Dec 8, 2022 at 10:49 AM George Dunlap wrote: > From: George Dunlap > > There was a question raised recently about the requriements for > checking in a patch which was originally written by one maintainer, > then picked up and modified by a second maintainer, and which they now both > agr

[PATCH] MAINTAINERS: Clarify check-in requirements for mixed-author patches

2022-12-08 Thread George Dunlap
From: George Dunlap There was a question raised recently about the requriements for checking in a patch which was originally written by one maintainer, then picked up and modified by a second maintainer, and which they now both agree should be checked in. It was proposed that in that case, the f

Re: preparations for 4.16.3

2022-12-08 Thread Jan Beulich
On 02.12.2022 10:16, Jan Beulich wrote: > On 02.12.2022 10:11, Andrew Cooper wrote: >> On 02/12/2022 08:26, Jan Beulich wrote: >>> On 01.12.2022 14:20, Andrew Cooper wrote: On 28/11/2022 10:50, Jan Beulich wrote: > All, > > the release is due in a couple of weeks time; ideally we'd

[libvirt test] 175086: tolerable all pass - PUSHED

2022-12-08 Thread osstest service owner
flight 175086 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/175086/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 175069 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [PATCH] Validate EFI memory descriptors

2022-12-08 Thread Jan Beulich
On 08.12.2022 10:36, Demi Marie Obenour wrote: > On Thu, Dec 08, 2022 at 09:02:57AM +0100, Jan Beulich wrote: >> Tainting the hypervisor in the event of finding an issue is certainly >> an option. > > I probably will not add such a mechanism, but if one exists I would be > happy to use it. See co

[xen-unstable test] 175083: tolerable FAIL - PUSHED

2022-12-08 Thread osstest service owner
flight 175083 xen-unstable real [real] flight 175088 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175083/ http://logs.test-lab.xenproject.org/osstest/logs/175088/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armh

Re: [PATCH] Validate EFI memory descriptors

2022-12-08 Thread Demi Marie Obenour
On Thu, Dec 08, 2022 at 09:02:57AM +0100, Jan Beulich wrote: > On 07.12.2022 23:23, Demi Marie Obenour wrote: > > On Wed, Dec 07, 2022 at 11:04:05AM +0100, Jan Beulich wrote: > >> On 07.12.2022 00:57, Demi Marie Obenour wrote: > >>> It turns out that these can be invalid in various ways. Based on

RE: [PATCH v3] Use EfiACPIReclaimMemory for ESRT

2022-12-08 Thread Henry Wang
Hi Jan, > -Original Message- > From: Jan Beulich > Subject: Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT > > On 07.12.2022 23:42, Demi Marie Obenour wrote: > > A previous patch tried to get Linux to use the ESRT under Xen if it is > > in memory of type EfiRuntimeServicesData. Howeve

Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT

2022-12-08 Thread Jan Beulich
On 07.12.2022 23:42, Demi Marie Obenour wrote: > A previous patch tried to get Linux to use the ESRT under Xen if it is > in memory of type EfiRuntimeServicesData. However, EfiRuntimeServices* > memory needs to be included in the EFI page tables, so it is best to > minimize the amount of memory of

Re: [PATCH] xsm: misra rule 8.4 fix

2022-12-08 Thread Jan Beulich
On 08.12.2022 09:14, Jan Beulich wrote: > On 07.12.2022 13:33, Michal Orzel wrote: >> On 07/12/2022 03:12, Stefano Stabellini wrote: >>> Fix two MISRA Issues Rule 8.4 ("A compatible declaration shall be >>> visible when an object or function with external linkage is defined") >>> found by cppcheck

Re: [PATCH] xsm: misra rule 8.4 fix

2022-12-08 Thread Michal Orzel
On 08/12/2022 09:14, Jan Beulich wrote: > > > On 07.12.2022 13:33, Michal Orzel wrote: >> Hi Stefano, >> >> On 07/12/2022 03:12, Stefano Stabellini wrote: >>> >>> >>> Fix two MISRA Issues Rule 8.4 ("A compatible declaration shall be >>> visible when an object or function with external linkage

Re: [PATCH v2] xsm/flask: misra rule 8.4 fix

2022-12-08 Thread Jan Beulich
On 08.12.2022 00:24, Stefano Stabellini wrote: > Fix several MISRA Issues Rule 8.4 ("A compatible declaration shall be > visible when an object or function with external linkage is defined") > found by cppcheck affecting xen/xsm/flask. > > - policydb_loaded_version is not declared; removed it beca

Re: [PATCH v3 3/5] xen/Makefile: remove Cppcheck invocation from the Makefile

2022-12-08 Thread Jan Beulich
On 07.12.2022 14:07, Luca Fancellu wrote: > The script xen-analysis.py is going to be used for the analysis with > cppcheck, so remove the rules from the Makefile. > > The python script xen/tools/merge_cppcheck_reports.py was used by the > makefile rules, but its functionality is integrated in the

[linux-linus test] 175081: regressions - FAIL

2022-12-08 Thread osstest service owner
flight 175081 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175081/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd11-amd64 13 guest-start fail REGR. vs. 173462 test-arm64-arm64-ex

Re: [XEN][RFC PATCH v4 10/16] asm/smp.h: move cpu related function to asm/cpu.h

2022-12-08 Thread Jan Beulich
On 07.12.2022 20:39, Vikram Garhwal wrote: > Hi Julien > > On 12/7/22 8:28 AM, Julien Grall wrote: >> Hi Vikram, >> >> On 07/12/2022 06:18, Vikram Garhwal wrote: >>> Dynamic programming ops will modify the dt_host and there might be other >>> function which are browsing the dt_host at the same tim

Re: [PATCH] xsm: misra rule 8.4 fix

2022-12-08 Thread Jan Beulich
On 07.12.2022 13:33, Michal Orzel wrote: > Hi Stefano, > > On 07/12/2022 03:12, Stefano Stabellini wrote: >> >> >> Fix two MISRA Issues Rule 8.4 ("A compatible declaration shall be >> visible when an object or function with external linkage is defined") >> found by cppcheck affecting xen/xsm/flask

Re: [PATCH] Validate EFI memory descriptors

2022-12-08 Thread Jan Beulich
On 07.12.2022 23:23, Demi Marie Obenour wrote: > On Wed, Dec 07, 2022 at 11:04:05AM +0100, Jan Beulich wrote: >> On 07.12.2022 00:57, Demi Marie Obenour wrote: >>> It turns out that these can be invalid in various ways. Based on code >>> Ard Biesheuvel contributed for Linux. >>> >>> Co-developed-b