[PATCH] tools/libs/light: set video_mem for PVH guests

2021-12-02 Thread Juergen Gross
The size of the video memory of PVH guests should be set to 0 in case no value has been specified. Doing not so will leave it to be -1, resulting in an additional 1 kB of RAM being advertised in the memory map (here the output of a PVH Mini-OS boot with 16 MB of RAM assigned): Memory map: 000

[xen-unstable-smoke test] 167064: regressions - FAIL

2021-12-02 Thread osstest service owner
flight 167064 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/167064/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 16

Re: [PATCH v2 06/18] IOMMU/x86: restrict IO-APIC mappings for PV Dom0

2021-12-02 Thread Jan Beulich
On 02.12.2021 20:16, Andrew Cooper wrote: > On 02/12/2021 15:28, Jan Beulich wrote: >> On 02.12.2021 16:12, Roger Pau Monné wrote: >>> On Wed, Dec 01, 2021 at 12:45:12PM +0100, Jan Beulich wrote: On 01.12.2021 11:32, Roger Pau Monné wrote: > On Wed, Dec 01, 2021 at 10:27:21AM +0100, Jan Be

[linux-5.4 test] 167023: regressions - FAIL

2021-12-02 Thread osstest service owner
flight 167023 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/167023/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 13 nested-setupfail REGR. vs. 166839 test-amd64-amd64-xl-p

[xen-unstable-smoke test] 167051: regressions - FAIL

2021-12-02 Thread osstest service owner
flight 167051 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/167051/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 20 guest-start/debianhvm.repeat fail REGR. vs. 16

Re: [PATCH] xen-blkfront: Use the bitmap API when applicable

2021-12-02 Thread Joe Perches
On Thu, 2021-12-02 at 20:07 +0100, Christophe JAILLET wrote: > Le 02/12/2021 à 19:16, Joe Perches a écrit : > > On Thu, 2021-12-02 at 19:12 +0100, Christophe JAILLET wrote: > > > Le 02/12/2021 à 07:12, Juergen Gross a écrit : > > > > On 01.12.21 22:10, Christophe JAILLET wrote: > > > > > Use 'bitma

[qemu-mainline test] 167007: regressions - FAIL

2021-12-02 Thread osstest service owner
flight 167007 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/167007/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166954 test-amd64-amd64-

[linux-linus test] 167019: regressions - FAIL

2021-12-02 Thread osstest service owner
flight 167019 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/167019/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 13 nested-setupfail REGR. vs. 166942 test-amd64-coresche

Re: [patch 09/10] PCI/MSI: Provide pci_msix_expand_vectors[_at]()

2021-12-02 Thread Raj, Ashok
Hi Thomas On Thu, Dec 02, 2021 at 09:40:08PM +0100, Thomas Gleixner wrote: > Ashok, > > On Thu, Dec 02 2021 at 11:21, Ashok Raj wrote: > > On Thu, Dec 02, 2021 at 11:16:39AM +0100, Thomas Gleixner wrote: > >> On Wed, Dec 01 2021 at 17:08, Megha Dey wrote: > >> You're missing the real world use ca

[xen-unstable-smoke test] 167033: regressions - FAIL

2021-12-02 Thread osstest service owner
flight 167033 xen-unstable-smoke real [real] flight 167046 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/167033/ http://logs.test-lab.xenproject.org/osstest/logs/167046/ Regressions :-( Tests which did not succeed and are blocking, including tests which co

[xen-unstable test] 166999: regressions - FAIL

2021-12-02 Thread osstest service owner
flight 166999 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/166999/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 22 guest-start/debian.repeat fail REGR. vs. 166912 test-amd64-i386-li

Re: [patch 09/10] PCI/MSI: Provide pci_msix_expand_vectors[_at]()

2021-12-02 Thread Thomas Gleixner
Ashok, On Thu, Dec 02 2021 at 11:21, Ashok Raj wrote: > On Thu, Dec 02, 2021 at 11:16:39AM +0100, Thomas Gleixner wrote: >> On Wed, Dec 01 2021 at 17:08, Megha Dey wrote: >> You're missing the real world use case. The above is fiction. > > I don't think there is a valid use case for freeing specif

Call for agenda items for December 7th Community Call @ 1500 UTC

2021-12-02 Thread Ashley Weltz
Hi everyone, Our next meeting is on Tuesday, December 7th at 1500 UTC. The proposed agenda is in https://cryptpad.fr/pad/#/2/pad/edit/0uM9VB27hQfkyZ+A8libTu4E/ Please add or edit any items to this agenda. Alternatively, please feel free to email me directly with agenda items. Please put your nam

[PATCH v2] xen-blkfront: Use the bitmap API when applicable

2021-12-02 Thread Christophe JAILLET
Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid some open-coded arithmetic in allocator arguments. Also change the corresponding 'kfree()' into 'bitmap_free()' to keep consistency. Use 'bitmap_copy()' to avoid an explicit 'memcpy()' Signed-off-by: Christophe JAILLET --- v

Re: [patch 09/10] PCI/MSI: Provide pci_msix_expand_vectors[_at]()

2021-12-02 Thread Raj, Ashok
Hi Thomas, On Thu, Dec 02, 2021 at 11:16:39AM +0100, Thomas Gleixner wrote: > Megha, > > On Wed, Dec 01 2021 at 17:08, Megha Dey wrote: > > On 11/26/2021 5:25 PM, Thomas Gleixner wrote: > >> /** > >> + * pci_msix_expand_vectors_at - Expand MSI-X interrupts for a device > >> + * > >> + * @dev:

Re: [PATCH v2 06/18] IOMMU/x86: restrict IO-APIC mappings for PV Dom0

2021-12-02 Thread Andrew Cooper
On 02/12/2021 15:28, Jan Beulich wrote: > On 02.12.2021 16:12, Roger Pau Monné wrote: >> On Wed, Dec 01, 2021 at 12:45:12PM +0100, Jan Beulich wrote: >>> On 01.12.2021 11:32, Roger Pau Monné wrote: On Wed, Dec 01, 2021 at 10:27:21AM +0100, Jan Beulich wrote: > On 01.12.2021 10:09, Roger Pa

Re: [PATCH 1/2] x86/mm: don't open-code p2m_is_pod()

2021-12-02 Thread Tim Deegan
At 12:01 +0100 on 01 Dec (1638360084), Jan Beulich wrote: > Replace all comparisons against p2m_populate_on_demand (outside of > switch() statements) with the designated predicate. > > Signed-off-by: Jan Beulich Acked-by: Tim Deegan

Re: [PATCH 1/2] x86/shadow: defer/avoid paging_mfn_is_dirty() invocation

2021-12-02 Thread Tim Deegan
At 11:35 +0100 on 01 Dec (1638358515), Jan Beulich wrote: > paging_mfn_is_dirty() is moderately expensive, so avoid its use unless > its result might actually change anything. This means moving the > surrounding if() down below all other checks that can result in clearing > _PAGE_RW from sflags, in

Re: [PATCH] xen-blkfront: Use the bitmap API when applicable

2021-12-02 Thread Christophe JAILLET
Le 02/12/2021 à 19:16, Joe Perches a écrit : On Thu, 2021-12-02 at 19:12 +0100, Christophe JAILLET wrote: Le 02/12/2021 à 07:12, Juergen Gross a écrit : On 01.12.21 22:10, Christophe JAILLET wrote: Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid some open-coded arithmeti

[xen-unstable-smoke test] 167020: regressions - FAIL

2021-12-02 Thread osstest service owner
flight 167020 xen-unstable-smoke real [real] flight 167031 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/167020/ http://logs.test-lab.xenproject.org/osstest/logs/167031/ Regressions :-( Tests which did not succeed and are blocking, including tests which co

Re: [PATCH] xen-blkfront: Use the bitmap API when applicable

2021-12-02 Thread Joe Perches
On Thu, 2021-12-02 at 19:12 +0100, Christophe JAILLET wrote: > Le 02/12/2021 à 07:12, Juergen Gross a écrit : > > On 01.12.21 22:10, Christophe JAILLET wrote: > > > Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid > > > some open-coded arithmetic in allocator arguments. > > >

Re: [PATCH] xen-blkfront: Use the bitmap API when applicable

2021-12-02 Thread Christophe JAILLET
Le 02/12/2021 à 07:12, Juergen Gross a écrit : On 01.12.21 22:10, Christophe JAILLET wrote: Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid some open-coded arithmetic in allocator arguments. Also change the corresponding 'kfree()' into 'bitmap_free()' to keep consistency

[libvirt test] 166997: regressions - FAIL

2021-12-02 Thread osstest service owner
flight 166997 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/166997/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH v2 09/18] AMD/IOMMU: drop stray TLB flush

2021-12-02 Thread Roger Pau Monné
On Fri, Sep 24, 2021 at 11:48:57AM +0200, Jan Beulich wrote: > I think this flush was overlooked when flushing was moved out of the > core (un)mapping functions. The flush the caller is required to invoke > anyway will satisfy the needs resulting from the splitting of a > superpage. > > Signed-off

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-12-02 Thread Oleksandr
On 02.12.21 11:09, Julien Grall wrote: Hi Julien, Jan Hi Jan, On 13/09/2021 07:41, Jan Beulich wrote: Without holding appropriate locks, attempting to remove a prior mapping of the underlying page is pointless, as the same (or another) mapping could be re-established by a parallel request o

Re: [PATCH v2 08/18] IOMMU/x86: support freeing of pagetables

2021-12-02 Thread Jan Beulich
On 02.12.2021 17:03, Roger Pau Monné wrote: > On Fri, Sep 24, 2021 at 11:48:21AM +0200, Jan Beulich wrote: >> For vendor specific code to support superpages we need to be able to >> deal with a superpage mapping replacing an intermediate page table (or >> hierarchy thereof). Consequently an iommu_a

Re: [PATCH v2 08/18] IOMMU/x86: support freeing of pagetables

2021-12-02 Thread Roger Pau Monné
On Fri, Sep 24, 2021 at 11:48:21AM +0200, Jan Beulich wrote: > For vendor specific code to support superpages we need to be able to > deal with a superpage mapping replacing an intermediate page table (or > hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is > needed to free in

Re: [PATCH v2 05/18] IOMMU: have iommu_{,un}map() split requests into largest possible chunks

2021-12-02 Thread Jan Beulich
On 30.11.2021 16:24, Roger Pau Monné wrote: > On Fri, Sep 24, 2021 at 11:45:57AM +0200, Jan Beulich wrote: >> --- a/xen/drivers/passthrough/iommu.c >> +++ b/xen/drivers/passthrough/iommu.c >> @@ -260,12 +260,38 @@ void iommu_domain_destroy(struct domain >> arch_iommu_domain_destroy(d); >> } >

Re: [PATCH v2 0/6] aio-posix: split poll check from ready handler

2021-12-02 Thread Stefan Hajnoczi
On Thu, Dec 02, 2021 at 03:49:08PM +, Richard W.M. Jones wrote: > > Not sure if this is related, but builds are failing with: > > FAILED: libblockdev.fa.p/block_export_fuse.c.o > cc -m64 -mcx16 -Ilibblockdev.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader > -I/usr/include/fuse3 -I/usr/include

Re: [PATCH v2 0/6] aio-posix: split poll check from ready handler

2021-12-02 Thread Richard W.M. Jones
Not sure if this is related, but builds are failing with: FAILED: libblockdev.fa.p/block_export_fuse.c.o cc -m64 -mcx16 -Ilibblockdev.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/fuse3 -I/usr/include/p11-kit-1 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/includ

[PATCH v2 5/6] virtio: use ->handle_output() instead of ->handle_aio_output()

2021-12-02 Thread Stefan Hajnoczi
The difference between ->handle_output() and ->handle_aio_output() was that ->handle_aio_output() returned a bool return value indicating progress. This was needed by the old polling API but now that the bool return value is gone, the two functions can be unified. Signed-off-by: Stefan Hajnoczi -

[PATCH v2 6/6] virtio: unify dataplane and non-dataplane ->handle_output()

2021-12-02 Thread Stefan Hajnoczi
Now that virtio-blk and virtio-scsi are ready, get rid of the handle_aio_output() callback. It's no longer needed. Signed-off-by: Stefan Hajnoczi --- include/hw/virtio/virtio.h | 4 +-- hw/block/dataplane/virtio-blk.c | 16 ++ hw/scsi/virtio-scsi-dataplane.c | 54 --

[PATCH v2 4/6] virtio-scsi: prepare virtio_scsi_handle_cmd for dataplane

2021-12-02 Thread Stefan Hajnoczi
Prepare virtio_scsi_handle_cmd() to be used by both dataplane and non-dataplane by making the condition for starting ioeventfd more specific. This way it won't trigger when dataplane has already been started. Signed-off-by: Stefan Hajnoczi --- hw/scsi/virtio-scsi.c | 2 +- 1 file changed, 1 inse

[PATCH v2 3/6] virtio-blk: drop unused virtio_blk_handle_vq() return value

2021-12-02 Thread Stefan Hajnoczi
The return value of virtio_blk_handle_vq() is no longer used. Get rid of it. This is a step towards unifying the dataplane and non-dataplane virtqueue handler functions. Prepare virtio_blk_handle_output() to be used by both dataplane and non-dataplane by making the condition for starting ioeventfd

[PATCH v2 2/6] virtio: get rid of VirtIOHandleAIOOutput

2021-12-02 Thread Stefan Hajnoczi
The virtqueue host notifier API virtio_queue_aio_set_host_notifier_handler() polls the virtqueue for new buffers. AioContext previously required a bool progress return value indicating whether an event was handled or not. This is no longer necessary because the AioContext polling API has been split

[PATCH v2 1/6] aio-posix: split poll check from ready handler

2021-12-02 Thread Stefan Hajnoczi
Adaptive polling measures the execution time of the polling check plus handlers called when a polled event becomes ready. Handlers can take a significant amount of time, making it look like polling was running for a long time when in fact the event handler was running for a long time. For example,

[PATCH v2 0/6] aio-posix: split poll check from ready handler

2021-12-02 Thread Stefan Hajnoczi
v2: - Cleaned up unused return values in nvme and virtio-blk [Stefano] - Documented try_poll_mode() ready_list argument [Stefano] - Unified virtio-blk/scsi dataplane and non-dataplane virtqueue handlers [Stefano] The first patch improves AioContext's adaptive polling execution time measurement. T

Re: [PATCH v2 06/18] IOMMU/x86: restrict IO-APIC mappings for PV Dom0

2021-12-02 Thread Jan Beulich
On 02.12.2021 16:12, Roger Pau Monné wrote: > On Wed, Dec 01, 2021 at 12:45:12PM +0100, Jan Beulich wrote: >> On 01.12.2021 11:32, Roger Pau Monné wrote: >>> On Wed, Dec 01, 2021 at 10:27:21AM +0100, Jan Beulich wrote: On 01.12.2021 10:09, Roger Pau Monné wrote: > On Fri, Sep 24, 2021 at 1

Re: [PATCH] docs/efi: Fix wrong compatible in dts example

2021-12-02 Thread Bertrand Marquis
Hi Luca, > On 2 Dec 2021, at 15:05, Luca Fancellu wrote: > > The example in section "UEFI boot and dom0less on ARM" has > a wrong compatible for the DTB passthrough, it is "ramdisk" > instead of "device-tree". > This patch fixes the example. > > Fixes: a1743fc3a9 ("arm/efi: Use dom0less configu

Re: Xen 4.16 is released

2021-12-02 Thread Ian Jackson
Correction: I wrote: > Xen 4.16, the product of 9 months' work by the Xen Project community, > is now released. > > You can find it here: > git clone -b RELEASE-4.16.0 https://xenbits.xen.org/git-http/xen.git > https://downloads.xenproject.org/release/xen/4.16.0/ > For more information see th

Re: [PATCH v2 06/18] IOMMU/x86: restrict IO-APIC mappings for PV Dom0

2021-12-02 Thread Roger Pau Monné
On Wed, Dec 01, 2021 at 12:45:12PM +0100, Jan Beulich wrote: > On 01.12.2021 11:32, Roger Pau Monné wrote: > > On Wed, Dec 01, 2021 at 10:27:21AM +0100, Jan Beulich wrote: > >> On 01.12.2021 10:09, Roger Pau Monné wrote: > >>> On Fri, Sep 24, 2021 at 11:46:57AM +0200, Jan Beulich wrote: > @@ -

[PATCH] docs/efi: Fix wrong compatible in dts example

2021-12-02 Thread Luca Fancellu
The example in section "UEFI boot and dom0less on ARM" has a wrong compatible for the DTB passthrough, it is "ramdisk" instead of "device-tree". This patch fixes the example. Fixes: a1743fc3a9 ("arm/efi: Use dom0less configuration when using EFI boot") Signed-off-by: Luca Fancellu --- Question: D

Re: [PATCH V3 1/5] Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM

2021-12-02 Thread Tom Lendacky
On 12/1/21 10:02 AM, Tianyu Lan wrote: From: Tianyu Lan In Isolation VM with AMD SEV, bounce buffer needs to be accessed via extra address space which is above shared_gpa_boundary (E.G 39 bit address line) reported by Hyper-V CPUID ISOLATION_CONFIG. The access physical address will be original

Re: [PATCH V3 3/5] hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM

2021-12-02 Thread Wei Liu
On Wed, Dec 01, 2021 at 11:02:54AM -0500, Tianyu Lan wrote: [...] > diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xen.c > index 46df59aeaa06..30fd0600b008 100644 > --- a/arch/x86/xen/pci-swiotlb-xen.c > +++ b/arch/x86/xen/pci-swiotlb-xen.c > @@ -4,6 +4,7 @@ > > #include

Xen 4.16 is released

2021-12-02 Thread Ian Jackson
Xen 4.16, the product of 9 months' work by the Xen Project community, is now released. You can find it here: git clone -b RELEASE-4.16.0 https://xenbits.xen.org/git-http/xen.git https://downloads.xenproject.org/release/xen/4.16.0/ For more information see the release notes: https://wiki.xenp

Re: [PATCH V3 2/5] x86/hyper-v: Add hyperv Isolation VM check in the cc_platform_has()

2021-12-02 Thread Wei Liu
On Wed, Dec 01, 2021 at 11:02:53AM -0500, Tianyu Lan wrote: > From: Tianyu Lan > > Hyper-V provides Isolation VM which has memory encrypt support. Add > hyperv_cc_platform_has() and return true for check of GUEST_MEM_ENCRYPT > attribute. > > Signed-off-by: Tianyu Lan > --- > arch/x86/kernel/cc

Re: [patch 11/22] x86/hyperv: Refactor hv_msi_domain_free_irqs()

2021-12-02 Thread Wei Liu
On Sat, Nov 27, 2021 at 02:18:51AM +0100, Thomas Gleixner wrote: > No point in looking up things over and over. Just look up the associated > irq data and work from there. > > No functional change. > > Signed-off-by: Thomas Gleixner Acked-by: Wei Liu

Re: [PATCH v2 07/18] IOMMU/x86: perform PV Dom0 mappings in batches

2021-12-02 Thread Roger Pau Monné
On Fri, Sep 24, 2021 at 11:47:41AM +0200, Jan Beulich wrote: > For large page mappings to be easily usable (i.e. in particular without > un-shattering of smaller page mappings) and for mapping operations to > then also be more efficient, pass batches of Dom0 memory to iommu_map(). > In dom0_constru

Re: [PATCH 5/8] x86/boot: Drop xen_virt_end

2021-12-02 Thread Andrew Cooper
On 02/12/2021 11:56, Jan Beulich wrote: > On 30.11.2021 11:04, Andrew Cooper wrote: >> The calculation in __start_xen() for xen_virt_end is an opencoding of >> ROUNDUP(_end, 2M). This is __2M_rwdata_end as provided by the linker script. >> >> This corrects the bound calculations in arch_livepatch_

Re: [PATCH 3/8] x86/boot: Fix data placement around __high_start()

2021-12-02 Thread Andrew Cooper
On 02/12/2021 11:49, Jan Beulich wrote: > On 30.11.2021 11:04, Andrew Cooper wrote: >> multiboot_ptr should be in __initdata - it is only used on the BSP path. >> Furthermore, the .align 8 then .long means that stack_start is misaligned. >> >> Move both into setup.c, which lets the compiler handle

Re: [XEN PATCH v8 04/47] build: set XEN_BUILD_EFI earlier

2021-12-02 Thread Jan Beulich
On 25.11.2021 14:39, Anthony PERARD wrote: > We are going to need the variable XEN_BUILD_EFI earlier. > > But a side effect of calculating the value of $(XEN_BUILD_EFI) is to > also to generate "efi/check.o" which is used for further checks. > Thus the whole chain that check for EFI support is mov

Re: [XEN PATCH v8 03/47] build: generate "include/xen/compile.h" with if_changed

2021-12-02 Thread Jan Beulich
On 25.11.2021 14:39, Anthony PERARD wrote: > This will avoid regenerating "compile.h" if the content hasn't changed. > > As it's currently the case, the file isn't regenerated during `sudo > make install` if it exist and does belong to a different user, thus we > can remove the target "delete-unfr

[linux-5.4 test] 166990: regressions - FAIL

2021-12-02 Thread osstest service owner
flight 166990 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/166990/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 13 nested-setupfail REGR. vs. 166839 test-amd64-amd64-xl-p

Re: [XEN PATCH v8 02/47] xen: move include/asm-* to arch/*/include/asm

2021-12-02 Thread Jan Beulich
On 25.11.2021 14:39, Anthony PERARD wrote: > This avoid the need to create the symbolic link "include/asm". > > Whenever a comment refer to an "asm" headers, this patch avoid > spelling the arch when not needed to avoid some code churn. > > One unrelated change is to sort entries in MAINTAINERS f

Re: [XEN PATCH 1/1] Add suport for SMBIOS tables 7,8,9,26,27,28 to improve virtual machine stealth from malware.

2021-12-02 Thread Jan Beulich
On 29.11.2021 13:59, Anton Belousov wrote: > --- > tools/firmware/hvmloader/smbios.c | 146 > tools/firmware/hvmloader/smbios_types.h | 76 > 2 files changed, 222 insertions(+) In addition to what Roger said: Without a commit message it's also unclear

Re: [PATCH RFC 8/8] x86/boot: Check that permission restrictions have taken effect

2021-12-02 Thread Jan Beulich
On 30.11.2021 11:04, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Roger Pau Monné > CC: Wei Liu > > RFC. I don't know if this is something we'd want to keep or not. > > Getting extable handling working for test_nx_data is proving tricky, and while > I can

Re: [PATCH 7/8] x86/boot: Support __ro_after_init

2021-12-02 Thread Jan Beulich
On 30.11.2021 11:04, Andrew Cooper wrote: > For security hardening reasons, it advantageous to make setup-once data > immutable after boot. Borrow __ro_after_init from Linux. > > On x86, place .data.ro_after_init at the start of .rodata, excluding it from > the early permission restrictions. Re-

[linux-linus test] 166980: regressions - FAIL

2021-12-02 Thread osstest service owner
flight 166980 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/166980/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 13 nested-setupfail REGR. vs. 166942 test-arm64-arm64-xl

[xen-unstable-smoke test] 167004: regressions - FAIL

2021-12-02 Thread osstest service owner
flight 167004 xen-unstable-smoke real [real] flight 167015 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/167004/ http://logs.test-lab.xenproject.org/osstest/logs/167015/ Regressions :-( Tests which did not succeed and are blocking, including tests which co

Re: [PATCH 6/8] x86/boot: Adjust .text/.rodata/etc permissions in one place

2021-12-02 Thread Jan Beulich
On 30.11.2021 11:04, Andrew Cooper wrote: > At the moment, we have two locations selecting restricted permissions, not > very far apart on boot, dependent on opposite answers from using_2M_mapping(). > The later location however can shatter superpages if needed, while the former > cannot. > > Coll

Re: [PATCH 5/8] x86/boot: Drop xen_virt_end

2021-12-02 Thread Jan Beulich
On 30.11.2021 11:04, Andrew Cooper wrote: > The calculation in __start_xen() for xen_virt_end is an opencoding of > ROUNDUP(_end, 2M). This is __2M_rwdata_end as provided by the linker script. > > This corrects the bound calculations in arch_livepatch_init() and > update_xen_mappings() to not enf

Re: [PATCH 3/8] x86/boot: Fix data placement around __high_start()

2021-12-02 Thread Jan Beulich
On 30.11.2021 11:04, Andrew Cooper wrote: > multiboot_ptr should be in __initdata - it is only used on the BSP path. > Furthermore, the .align 8 then .long means that stack_start is misaligned. > > Move both into setup.c, which lets the compiler handle the details correctly, > as well as providlin

Re: [PATCH 2/8] x86/boot: Better describe the pagetable relocation loops

2021-12-02 Thread Jan Beulich
On 30.11.2021 11:04, Andrew Cooper wrote: > The first loop relocates all reachable non-leaf entries in idle_pg_table[], > which includes l2_xenmap[511]'s reference to l1_fixmap_x[]. > > The second loop relocates only leaf mappings in l2_xenmap[], so update the > skip condition to be opposite to th

Re: [PATCH 18/65] xen/hypfs: Annotate fnptr targets

2021-12-02 Thread Juergen Gross
On 26.11.21 13:33, Andrew Cooper wrote: Signed-off-by: Andrew Cooper Acked-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

Re: [xen-unstable test] 166960: regressions - FAIL

2021-12-02 Thread Jan Beulich
On 02.12.2021 11:44, Dario Faggioli wrote: > Hey! So, I noticed this osstests report and got curious about one > thing, which looks weird to me... If I am missing something obvious, > sorry for the noise. > > On Wed, 2021-12-01 at 05:43 +, osstest service owner wrote: >>  test-armhf-armhf-xl-m

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-12-02 Thread Julien Grall
Hi Jan, On 02/12/2021 10:12, Jan Beulich wrote: On 02.12.2021 10:09, Julien Grall wrote: Hi Jan, On 13/09/2021 07:41, Jan Beulich wrote: Without holding appropriate locks, attempting to remove a prior mapping of the underlying page is pointless, as the same (or another) mapping could be re-es

Re: [xen-unstable test] 166960: regressions - FAIL

2021-12-02 Thread Dario Faggioli
Hey! So, I noticed this osstests report and got curious about one thing, which looks weird to me... If I am missing something obvious, sorry for the noise. On Wed, 2021-12-01 at 05:43 +, osstest service owner wrote: >  test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. > vs.

Re: [PATCH 0/2] xsm: Further fixes

2021-12-02 Thread Bertrand Marquis
> On 1 Dec 2021, at 11:15, Andrew Cooper wrote: > > Andrew Cooper (2): > xsm: Switch xsm_ops to __alt_call_maybe_initdata > xsm: Drop extern of non-existent variable Reviewed-by: Bertrand Marquis

Re: [PATCH 00/65] x86: Support for CET Indirect Branch Tracking

2021-12-02 Thread Dario Faggioli
On Mon, 2021-11-29 at 15:44 +0100, Jan Beulich wrote: > On 26.11.2021 13:33, Andrew Cooper wrote: > > > > Andrew Cooper (63): > >   x86: Introduce support for CET-IBT > >   x86/hypercall: Annotate fnptr targets > >   xen: Annotate fnptr targets from custom_param() > >   xen: Annotate fnptr targets

Re: [patch 09/10] PCI/MSI: Provide pci_msix_expand_vectors[_at]()

2021-12-02 Thread Thomas Gleixner
Megha, On Wed, Dec 01 2021 at 17:08, Megha Dey wrote: > On 11/26/2021 5:25 PM, Thomas Gleixner wrote: >> /** >> + * pci_msix_expand_vectors_at - Expand MSI-X interrupts for a device >> + * >> + * @dev:PCI device to operate on >> + * @at: Allocate at MSI-X index. If @at == PCI_MSI

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-12-02 Thread Jan Beulich
On 02.12.2021 10:09, Julien Grall wrote: > Hi Jan, > > On 13/09/2021 07:41, Jan Beulich wrote: >> Without holding appropriate locks, attempting to remove a prior mapping >> of the underlying page is pointless, as the same (or another) mapping >> could be re-established by a parallel request on ano

Re: [PATCH 3/4] x86/altp2m: p2m_altp2m_get_or_propagate() should honor present page order

2021-12-02 Thread Jan Beulich
On 01.12.2021 13:44, Andrew Cooper wrote: > On 01/12/2021 10:54, Jan Beulich wrote: >> @@ -2237,11 +2243,11 @@ bool p2m_altp2m_get_or_propagate(struct >> * to the start of the superpage. NB that we repupose `amfn` >> * here. >> */ >> -mask = ~((1UL << page_order) - 1); >> +

Re: [PATCH 1/4] x86/PoD: simplify / improve p2m_pod_cache_add()

2021-12-02 Thread Jan Beulich
On 01.12.2021 13:01, Andrew Cooper wrote: > On 01/12/2021 10:53, Jan Beulich wrote: >> --- a/xen/arch/x86/mm/p2m-pod.c >> +++ b/xen/arch/x86/mm/p2m-pod.c >> @@ -58,14 +58,10 @@ p2m_pod_cache_add(struct p2m_domain *p2m >>unsigned int order) >> { >> unsigned long i; >> -

[qemu-mainline test] 166978: regressions - FAIL

2021-12-02 Thread osstest service owner
flight 166978 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/166978/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-seattle 18 guest-start/debian.repeat fail REGR. vs. 166954 test-arm64-arm64-

Re: [PATCH 2/4] VT-d / x86: re-arrange cache syncing

2021-12-02 Thread Jan Beulich
On 01.12.2021 15:39, Andrew Cooper wrote: > On 01/12/2021 09:40, Jan Beulich wrote: >> The actual function should always have lived in core x86 code; move it >> there, replacing get_cache_line_size() by readily available (except very >> early during boot; see the code comment) data. >> >> Drop the

Re: [PATCH 1/2] gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()

2021-12-02 Thread Julien Grall
Hi Jan, On 13/09/2021 07:41, Jan Beulich wrote: Without holding appropriate locks, attempting to remove a prior mapping of the underlying page is pointless, as the same (or another) mapping could be re-established by a parallel request on another vCPU. Move the code to Arm's gnttab_set_frame_gfn

Re: [PATCH v2] bitops: Fix incorrect value in comment

2021-12-02 Thread Julien Grall
Hi Andrew, On 01/12/2021 21:38, Andrew Cooper wrote: On 01/12/2021 09:56, Julien Grall wrote: Hi, On 01/12/2021 09:38, Jan Beulich wrote: On 01.12.2021 10:33, Julien Grall wrote: On 30/11/2021 18:12, Ayan Kumar Halder wrote: --- a/xen/include/xen/bitops.h +++ b/xen/include/xen/bitops.h @@ -

Re: [PATCH 3/4] VT-d: replace flush_all_cache()

2021-12-02 Thread Jan Beulich
On 01.12.2021 14:02, Andrew Cooper wrote: > On 01/12/2021 09:41, Jan Beulich wrote: >> --- a/xen/drivers/passthrough/vtd/iommu.c >> +++ b/xen/drivers/passthrough/vtd/iommu.c >> @@ -591,7 +591,8 @@ static int __must_check iommu_flush_all( >> bool_t flush_dev_iotlb; >> int rc = 0; >> >> -

Re: [PATCH 2/2] x86/paging: tidy paging_mfn_is_dirty()

2021-12-02 Thread Jan Beulich
On 01.12.2021 17:06, Andrew Cooper wrote: > On 01/12/2021 10:35, Jan Beulich wrote: >> --- a/xen/arch/x86/mm/mm-locks.h >> +++ b/xen/arch/x86/mm/mm-locks.h >> @@ -40,7 +40,7 @@ static inline void mm_lock_init(mm_lock_ >> l->unlock_level = 0; >> } >> >> -static inline int mm_locked_by_me(mm_

Re: [PATCH 1/2] x86/shadow: defer/avoid paging_mfn_is_dirty() invocation

2021-12-02 Thread Jan Beulich
On 01.12.2021 19:33, Andrew Cooper wrote: > On 01/12/2021 10:35, Jan Beulich wrote: >> paging_mfn_is_dirty() is moderately expensive, so avoid its use unless >> its result might actually change anything. This means moving the >> surrounding if() down below all other checks that can result in cleari

Re: [PATCH 2/2] x86/hvm: Rework nested hap functions to reduce parameters

2021-12-02 Thread Jan Beulich
On 01.12.2021 21:13, Andrew Cooper wrote: > On 01/12/2021 09:14, Jan Beulich wrote: >> On 30.11.2021 19:11, Andrew Cooper wrote: >>> Most functions in this call chain have 8 parameters, meaning that the final >>> two booleans are spilled to the stack for for calls. >>> >>> First, delete nestedhap_w

Re: [PATCH 2/4] x86/altcall: Optimise away endbr64 instruction where possible

2021-12-02 Thread Jan Beulich
On 01.12.2021 20:07, Andrew Cooper wrote: > On 01/12/2021 08:20, Jan Beulich wrote: >> On 26.11.2021 22:22, Andrew Cooper wrote: >>> With altcall, we convert indirect branches into direct ones. With that >>> complete, none of the potential targets need an endbr64 instruction. >> Assuming that no o