On 29.11.2021 13:59, Anton Belousov wrote: > --- > tools/firmware/hvmloader/smbios.c | 146 ++++++++++++++++++++++++ > tools/firmware/hvmloader/smbios_types.h | 76 ++++++++++++ > 2 files changed, 222 insertions(+)
In addition to what Roger said: Without a commit message it's also unclear whether it was considered that the extra information might misguide a guest (kernel). Also, even if I expect you simply cloned existing functions: Please try to avoid cloning style violations; see ./CODING_STYLE. The most noticable to me issue was missing blanks around &&. Jan
