Re: user: Pass all required information with internal message when chaining hooks

2006-08-15 Thread Alexandre Julliard
Vitaliy Margolen <[EMAIL PROTECTED]> writes: > I don't see a problem here. We don't remove hook when chain is in use. > However calling server means we'll have to call server one more time. > That's on top of 5-6 calls already. Avoiding server calls is good, but not if it leads to incorrect seman

Re: user: Pass all required information with internal message when chaining hooks

2006-08-15 Thread Vitaliy Margolen
Tuesday, August 15, 2006, 3:21:51 AM, Alexandre Julliard wrote: > Vitaliy Margolen <[EMAIL PROTECTED]> writes: >> This patch deals with two sides of this problem. And actually saves >> some time by not calling server one extra time. > I don't think that's a good thing, now you risk calling a hook

Re: user: Pass all required information with internal message when chaining hooks

2006-08-15 Thread Alexandre Julliard
Vitaliy Margolen <[EMAIL PROTECTED]> writes: > This patch deals with two sides of this problem. And actually saves > some time by not calling server one extra time. I don't think that's a good thing, now you risk calling a hook that has been deleted already. You really want to fetch the hook info