Re: setupapi/tests: Remove an unneeded cast.

2009-01-08 Thread Steven Edwards
On Thu, Jan 8, 2009 at 12:29 PM, Steven Edwards wrote: > According to this link from google search, the prototypes are in MASM > include files going back to 2001. You might want to check the others > as well. > > http://www.cecs.csulb.edu/~hill/cecs325/MASM32/INCLUDE/SETUPAPI.INC Heh ignore that

Re: setupapi/tests: Remove an unneeded cast.

2009-01-08 Thread Steven Edwards
On Thu, Jan 8, 2009 at 5:22 AM, Alexandre Julliard wrote: > Where does the prototype come from? AFAICS it's not in the PSDK. Maybe > it's just wrong. When Eric first implemented those functions they were mostly undocumented. I believe I checked the prototypes verses some VB or Pascal code I foun

Re: setupapi/tests: Remove an unneeded cast.

2009-01-08 Thread Francois Gouget
On Thu, 8 Jan 2009, Hans Leidekker wrote: [...] > I don't know where the prototype came from, there was a stub there already > which entered Wine with commit 8196e2d0d0dbd04325201e14d95f88cad3cfd00f. I did not find it in my SDKs either. And a web search turned no useful result. > So we might as

Re: setupapi/tests: Remove an unneeded cast.

2009-01-08 Thread Hans Leidekker
On Thursday 08 January 2009 11:22:59 Alexandre Julliard wrote: > > This test is there to show that the prototype of StringTableLookUpStringEx > > is broken; the last parameter is treated as an integer instead of a pointer > > and this notation serves to document that fact. But I can see how this w

Re: setupapi/tests: Remove an unneeded cast.

2009-01-08 Thread Paul TBBle Hampson
On Thu, Jan 08, 2009 at 10:05:28AM +0100, Hans Leidekker wrote: > On Thursday 08 January 2009 00:05:01 Francois Gouget wrote: >> memset(buffer, 0x55, sizeof(buffer)); >> -retval = pStringTableLookUpStringEx(table, uilevel, >> ST_CASE_SENSITIVE_COMPARE, buffer, (LPDWORD)0); >> +retval

Re: setupapi/tests: Remove an unneeded cast.

2009-01-08 Thread Alexandre Julliard
Hans Leidekker writes: > On Thursday 08 January 2009 00:05:01 Francois Gouget wrote: > >> memset(buffer, 0x55, sizeof(buffer)); >> -retval = pStringTableLookUpStringEx(table, uilevel, >> ST_CASE_SENSITIVE_COMPARE, buffer, (LPDWORD)0); >> +retval = pStringTableLookUpStringEx(table, u

Re: setupapi/tests: Remove an unneeded cast.

2009-01-08 Thread Henri Verbeet
2009/1/8 Hans Leidekker : > On Thursday 08 January 2009 00:05:01 Francois Gouget wrote: > >> memset(buffer, 0x55, sizeof(buffer)); >> -retval = pStringTableLookUpStringEx(table, uilevel, >> ST_CASE_SENSITIVE_COMPARE, buffer, (LPDWORD)0); >> +retval = pStringTableLookUpStringEx(table,

Re: setupapi/tests: Remove an unneeded cast.

2009-01-08 Thread Hans Leidekker
On Thursday 08 January 2009 00:05:01 Francois Gouget wrote: > memset(buffer, 0x55, sizeof(buffer)); > -retval = pStringTableLookUpStringEx(table, uilevel, > ST_CASE_SENSITIVE_COMPARE, buffer, (LPDWORD)0); > +retval = pStringTableLookUpStringEx(table, uilevel, > ST_CASE_SENSITIVE_COM