Re: comctl32: initial theming tests (try 4)

2009-10-08 Thread André Hentschel
Owen Rudge schrieb: >> Ah, I see, no, it won't link I think without static. Some time ago I >> thought about adding v6util.c back and move code here, I'm not very >> familiar with makefile generation but I think we could place this new >> v6util.c into C_SRCS section of test makefile (if it's allow

Re: comctl32: initial theming tests (try 4)

2009-10-07 Thread Owen Rudge
Ah, I see, no, it won't link I think without static. Some time ago I thought about adding v6util.c back and move code here, I'm not very familiar with makefile generation but I think we could place this new v6util.c into C_SRCS section of test makefile (if it's allowed of course, but I think if

Re: comctl32: initial theming tests (try 4)

2009-10-07 Thread Nikolay Sivov
André Hentschel wrote: Nikolay Sivov schrieb: We already have this stuff defined in v6util.h. No reason to duplicate I suppose. My reason is, that the compiler warns that i am not using the functions inside v6util.h when i use it. Sorry, don't follow you. Does inclu

Re: comctl32: initial theming tests (try 4)

2009-10-07 Thread André Hentschel
Nikolay Sivov schrieb: > André Hentschel wrote: >> Nikolay Sivov schrieb: >> >>> André Hentschel wrote: >>> --- dlls/comctl32/tests/Makefile.in |1 + dlls/comctl32/tests/theming.c | 235 +++ 2 files changed, 236 insertions(+

Re: comctl32: initial theming tests (try 4)

2009-10-07 Thread Nikolay Sivov
André Hentschel wrote: Nikolay Sivov schrieb: André Hentschel wrote: --- dlls/comctl32/tests/Makefile.in |1 + dlls/comctl32/tests/theming.c | 235 +++ 2 files changed, 236 insertions(+), 0 deletions(-) create mode 100644 dlls/comctl32/tests/

Re: comctl32: initial theming tests (try 4)

2009-10-07 Thread André Hentschel
Nikolay Sivov schrieb: > André Hentschel wrote: >> --- >> dlls/comctl32/tests/Makefile.in |1 + >> dlls/comctl32/tests/theming.c | 235 >> +++ >> 2 files changed, 236 insertions(+), 0 deletions(-) >> create mode 100644 dlls/comctl32/tests/theming.c >>

Re: comctl32: initial theming tests (try 4)

2009-10-07 Thread Nikolay Sivov
André Hentschel wrote: --- dlls/comctl32/tests/Makefile.in |1 + dlls/comctl32/tests/theming.c | 235 +++ 2 files changed, 236 insertions(+), 0 deletions(-) create mode 100644 dlls/comctl32/tests/theming.c Hi, Andre. +#ifdef __i386__ +#define ARCH

Re: comctl32: initial theming tests

2009-09-24 Thread André Hentschel
Nikolay Sivov schrieb: > Why not reuse this > > +static const CHAR manifest[] = > > from v6util.h. > > Also it's better to introduce new create/delete manifest helpers in this > header and use them. > > It's better to use already defined classnames here: > --- > + struct classlist {WCHAR class[

Re: comctl32: initial theming tests

2009-09-24 Thread Roderick Colenbrander
> BTW. Do you plan to reregister all user32 classes on comctl32 load? How > could this be done at user32 side - testing for something like > IsThemeActive() while loading user32? > I have been toying with this a bit and trying to figure out how it works. From MSDN info and info from a site which h

Re: comctl32: initial theming tests

2009-09-23 Thread Nikolay Sivov
André Hentschel wrote: tests class redirection and "load"-order atm --- dlls/comctl32/tests/Makefile.in |1 + dlls/comctl32/tests/theming.c | 301 +++ 2 files changed, 302 insertions(+), 0 deletions(-) create mode 100644 dlls/comctl32/tests/theming.c