Nikolay Sivov schrieb:
> Why not reuse this
>
> +static const CHAR manifest[] =
>
> from v6util.h.
>
> Also it's better to introduce new create/delete manifest helpers in this
> header and use them.
>
> It's better to use already defined classnames here:
> ---
> + struct classlist {WCHAR class[24]; BOOL todo;} listW[] = {like
> ---
> STATUSCLASSNAMEW for example.
>
> If the purpose of that
> ---
> static void test_redirection(HINSTANCE hInstance, LPCWSTR clsname, BOOL
> todo)
> ---
>
> is to show that message procedure moves to comctl32 after enabling
> themes than
> testing for comctl32 classes is useless - winproc is already in this
> module.
>
> I don't think it's a good choice:
> ---
> + pIsThemeActive = (void*)GetProcAddress(hUxtheme, "IsThemeActive");
> + if (!pIsThemeActive || !pIsThemeActive())
> ---
> I mean what if I don't use theming on XP but classic decorations will it
> return TRUE?
> Not sure but maybe this class reregistration occurs anyway when v6
> module is loaded (manifest specified).
> Skipping like that will drop tests on native boxes that have theming
> disable what isn't good.
First, thanks for you review!
I think i fixed all of that in try 2
(http://www.winehq.org/pipermail/wine-patches/2009-September/078869.html) and i
hope i didnt introduce new traps.
--
Best Regards, André Hentschel
