Am Samstag, 28. Januar 2012, 14:19:22 schrieb Austin English:
> Follow up to
> http://www.winehq.org/pipermail/wine-patches/2012-January/110971.html. I
> was hoping to get it in before 1.4, to reduce users asking about it in
> #winehq/forums.
>
> I know Henri feels it should be properly fixed inst
Am 12.03.2011 23:29, schrieb Vitaliy Margolen:
> On 03/12/2011 12:10 PM, André Hentschel wrote:
>> Yeah i know the fixme has good reasons, but still it shouldn't mess on
>> console.
> You shouldn't use broken Wine. Anything that indicates a broken Wine,
> especially due to missing dependencies du
On 03/12/2011 12:10 PM, André Hentschel wrote:
Yeah i know the fixme has good reasons, but still it shouldn't mess on console.
You shouldn't use broken Wine. Anything that indicates a broken Wine,
especially due to missing dependencies during compile, should not be hidden.
Vitaliy.
On 03/12/2011 01:10 PM, André Hentschel wrote:
> Yeah i know the fixme has good reasons, but still it shouldn't mess on
> console.
> ---
> dlls/winex11.drv/xrender.c |4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xre
Yeah, this is the correct fix for this horribly broken API (did quite
a bit of xinput hacking recently). There is no call to query what
joysticks are available since the API was designed to allow you to
plug in a joystick while you are playing a game. Games just use
XInputGetState (which retrieves
I don't think so. That FIXME should have been an ERR, and if you're
seeing it that's a bug.
On Oct 16, 2009, at 10:26 PM, Peter Dons Tychsen wrote:
On Thu, 2009-10-15 at 19:19 -0500, Ken Thomases wrote:
+static int once;
+
+if (!once++) FIXME("independent left/right volume not
implemented
(%f, %f)\n", left, right);
I know it is a detail, but is it not a bit misleading hav
On Thu, 2009-10-15 at 19:19 -0500, Ken Thomases wrote:
> +static int once;
> +
> +if (!once++) FIXME("independent left/right volume not implemented
> (%f, %f)\n", left, right);
I know it is a detail, but is it not a bit misleading having a variable
called "once" when it will trigger the co
;>
>> --
>> -Austin
>
>> From 0dead16d2588bce8330ed862f8e5b6d3c6bb71a7 Mon Sep 17 00:00:00 2001
>> From: Austin English <[EMAIL PROTECTED]>
>> Date: Wed, 22 Oct 2008 20:28:37 -0500
>> Subject: [PATCH] ole32: quiet a ridiculously noisy fixme
>>
>&
:00 2001
> From: Austin English <[EMAIL PROTECTED]>
> Date: Wed, 22 Oct 2008 20:28:37 -0500
> Subject: [PATCH] ole32: quiet a ridiculously noisy fixme
>
> ---
> dlls/ole32/usrmarshal.c |6 +-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/d
Uh, you're changing what the function does.
*lpdwStatus = INTERNET_CONNECTION_LAN;
will only happen the first time.
Vincent Povirk
2008/10/18 Austin English <[EMAIL PROTECTED]>:
> Didn't receive any feedback on this one last time...
>
> --
> -Austin
>
>
>
>
On Fri, Oct 17, 2008 at 12:09 PM, Detlef Riekenberg <[EMAIL PROTECTED]> wrote:
> On Do, 2008-10-16 at 19:44 -0500, Austin English wrote:
>
>> +if (quietfixme == 0)
>> +{
>> +FIXME("unhandled bitmap format\n");
> Such a FIXME has no useful information.
> You should also d
On Do, 2008-10-16 at 19:44 -0500, Austin English wrote:
> +if (quietfixme == 0)
> +{
> +FIXME("unhandled bitmap format\n");
Such a FIXME has no useful information.
You should also dump the unhandled bitmap format in the FIXME
> +quietfixme = 1;
> +
On Fri, Oct 17, 2008 at 2:11 AM, Henri Verbeet <[EMAIL PROTECTED]> wrote:
> I don't think you want to change the return code based on whether the
> FIXME is shown or not.
>
>
>
Without the return code, gcc gives a compiler warning:
[EMAIL PROTECTED]:~/wine-git/dlls/mscms$ make
ccache gcc -c -I. -I
I don't think you want to change the return code based on whether the
FIXME is shown or not.
I think this one can be better removed entirely, wine will never get
support for dialup programs or other fancy ways to connect to the
internet, so this fixme is useless.
This fixme is quite an important one and it is not printed much in each app. It
can indicate real problems. At most it is printed a handful of times but in
general only once or twice. It is not a standard fixme which is printed
thousands of times for no good reason.
Roderick
> On Mon, Oct 6, 2
On Mon, Oct 6, 2008 at 3:39 AM, Henri Verbeet <[EMAIL PROTECTED]> wrote:
> 2008/10/6 Austin English <[EMAIL PROTECTED]>:
>> -if(DepthStencilFormat != WINED3DFMT_D24S8)
>> -FIXME("Add OpenGL context recreation support to
>> SetDepthStencilSurface\n");
>>
>> +if(DepthStencilFormat !=
2008/10/6 Austin English <[EMAIL PROTECTED]>:
> -if(DepthStencilFormat != WINED3DFMT_D24S8)
> -FIXME("Add OpenGL context recreation support to
> SetDepthStencilSurface\n");
>
> +if(DepthStencilFormat != WINED3DFMT_D24S8) {
> + if (warn) {
> +FIXME("Add OpenGL context
On Fri, 2008-10-03 at 12:01 -0500, Austin English wrote:
> +if (apc_user)
> + if (warn) {
> + FIXME("I/O completion on lock not implemented yet\n");
> + warn = FALSE;
> + }
It's a style thing, but I for one would much prefer
brackets around the outer if to pre
Hi Austin,
> Not sure if this is the best way to go about this or not. Any advice
> appreciated (or if anyone else wants to silence it :-P).
You're close. The only fix is:
+BOOLEAN warn = TRUE;
should be static. (Otherwise it'll be TRUE every time the function is
called, so it'll always
Austin English wrote:
> Howdy,
>
> I was taking a look at some of the noisy fixme's, and wanted some
> feedback on the attached patch.
> This particular fixme is _really_ noisy...out of this
> (http://bugs.winehq.org/attachment.cgi?id=16447)
> log, it has 9635 of the 13117 lines!
>
> "fixme:ntdll:N
2008/10/3 Austin English <[EMAIL PROTECTED]>:
> Howdy,
>
> I was taking a look at some of the noisy fixme's, and wanted some
> feedback on the attached patch.
That patch won't make the FIXME any less noisy, for one.
> This particular fixme is _really_ noisy...out of this
> (http://bugs.winehq.org/
On Fri, Oct 3, 2008 at 11:46 AM, Austin English <[EMAIL PROTECTED]> wrote:
> Howdy,
>
> I was taking a look at some of the noisy fixme's, and wanted some
> feedback on the attached patch.
> This particular fixme is _really_ noisy...out of this
> (http://bugs.winehq.org/attachment.cgi?id=16447)
> lo
On Fri, 2008-10-03 at 11:46 -0500, Austin English wrote:
> +BOOLEAN warn = TRUE;
This has to be static, else it will always be TRUE.
--
Dimi Paun <[EMAIL PROTECTED]>
Lattica, Inc.
Howdy,
I was taking a look at some of the noisy fixme's, and wanted some
feedback on the attached patch.
This particular fixme is _really_ noisy...out of this
(http://bugs.winehq.org/attachment.cgi?id=16447)
log, it has 9635 of the 13117 lines!
"fixme:ntdll:NtLockFile I/O completion on lock not i
2008/9/28 Dimi Paun <[EMAIL PROTECTED]>:
> Silence noisy FIXME about uninteresting ExtTextOut() flags.
> Keep the FIXME in the string to make it easily grep-able.
>
> diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c
> index 1e8cac3..c3e4840 100644
> --- a/dlls/gdi32/f
27 matches
Mail list logo
