On Oct 16, 2009, at 10:26 PM, Peter Dons Tychsen wrote:

On Thu, 2009-10-15 at 19:19 -0500, Ken Thomases wrote:
+    static int once;
+
+ if (!once++) FIXME("independent left/right volume not implemented
(%f, %f)\n", left, right);

I know it is a detail, but is it not a bit misleading having a variable
called "once" when it will trigger the code every 4294967295th time.

Its not 100% wrong, but only 0.000000023% wrong :-)

More correct would probably be:

static int once;
if(!once) {bla...bla; once=1};

I originally wrote it something like that, but then looked at how others were coding similar tests and decided to follow their example. For example:

http://www.winehq.org/pipermail/wine-cvs/2009-September/059735.html

Cheers,
Ken



Reply via email to