Re: Fixing wrong prototypes in a header

2007-08-20 Thread Juan Lang
> I think that's a case where we could diverge from the PSDK (with a > comment explaining why). Otherwise the header is completely useless: we > could not even make sure its prototypes match those of our > implementation. Thanks Francois, I was hoping you'd check in. > Btw, did you check this aga

Re: Fixing wrong prototypes in a header

2007-08-20 Thread Francois Gouget
On Wed, 15 Aug 2007, Juan Lang wrote: [...] > Should I leave the prototypes incorrect in wintrust.h to match the > PSDK, or should I fix them to make them more convenient for me to use? I think that's a case where we could diverge from the PSDK (with a comment explaining why). Otherwise the heade

re: Fixing wrong prototypes in a header

2007-08-15 Thread Dan Kegel
I'd say leave them wrong in our headers, but report the problem to Microsoft, and fix our headers when they fix theirs... - Dan

Fixing wrong prototypes in a header

2007-08-15 Thread Juan Lang
Some of the function prototypes in wintrust.h have the wrong calling convention. The trouble is, PSDK gets them wrong too. So calling the functions, as declared in the PSDK header, results in a crash in Windows. Casting them to function pointers with the correct calling convention succeeds. Sho