Re: [PATCH 3/3]vbscript: Implemented builtin function CBool

2013-04-18 Thread Zhan Jianyu
On Thu, Apr 18, 2013 at 6:24 PM, Jacek Caban wrote: > > I don't think converting to double is a good idea here. Why don't you do > conversions directly to BOOL for all cases? > My fisrt thought on this is to convert all type to double, and then at last I just do one-time comparision, to avoid

Re: [PATCH 3/3]vbscript: Implemented builtin function CBool

2013-04-18 Thread Jacek Caban
On 04/17/13 18:18, larmbr zhan wrote: > +double tmp; > +WCHAR trueW[] = {'T','r','u','e','\0'}; > +WCHAR falseW[] = {'F','a','l','s','e','\0'}; > + > +TRACE("%s\n", debugstr_variant(arg)); > + > +assert(args_cnt == 1); > + > +switch(V_VT(arg)) { > +case VT_I2: > +

Re: [PATCH 3/3]vbscript: Implemented builtin function CBool

2013-04-17 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25139 Your paranoid android