Re: [PATCH 2/3]vbscript: Implemented builtin function CInt

2013-04-18 Thread Jacek Caban
On 04/17/13 18:17, larmbr zhan wrote: > +static HRESULT to_int_banker_rounding(VARIANT *v, int *ret) > +{ I wonder if this conversion is used in any other place as well. I think this does not need a helper function until we find other use cases as well, esp. since you could simplify that to: if(V

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt

2013-04-17 Thread Dmitry Timoshkov
larmbr zhan wrote: > +case VT_BOOL: > +*ret = V_BOOL(v) ? -1 : 0; > +break; Shouldn't this be VARIANT_TRUE/VARIANT_FALSE instead of -1/0? -- Dmitry.

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt

2013-04-17 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25138 Your paranoid android