Re: [PATCH] imm32: Fixed crashing in ImmGetIMCCSize.

2013-07-30 Thread Qian Hong
Hello Nikolay, On Wed, Jul 10, 2013 at 1:06 AM, Nikolay Sivov wrote: > This could be some a different bug, and putting exception handler around it > is not necessary a right solution. Good catch, I think you are right. I found ImmLockIMC()/ImmUnLockIMC()/etc are called even after ImmDestroyCont

Re: [PATCH] imm32: Fixed crashing in ImmGetIMCCSize.

2013-07-30 Thread Qian Hong
Forgot to say, as described in the last post, this patch doesn't kill the culprit, please reject the patch, thanks.

Re: [PATCH] imm32: Fixed crashing in ImmGetIMCCSize.

2013-07-09 Thread Nikolay Sivov
On 7/9/2013 18:52, Qian Hong wrote: Hi Nikolay, Thanks for comments! On Tue, Jul 9, 2013 at 9:01 PM, Nikolay Sivov wrote: Do you really need this for Office 2010 or null check is enough? If it's passing 0 handle here that's what you should check imho. If HIMCC is really a handle and not a str

Re: [PATCH] imm32: Fixed crashing in ImmGetIMCCSize.

2013-07-09 Thread Qian Hong
Hi Nikolay, Thanks for comments! On Tue, Jul 9, 2013 at 9:01 PM, Nikolay Sivov wrote: > Do you really need this for Office 2010 or null check is enough? If it's > passing 0 handle here that's what you should check imho. If HIMCC is really > a handle and not a struct pointer like in wine, that's

Re: [PATCH] imm32: Fixed crashing in ImmGetIMCCSize.

2013-07-09 Thread Nikolay Sivov
On 7/9/2013 16:50, Qian Hong wrote: Fixed a crash in MS Office 2010 Chinese version. Thanks Jiang Yike for the helps on testing :) --- dlls/imm32/imm.c |6 ++ dlls/imm32/tests/imm32.c | 13 + 2 files changed, 19 insertions(+) +if (IsBadReadPtr(internal, siz