On 7/9/2013 18:52, Qian Hong wrote:
Hi Nikolay,
Thanks for comments!
On Tue, Jul 9, 2013 at 9:01 PM, Nikolay Sivov <bungleh...@gmail.com> wrote:
Do you really need this for Office 2010 or null check is enough? If it's
passing 0 handle here that's what you should check imho. If HIMCC is really
a handle and not a struct pointer like in wine, that's not how a handle
validity check will look like.
null check is not enough, see the below quoted log:
--- snip ---
0029:Call imm32.ImmGetIMCCSize(bf9c73e5) ret=0d6d3545
--- snip ---
This could be some a different bug, and putting exception handler around it
is not necessary a right solution.
Another example:
--- snip ---
0029:Call imm32.ImmGetIMCCSize(00000190) ret=0a193545
--- snip ---
Could you provide more details for how to check the validity of the
handle in the right way?
Well, if it's really supposed to be a handle, meaning it's a table index
(with some offset or not),
this check will simply check for index boundaries and whether slot is
allocated. This all need
some tests.
Thanks a lot!
--
Regards,
Qian Hong
-
http://www.winehq.org
