Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

2013-06-24 Thread Henri Verbeet
On 24 June 2013 16:44, Matteo Bruni wrote: > @@ -1673,6 +1673,8 @@ struct texture_stage_op > unsignedaarg2 : 8; > unsignedaarg0 : 8; > > +DWORD constant; > + > struct color_fixup_desc color_fixup; > unsignedt

Re: [PATCH] advapi32: RegDeleteKey tests

2013-06-24 Thread Dmitry Timoshkov
George Stephanos wrote: > +res = RegOpenKeyExA( hkey, "subkey1", 0, KEY_READ, &hkeysub1 ); > +ok(res != ERROR_SUCCESS, "test key found in user's classes: %d\n", res); ... > +res = RegOpenKeyExA( hklm, "subkey1", 0, KEY_READ, &hklmsub1 ); > +ok(res != ERROR_SUCCESS, "test key found

Re: d3dx9: Implement adjacency in D3DXCreateSphere

2013-06-24 Thread Nozomi Kodama
Hello Thank you for the feedback, Rico. But, there is a problem with this patch.  Native d3dx9 does not call GenerateAdjacency. It hardcodes the adjacency. That is proved by the case D3DXCreateSpehere(device, 0.0f, 10,10,adjacency) where native gives different result using GenerateAdjacency or

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

2013-06-24 Thread Christian Costa
I'm not Henri but I can mention a number of issues (which might or might not match with Henri's). +for (stage = 0; stage < MAX_TEXTURES && settings->op[stage].cop != WINED3D_TOP_DISABLE; ++stage) You probably want to generate this code only for texture stages actually using constants. Yes.

Re: msvcr90/tests: skip tests of function ?_name_internal_method if it is not present

2013-06-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26093 Your paranoid android

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

2013-06-24 Thread Matteo Bruni
2013/6/24 Christian Costa : > Le 24/06/2013 09:24, Henri Verbeet a écrit : > >> On 23 June 2013 21:57, Christian Costa wrote: >>> >>> When D3DTA_CONSTANT is use in a texture stage, the generated shader uses >>> variables that are not defined making thus the compilation to fail. >>> This patch decl

Re: ws2_32: Fix interface-bound filter to accept locally generated targeted packets.

2013-06-24 Thread Erich E. Hoover
On Mon, Jun 24, 2013 at 2:33 AM, Jonas Maebe wrote: > ... > The added "struct sock_filter ip_memaddr" field doesn't seem to be used. It's set in the initialization of "generic_interface_filter", which is used to setup "specific_interface_filter" for individual sockets. Only the field correspondin

Re: ol32: Make enumx implementation look more like a COM interface.

2013-06-24 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> > The patch actually removes the casts, the only cast that remains is the >> > cast >> > on the caller's side for the vtable pointer (which is much cleaner IMO >> > since >> > every COM object implements IUnknown), but the implementatio

Re: [PATCH]winhttp:session.c fix a bug(return value is null)

2013-06-24 Thread Hans Leidekker
On Mon, 2013-06-24 at 19:57 +0900, 中川祥 wrote: > diff --git a/dlls/winhttp/session.c b/dlls/winhttp/session.c > index 660eae5..dfe23d4 100644 > --- a/dlls/winhttp/session.c > +++ b/dlls/winhttp/session.c > @@ -1316,6 +1316,8 @@ BOOL WINAPI WinHttpDetectAutoProxyConfigUrl( DWORD > flags, LPWSTR *url

Re: ol32: Make enumx implementation look more like a COM interface.

2013-06-24 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > The patch actually removes the casts, the only cast that remains is the cast > > on the caller's side for the vtable pointer (which is much cleaner IMO since > > every COM object implements IUnknown), but the implementation itself is cast > > free, and looks now as a

Re: ol32: Make enumx implementation look more like a COM interface.

2013-06-24 Thread Alexandre Julliard
Dmitry Timoshkov writes: > The patch actually removes the casts, the only cast that remains is the cast > on the caller's side for the vtable pointer (which is much cleaner IMO since > every COM object implements IUnknown), but the implementation itself is cast > free, and looks now as an actual

Re: ol32: Make enumx implementation look more like a COM interface.

2013-06-24 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > This patch should be quite obvious in its intent: it changes vtable type > > to IUnknown which helps to remove This* to IUnknown* casts in order to > > avoid obvious problems with vtable pointer placement inside of object > > implementation. Basically this is just a

Re: ol32: Make enumx implementation look more like a COM interface.

2013-06-24 Thread Alexandre Julliard
Dmitry Timoshkov writes: > This patch should be quite obvious in its intent: it changes vtable type > to IUnknown which helps to remove This* to IUnknown* casts in order to > avoid obvious problems with vtable pointer placement inside of object > implementation. Basically this is just a clean up

Re: ws2_32: Fix interface-bound filter to accept locally generated targeted packets.

2013-06-24 Thread Jonas Maebe
On 24 Jun 2013, at 04:30, Erich E. Hoover wrote: <0001-ws2_32-Fix-interface-bound-filter-to-accept-locally-.patch> The added "struct sock_filter ip_memaddr" field doesn't seem to be used. Jonas

Re: wbemprox: Implement Win32_OperatingSystem.LocalDateTime.

2013-06-24 Thread Hans Leidekker
On Sun, 2013-06-23 at 18:55 +0200, Sylvain Petreolle wrote: > +static WCHAR *get_localdatetime(void) > +{ > +static const WCHAR fmtW[] = > + > {'%','0','4','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u', > + '.','%','0','6','u','+','0','0','0

Re: wbemprox: Implement some properties of Win32_BIOS. (resend 4)

2013-06-24 Thread Hans Leidekker
On Sat, 2013-06-22 at 12:17 +0900, Kim Jung Eon (김중언) wrote: > static const struct column col_bios[] = > { > +{ prop_biosversionW, CIM_STRING|CIM_FLAG_ARRAY}, > { prop_descriptionW, CIM_STRING }, > { prop_manufacturerW, CIM_STRING }, > { prop_releasedateW, CIM_DATETIME }, >

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

2013-06-24 Thread Christian Costa
Le 24/06/2013 09:24, Henri Verbeet a écrit : On 23 June 2013 21:57, Christian Costa wrote: When D3DTA_CONSTANT is use in a texture stage, the generated shader uses variables that are not defined making thus the compilation to fail. This patch declare these variables with the value from the rel

Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

2013-06-24 Thread Henri Verbeet
On 23 June 2013 21:57, Christian Costa wrote: > When D3DTA_CONSTANT is use in a texture stage, the generated shader uses > variables that are not defined making thus the compilation to fail. > This patch declare these variables with the value from the related texture > stage state D3D_TSS_CONSTA

Re: wined3d: print the architecture when showing driver problems

2013-06-24 Thread Henri Verbeet
On 23 June 2013 07:10, Austin English wrote: > Please consider applying before the release of 1.6. It has no > functional changes, but would really help when diagnosing user > problems. > This is not really a wined3d patch. That said, while I agree that printing the architecture would be useful he

Re: po: Update Simplified Chinese translation (resend)

2013-06-24 Thread Tiger Soldier
(Sorry to Hin-Tak for reposting, I didn't reply all) Thanks for your comment, Hin-Tak. I categorized your comment as follow: 1. Difference between SC and TC: 活跃连接 - 作用中的連線 句柄 - 控制代碼 (yes I hate it but it has been used in SC for a long time) 接口 - 介面 (as in programming and network interface) 优先级 - 優