Re: loader: Add --compile-info option to Wine.

2007-12-22 Thread Zachary Goldberg
On Dec 19, 2007 2:18 AM, Andrew Riedi <[EMAIL PROTECTED]> wrote: > I have sent in a new patch with the same title to address the problems > discussed in this thread. Thanks to all of the people who looked over my > patch and discussed its possible problems. It should surely help debugging > Wine

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.

2007-12-22 Thread Huang, Zhangrong
hi, 2007/12/23, James Hawkins <[EMAIL PROTECTED]>: > On Dec 22, 2007 6:57 PM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > > James Hawkins schreef: > > > > > On Dec 22, 2007 12:25 PM, Huang, Zhangrong <[EMAIL PROTECTED]> wrote: > > > > > >> 2007/12/23, James Hawkins <[EMAIL PROTECTED]> > > >

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.

2007-12-22 Thread James Hawkins
On Dec 22, 2007 6:57 PM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > James Hawkins schreef: > > > On Dec 22, 2007 12:25 PM, Huang, Zhangrong <[EMAIL PROTECTED]> wrote: > > > >> 2007/12/23, James Hawkins <[EMAIL PROTECTED]> > >>> On Dec 22, 2007 9:46 AM, Huang, Zhangrong <[EMAIL PROTECTED]> wrote

Re: bugfix for bug #6994

2007-12-22 Thread Chris Robinson
On Saturday 22 December 2007 04:43:17 pm Alexei Slepov wrote: > We can't use ordinary backbuffer to render textures, which size is more > than > size of the screen. For example, if the screen size is 800x600, we can't > render background texture, which size is 1024x1024. So, if we are using > backb

Fix build when valgrind header is present but does not define VALGRIND_MAKE_WRITABLE

2007-12-22 Thread Vincent Pelletier
Fixes gcc error: signal_i386.o: In function `setup_exception': /home/vincent/git/wine/dlls/ntdll/signal_i386.c:940: undefined reference to `VALGRIND_MAKE_WRITABLE' collect2: ld returned 1 exit status Others uses of this constant are already checked this way. diff --git a/dlls/ntdll/signal_i386.c

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.

2007-12-22 Thread Maarten Lankhorst
James Hawkins schreef: > On Dec 22, 2007 12:25 PM, Huang, Zhangrong <[EMAIL PROTECTED]> wrote: > >> 2007/12/23, James Hawkins <[EMAIL PROTECTED]> >>> On Dec 22, 2007 9:46 AM, Huang, Zhangrong <[EMAIL PROTECTED]> wrote: >>> Hi, Sorry for the delay. Here is a test, pls import

Re: New bugzilla components (round 3)

2007-12-22 Thread James Hawkins
On Dec 22, 2007 12:54 PM, Vitaliy Margolen <[EMAIL PROTECTED]> wrote: > Ok we talked and talked and talked and where did it all go? Where are the > agreed upon changes? > > If we can't agree on everything, then lets do parts that everyone is ok > with. Then decide on more changes. > > > So far this

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.

2007-12-22 Thread James Hawkins
On Dec 22, 2007 12:25 PM, Huang, Zhangrong <[EMAIL PROTECTED]> wrote: > 2007/12/23, James Hawkins <[EMAIL PROTECTED]>: > > > On Dec 22, 2007 9:46 AM, Huang, Zhangrong <[EMAIL PROTECTED]> wrote: > > > Hi, > > > Sorry for the delay. > > > Here is a test, pls import the attached registry files, and co

skype regression (kernel32 / winedos)

2007-12-22 Thread Alexander Dorofeyev
Hi. Unfortunately, Skype stopped working in git wine, it crashes shortly after start. Commit found via bisect: http://source.winehq.org/git/wine.git/?a=commit;h=e2a366ce338d5b6b0f3c8962d70134f8d4e87f3b kernel32: Forward interrupts in 32-bit code to winedos too last messages with +io,+int: warn

New bugzilla components (round 3)

2007-12-22 Thread Vitaliy Margolen
Ok we talked and talked and talked and where did it all go? Where are the agreed upon changes? If we can't agree on everything, then lets do parts that everyone is ok with. Then decide on more changes. So far this what everyone was happy with: wine-misc -> unknown (default selection) test ->

Re: wined3d: fix check for P8 render target

2007-12-22 Thread Alexander Dorofeyev
Yes your patch fixes most problems (there are some remaining issues but they were not fixed by mine either). Roderick Colenbrander wrote: >> Hi. >> >> Yes, exactly, the AVP1 game is using p8 textures and color keys on some of >> them >> for transparency. >> >> The thing is, the "index_in_alpha" h

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.

2007-12-22 Thread Huang, Zhangrong
2007/12/23, James Hawkins <[EMAIL PROTECTED]>: > On Dec 22, 2007 9:46 AM, Huang, Zhangrong <[EMAIL PROTECTED]> wrote: > > Hi, > > Sorry for the delay. > > Here is a test, pls import the attached registry files, and copy > > native activeds.dll, adsldpc.dll, > > adsldp.dll to your windows system32 d

Re: wined3d: fix check for P8 render target

2007-12-22 Thread Roderick Colenbrander
> Hi. > > Yes, exactly, the AVP1 game is using p8 textures and color keys on some of > them > for transparency. > > The thing is, the "index_in_alpha" hack DOES get enabled on its P8 3D > textures, > and that's the problem I'm trying to fix. I don't see the "primary render > target > is p8" check

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.

2007-12-22 Thread James Hawkins
On Dec 22, 2007 9:46 AM, Huang, Zhangrong <[EMAIL PROTECTED]> wrote: > Hi, > Sorry for the delay. > Here is a test, pls import the attached registry files, and copy > native activeds.dll, adsldpc.dll, > adsldp.dll to your windows system32 dir, and patch > wine/dlls/ole32/tests/moniker.c > > Then ru

Re: msi: fix memory leaks on error paths (found by Smatch). [2/2]

2007-12-22 Thread James Hawkins
On Dec 22, 2007 4:29 AM, Lionel_Debroux <[EMAIL PROTECTED]> wrote: > "msi_load_summary_properties" and "MsiSourceListAddSourceExW" in > dlls/msi/package.c and dlls/msi/source.c get flagged by Michael > Stefaniuc's unfree-wine.pl script. > > 2007-12-21 Lionel Debroux <[EMAIL PROTECTED]> > *

Re: msi: correctly handle return value of msi_realloc. [1/2]

2007-12-22 Thread James Hawkins
On Dec 22, 2007 4:28 AM, Lionel_Debroux <[EMAIL PROTECTED]> wrote: > Several functions in dlls/msi/action.c and dlls/msi/database.c use > constructs of the form > ptr = msi_realloc (ptr, newsize); > > In the (admittedly very unlikely) situation where msi_realloc fails, > this leaks, or even faults:

Re: Calls to realloc-type functions in Wine...

2007-12-22 Thread Lionel_Debroux
Hi Juan, > The results you sent aren't very useful without more investigation. Indeed. I have started doing that on msi (which is the first place where I spotted such a construct, but as the list shows, it's far from being the only one), and sent a patch this morning. However, I have neither the t

Re: Calls to realloc-type functions in Wine...

2007-12-22 Thread Juan Lang
Hi Lionel, > It's very unlikely that *realloc fails, but if it does, this leaks some > memory (or may fault, if the code is not protected against *realloc > returning NULL). Note that it's debatable what the best course of action here is. It's true that in case of failure, the original pointer s

Re: wined3d: fix check for P8 render target

2007-12-22 Thread Alexander Dorofeyev
Hi. Yes, exactly, the AVP1 game is using p8 textures and color keys on some of them for transparency. The thing is, the "index_in_alpha" hack DOES get enabled on its P8 3D textures, and that's the problem I'm trying to fix. I don't see the "primary render target is p8" check in the code, instead

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.

2007-12-22 Thread Huang, Zhangrong
Hi, Sorry for the delay. Here is a test, pls import the attached registry files, and copy native activeds.dll, adsldpc.dll, adsldp.dll to your windows system32 dir, and patch wine/dlls/ole32/tests/moniker.c Then run the test: $ ../../../wine ole32_test.exe.so moniker err:ole:apartment_getclassobje

Re: wined3d: fix check for P8 render target

2007-12-22 Thread Roderick Colenbrander
> Hi. > > I think this part of d3dfmt_p8_init_palette has a bug, because it appears > to be > checking that render target is a render target. Incorrectly going into > index_in_alpha codepath here causes this bug: > > http://bugs.winehq.org/show_bug.cgi?id=10797 > > in Aliens vs Predator 1 game -

Re: Calls to realloc-type functions in Wine...

2007-12-22 Thread Kai Blin
On Saturday 22 December 2007 11:30:05 Lionel_Debroux wrote: > ./dlls/secur32/dispatcher.c:152 This one is safe, as buf is only assigned to helper->com_buf on success of the call. helper->com_buf is free()d when the user correctly shuts down the security context. Cheers, Kai -- Kai Blin WorldF

Re: ole32: fix wrong timeout check

2007-12-22 Thread Alexander Dorofeyev
Yeah these calculations are a headache. I could probably write now < start_time || now >= start_time + dwTimeout to at least avoid a "hang" if GetTickCount counter overflows. This won't solve not waiting the required time if, say, start_time + dwTimeout overflows, and that can also be a problem

Re: mapi32: Resolve FIXME regarding attachment lists in MAPISendMail function

2007-12-22 Thread Hans Leidekker
On Friday 21 December 2007 22:54:35 Mark Neyhart wrote: > Can you refer me to examples of command line parameter parsing which I could > use in winebrowser? Many apps under programs/ do command line parsing. Look at winepath for example, which handles both long and short options. > Are you refer