Re: RFC: XEmbed Systray Patches

2006-08-15 Thread James Liggett
On Tue, 2006-08-15 at 12:14 +0100, Mike Hearn wrote: > Great work! Now let's hope Alexandre accepts it. We're working on it. I talked about it briefly with Alexandre this morning on IRC. ATM he thinks I should get rid of the low-level checks for the systray windows. He suggested that I do somethin

Re: oleaut32: Added insufficient memory check to ITypelib2:GetDocumentation2

2006-08-15 Thread Dan Kegel
2006/8/15, Benjamin Arai <[EMAIL PROTECTED]>: ChangeLog: - Added insufficient memory check to ITypelib2::GetDocumentation2 - Returns MSDN specified value STG_E_INSUFFICIENTMEMORY Have you *ever* seen this run out of memory in real life? - Dan

Re: oleaut32: Added insufficient memory check to ITypelib2:GetDocumentation2

2006-08-15 Thread Frank Richter
On 16.08.2006 04:23, Benjamin Arai wrote: >if(pbstrHelpString) > + { > *pbstrHelpString=SysAllocString(This->DocString); > +if(!*pbstrHelpString) > + return STG_E_INSUFFICIENTMEMORY; > + } >if(pdwHelpStringContext) > *pdwHelpStringContext

Re: kernel32: add GetNativeSystemInfo (Try 2)

2006-08-15 Thread Dan Kegel
This patch is good, and helps fix MS Photostory 2 LE's installer ( http://bugs.winehq.org/show_bug.cgi?id=5966 ). Robert, you might need to repost, though; there was a wrapped line.

Re: ddraw: direct3d.c variable-names request

2006-08-15 Thread Andrew Talbot
H. Verbeet wrote: > I assume you're talking about direct3d.c in ddraw then. Sorry, yes. > The second > parameter is the "device description" for the enumerated device. The > first device is the reference device, the second one is our wined3d > implementation. In which case, would you be happy

Re: wined3d: direct3d.c variable-names request

2006-08-15 Thread H. Verbeet
On 15/08/06, Andrew Talbot <[EMAIL PROTECTED]> wrote: I'm looking to fix a couple of write-strings warnings in direct3d.c: lines 323 and 334, the second parameter to Callback(), but I don't know enough to give suitable names to the intended substitute variables. So I would be glad of suggestions,

wined3d: direct3d.c variable-names request

2006-08-15 Thread Andrew Talbot
This request is aimed at the wined3d specialists. Hi, I'm looking to fix a couple of write-strings warnings in direct3d.c: lines 323 and 334, the second parameter to Callback(), but I don't know enough to give suitable names to the intended substitute variables. So I would be glad of suggestions,

Re: [meta-bug] I can not contact Jeremy Newman

2006-08-15 Thread Molle Bestefich
Joerg Mayer wrote: http://www.bugzilla.org/features/#eam As far as I can see from a real-world Bugzilla, Bugzilla's HTML munging means replacing the @ character with the HTML entity "@". That's a stupid scheme. Even if it replaced all the characters, it would be a stupid scheme: First, it's t

Re: RFC: XEmbed Systray Patches

2006-08-15 Thread Mike Hearn
On 8/15/06, James Liggett <[EMAIL PROTECTED]> wrote: Just FYI--I figured out what was wrong with my X test app. I just needed to set some size hints on the window, and now the size is perfect when the window docks. Now I've got my test app, a GNOME program, and some wine apps all peacefully coexi

Re: user: Pass all required information with internal message when chaining hooks

2006-08-15 Thread Alexandre Julliard
Vitaliy Margolen <[EMAIL PROTECTED]> writes: > I don't see a problem here. We don't remove hook when chain is in use. > However calling server means we'll have to call server one more time. > That's on top of 5-6 calls already. Avoiding server calls is good, but not if it leads to incorrect seman

Re: user: Pass all required information with internal message when chaining hooks

2006-08-15 Thread Vitaliy Margolen
Tuesday, August 15, 2006, 3:21:51 AM, Alexandre Julliard wrote: > Vitaliy Margolen <[EMAIL PROTECTED]> writes: >> This patch deals with two sides of this problem. And actually saves >> some time by not calling server one extra time. > I don't think that's a good thing, now you risk calling a hook

Re: usp10: Resend - Remove unnecessary casts in test suite

2006-08-15 Thread Alexandre Julliard
Jeff L <[EMAIL PROTECTED]> writes: > Any problems? It doesn't apply. When resending a patch please regenerate it against the current tip. -- Alexandre Julliard [EMAIL PROTECTED]

Re: usp10: Resend - Add funtionality for ScriptStringAnalyse

2006-08-15 Thread Alexandre Julliard
Jeff L <[EMAIL PROTECTED]> writes: > +cMaxItems = 255; /* Pick an abritary size for buffers */ > +if (!*pssa) /* Clean it out and start again */ > +ScriptStringFree(pssa); I still don't see why you want to free a NULL pointer. > +{ > +

Re: user: Pass all required information with internal message when chaining hooks

2006-08-15 Thread Alexandre Julliard
Vitaliy Margolen <[EMAIL PROTECTED]> writes: > This patch deals with two sides of this problem. And actually saves > some time by not calling server one extra time. I don't think that's a good thing, now you risk calling a hook that has been deleted already. You really want to fetch the hook info

Re: RFC: XEmbed Systray Patches

2006-08-15 Thread Alexandre Julliard
James Liggett <[EMAIL PROTECTED]> writes: > +{ > +if ((X11DRV_get_systray_window( display ) == None) || > +(!(ex_style & WS_EX_TRAYWINDOW))) > +{ > +XMapWindow( display, data->whole_window ); > +

Re: [meta-bug] I can not contact Jeremy Newman

2006-08-15 Thread Joerg Mayer
On Mon, Aug 14, 2006 at 08:31:16PM -0500, Jeremy White wrote: > > It would be really helpful if you could add a constructive comment. > So, for example, if you could download and install the current > WineHQ version of Bugzilla and determine what settings mask > the emails, or work up a patch that