Re: HAL and Copy Protection

2006-08-07 Thread Jesse Allen
Ok, I just verified that HAL works perfectly fine for what we want. In fact, it does make thing easier for people as you don't have to mess with those device symlinks :) I don't suspect anything wrong with GCC 4.xx now, as I think the ubuntu package is compiled with 4.0.3. I think the report on t

Re: winebrowser and multi-word commands

2006-08-07 Thread Yuriy
Hello, Ok, so I realized that winebrowser is an actual program, not a script. I fixed the bug, but I'm sending the patch here first so somebody can look over it because I've never written more than a couple lines of C before. This patch allows commands with up to 4 arguments, such as "kfmclient

Re: wined3d: stub out remaining renderstates

2006-08-07 Thread Stefan Dösinger
Am Dienstag 08 August 2006 00:06 schrieb Jan Zerebecki: > If this patch is rejected from inclusion, please tell me why, as i would > have to ask anyway. It looks like you forgot d3d7 render states like TEXTUREMAPBLEND. This state isn't really important for this patch, I will send an implementation

Re: Wide-string Functions: Double Casting

2006-08-07 Thread Andrew Talbot
David Laight wrote: > On Mon, Aug 07, 2006 at 09:54:20PM +0100, Andrew Talbot wrote: >> would like to submit a patch that, for example, changes strchrW() to: >> >> extern inline WCHAR *strrchrW( const WCHAR *str, WCHAR ch ) >> { >> WCHAR *ret = NULL; >> do { if (*str == ch) ret = (WCHAR *

Re: Wide-string Functions: Double Casting

2006-08-07 Thread David Laight
On Mon, Aug 07, 2006 at 09:54:20PM +0100, Andrew Talbot wrote: > would like to submit a patch that, for example, changes strchrW() to: > > extern inline WCHAR *strrchrW( const WCHAR *str, WCHAR ch ) > { > WCHAR *ret = NULL; > do { if (*str == ch) ret = (WCHAR *)(size_t)str; } while (*str++

Re: Wide-string Functions: Double Casting

2006-08-07 Thread Andrew Talbot
Andrew Talbot wrote: >[...] > So I > would like to submit a patch that, for example, changes strchrW() to: > > extern inline WCHAR *strrchrW( const WCHAR *str, WCHAR ch ) >[...] Yes, that was a typo: it should say "changes strrchrW()...". -- Andy.

Wide-string Functions: Double Casting

2006-08-07 Thread Andrew Talbot
Although I accept that my opinion may not be universally shared :-), I believe that it is better to turn -Wcast-qual on permanently and double-cast the appropriate return values of the relevant wide-string functions (strchrW(), strrchrW(), strpbrkW(), memchrW() and memrchrW()) than to leave it norm

Re: RFC: XEmbed Systray Patches

2006-08-07 Thread James Liggett
On Mon, 2006-08-07 at 18:02 +0100, Mike Hearn wrote: > On Sun, 06 Aug 2006 20:10:19 -0700, James Liggett wrote: > > so I suspect that this has something to do with stack problem > > More likely it's a speed issue - logging slows the code down a lot which > could "fix" a race condition. X is sort o

Re: RFC: XEmbed Systray Patches

2006-08-07 Thread James Liggett
On Mon, 2006-08-07 at 18:02 +0100, Mike Hearn wrote: > On Sun, 06 Aug 2006 20:10:19 -0700, James Liggett wrote: > > so I suspect that this has something to do with stack problem > > More likely it's a speed issue - logging slows the code down a lot which > could "fix" a race condition. X is sort o

Re: dinput & [Get|Set]CursorPos conandrum

2006-08-07 Thread Alexandre Julliard
Vitaliy Margolen <[EMAIL PROTECTED]> writes: > Current dinput has lots of problems with lots of games for number of different > reasons (and I'm talking about just mouse). To fix some(all) of them we need > to > move managing of mouse warping to x11drv - only it has enough information > about >

Re: HAL and Copy Protection

2006-08-07 Thread Jesse Allen
On 8/7/06, Marcus Meissner <[EMAIL PROTECTED]> wrote: HAL should be of no importance here, there will be no visible difference to static CDROM configuration. Otherwise, no clue. Ciao, Marcus I just remembered that these new distros with HAL also have GCC 4.xx. I remember that it has been t

Re: wintrust: Always return ERROR_SUCCESS in WinVerifyTrust [RESEND]

2006-08-07 Thread Paul Vriens
On Mon, 2006-08-07 at 11:44 -0700, James Hawkins wrote: > On 8/7/06, Paul Vriens <[EMAIL PROTECTED]> wrote: > > > > > When I run process explorer without tracing/debugging everything is > > fine. As soon as I add +wintrust,+heap it fails again. There is most > > likely some heap corruption somewher

Re: wintrust: Always return ERROR_SUCCESS in WinVerifyTrust [RESEND]

2006-08-07 Thread James Hawkins
On 8/7/06, Paul Vriens <[EMAIL PROTECTED]> wrote: > When I run process explorer without tracing/debugging everything is fine. As soon as I add +wintrust,+heap it fails again. There is most likely some heap corruption somewhere (couldn't be more vague). Alexandre's patch to add more free list ent

Re: HAL and Copy Protection

2006-08-07 Thread Jesse Allen
On 8/7/06, Marcus Meissner <[EMAIL PROTECTED]> wrote: HAL should be of no importance here, there will be no visible difference to static CDROM configuration. Otherwise, no clue. Ciao, Marcus I'm going to try setting up ubuntu with HAL on a spare machine and see what it does. I use slack an

Re: wineconsole: command line option output / default user backend

2006-08-07 Thread Eric Pouech
Alexandre Julliard wrote: Ekkehard Morgenstern <[EMAIL PROTECTED]> writes: This small patch provides command line option output, a "--help" option and a default user backend ("--backend=user" is default) to "wineconsole". Your mailer wrapped the patch, please resend it. Also please s

Re: wintrust: Always return ERROR_SUCCESS in WinVerifyTrust [RESEND]

2006-08-07 Thread Paul Vriens
On Mon, 2006-08-07 at 11:11 -0700, James Hawkins wrote: > Hi, > > Accoring to recent comments by Paul Vriens, Process Explorer now > accepts ERROR_SUCCESS from WinVerifyTrust, and several installers > require ERROR_SUCCESS in order to continue, so everyone is happy. > Fixes bugs 5573 and 3619. >

Re: HAL and Copy Protection

2006-08-07 Thread Marcus Meissner
On Sun, Aug 06, 2006 at 02:32:23PM -0700, Jesse Allen wrote: > On 8/6/06, Marcus Meissner <[EMAIL PROTECTED]> wrote: > >On Tue, Aug 01, 2006 at 11:25:12AM -0700, Jesse Allen wrote: > >> Does anyone have HAL and SecuRom copy protection working? I'm starting > >> to get support questions with people

Re: user[2/2]: Preserve LastError.

2006-08-07 Thread Alexandre Julliard
Vitaliy Margolen <[EMAIL PROTECTED]> writes: > Sure but we call TlsGetValue() which does set LastError. So unless we can > avoid > that call (which I doubt) we have to do something extra to preserve the > LastError. If an app depends on it, yes. > No I don't have any games directly. But I had f

Re: Constifying Undocumented Code?

2006-08-07 Thread Andrew Talbot
James Hawkins wrote: > > Can you give us examples of code in question? > In shlwapi/ordinal.c, FDSA_InsertItem(), I would like to change the third parameter's declaration from void * to const void *. -- Andy.

Re: wintrust: Only return ERROR_SUCCESS in WinVerifyTrust

2006-08-07 Thread Paul Vriens
On Sun, 2006-08-06 at 11:43 +0200, Molle Bestefich wrote: > Dan Kegel wrote: > > Not to be harsh, but: > > Hehe ;-). > > I know, I was just poking, hoping to get an explanation for why James' > particular app might be more beneficial than Process Explorer. > > (yes, I like Process Explorer, I us

Re: RFC: XEmbed Systray Patches

2006-08-07 Thread Mike Hearn
On Sun, 06 Aug 2006 20:10:19 -0700, James Liggett wrote: > so I suspect that this has something to do with stack problem More likely it's a speed issue - logging slows the code down a lot which could "fix" a race condition. X is sort of susceptible to this kind of thing it seems.

Re: Constifying Undocumented Code?

2006-08-07 Thread James Hawkins
On 8/7/06, Andrew Talbot <[EMAIL PROTECTED]> wrote: Where we emulate undocumented code, is it acceptable to constify the formal arguments, where appropriate? Can you give us examples of code in question? -- James Hawkins

Re: Time to commit remote ops for VirtualAllocEx, CreateRemoteThread

2006-08-07 Thread Mike Hearn
On Sat, 05 Aug 2006 10:32:15 +0200, Alexandre Julliard wrote: > Still, doing that stuff in APCs is a step in the right direction, you > just need to make sure you can safely run these APCs from the SIGUSR1 > handler. How is the thread to interrupt to be selected? I really am not seeing what's wron

Constifying Undocumented Code?

2006-08-07 Thread Andrew Talbot
Where we emulate undocumented code, is it acceptable to constify the formal arguments, where appropriate? Thanks, -- Andy.

Re: user[2/2]: Preserve LastError.

2006-08-07 Thread Vitaliy Margolen
Monday, August 7, 2006, 3:52:51 AM, Alexandre Julliard wrote: > Vitaliy Margolen <[EMAIL PROTECTED]> writes: >> Anything wrong with this patch? Test case clearly shows that >> we should preserve the LastError. > In general, saving/restoring last error is discouraged, the function > should be fixe

Re: riched20: new selection invalidation logic

2006-08-07 Thread Dan Kegel
On 8/7/06, Krzysztof Foltman <[EMAIL PROTECTED]> wrote: +#define static That deserves a comment, at the very least! I don't think such a define should be allowed. Can you recode without this? I like the number of asserts. It's hard to get this stuff right, and the asserts will help make sur

Re: riched20: new selection invalidation logic

2006-08-07 Thread Krzysztof Foltman
Vitaliy Margolen wrote: I think this patch takes number of asserts per line to the highest level I've ever seen. Could you explain why you adding asserts everywhere (only 11 in this patch alone!!!)? Instead of using proper error handling? Well, that's the good question. The thing is, those con

Re: riched20: new selection invalidation logic

2006-08-07 Thread Vitaliy Margolen
Monday, August 7, 2006, 9:27:16 AM, Krzysztof Foltman wrote: > ChangeLog: > * New, clean, simple selection repaint logic - should fix all > outstanding refresh issues (and bug#5882) > Krzysztof I think this patch takes number of asserts per line to the highest level I've ever seen. Could you

Re: Tijl Coosemans : ntdll: Add FreeBSD default serial port device.

2006-08-07 Thread Tijl Coosemans
On Monday 07 August 2006 14:26, Marcus Meissner wrote: > On Mon, Aug 07, 2006 at 07:13:04AM -0500, Alexandre Julliard wrote: > > Module: wine > > Branch: refs/heads/master > > Commit: e548d4083177125559f752d902907187cea60474 > > URL: > > http://source.winehq.org/git/?p=wine.git;a=commit;h=e548d

Re: riched20: modify ME_CharFromPoint to work properly with password controls

2006-08-07 Thread Matt Finnicum
Oops! Good Call, Phil. Attached is an updated patch. --Matt On 8/7/06, Phil Krylov <[EMAIL PROTECTED]> wrote: Hi Matt, On 07/08/06, Matt Finnicum <[EMAIL PROTECTED]> wrote: > This patch modifies ME_CharFromPoint to work properly with password > controls (the patch i sent in / got committed a c

Re: DirectX can't change Screen depth

2006-08-07 Thread n0dalus
On 8/7/06, Colin Pitrat <[EMAIL PROTECTED]> wrote: colors, it works well, but if it's in 24 or 32 bits, the app display in black and white, and I've got the following message : fixme:x11drv:X11DRV_desktop_SetCurrentMode Cannot change screen BPP from 32 to 16 I've seen this in lots of games but

Re: wineconsole: command line option output / default user backend

2006-08-07 Thread Alexandre Julliard
Ekkehard Morgenstern <[EMAIL PROTECTED]> writes: > This small patch provides command line option output, a "--help" option > and a default user backend ("--backend=user" is default) to "wineconsole". Your mailer wrapped the patch, please resend it. Also please send separate changes as separate p

Re: Tijl Coosemans : ntdll: Add FreeBSD default serial port device.

2006-08-07 Thread Marcus Meissner
On Mon, Aug 07, 2006 at 07:13:04AM -0500, Alexandre Julliard wrote: > Module: wine > Branch: refs/heads/master > Commit: e548d4083177125559f752d902907187cea60474 > URL: > http://source.winehq.org/git/?p=wine.git;a=commit;h=e548d4083177125559f752d902907187cea60474 > > Author: Tijl Coosemans <[E

DirectX can't change Screen depth

2006-08-07 Thread Colin Pitrat
Hello, I'm maintaining a game named Blip & Blop (http://appdb.winehq.org/appview.php?iAppId=3470), and I have some problems with color depth. If the X server is configured in 16 bits colors, it works well, but if it's in 24 or 32 bits, the app display in black and white, and I've got the follo

Re: [FreeBSD] locating wine at 0x20000000

2006-08-07 Thread Tijl Coosemans
On Monday 31 July 2006 18:15, Tijl Coosemans wrote: > On Monday 31 July 2006 16:22, Alexandre Julliard wrote: > > Tijl Coosemans <[EMAIL PROTECTED]> writes: > > > So I was thinking of moving Wine to 0x2000. That would be the > > > easiest solution by far, but, are there any potential problems w

Re: user[2/2]: Preserve LastError.

2006-08-07 Thread Alexandre Julliard
Vitaliy Margolen <[EMAIL PROTECTED]> writes: > Anything wrong with this patch? Test case clearly shows that > we should preserve the LastError. In general, saving/restoring last error is discouraged, the function should be fixed to not change it at all. Do you have an app that depends on this? -