Monday, August 7, 2006, 3:52:51 AM, Alexandre Julliard wrote: > Vitaliy Margolen <[EMAIL PROTECTED]> writes:
>> Anything wrong with this patch? Test case clearly shows that >> we should preserve the LastError. > In general, saving/restoring last error is discouraged, the function > should be fixed to not change it at all. Do you have an app that Sure but we call TlsGetValue() which does set LastError. So unless we can avoid that call (which I doubt) we have to do something extra to preserve the LastError. > depends on this? No I don't have any games directly. But I had few tests testing several things in screen related areas and wasn't getting correct LastError. Also, looking at the fact that x11drv doesn't set LastError at all we should preserve it as much as possible. I haven't seen that many places in user32 that take care of preserving LastError either. Vitaliy.
