Re: [PATCH wayland-protocols] Add the wl_drm protocol

2017-11-14 Thread Pekka Paalanen
On Tue, 14 Nov 2017 11:23:22 + Emil Velikov wrote: > On 14 November 2017 at 08:18, Pekka Paalanen wrote: > > On Mon, 13 Nov 2017 16:27:24 + > > Emil Velikov wrote: > > > >> On 13 November 2017 at 14:52, Emil Velikov > >> wrote: > >&

Re: [PATCH wayland] client: Allow absolute paths in WAYLAND_DISPLAY

2017-11-14 Thread Pekka Paalanen
On Fri, 10 Nov 2017 11:19:49 -0600 Matt Hoosier wrote: > Hi, > > On Fri, Nov 10, 2017 at 5:37 AM, Pekka Paalanen wrote: > > On Thu, 9 Nov 2017 09:36:29 -0600 > > Matt Hoosier wrote: > > > >> From: Matt Hoosier > >> > >> In order to s

Re: [PATCH v2 wayland] client: Allow absolute paths in WAYLAND_DISPLAY

2017-11-14 Thread Pekka Paalanen
On Fri, 10 Nov 2017 11:20:42 -0600 Matt Hoosier wrote: > From: Matt Hoosier > > In order to support system compositor instances, it is necessary to > allow clients' wl_display_connect() to find the compositor's listening > socket somewhere outside of XDG_RUNTIME_DIR. For a full account, see > t

Re: Wayland Message Behaviour

2017-11-16 Thread Pekka Paalanen
On Wed, 15 Nov 2017 15:47:32 + "Turner, LewisX" wrote: > Hi Derek and pq, > > Thanks for the further suggestions and comments. > > The idea around multiple threads is a likely candidate. We have added > a thread and the flush is coming from the extra thread. > > There seems to be two obvio

Re: [PATCH v3 wayland] client: Allow absolute paths in WAYLAND_DISPLAY

2017-11-17 Thread Pekka Paalanen
tocol documentation. > > Signed-off-by: Matt Hoosier Hi Matt, this patch looks very good. I have made some very small comments below, but I'm confident that those fixed or discussed this patch will be: Reviewed-by: Pekka Paalanen Everyone else, especially those in the CC, I would l

Re: Fragment Shader of FP16 produces incorrect image drawing.

2017-11-17 Thread Pekka Paalanen
On Fri, 17 Nov 2017 17:30:47 +0900 YoungJun Jo wrote: > Dear all, > > In the weston environment, there is a problem when displaying a specific > image using the GPU(Fragment Shader(FS) only supports FP16). > In fact, I think it's not common case to use a GPU with FS of FP16 > constraints in a de

Re: [PATCH v3 wayland] client: Allow absolute paths in WAYLAND_DISPLAY

2017-11-19 Thread Pekka Paalanen
On Sat, 18 Nov 2017 07:36:58 -0600 Matt Hoosier wrote: > On Fri, Nov 17, 2017 at 2:22 AM, Pekka Paalanen wrote: > > On Tue, 14 Nov 2017 12:23:55 -0600 > > Matt Hoosier wrote: > > > >> From: Matt Hoosier > >> > >> In order to support system com

Re: Fragment Shader of FP16 produces incorrect image drawing.

2017-11-20 Thread Pekka Paalanen
riangle, and the magnification does not have it. Therefore, I don't think this is a misrendering but some other effect in the display signal, the monitor device, or even human vision. I don't know what to do about it. Thanks, pq > Regards, > yj > > 2017-11-17 18:56 GMT+09:

Re: VNC or RDP in Weston

2017-11-20 Thread Pekka Paalanen
On Tue, 21 Nov 2017 06:37:32 + "Keskinarkaus, Teemu" wrote: > Hi, > > Just inquiring what is the state of the Wayland VNC and/or RDP > support? > > We have i.MX6 based HW and atm. it's using Weston 1.11.x which I > assume is way too old for VNC/RDP? Or is there backport for that? > > We ar

Re: Fragment Shader of FP16 produces incorrect image drawing.

2017-11-21 Thread Pekka Paalanen
On Tue, 21 Nov 2017 17:08:51 +0900 YoungJun Jo wrote: > Hi, > > The uploaded image was not capture using the camera or mobile phone. > I captured image using the screenshot program. > So that's not related display signals or illusion or the human vision. > The triangle error is shown in the top-

Re: Screen dimensions, top level surface positioning...

2017-11-21 Thread Pekka Paalanen
On Wed, 22 Nov 2017 10:07:47 +0800 Jonas Ådahl wrote: > On Wed, Nov 22, 2017 at 03:43:43AM +0200, Jari Vuomajoki wrote: > > Hi Jasper, > > > > Thank you very much for your very clear and comprehensible answer. I > > understand the challenges you are addressing. > > > > I want to build applicati

Re: [RFC wayland] protocol: Add high-resolution wl_touch timestamp event

2017-11-24 Thread Pekka Paalanen
On Tue, 21 Nov 2017 18:20:08 +0200 Alexandros Frantzis wrote: > On Tue, Nov 21, 2017 at 10:52:00PM +0800, Jonas Ådahl wrote: > > On Tue, Nov 21, 2017 at 03:45:48PM +0200, Alexandros Frantzis wrote: > > > wl_touch events currently use a 32-bit timestamp with millisecond > > > resolution. In some

Re: [RFC wayland] protocol: Add high-resolution wl_touch timestamp event

2017-11-24 Thread Pekka Paalanen
On Tue, 21 Nov 2017 15:45:48 +0200 Alexandros Frantzis wrote: > wl_touch events currently use a 32-bit timestamp with millisecond > resolution. In some cases, notably latency measurements, this resolution > is too coarse-grained to be useful. > > This protocol update adds a wl_touch.timestamp ev

Re: [PATCH weston] ivi-shell: Fix incorrect use of logical instead of bitwise operator

2017-11-24 Thread Pekka Paalanen
On Tue, 21 Nov 2017 12:04:55 + "Ucan, Emre (ADITG/ESB)" wrote: > Hi, > > Thank you for the patch. It looks good to me. > > Reviewed-by: Emre Ucan Pushed: 71c4f70e..0343c6ac master -> master Thanks, pq pgpqRh5RLlutk.pgp Description: OpenPGP digital signature

Re: [PATCH weston 04/12] libweston: Use struct timespec for the output presentation timestamp

2017-11-24 Thread Pekka Paalanen
libweston/compositor.c| 12 ++-- > libweston/compositor.h| 2 +- > libweston/screenshooter.c | 3 ++- > 3 files changed, 9 insertions(+), 8 deletions(-) Patches 1-4 are: Reviewed-by: Pekka Paalanen Thanks, pq pgpIw2DMm3Ok_.pgp Descr

Re: [PATCH weston 05/12] libweston: Use struct timespec for motion events

2017-11-24 Thread Pekka Paalanen
On Thu, 16 Nov 2017 18:20:54 +0200 Alexandros Frantzis wrote: > Change code related to motion events to use struct timespec to represent > time. > > This commit is part of a larger effort to transition the Weston codebase > to struct timespec. > > Signed-off-by: Alexandros Frantzis > --- > co

Re: [PATCH weston 12/12] libweston: Use struct timespec for compositor time

2017-11-24 Thread Pekka Paalanen
ons(+), 34 deletions(-) Hi, patches 6-12 are: Reviewed-by: Pekka Paalanen I think it would be fine to send v2 of just patch 5, and then I can land all this on Monday. Thanks, pq pgpxeIzF60RAT.pgp Description: OpenPGP digital signature ___ wayland-d

Re: [PATCH weston 01/12] shared: Add timespec_is_zero helper

2017-11-27 Thread Pekka Paalanen
On Fri, 24 Nov 2017 18:36:43 + Emil Velikov wrote: > Hi Alexandros, > > On 16 November 2017 at 16:20, Alexandros Frantzis > wrote: > > > +ZUC_TEST(timespec_test, timespec_is_zero) > > +{ > > + struct timespec zero = { 0 }; > > + struct timespec non_zero_sec = { 1, 0 }; > > +

Re: Screen dimensions, top level surface positioning...

2017-11-27 Thread Pekka Paalanen
On Fri, 24 Nov 2017 18:40:13 +0200 Jari Vuomajoki wrote: > Hi Everyone! > > Thank you all for clear answers. I can understand the problematic of > providing parallel solutions for several graphics environments... > > ...so here is the use-case I am puzzled with: > > I am implementing a desktop

Re: [PATCH v3 wayland] client: Allow absolute paths in WAYLAND_DISPLAY

2017-11-27 Thread Pekka Paalanen
On Sat, 25 Nov 2017 08:11:43 -0600 Matt Hoosier wrote: > Hi Jonas, Pekka, > > I have no objection to making the tweaks that Jonas mentions, but I'm > wary of messing with the form of this patch that Pekka already > stamped. Pekka, am I going to lose your consent as given in v3 if I > make change

Re: [PATCH weston 00/12] libweston: Use struct timespec for time values

2017-11-27 Thread Pekka Paalanen
On Thu, 16 Nov 2017 18:20:49 +0200 Alexandros Frantzis wrote: > This patchset changes libweston to consistently use struct timespec for time > values. > > struct timespec is the standard way to represent time on Linux and allows for > an improved range and accuracy compared to the millisecond ba

Re: [PATCH weston v3 01/36] weston: arm SEGV handler earlier

2017-11-27 Thread Pekka Paalanen
On Tue, 31 Oct 2017 12:41:08 + Daniel Stone wrote: > On 31 October 2017 at 12:31, Quentin Glidic > wrote: > > On 10/31/17 12:48 PM, Pekka Paalanen wrote: > >> It is useful to print the backtrace regardless of whether we have a > >> compositor and a

Re: [PATCH weston 1/3] weston-launch: quit if -t without -u

2017-11-28 Thread Pekka Paalanen
On Thu, 2 Nov 2017 09:53:41 +0200 Pekka Paalanen wrote: > On Wed, 1 Nov 2017 15:37:53 +0100 > Quentin Glidic wrote: > > > On 11/1/17 3:24 PM, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > > > setup_tty() function uses the tty argumen

Re: [PATCH weston] weston: add wait-for-debugger option

2017-11-28 Thread Pekka Paalanen
On Thu, 2 Nov 2017 06:31:28 + "Ray, Ian (GE Healthcare)" wrote: > On 01/11/2017, 16.24, "wayland-devel on behalf of Pekka Paalanen" > ppaala...@gmail.com> wrote: > > > > From: Pekka Paalanen > > > > When you need to start Weston via

Re: [PATCH weston 2/2] man: mention logind for launching

2017-11-28 Thread Pekka Paalanen
On Tue, 31 Oct 2017 11:53:15 +0200 Pekka Paalanen wrote: > From: Pekka Paalanen > > Logind has been long supported as means to launch Weston without > weston-launch. It's good to note it in the manual. > > Signed-off-by: Pekka Paalanen > --- > man/weston.man |

[PATCH weston] doc/systemd: system service example

2017-11-28 Thread Pekka Paalanen
From: Pekka Paalanen There are many bad and even worse attempts to make Weston run as a systemd service, and very few good ones. Let's add a good one as an example in upstream: does not use weston-launch, does not run weston as root, does not need wrapper scripts, and relies on logind an

Re: [RFC wayland] protocol: Add high-resolution wl_touch timestamp event

2017-11-28 Thread Pekka Paalanen
On Tue, 28 Nov 2017 14:16:32 + Daniel Stone wrote: > Hi, > > On 24 November 2017 at 11:59, Pekka Paalanen wrote: > > On Tue, 21 Nov 2017 15:45:48 +0200 > > Alexandros Frantzis wrote: > >> 2. Should we introduce similar timestamp events for keyboard and

libwayland-cursor heap overflow fix

2017-11-29 Thread Pekka Paalanen
: https://bugs.freedesktop.org/show_bug.cgi?id=103961 Signed-off-by: Tobias Stoeckmann [Pekka: add link to the corresponding libXcursor commit] Signed-off-by: Pekka Paalanen This fix is not yet in any release, so would be nice if distributions cherry-picked this into what they ship

Re: [systemd-devel] [PATCH weston] doc/systemd: system service example

2017-11-29 Thread Pekka Paalanen
the CCs) > On 28/11/2017 11:14, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > There are many bad and even worse attempts to make Weston run as a > > systemd service, and very few good ones. Let's add a good one as an > > example in upstream: does no

Re: [PATCH RFC xserver] xwayland: List all wl_output::mode(s) in xrandr

2017-11-29 Thread Pekka Paalanen
On Wed, 29 Nov 2017 15:26:58 +0100 Olivier Fourdan wrote: > Xwayland would only list the current wl_output mode in xrandr, even > though multiple modes might be advertised by the Wayland compositor. > > List all available modes listed by the Wayland compositor using > wl_output::mode in XrandR.

Re: [PATCH RFC xserver] xwayland: List all wl_output::mode(s) in xrandr

2017-11-30 Thread Pekka Paalanen
On Wed, 29 Nov 2017 10:18:47 -0500 (EST) Olivier Fourdan wrote: > Hi Pekka, > > > do you also plan to let Xwayland change the mode? If not, what's the > > benefit of this? > > Yeah, sorry, I didn't give all the details on why this RFC patch, my bad. > > Basically, in downstream RH bug 128971

Re: [PATCH RFC xserver] xwayland: List all wl_output::mode(s) in xrandr

2017-11-30 Thread Pekka Paalanen
On Thu, 30 Nov 2017 04:14:08 -0500 (EST) Olivier Fourdan wrote: > Hi Pekka, > > > > [...] > > > > > > Basically, in downstream RH bug 1289714 [1], Robert Mader (cc'ed) is > > > running some proof of concept to see how he can improve the support > > > for older games in Xwayland. > > > > Ooh,

Re: [systemd-devel] [PATCH weston] doc/systemd: system service example

2017-11-30 Thread Pekka Paalanen
On Wed, 29 Nov 2017 19:05:07 +0100 Lennart Poettering wrote: > On Di, 28.11.17 12:14, Pekka Paalanen (ppaala...@gmail.com) wrote: > > > + > > +[Unit] > > +Description=Weston, a Wayland compositor, as a system service > > +Documentation=man:weston(1) man:weston.

Re: [systemd-devel] [PATCH weston] doc/systemd: system service example

2017-11-30 Thread Pekka Paalanen
On Thu, 30 Nov 2017 13:29:22 +0100 Lennart Poettering wrote: > On Do, 30.11.17 12:09, Pekka Paalanen (ppaala...@gmail.com) wrote: > > > > Hmm, what is this about? > > > > > > This is racy, as the session ID is not really reliably predictable, > > > a

Re: [PATCH weston 2/2] clients/editor: Toggle panel visibility on click

2017-11-30 Thread Pekka Paalanen
On Mon, 27 Nov 2017 10:32:01 -0600 Joshua Watt wrote: > On Sat, 2017-06-24 at 16:03 -0500, Joshua Watt wrote: > > If the --click-to-show option is specified, clicking an input field > > will toggle > > the input panel visiblity > > > > Signed-off-by: Joshua Watt > > --- > > clients/editor.c |

Re: [systemd-devel] [PATCH weston] doc/systemd: system service example

2017-12-01 Thread Pekka Paalanen
On Thu, 30 Nov 2017 11:16:19 + Martyn Welch wrote: > On Thu, 2017-11-30 at 12:09 +0200, Pekka Paalanen wrote: > > On Wed, 29 Nov 2017 19:05:07 +0100 > > Lennart Poettering wrote: > > > > > On Di, 28.11.17 12:14, Pekka Paalan

Re: [PATCH wayland] connection: Print the content of arrays in closures

2017-12-04 Thread Pekka Paalanen
On Fri, 1 Dec 2017 17:08:15 + Daniel Stone wrote: > Hi, > > On 10 July 2017 at 19:28, Emmanuel Gil Peyrot > wrote: > > The current behaviour when WAYLAND_DEBUG is set is to print “array”, > > which is quite unhelpful. > > > > This patch prints a list of the bytes present in the array. It d

Re: [PATCH wayland] protocol: Add deprecation note about wl_shell

2017-12-04 Thread Pekka Paalanen
On Sat, 2 Dec 2017 10:57:45 +0800 Jonas Ådahl wrote: > Now that xdg_shell is stable and much better defined than wl_shell we > can finally deprecate wl_shell and guide users towards xdg_shell > instead. > > Signed-off-by: Jonas Ådahl > --- Hi, Acked-by: Pekka Paalanen

Re: Can I copy-paste Wayland generated header in my own library header?

2017-12-04 Thread Pekka Paalanen
On Sat, 02 Dec 2017 09:39:33 -0500 ferreiradaselva wrote: > Good morning. > > I'm writing a cross-platform window framework, like GLFW, but > containing only two files (a source and a header). > > I would like to copy and paste the content of the xdg-shell.h > generated with wayland-scanner int

Re: Can I copy-paste Wayland generated header in my own library header?

2017-12-04 Thread Pekka Paalanen
On Mon, 04 Dec 2017 05:59:02 -0500 ferreiradaselva wrote: > >From: ppaala...@gmail.com > >To: ferreiradaselva > > > > Hi, > > > > first, IANAL, of course. > > I don't know ZLIB license, or why you picked that instead of MIT, for > > instance. > > > > Since the whole purpose of wayland-protocols

Re: [systemd-devel] [PATCH weston] doc/systemd: system service example

2017-12-04 Thread Pekka Paalanen
On Fri, 1 Dec 2017 18:25:35 +0100 Lennart Poettering wrote: > On Fr, 01.12.17 13:42, Pekka Paalanen (ppaala...@gmail.com) wrote: > > > > > > This is racy, as the session ID is not really reliably predictable, > > > > > and is synthesized in diffe

Re: Wayland talk at FOSDEM

2017-12-06 Thread Pekka Paalanen
On Tue, 05 Dec 2017 16:46:41 +0200 Philipp Kerling wrote: > Hey everyone, > > I've been thinking about submitting a Wayland-themed talk to the FOSDEM > graphics devroom [1] and wanted to check with the community if anyone > else has considered this or another Wayland topic and whether you think

Re: Making weston (or maybe libinput) ignore an input device

2017-12-07 Thread Pekka Paalanen
On Tue, 5 Dec 2017 13:57:39 -0600 Matt Hoosier wrote: > Hi all, > > The thing I'd like to arrange is for a device which is otherwise a > valid keyboard, not to get automatically vacuumed up into the Weston > DRM backend's usage of libinput. > > Nowadays, Weston has delegated most of its former

Re: Wayland talk at FOSDEM

2017-12-08 Thread Pekka Paalanen
On Thu, 07 Dec 2017 23:56:49 +0200 Philipp Kerling wrote: > Hi Pekka, > > 2017-12-07 (木) の 09:56 +0200 に Pekka Paalanen さんは書きました: > > On Tue, 05 Dec 2017 16:46:41 +0200 > > Philipp Kerling wrote: > > > > > Hey everyone, > > > > > > I&#

Re: [PATCH v4 wayland] client: Allow absolute paths in WAYLAND_DISPLAY

2017-12-11 Thread Pekka Paalanen
ute path behavior in wl_display_connect() > doxygen comments. > * Mentioned new absolute path interpretation of WAYLAND_DISPLAY in > protocol documentation. > > Signed-off-by: Matt Hoosier > Acked-by: Pekka Paalanen > Acked-by: Jonas Åd

Re: [PATCH wayland-protocols] unstable: Add input-timestamps protocol

2017-12-11 Thread Pekka Paalanen
On Tue, 5 Dec 2017 18:20:35 +0200 Alexandros Frantzis wrote: > On Tue, Dec 05, 2017 at 06:07:02PM +0200, Alexandros Frantzis wrote: > > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit > > timestamp with millisecond resolution. In some cases, notably latency > > measurements, th

Re: [PATCH wayland-protocols] unstable: Add input-timestamps protocol

2017-12-11 Thread Pekka Paalanen
a high-resolution version of > + the timestamp argument of the associated input event. The provided "..of the associated input event(s)." would perhaps cover the above change in wording? > +timestamp is in the same clock domain and is at least as accurate as > +

Re: [PATCH v2] configure.ac: use AC_HEADER_MAJOR to detect major()/minor()

2017-12-11 Thread Pekka Paalanen
On Wed, 31 May 2017 22:17:50 +0100 Sergei Trofimovich wrote: > This change slightly updates c4d7f66c12853b9575366dd9f4a7960ec5694934 > which added inclusion. > > Autoconf has AC_HEADER_MAJOR to find out which header defines > reqiured macros: > > https://www.gnu.org/software/autoconf/manua

Re: [PATCH v2] configure.ac: use AC_HEADER_MAJOR to detect major()/minor()

2017-12-12 Thread Pekka Paalanen
On Mon, 11 Dec 2017 16:16:47 +0200 Pekka Paalanen wrote: > On Wed, 31 May 2017 22:17:50 +0100 > Sergei Trofimovich wrote: > > > This change slightly updates c4d7f66c12853b9575366dd9f4a7960ec5694934 > > which added inclusion. > > > > Autoconf has AC_HEAD

Re: [PATCH weston 1/8] shared: Add timespec_normalize helper

2017-12-12 Thread Pekka Paalanen
On Mon, 4 Dec 2017 15:34:01 +0200 Alexandros Frantzis wrote: > Add a helper function to normalize struct timespec values so that the > nanoseconds part is less than 1 second and has the same sign as the > seconds part (if the seconds part is not 0). > > Normalization is required to ensure we ca

Re: [PATCH weston 2/8] shared: Add helpers to convert between protocol data and timespec

2017-12-12 Thread Pekka Paalanen
On Mon, 4 Dec 2017 15:34:02 +0200 Alexandros Frantzis wrote: > Add helpers to safely convert between struct timespec values and > tv_sec_hi, tv_sec_lo, tv_nsec triplets used for sending high-resolution > timestamp data over the wayland protocol. Replace existing conversion > code with the helper

Re: [PATCH weston 3/8] tests: Move wl_pointer tests to their own file

2017-12-12 Thread Pekka Paalanen
On Mon, 4 Dec 2017 15:34:03 +0200 Alexandros Frantzis wrote: > Move wl_pointer tests from event-test.c to their own pointer-test.c > file. This move makes the test organization clearer and more consistent, > and will make addition of further pointer tests easier. > > Signed-off-by: Alexandros F

Re: Providing shared buffer for applications within Smack environment

2017-12-12 Thread Pekka Paalanen
On Tue, 12 Dec 2017 11:00:23 +0100 José Bollo wrote: > Hi all, > > While working for AGL [1], I want to allow applications to receive the > buffers allocated by WESTON. The use of the surfaces/buffers > allocated by Weston is difficult when Smack is activated. Hi, why do you need to make Westo

Re: [PATCH weston 1/8] shared: Add timespec_normalize helper

2017-12-12 Thread Pekka Paalanen
On Tue, 12 Dec 2017 12:36:39 +0200 Alexandros Frantzis wrote: > On Tue, Dec 12, 2017 at 11:50:49AM +0200, Pekka Paalanen wrote: > > On Mon, 4 Dec 2017 15:34:01 +0200 > > Alexandros Frantzis wrote: > > > > > Add a helper function to normalize stru

Re: Providing shared buffer for applications within Smack environment

2017-12-12 Thread Pekka Paalanen
On Tue, 12 Dec 2017 12:08:43 +0100 José Bollo wrote: > On Tue, 12 Dec 2017 12:44:46 +0200 > Pekka Paalanen wrote: > > > On Tue, 12 Dec 2017 11:00:23 +0100 > > José Bollo wrote: > > > > > Hi all, > > > > > > While working for AGL

Re: [PATCH weston 4/8] tests: Use separate test cases for pointer motion and button tests

2017-12-12 Thread Pekka Paalanen
On Mon, 4 Dec 2017 15:34:04 +0200 Alexandros Frantzis wrote: > Split pointer motion and pointer button tests so that each test case is > more focused and self-contained. > > Signed-off-by: Alexandros Frantzis > --- > tests/pointer-test.c | 36 +--- > 1 file cha

Re: [PATCH weston 5/8] tests: Add checks for pointer motion and button event timestamps

2017-12-12 Thread Pekka Paalanen
On Mon, 4 Dec 2017 15:34:05 +0200 Alexandros Frantzis wrote: > Enhance the existing pointer motion and button event tests to > additionally verify the event timestamps. This requires updating the > weston-test protocol to support passing motion and button event > timestamps. > > Signed-off-by:

Re: [PATCH weston 2/8] shared: Add helpers to convert between protocol data and timespec

2017-12-12 Thread Pekka Paalanen
On Tue, 12 Dec 2017 14:43:11 +0200 Alexandros Frantzis wrote: > On Tue, Dec 12, 2017 at 12:09:59PM +0200, Pekka Paalanen wrote: > > On Mon, 4 Dec 2017 15:34:02 +0200 > > Alexandros Frantzis wrote: > > > > > Add helpers to safely convert between struct times

Re: [PATCH weston 6/8] tests: Add test for pointer axis events

2017-12-12 Thread Pekka Paalanen
On Mon, 4 Dec 2017 15:34:06 +0200 Alexandros Frantzis wrote: > Add test to verify the server correctly emits pointer axis events. This > requires updating the weston-test protocol with a new request for > pointer axis events. > > Signed-off-by: Alexandros Frantzis > --- > protocol/weston-tes

Re: [PATCH weston 7/8] tests: Add test for keyboard key event timestamps

2017-12-12 Thread Pekka Paalanen
On Mon, 4 Dec 2017 15:34:07 +0200 Alexandros Frantzis wrote: > Add test to verify that the server correctly sets the timestamps of > keyboard key events. This requires updating the weston-test protocol to > support passing key event timestamps. > > Signed-off-by: Alexandros Frantzis > --- > p

Re: [PATCH weston 8/8] tests: Add test for touch event timestamps

2017-12-12 Thread Pekka Paalanen
On Mon, 4 Dec 2017 15:34:08 +0200 Alexandros Frantzis wrote: > Add test to verify that the server correctly sets the timestamps of > touch events. This requires updating the weston-test protocol with a new > request for touch events. > > Signed-off-by: Alexandros Frantzis > --- > Makefile.am

Re: [PATCH weston 2/8] shared: Add helpers to convert between protocol data and timespec

2017-12-12 Thread Pekka Paalanen
On Tue, 12 Dec 2017 16:29:49 +0200 Alexandros Frantzis wrote: > On Tue, Dec 12, 2017 at 03:09:56PM +0200, Pekka Paalanen wrote: > > On Tue, 12 Dec 2017 14:43:11 +0200 > > Alexandros Frantzis wrote: > > > > > On Tue, Dec 12, 2017 at 12:09:59PM +0200, Pekka Paalan

Re: [PATCH v2] configure.ac: use AC_HEADER_MAJOR to detect major()/minor()

2017-12-12 Thread Pekka Paalanen
On Tue, 12 Dec 2017 15:41:52 + Emil Velikov wrote: > On 12 December 2017 at 08:28, Pekka Paalanen wrote: > > On Mon, 11 Dec 2017 16:16:47 +0200 > > Pekka Paalanen wrote: > > > >> On Wed, 31 May 2017 22:17:50 +0100 > >> Sergei Trofimovich wrote: >

Re: [PATCH] server: add wl_display_destroy_clients

2017-12-13 Thread Pekka Paalanen
On Mon, 11 Dec 2017 22:56:32 +0100 emersion wrote: > wl_display_destroy doesn't destroy clients, so client socket file > descriptors are being kept open until the compositor process exits. > > To maintain ABI compatibility, we cannot destroy clients in > wl_display_destroy. Thus, a new wl_displa

Re: [PATCH v2] server: add wl_display_destroy_clients()

2017-12-13 Thread Pekka Paalanen
t_list.next; > + client = wl_container_of(pos, client, link); > + > + wl_client_destroy(client); > + } > + > + if (!wl_list_empty(&display->client_list)) { > + wl_log("wl_display_destroy_clients: cannot destroy all clients >

Re: [PATCH v2] server: add wl_display_destroy_clients()

2017-12-13 Thread Pekka Paalanen
; > >> - > >> - /* wl_list_for_each_safe isn't enough here: it fails if the next client > >> is > >> - - destroyed by the destroy handler of the current one. */ > >> - while (!wl_list_empty(&tmp_client_list)) { > >> - pos = tmp_client

Re: Weston stuff: fractional HiDPI, FreeBSD, Rust

2017-12-14 Thread Pekka Paalanen
On Thu, 14 Dec 2017 03:05:59 +0300 Greg V wrote: > Hi everyone! > > I've been hacking around, trying to make Weston more usable for myself… Hi, nice work! Here are my initial thoughts of the ideas, but mind that I didn't look at the code at all, so some questions might sound lazy. > So far I

Re: [PATCH v4 wayland] client: Allow absolute paths in WAYLAND_DISPLAY

2017-12-14 Thread Pekka Paalanen
On Wed, 13 Dec 2017 08:19:46 -0600 Matt Hoosier wrote: > On Mon, Dec 11, 2017 at 2:03 AM, Pekka Paalanen wrote: > > On Mon, 27 Nov 2017 08:54:54 -0600 > > Matt Hoosier wrote: > > > >> From: Matt Hoosier > >> > >> In order to support system com

[PATCH weston v5 00/36] Head-based output configuration API a.k.a clone mode infrastructure

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Hi all, this is v5 (to match the numbering of my public branches) of the libweston user facing API and infrastructure for supporting shared-CRTC clone mode. Previous submission with rationale: https://lists.freedesktop.org/archives/wayland-devel/2017-October/035604.html

[PATCH weston v5 03/36] libweston: use head in wl_output global

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen As a wl_output represents weston_head, use a weston_head pointer as the wl_output global's user data. Signed-off-by: Pekka Paalanen --- libweston/compositor.c | 11 +++ libweston/compositor.h | 2 ++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --

[PATCH weston v5 02/36] libweston: move wl_output to weston_head

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen The wl_output protocol interface exposes things like monitor make, model, sub-pixel layout and physical dimensions. Obviously wl_output is meant to represent a monitor. The abstraction of a monitor is weston_head. Therefore move the wl_output global and the bound resources

[PATCH weston v5 04/36] libweston: make wl_output point to weston_head

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen The user data of a wl_resource representing a wl_output protocol object used to be a pointer to weston_output. Now that weston_output is being split, wl_output more accurately refers to weston_head which is a single monitor. Change the wl_output user data to point to

[PATCH weston v5 05/36] libweston: refactor weston_mode_switch_finish

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Split out a new function. This is a pure refactoring, no change in behaviour. This helps a following patch that adds a loop over output->head_list. Signed-off-by: Pekka Paalanen Reviewed-by: Quentin Glidic --- libweston/compositor.c |

[PATCH weston v5 06/36] libweston: introduce weston_output::head_list

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen The intention is that in the future backends will dynamically allocate weston_heads based on the resources they have. The lifetime of a weston_head will be independent of the lifetime of a weston_output it may be attached to. Backends allocate objects derived from

[PATCH weston v5 09/36] cms-colord: find a good head

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen The 'head' member of 'struct weston_output' is going to go unused and then disappear, so stop using it and find a head from the proper list. However, this leaves a problem in cms-colord: if you have multiple monitors driver with the same CRTC, what do

[PATCH weston v5 07/36] libweston: properly orphan wl_output resources

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Remove the wl_resource in the head's resource list when we are removing the wl_output global. We sent global removal events to clients, the resources should become dummies until clients reap them. Reset user data so that clients triying to use dummy objects don't

[PATCH weston v5 08/36] libweston: strdup head make, model, serial_number

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Duplicate these strings to decouple their lifetime from whatever the backends used. This should prevent hard to catch use after frees and such problems in the future. Signed-off-by: Pekka Paalanen Reviewed-by: Quentin Glidic --- libweston/compositor.c | 14

[PATCH weston v5 01/36] libweston: introduce weston_head

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen In order to support clone modes, libweston needs the concept of a head that is separate from weston_output. While weston_output manages buffers and the repaint state machine, weston_head will represent a single monitor. In the future it will be possible to have a single

[PATCH weston v5 10/36] libweston: add name to weston_head

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Heads need to be named, so they can be referenced in logs and configuration sources. When clone mode is implemented, output and head names may differ. Signed-off-by: Pekka Paalanen --- libweston/compositor.c | 10 -- libweston/compositor.h | 2 ++ 2 files

[PATCH weston v5 11/36] libweston: add weston_head::connected

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Heads may be disconnected or connected and the compositor needs to be able to know the state to know which heads to take into use. Currently a single head is automatically created with an output, and outputs are only ever created as connected and destroyed on disconnection

[PATCH weston v5 15/36] libweston: add weston_head destroy signal

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Add support for subscribing to weston_head destruction. The primary use case for heads being destroyed arbitrarily is the DRM-backend with MST connectors, which may disappear on unplug. It is not just the connector becoming disconnected, it is the connector actually

[PATCH weston v5 14/36] libweston: new head-based output management API

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Introduce the API for users (compositors) to create an output from a head, attach and detach heads, and destroy outputs created this way. This also adds the backend-facing API to libweston. In the new API design, a backend creates heads, and the compositor chooses one or

[PATCH weston v5 13/36] libweston: add heads_changed hook

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Add a hook for compositors to get a callback when heads are added or their connection status changes, to which compositors likely want to react to by enabling or disabling outputs (API for that to be added later). As many head changes as possible should be coalesced into a

[PATCH weston v5 20/36] weston: migrate wayland to head-based output API

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Migrate the Wayland frontend to use the new head-based output configuration API: listen for heads_changed, and process all heads. Signed-off-by: Pekka Paalanen --- compositor/main.c | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-) diff

[PATCH weston v5 19/36] weston: migrate x11 to head-based output API

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Migrate the x11 frontend to use the new head-based output configuration API: listen for heads_changed, and process all heads. Signed-off-by: Pekka Paalanen --- compositor/main.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/compositor

[PATCH weston v5 18/36] weston: migrate headless to head-based output API

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Migrate the headless frontend to use the new head-based output configuration API: listen for heads_changed, and process all heads. The simple_heads_changed() function is written to be able to cater for all backends. The rest will be migrated individually. The head destroy

[PATCH weston v5 17/36] weston: move weston_output_enable() into callers

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Move the call out of wet_configure_windowed_output_from_config() and into its callers. This allows to migrate each frontend one by one. Signed-off-by: Pekka Paalanen --- compositor/main.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a

[PATCH weston v5 12/36] libweston: add compositor list of heads

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen weston_compositor needs to maintain a list of all available heads, so that a compositor can pick and choose which heads to take into or out of use at arbitrary times. The heads may be on or off, and connected or disconnected. Signed-off-by: Pekka Paalanen --- libweston

[PATCH weston v5 16/36] libweston: add weston_head_is_device_changed() API

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Reacting to DRM hotplug events is racy. It is theoretically possible to get hotplug events for a quick swap from one monitor to another and process both only after the new monitor is connected. Hence it is possible for display device information to change without going

[PATCH weston v5 26/36] libweston: stop auto-adding the implicit head

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen All frontends have been converted to the new head-based output management API, which means that weston_compositor_create_output_with_head() is calling weston_output_attach_head(). We will never hit the implicit attach anymore. Therefore we can now require that an output has

[PATCH weston v5 25/36] libweston: remove output_pending_signal

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen The signal has been replaced with the heads_changed hook and is no longer useful. weston_pending_output_coldplug() is renamed to weston_compositor_flush_heads_changed() for two reasons: it better describes what it does now, and it serves as an obvious flag that libweston

[PATCH weston v5 30/36] compositor-headless: migrate to head-based output API

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Implement the head-based output API in this backend, and stop relying on the implicit weston_output::head. Signed-off-by: Pekka Paalanen --- libweston/compositor-headless.c | 75 ++--- 1 file changed, 63 insertions(+), 12 deletions

[PATCH weston v5 27/36] libweston: assert make/model in weston_output_enable()

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Output make and model are not allowed to be NULL in the protocol, so ensure they are not forgotten when enabling an output. Signed-off-by: Pekka Paalanen --- libweston/compositor.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libweston/compositor.c b

[PATCH weston v5 28/36] libweston: assert current_mode in weston_output_enable()

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen The functions called here, particularly weston_output_transform_scale_init(), rely on current mode being set. The current mode must also be found in the mode list, though we don't explicitly check it here. current_mode not being set is a programmer error. It could

[PATCH weston v5 29/36] libweston: cancel idle_repaint on output destroy

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen If the idle_repaint() callback has been scheduled when a weston_output gets destroyed, the callback will hit use-after-free. I have encountered this when migrating the wayland backend to the head-based API, using --sprawl, and closing/disconnecting one of the parent

[PATCH weston v5 32/36] compositor-fbdev: make re-enable less drastic

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Destroying the whole output in reenable would cause list walk corruption: the loop over output_list in session_notify() is not using wl_list_for_each_safe so output removal would break it. Creating a new output is also problematic as it needs the compositor to configure it

[PATCH weston v5 22/36] weston: migrate RDP to head-based output API

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Migrate the RDP frontend to use the new head-based output configuration API: listen for heads_changed, and process all heads. Signed-off-by: Pekka Paalanen --- compositor/main.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/compositor

[PATCH weston v5 21/36] weston: migrate fbdev to head-based output API

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Migrate the fbdev frontend to use the new head-based output configuration API: listen for heads_changed, and process all heads. Signed-off-by: Pekka Paalanen --- compositor/main.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/compositor

[PATCH weston v5 31/36] compositor-rdp: migrate to head-based output API

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Follow the starndard patttern as the other backends, headless and x11 in particular, to stop relying on the implicit weston_output::head. Signed-off-by: Pekka Paalanen --- libweston/compositor-rdp.c | 64 ++ 1 file changed, 53

[PATCH weston v5 23/36] weston: migrate DRM to head-based output API

2017-12-14 Thread Pekka Paalanen
From: Pekka Paalanen Migrate the DRM frontend to use the simple head-based output configurator, maintaining the exact same features and semantics as before. This is an intermediate step. It is unoptimal to create a weston_output just to turn it off, but the libweston implementation and the DRM

  1   2   3   4   5   6   7   8   9   10   >