On Wed, 13 Dec 2017 08:19:46 -0600 Matt Hoosier <matt.hoos...@gmail.com> wrote:
> On Mon, Dec 11, 2017 at 2:03 AM, Pekka Paalanen <ppaala...@gmail.com> wrote: > > On Mon, 27 Nov 2017 08:54:54 -0600 > > Matt Hoosier <matt.hoos...@gmail.com> wrote: > > > >> From: Matt Hoosier <matt.hoos...@garmin.com> > >> > >> In order to support system compositor instances, it is necessary to > >> allow clients' wl_display_connect() to find the compositor's listening > >> socket somewhere outside of XDG_RUNTIME_DIR. For a full account, see > >> the discussion beginning here: > >> > >> https://lists.freedesktop.org/archives/wayland-devel/2017-November/035664.html > >> > >> This change adjusts the client-side connection logic so that, if > >> WAYLAND_DISPLAY is formatted as an absolute pathname, the socket > >> connection attempt is made to just $WAYLAND_DISPLAY rather than > >> usual user-private location $XDG_RUNTIME_DIR/$WAYLAND_DISPLAY. > >> > >> This change is based on Davide Bettio's submission of the same concept > >> at: > >> > >> https://lists.freedesktop.org/archives/wayland-devel/2015-August/023838.html. > >> > >> v4 changes: > >> > >> * Improved internal comments and some boundary-condition > >> error checks in test case. > >> * Refer to compositor as "Wayland server" rather than "Wayland > >> display" in wl_display_connect() doxygen comments. > >> * Remove redundant descriptions of parameter-interpretation > >> mechanics from wl_display_connect() manpage. Reworked things > >> to make it clear that 'name' and $WAYLAND_DISLAY are each > >> capable of encoding absolute server socket paths. > >> * Remove callout to reference implementation behavior in protocol > >> documented. In its place there is now a simple statement that > >> implementations can optionally support absolute socket paths. > >> > >> v3 changes: > >> > >> * Added test case. > >> * Clarified documentation to note that 'name' parameter to > >> wl_display_connect() > >> can also be an absolute path. > >> > >> v2 changes: > >> > >> * Added backward incompatibility note to wl_display_connect() manpage. > >> * Rephased wl_display_connect() manpage changes to precisely match actual > >> changed behavior. > >> * Added mention of new absolute path behavior in wl_display_connect() > >> doxygen comments. > >> * Mentioned new absolute path interpretation of WAYLAND_DISPLAY in > >> protocol documentation. > >> > >> Signed-off-by: Matt Hoosier <matt.hoos...@gmail.com> > >> Acked-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> > >> Acked-by: Jonas Ådahl <jad...@gmail.com> > >> --- > >> doc/man/wl_display_connect.xml | 32 +++++++++-- > >> doc/publican/sources/Protocol.xml | 5 +- > >> src/wayland-client.c | 47 ++++++++++++---- > >> tests/socket-test.c | 109 > >> ++++++++++++++++++++++++++++++++++++++ > >> 4 files changed, 177 insertions(+), 16 deletions(-) > > > > Hi Matt, > > > > this patch is: > > > > Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> > > > > The wording in the man page sounds little like WAYLAND_DISPLAY > > accepting an absolute path is a side-effect rather than an intentional > > feature, but it doesn't matter. > > > > Everyone, > > > > if there are no objections, I will push this patch on Wednesday, that > > is in two days. If you want your R-b or Acks recorded that are not > > already in the above, please send them explicitly. > > > > > > Thanks, > > pq > > Hi Pekka, > > Did you ever hear any objections to this one? Nope, and it's pushed now: de24f4d..1b6521e master -> master I just forgot yesterday. :-) Thanks, pq
pgprcF0JILR50.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
