Re: Setting the display calibration ramps using weston

2013-04-03 Thread Richard Hughes
On 3 April 2013 13:56, Graeme Gill wrote: > A callback makes sense if this is essentially event driven. How is the > responder (ie. CMM) registered ? At the moment I've just got a: [core] cms=colord.so in weston.ini with the .so object setting vfuncs of a weston_color_manager struct. It's all v

Re: Setting the display calibration ramps using weston

2013-04-03 Thread Graeme Gill
Richard Hughes wrote: Hmm, we need to be able to change this on the fly, for instance the user changing the profile or clearing the curves to linear for profiling. The "user" meaning "an application working on behalf of the user to calibrate or profile the display". 1. Read the hardcoded .ic

Re: Setting the display calibration ramps using weston

2013-04-02 Thread John Kåre Alsaker
I'd say we make it a ./configure option which builds a shared library which talks to colord over D-Bus. It can then be packaged separately by distros. A weston.ini option should be added to pick the CMS plugin to load. lcms2 can be added as a dependency for the weston side code (it will probably be

Re: Setting the display calibration ramps using weston

2013-04-02 Thread Richard Hughes
On 2 April 2013 02:42, Kristian Høgsberg wrote: > So for something like weston, where we store our configuration in > weston.ini, I'd expect that we add a config key to set the gamma (is > this just a number like what xgamma takes? or one for red, green and > blue?) per output in weston.ini. So w

Re: Setting the display calibration ramps using weston

2013-04-02 Thread Richard Hughes
On 2 April 2013 12:10, Kai-Uwe Behrmann wrote: > Querying a CMM for a monitor profile is top down. Most people understand a > CMM (Colour Matching Modul) to do context preparation Right, sorry for being unclear. In this instance I was referring to a CMM being Oyranos or colord. I myself tried to

Re: Setting the display calibration ramps using weston

2013-04-02 Thread Richard Hughes
On 2 April 2013 12:10, Kai-Uwe Behrmann wrote: > Am 02.04.2013 11:24, schrieb Richard Hughes: > >> On 2 April 2013 06:45, Graeme Gill wrote: >>> >>> The display's ICC profile will also be stored in the _ICC_PROFILE atom, >>> to make it available to the display client, so that color can be adjuste

Re: Setting the display calibration ramps using weston

2013-04-02 Thread Kai-Uwe Behrmann
Am 02.04.2013 11:24, schrieb Richard Hughes: On 2 April 2013 06:45, Graeme Gill wrote: The display's ICC profile will also be stored in the _ICC_PROFILE atom, to make it available to the display client, so that color can be adjusted appropriately for that display. Using XRandR it will/should al

Re: Setting the display calibration ramps using weston

2013-04-02 Thread Richard Hughes
On 2 April 2013 11:11, John Kåre Alsaker wrote: > My planned approach was to make colord and Oyranos plugins for Weston. Sure, I'd be really keen on helping with this. Is there any documentation on the plugin interface? Also, bear in mind I'm keeping half and eye on the "full fat" gnome-shell imp

Re: Setting the display calibration ramps using weston

2013-04-02 Thread John Kåre Alsaker
My planned approach was to make colord and Oyranos plugins for Weston. The plugins would provide the CMSes with information about the outputs and Weston in return gets ICC profiles for them (which contains gamma curves). Weston needs the full ICC profile in order to do proper color correction and t

Re: Setting the display calibration ramps using weston

2013-04-02 Thread Richard Hughes
On 2 April 2013 06:45, Graeme Gill wrote: > The display's ICC profile will also be stored in the _ICC_PROFILE atom, > to make it available to the display client, so that color can be adjusted > appropriately for that display. Using XRandR it will/should > also be set in an output property. There'

Re: Setting the display calibration ramps using weston

2013-04-02 Thread Richard Hughes
On 2 April 2013 02:42, Kristian Høgsberg wrote: > All the KMS interactions happens in src/compositor-drm.c. As you say, > the end result should be calling drmModeCrtcSetGamma(), but what's the > input? The user selected ICC profile which contain the gamma curves. > We don't have protocol for c

Re: Setting the display calibration ramps using weston

2013-04-01 Thread Graeme Gill
Kristian Høgsberg wrote: So for something like weston, where we store our configuration in weston.ini, I'd expect that we add a config key to set the gamma (is this just a number like what xgamma takes? or one for red, green and blue?) per output in weston.ini. In general it's not a number, it

Re: Setting the display calibration ramps using weston

2013-04-01 Thread Kristian Høgsberg
On Sun, Mar 31, 2013 at 06:24:30PM +0100, Richard Hughes wrote: > krh mentioned in a G+ post that I should add to weston functionality > to set the output gamma ramps for color calibration. Does anyone have > any ideas on where I should start? I'm familiar with color stuff, but > the Weston interna

Setting the display calibration ramps using weston

2013-03-31 Thread Richard Hughes
krh mentioned in a G+ post that I should add to weston functionality to set the output gamma ramps for color calibration. Does anyone have any ideas on where I should start? I'm familiar with color stuff, but the Weston internals confuse me somewhat. I need to be a position where I can call drmMode