I'd say we make it a ./configure option which builds a shared library which talks to colord over D-Bus. It can then be packaged separately by distros. A weston.ini option should be added to pick the CMS plugin to load. lcms2 can be added as a dependency for the weston side code (it will probably be required to generate 3D LUTs later on anyway). We probably want a configure option to disable the CMS plugin loader which also removes the dependency on lcms2. The CMS plugin loader or an CMS API doesn't exist yet, so we'll have to create one. We probably want to pass EDID data over to the CMS plugin and it notifies weston about output profile changes in form of a ICC profile which lcms2 handles on the weston side.
On Tue, Apr 2, 2013 at 5:40 PM, Richard Hughes <[email protected]> wrote: > On 2 April 2013 02:42, Kristian Høgsberg <[email protected]> wrote: >> So for something like weston, where we store our configuration in >> weston.ini, I'd expect that we add a config key to set the gamma (is >> this just a number like what xgamma takes? or one for red, green and >> blue?) per output in weston.ini. So we need to parse that in >> output_section_done() and store in struct drm_configured_output, copy >> the value into struct drm_output in create_output_for_connector() and >> then apply that whenever we call drmModeSetCrtc(), generally. > > I've attached a patch that works for me, I'd appreciate any comments > or a formal review. If you've got colord and lcms2 installed and you > uncomment the icc_profile item in weston.ini then the Bluish test > profile will be applied and LVDS will go a deep shade of blue. lcms2 > is a totally sane dep IMO, it's used by tons of embedded and desktoppy > things already. > > I'm totally up for abstracting this like John suggested, I just need > some more guidance on how you'd like me to do this. For instance, are > the plugins going to be installed by the CMF (e.g. colord installs > /usr//lib/weston/plugins/colord.so), ./configure compile arguments > (e.g. --enable-colord) or can I just link to D-Bus and make it a > runtime dep? > > Richard > > _______________________________________________ > wayland-devel mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/wayland-devel > _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
