Re: [PATCH weston] log: Open log file CLOEXEC so child processes don't get the fd

2015-06-04 Thread Khem Raj
> On Jun 4, 2015, at 9:13 AM, Derek Foreman wrote: > > On 04/06/15 11:03 AM, Khem Raj wrote: >> >> On Jun 4, 2015 8:54 AM, "Derek Foreman" > > wrote: >>> >>> Uses a glibc extension to fopen(), but we seem ok with glibc >>> extensions elsewhere (such as printf %m)

Re: [PATCH weston] log: Open log file CLOEXEC so child processes don't get the fd

2015-06-04 Thread Alan Hourihane
On 04/06/15 17:03, Khem Raj wrote: > > > On Jun 4, 2015 8:54 AM, "Derek Foreman" > wrote: > > > > Uses a glibc extension to fopen(), but we seem ok with glibc > > extensions elsewhere (such as printf %m)... > > I have been using wayland/weston with musl. So this fix

Re: [PATCH weston] log: Open log file CLOEXEC so child processes don't get the fd

2015-06-04 Thread Derek Foreman
On 04/06/15 11:03 AM, Khem Raj wrote: > > On Jun 4, 2015 8:54 AM, "Derek Foreman" > wrote: >> >> Uses a glibc extension to fopen(), but we seem ok with glibc >> extensions elsewhere (such as printf %m)... > > I have been using wayland/weston with musl. So this fix

Re: [PATCH weston] log: Open log file CLOEXEC so child processes don't get the fd

2015-06-04 Thread Khem Raj
On Jun 4, 2015 8:54 AM, "Derek Foreman" wrote: > > Uses a glibc extension to fopen(), but we seem ok with glibc > extensions elsewhere (such as printf %m)... I have been using wayland/weston with musl. So this fix is not good from portability aspect. There might be glibc ' isms there but it's be

[PATCH weston] log: Open log file CLOEXEC so child processes don't get the fd

2015-06-04 Thread Derek Foreman
Uses a glibc extension to fopen(), but we seem ok with glibc extensions elsewhere (such as printf %m)... Signed-off-by: Derek Foreman --- src/log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/log.c b/src/log.c index 99bbe18..ef9b54d 100644 --- a/src/log.c +++ b/src/lo