On 04/06/15 11:03 AM, Khem Raj wrote: > > On Jun 4, 2015 8:54 AM, "Derek Foreman" <[email protected] > <mailto:[email protected]>> wrote: >> >> Uses a glibc extension to fopen(), but we seem ok with glibc >> extensions elsewhere (such as printf %m)... > > I have been using wayland/weston with musl. So this fix is not good from > portability aspect. There might be glibc ' isms there but it's better > to not make it worse
Looks like musl does indeed support "e" as an fopen() flag. Do we still want to do this in a more portable way? >> >> Signed-off-by: Derek Foreman <[email protected] > <mailto:[email protected]>> >> --- >> src/log.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/log.c b/src/log.c >> index 99bbe18..ef9b54d 100644 >> --- a/src/log.c >> +++ b/src/log.c >> @@ -75,7 +75,7 @@ weston_log_file_open(const char *filename) >> wl_log_set_handler_server(custom_handler); >> >> if (filename != NULL) >> - weston_logfile = fopen(filename, "a"); >> + weston_logfile = fopen(filename, "ae"); >> >> if (weston_logfile == NULL) >> weston_logfile = stderr; >> -- >> 2.1.4 >> >> _______________________________________________ >> wayland-devel mailing list >> [email protected] > <mailto:[email protected]> >> http://lists.freedesktop.org/mailman/listinfo/wayland-devel > _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
