Re: [PATCH] xdg-shell: rename the xdg_surface.delete event to close.

2014-04-01 Thread Kristian Høgsberg
On Mon, Mar 24, 2014 at 02:13:22PM +0200, Giulio Camuffo wrote: > 'close' is more consistent with the purpose of the event than > 'delete', and it is also c++ friendly, since 'delete' is a keyword. > --- > protocol/xdg-shell.xml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Thanks

Re: [PATCH] xdg-shell: rename the xdg_surface.delete event to close.

2014-03-24 Thread Jasper St. Pierre
Yeah, this is fine with me. Reviewed-by: Jasper St. Pierre On Mon, Mar 24, 2014 at 8:13 AM, Giulio Camuffo wrote: > 'close' is more consistent with the purpose of the event than > 'delete', and it is also c++ friendly, since 'delete' is a keyword. > --- > protocol/xdg-shell.xml | 4 ++-- > 1

[PATCH] xdg-shell: rename the xdg_surface.delete event to close.

2014-03-24 Thread Giulio Camuffo
'close' is more consistent with the purpose of the event than 'delete', and it is also c++ friendly, since 'delete' is a keyword. --- protocol/xdg-shell.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml index a2913c4..79a283