Re: array and enum attributes (Was: [PATCH] xdg-shell: add draw states for xdg_surface)

Hi! On Fri, Jul 29, 2016 at 10:52 AM, Pekka Paalanen wrote: > On Fri, 22 Jul 2016 21:39:20 +0200 > "Nils Chr. Brause" wrote: > >> HI, >> >> On Thu, Jun 2, 2016 at 10:30 AM, Pekka Paalanen wrote: >> > On Thu, 2 Jun 2016 15:39:47 +0800 >> > Jonas Ådahl wrote: >> > >> >> On Thu, Jun 02, 2016 at 1

Re: array and enum attributes (Was: [PATCH] xdg-shell: add draw states for xdg_surface)

On Fri, 22 Jul 2016 21:39:20 +0200 "Nils Chr. Brause" wrote: > HI, > > On Thu, Jun 2, 2016 at 10:30 AM, Pekka Paalanen wrote: > > On Thu, 2 Jun 2016 15:39:47 +0800 > > Jonas Ådahl wrote: > > > >> On Thu, Jun 02, 2016 at 10:24:19AM +0300, Pekka Paalanen wrote: > >> > On Wed, 1 Jun 2016 13:1

Re: array and enum attributes (Was: [PATCH] xdg-shell: add draw states for xdg_surface)

HI, On Thu, Jun 2, 2016 at 10:30 AM, Pekka Paalanen wrote: > On Thu, 2 Jun 2016 15:39:47 +0800 > Jonas Ådahl wrote: > >> On Thu, Jun 02, 2016 at 10:24:19AM +0300, Pekka Paalanen wrote: >> > On Wed, 1 Jun 2016 13:16:31 -0500 >> > Yong Bakos wrote: >> > >> > > On May 30, 2016, at 3:54 AM, Pekka P

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hello Olivier, On 07/06/2016 11:15, Olivier Fourdan wrote: > Hi Benoit, > > - Original Message - >> On 07/06/2016 10:30, Olivier Fourdan wrote: >>> [...] >>> I disagree here, if anything we should keep the semantic states separate, >>> we wouldn't want to have something like "no_shadow" o

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hello Jonas, I understand your point, and also we bike-shedding. if you add not_shadowed state to the state list you solve the first part of the issue. I do not think we need more states list. Next issue is to how advertise to the compositor which optional states are supported by the client. In t

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hi Benoit, - Original Message - > On 07/06/2016 10:30, Olivier Fourdan wrote: > > [...] > > I disagree here, if anything we should keep the semantic states separate, > > we wouldn't want to have something like "no_shadow" or "no_border" as a > > semantic state like "maximized" or "fullscre

Re: [PATCH] xdg-shell: add draw states for xdg_surface

On Tue, Jun 07, 2016 at 10:47:13AM +0200, Benoit Gschwind wrote: > Hello Olivier > > On 07/06/2016 10:30, Olivier Fourdan wrote: > > Hi Benoit, > > > > - Original Message - > >> [...] > >> > >> My primary complain is that draw states should be merged with the > >> previously defined windo

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hello Olivier On 07/06/2016 10:30, Olivier Fourdan wrote: > Hi Benoit, > > - Original Message - >> [...] >> >> My primary complain is that draw states should be merged with the >> previously defined window/surface states, because by definition a draw >> state is a state for a window, just

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hi Benoit, - Original Message - > [...] > > My primary complain is that draw states should be merged with the > previously defined window/surface states, because by definition a draw > state is a state for a window, just like the state activated for example. I disagree here, if anything

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hello Matthias, I agree the two reply from Jonas, and Olivier. I just add to Olivier comment, that even we tried to remove MWM hints (i.e. they do not belong any up-to-date standards), they are still used by up-to-date software and implemented by popular WMs. This use case show that (1) those hin

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hi Jonas, - Original Message - > On Mon, Jun 06, 2016 at 09:50:19AM -0400, Matthias Clasen wrote: > > To me, 'draw states' sounds a lot like 'mwm hints' - which would be a > > 180 degree reversal from semantic states back to presentation states. > > Do we really want to go down that road ?

Re: [PATCH] xdg-shell: add draw states for xdg_surface

On Mon, Jun 06, 2016 at 09:50:19AM -0400, Matthias Clasen wrote: > To me, 'draw states' sounds a lot like 'mwm hints' - which would be a > 180 degree reversal from semantic states back to presentation states. > Do we really want to go down that road ? I'm not too familiar with MWM hints, but this

Re: [PATCH] xdg-shell: add draw states for xdg_surface

To me, 'draw states' sounds a lot like 'mwm hints' - which would be a 180 degree reversal from semantic states back to presentation states. Do we really want to go down that road ? ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https:/

Re: array and enum attributes (Was: [PATCH] xdg-shell: add draw states for xdg_surface)

On Jun 2, 2016, at 4:26 AM, Auke Booij wrote: > > On 1 June 2016 at 20:16, Yong Bakos wrote: >> On May 30, 2016, at 3:54 AM, Pekka Paalanen wrote: >>> >>> On Sat, 28 May 2016 08:39:59 -0500 >>> Yong Bakos wrote: >>> Hi Mike, Regarding the combination of type="array" enum="foo"... >

Re: array and enum attributes (Was: [PATCH] xdg-shell: add draw states for xdg_surface)

On 1 June 2016 at 20:16, Yong Bakos wrote: > On May 30, 2016, at 3:54 AM, Pekka Paalanen wrote: >> >> On Sat, 28 May 2016 08:39:59 -0500 >> Yong Bakos wrote: >> >>> Hi Mike, >>> Regarding the combination of type="array" enum="foo"... >>> On May 27, 2016, at 12:30 PM, Mike Blumenkrantz

Re: array and enum attributes (Was: [PATCH] xdg-shell: add draw states for xdg_surface)

On Thu, Jun 02, 2016 at 11:30:41AM +0300, Pekka Paalanen wrote: > On Thu, 2 Jun 2016 15:39:47 +0800 > Jonas Ådahl wrote: > > > On Thu, Jun 02, 2016 at 10:24:19AM +0300, Pekka Paalanen wrote: > > > On Wed, 1 Jun 2016 13:16:31 -0500 > > > Yong Bakos wrote: > > > > > > > On May 30, 2016, at 3:54

Re: array and enum attributes (Was: [PATCH] xdg-shell: add draw states for xdg_surface)

On Thu, 2 Jun 2016 15:39:47 +0800 Jonas Ådahl wrote: > On Thu, Jun 02, 2016 at 10:24:19AM +0300, Pekka Paalanen wrote: > > On Wed, 1 Jun 2016 13:16:31 -0500 > > Yong Bakos wrote: > > > > > On May 30, 2016, at 3:54 AM, Pekka Paalanen wrote: > > > > > > > > On Sat, 28 May 2016 08:39:59 -050

Re: array and enum attributes (Was: [PATCH] xdg-shell: add draw states for xdg_surface)

On Thu, Jun 02, 2016 at 10:24:19AM +0300, Pekka Paalanen wrote: > On Wed, 1 Jun 2016 13:16:31 -0500 > Yong Bakos wrote: > > > On May 30, 2016, at 3:54 AM, Pekka Paalanen wrote: > > > > > > On Sat, 28 May 2016 08:39:59 -0500 > > > Yong Bakos wrote: > > > > > >> Hi Mike, > > >> Regarding the

Re: array and enum attributes (Was: [PATCH] xdg-shell: add draw states for xdg_surface)

On Wed, 1 Jun 2016 13:16:31 -0500 Yong Bakos wrote: > On May 30, 2016, at 3:54 AM, Pekka Paalanen wrote: > > > > On Sat, 28 May 2016 08:39:59 -0500 > > Yong Bakos wrote: > > > >> Hi Mike, > >> Regarding the combination of type="array" enum="foo"... > >> > >>> On May 27, 2016, at 12:30 PM

Re: array and enum attributes (Was: [PATCH] xdg-shell: add draw states for xdg_surface)

On May 30, 2016, at 3:54 AM, Pekka Paalanen wrote: > > On Sat, 28 May 2016 08:39:59 -0500 > Yong Bakos wrote: > >> Hi Mike, >> Regarding the combination of type="array" enum="foo"... >> >>> On May 27, 2016, at 12:30 PM, Mike Blumenkrantz >>> wrote: >>> >>> I've inlined some replies below. >

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hello Derek, Maybe I fail to explain my point of view: I propose to have only one state array, I also propose that client provide hints about which optional state he support. This is somehow similar to EWMH - _NET_WM_STATE and EWMH - _NET_WM_ALLOWED_ACTIONS respectively. my arguments are: - sta

Re: [PATCH] xdg-shell: add draw states for xdg_surface

On 31/05/16 02:31 PM, Benoit Gschwind wrote: > Hello mike, > > Thank for your clarification, I try to summarize the issue/need: > > A compositor may want to draw a client without the shadow. In particular > if the window is integrated to a GUI component, I can imagine tilling. Tiling seems only

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hello mike, Thank for your clarification, I try to summarize the issue/need: A compositor may want to draw a client without the shadow. In particular if the window is integrated to a GUI component, I can imagine tilling. Taking your issue, the drawing state look very similar to the state flags.

Re: [PATCH] xdg-shell: add draw states for xdg_surface

After a long weekend of not reading mails, I've read some mails; I'll try to make comments to everything in this reply. On Tue, May 31, 2016 at 7:38 AM Olivier Fourdan wrote: > Hey > > - Original Message - > > On Tue, May 31, 2016 at 05:24:35AM -0400, Olivier Fourdan wrote: > > > [...] >

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hey - Original Message - > On Tue, May 31, 2016 at 05:24:35AM -0400, Olivier Fourdan wrote: > > [...] > > If we considered and dismissed them, fine. > > They are not "actively" considered in this patch, but as I mentioned > earlier, I think tiling states can later be added to the window s

Re: [PATCH] xdg-shell: add draw states for xdg_surface

On Tue, May 31, 2016 at 05:24:35AM -0400, Olivier Fourdan wrote: > Hey > > Just to make it clear, as a foreword to my comments inline below, I am not > against the patch, far from it, I just wanted to make sure we considered edge > values instead of only "no shadow", and we also considered other

Re: [PATCH] xdg-shell: add draw states for xdg_surface

On Tue, May 31, 2016 at 11:16:51AM +0200, Benoit Gschwind wrote: > > > On 31/05/2016 10:53, Jonas Ådahl wrote: > > On Tue, May 31, 2016 at 10:31:28AM +0200, Benoit Gschwind wrote: > >> Hello Jonas, Mike and Olivier, > >> > >> On 30/05/2016 15:09, Olivier Fourdan wrote: > >>> Hi Jonas, > >>> > >>>

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hello, Just a reply to EWMH/MOTIF comments, EWMH semantic is the path already started within xdg, as far as remember v6 have toplevel, popup and tooltips surfaces, and will probably have many more in the future. That why we need a description of the issue we trying to solve. I can assume that th

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hey Just to make it clear, as a foreword to my comments inline below, I am not against the patch, far from it, I just wanted to make sure we considered edge values instead of only "no shadow", and we also considered other draw states. If we considered and dismissed them, fine. For reference, t

Re: [PATCH] xdg-shell: add draw states for xdg_surface

On 31/05/2016 10:53, Jonas Ådahl wrote: > On Tue, May 31, 2016 at 10:31:28AM +0200, Benoit Gschwind wrote: >> Hello Jonas, Mike and Olivier, >> >> On 30/05/2016 15:09, Olivier Fourdan wrote: >>> Hi Jonas, >>> >>> - Original Message - On Mon, May 30, 2016 at 05:01:58AM -0400, Olivier

Re: [PATCH] xdg-shell: add draw states for xdg_surface

On Tue, May 31, 2016 at 10:31:28AM +0200, Benoit Gschwind wrote: > Hello Jonas, Mike and Olivier, > > On 30/05/2016 15:09, Olivier Fourdan wrote: > > Hi Jonas, > > > > - Original Message - > >> On Mon, May 30, 2016 at 05:01:58AM -0400, Olivier Fourdan wrote: > >>> > >>> Do we really want

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hello Jonas, Mike and Olivier, On 30/05/2016 15:09, Olivier Fourdan wrote: > Hi Jonas, > > - Original Message - >> On Mon, May 30, 2016 at 05:01:58AM -0400, Olivier Fourdan wrote: >>> >>> Do we really want reserved ranges here? >>> >>> Some people reckon having (undocumented) reserved ran

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hello Mike and Jonas, I wonder why ? I do not saying you proposal is useless, but any proposal should solve an issue or add a feature to be discussed. In both case, I think a proposal must provide an explanation of why this proposal. This may be obvious for you but it might be not so obvious. An

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hi Jonas, - Original Message - > On Mon, May 30, 2016 at 05:01:58AM -0400, Olivier Fourdan wrote: > > > > Do we really want reserved ranges here? > > > > Some people reckon having (undocumented) reserved ranges was a bad idea in > > "states", I wonder if we should redo this here again. >

Re: [PATCH] xdg-shell: add draw states for xdg_surface

On Mon, May 30, 2016 at 05:01:58AM -0400, Olivier Fourdan wrote: > Hi Mike, > > Thanks for posting this, perfect timing to discuss this in light of the > tiling discussions ^_~ > > I reckon tiling and shadows can be related (even though one is an actual > state, the other is a draw state). > >

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hi Mike, Thanks for posting this, perfect timing to discuss this in light of the tiling discussions ^_~ I reckon tiling and shadows can be related (even though one is an actual state, the other is a draw state). For a bit of background on my comments below, see https://bugzilla.gnome.org/show

Re: [PATCH] xdg-shell: add draw states for xdg_surface

On Sat, 28 May 2016 08:39:59 -0500 Yong Bakos wrote: > Hi Mike, > Regarding the combination of type="array" enum="foo"... > > > On May 27, 2016, at 12:30 PM, Mike Blumenkrantz > > wrote: > > > > I've inlined some replies below. > > > > On Fri, May 27, 2016 at 1:13 PM Yong Bakos >

Re: [PATCH] xdg-shell: add draw states for xdg_surface

On May 28, 2016, at 9:51 AM, Mike Blumenkrantz wrote: > > On Sat, May 28, 2016 at 9:40 AM Yong Bakos > wrote: > Hi Mike, > Regarding the combination of type="array" enum="foo"... > >> On May 27, 2016, at 12:30 PM, Mike Blumenkrantz >> mailto:michael.blumenkra...

Re: [PATCH] xdg-shell: add draw states for xdg_surface

On Sat, May 28, 2016 at 9:40 AM Yong Bakos wrote: > Hi Mike, > Regarding the combination of type="array" enum="foo"... > > On May 27, 2016, at 12:30 PM, Mike Blumenkrantz < > michael.blumenkra...@gmail.com> wrote: > > I've inlined some replies below. > > On Fri, May 27, 2016 at 1:13 PM Yong Bakos

Re: [PATCH] xdg-shell: add draw states for xdg_surface

Hi Mike, Regarding the combination of type="array" enum="foo"... > On May 27, 2016, at 12:30 PM, Mike Blumenkrantz > wrote: > > I've inlined some replies below. > > On Fri, May 27, 2016 at 1:13 PM Yong Bakos > wrote: > On May 27, 2016, at 10:29 AM, Mike Blumenkr

Re: [PATCH] xdg-shell: add draw states for xdg_surface

I've inlined some replies below. On Fri, May 27, 2016 at 1:13 PM Yong Bakos wrote: > On May 27, 2016, at 10:29 AM, Mike Blumenkrantz > wrote: > > > > this adds a method for compositors to change various draw attributes > > for a surface > > > > Signed-off-by: Mike Blumenkrantz > > Signed-off-b

Re: [PATCH] xdg-shell: add draw states for xdg_surface

On May 27, 2016, at 10:29 AM, Mike Blumenkrantz wrote: > > this adds a method for compositors to change various draw attributes > for a surface > > Signed-off-by: Mike Blumenkrantz > Signed-off-by: Jonas Ådahl Hi Mike & Jonas, A question about communicating default state, and some minor nits

[PATCH] xdg-shell: add draw states for xdg_surface

this adds a method for compositors to change various draw attributes for a surface Signed-off-by: Mike Blumenkrantz Signed-off-by: Jonas Ådahl --- unstable/xdg-shell/xdg-shell-unstable-v6.xml | 69 1 file changed, 69 insertions(+) diff --git a/unstable/xdg-shell/xd