Re: [PATCH] compositor: fix uniform handling for fade_output()

2011-12-20 Thread Kristian Høgsberg
On Tue, Dec 20, 2011 at 9:38 AM, Pekka Paalanen wrote: > fade_output() is strange in that it manufactures a wlsc_surface object > by hand, and then calls wlsc_surface_draw() on it. > > Valgrind complained, that wlsc_surface_draw() accesses uninitialised > data: wlsc_surface::alpha. fade_output() f

[PATCH] compositor: fix uniform handling for fade_output()

2011-12-20 Thread Pekka Paalanen
fade_output() is strange in that it manufactures a wlsc_surface object by hand, and then calls wlsc_surface_draw() on it. Valgrind complained, that wlsc_surface_draw() accesses uninitialised data: wlsc_surface::alpha. fade_output() forgets to set it. Initialise surface.alpha in fade_output(). Spe