Re: Floating windows in input-method

2019-12-16 Thread Silvan Jegen
Hi Simon Ser wrote: > Hi Dorota, > > On Sunday, December 15, 2019 7:55 PM, Dorota Czaplejewicz > wrote: > > > Hi all, > > > > in order to give this change more traction, I've been thinking about > > slimming down the protocol, and removing floating windows from this > > revision. > > > > This

Re: [RFC wayland-protocols] input-method: Add zwp-input-method-v2

2018-08-07 Thread Silvan Jegen
Hi Just some typos I found (for now): On Mon, Aug 06, 2018 at 03:00:21PM +0200, Dorota Czaplejewicz wrote: > This protocol is based on v1, and current text-input-v3. > > The pieces passing data relevant to the application on the other side of the > compositor are a mirror copy of text-input-v3

Re: [PATCH] scanner: allow referencing foreign enums

2018-05-26 Thread Silvan Jegen
insertion(+), 6 deletions(-) It looks good to me and I can confirm that this works as intended. If no solution allowing for the passing of reference protocols is desired, this should be applied. Reviewed-by: Silvan Jegen Cheers, Silvan > > diff --git a/src/scanner.c b/src/scanner.c > in

Re: [PATCH] virtual-keyboard: Add new virtual keyboard protocol

2018-05-18 Thread Silvan Jegen
Hi Just a typo I found below. On Thu, May 17, 2018 at 06:53:10PM +0200, Dorota Czaplejewicz wrote: > Provides the ability to emulate keyboards by > applications. Complementary to input-method protocol. > > The interface is a mirror copy of wl_keyboard, with removed serials, > and added seat bind

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-10 Thread Silvan Jegen
On Thu, May 10, 2018 at 11:46:32AM +0200, Dorota Czaplejewicz wrote: > On Thu, 10 May 2018 11:43:12 +0200 > Dorota Czaplejewicz wrote: > > > On Tue, 08 May 2018 07:07:24 +0000 > > Silvan Jegen wrote: > > > > > On Mon, May 7, 2018 at 5:11 AM Joshua Watt wro

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-08 Thread Silvan Jegen
On Mon, May 7, 2018 at 5:11 AM Joshua Watt wrote: > IMHO, if you are doing UTF-8 (which you should), you should *always* > specify any offset in the string as a byte offset. I have a few > reasons for this justification: I agree with this as well. I thought some more about how to spell out my gut

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-07 Thread Silvan Jegen
Hi Joshua On Sun, May 06, 2018 at 10:11:32PM -0500, Joshua Watt wrote: > On Sun, May 6, 2018 at 3:37 PM, Dorota Czaplejewicz > wrote: > > Unless someone chimes in with more arguments, I'm going to keep > > using code points in following revisions. > > I don't mean to do a drive by or bikeshed, I

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-07 Thread Silvan Jegen
On Sun, May 06, 2018 at 10:37:57PM +0200, Dorota Czaplejewicz wrote: > On Sat, 5 May 2018 13:37:44 +0200 > Silvan Jegen wrote: > > > On Sat, May 05, 2018 at 11:09:10AM +0200, Dorota Czaplejewicz wrote: > > > On Fri, 4 May 2018 22:32:15 +0200 > > > Silvan Jege

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-05 Thread Silvan Jegen
On Sat, May 05, 2018 at 11:09:10AM +0200, Dorota Czaplejewicz wrote: > On Fri, 4 May 2018 22:32:15 +0200 > Silvan Jegen wrote: > > > On Thu, May 03, 2018 at 10:46:47PM +0200, Dorota Czaplejewicz wrote: > > > On Thu, 3 May 2018 21:55:40 +0200 > > > Silvan Jege

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-04 Thread Silvan Jegen
On Thu, May 03, 2018 at 10:46:47PM +0200, Dorota Czaplejewicz wrote: > On Thu, 3 May 2018 21:55:40 +0200 > Silvan Jegen wrote: > > > On Thu, May 03, 2018 at 09:22:46PM +0200, Dorota Czaplejewicz wrote: > > > On Thu, 3 May 2018 20:47:27 +0200 > > > Silvan Jegen

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-03 Thread Silvan Jegen
On Thu, May 03, 2018 at 09:22:46PM +0200, Dorota Czaplejewicz wrote: > On Thu, 3 May 2018 20:47:27 +0200 > Silvan Jegen wrote: > > > Hi Dorota > > > > Some comments and typo fixes below. > > > > On Thu, May 03, 2018 at 05:41:21PM +0200, Dorota Czap

Re: [PATCHv4 wayland-protocols] text-input: Add v3 of the text-input protocol

2018-05-03 Thread Silvan Jegen
Hi Dorota Some comments and typo fixes below. On Thu, May 03, 2018 at 05:41:21PM +0200, Dorota Czaplejewicz wrote: > This new protocol description is a simplification over v2. > > - All pre-edit text styling is gone. > - Pre-edit cursor can span characters. > - No events regarding input panel (O

Re: [PATCHv2] text-input: Add v3 of the text-input protocol

2018-04-14 Thread Silvan Jegen
On Thu, Apr 12, 2018 at 09:53:17PM +0200, Dorota Czaplejewicz wrote: > On Thu, 12 Apr 2018 21:26:08 +0200 > Silvan Jegen wrote: > > > Hi Dorota > > > > On Wed, Apr 11, 2018 at 03:03:58PM +0200, Dorota Czaplejewicz wrote: > > > Cheers, > > > Dorota

Re: [PATCHv2] text-input: Add v3 of the text-input protocol

2018-04-13 Thread Silvan Jegen
On Thu, Apr 12, 2018 at 9:53 PM, Dorota Czaplejewicz wrote: > On Thu, 12 Apr 2018 21:26:08 +0200 > Silvan Jegen wrote: > >> Hi Dorota >> >> On Wed, Apr 11, 2018 at 03:03:58PM +0200, Dorota Czaplejewicz wrote: >> > This new protocol description is a simplif

Re: [PATCHv2] text-input: Add v3 of the text-input protocol

2018-04-12 Thread Silvan Jegen
l as issues pointed out in > response to the original proposal. > > Changes over the original: > - typos, whitespace and naming as pointed out by Silvan Jegen > - an explicit description of what happens to state: it's conceptually > double-buffered, and is not altered between

Re: [PATCH wayland-protocols] text-input: Add v3 of the text-input protocol

2018-04-01 Thread Silvan Jegen
Hi Please find some comments and questions below. On Sun, Mar 11, 2018 at 08:30:14PM +0100, Carlos Garnacho wrote: > This new protocol description is a vast simplification over v2, highlights > are: > - All pre-edit text styling is gone, the protocol doesn't seem the place > to convey UI state.

Re: [PATCH 1/2] xdg-shell: move maximized state difnition together

2018-02-27 Thread Silvan Jegen
Hi One typo corrected below. On Tue, Feb 27, 2018 at 1:24 PM, wrote: > From: Markus Ongyerth > > The xdg-shell documentation had part of the maximized state render > implications in the `set_maximized` request documentation, not the > actual state. > This moves the relevant lines into the stat

Re: Wayland talk at FOSDEM

2017-12-08 Thread Silvan Jegen
On Thu, Dec 7, 2017 at 10:32 PM, Philipp Kerling wrote: > Hi, > > 2017-12-06 (水) の 08:56 +0100 に Silvan Jegen さんは書きました: >> I see that you left out the text-input/input-method protocols in your >> topics. Is it because those are unstable or because you don't >>

Re: Wayland talk at FOSDEM

2017-12-05 Thread Silvan Jegen
Hi On Tue, Dec 5, 2017 at 3:46 PM, Philipp Kerling wrote: > I've been thinking about submitting a Wayland-themed talk to the FOSDEM > graphics devroom [1] and wanted to check with the community if anyone > else has considered this or another Wayland topic and whether you think > it would be a goo

Re: [PATCH weston 1/2] text-backend: Allow client hiding of input panel

2017-07-19 Thread Silvan Jegen
On Wed, Jul 19, 2017 at 3:49 PM, Joshua Watt wrote: > On Sun, 2017-07-09 at 21:26 +0200, Silvan Jegen wrote: >> Hi Joshua >> >> On Wed, Jul 05, 2017 at 08:58:51AM -0500, Joshua Watt wrote: >> > On Sat, 2017-06-24 at 16:03 -0500, Joshua Watt wrote: >> >

Re: [PATCH weston 1/2] text-backend: Allow client hiding of input panel

2017-07-09 Thread Silvan Jegen
Hi Joshua On Wed, Jul 05, 2017 at 08:58:51AM -0500, Joshua Watt wrote: > On Sat, 2017-06-24 at 16:03 -0500, Joshua Watt wrote: > > Previously, the hide_input_panel and show_input_panel messages for > > the text > > input protocol were limited to specific cases, such as showing the > > panel on > >

Re: Wayland Virtual Keyboard

2017-05-17 Thread Silvan Jegen
Hi On Wed, May 17, 2017 at 9:49 PM, Joshua Watt wrote: > I'm working on an embedded device where we are writing our own custom > Wayland compositor, and we have need of a virtual keyboard (something > implementing one of the text-input protocols). Does anyone know of > such a project? My searches

Re: [RFC PATCH 0/8] Meson build system

2016-11-30 Thread Silvan Jegen
On Wed, Nov 30, 2016 at 11:58 AM, Daniel Stone wrote: > Hi Silvan, > > On 30 November 2016 at 10:51, Silvan Jegen wrote: >> On Wed, Nov 30, 2016 at 11:00 AM, Daniel Stone wrote: >>> Ha, this isn't Skylake laptop vs. Broadwell laptop, this is my 14-core >>>

Re: [RFC PATCH 0/8] Meson build system

2016-11-30 Thread Silvan Jegen
Hi On Wed, Nov 30, 2016 at 11:00 AM, Daniel Stone wrote: > Hey Emil, > Thanks for the detailed reply! :) It's really interesting to hear your > perspective, especially with Mesa also using SCons. > > On 30 November 2016 at 01:02, Emil Velikov wrote: >> On 29 November 2016 at 20:50, Daniel Stone

Re: [PATCH wayland-protocols v7] text: Create second version of text input protocol

2016-11-25 Thread Silvan Jegen
On Wed, Oct 12, 2016 at 03:50:33PM -0700, Bryce Harrington wrote: > On Wed, Jul 06, 2016 at 12:26:28AM +0200, Jan Arne Petersen wrote: > > On Thu, Jun 9, 2016 at 1:01 PM Carlos Garnacho wrote: > > > > Hi Carlos, > > > > Thanks for the feedback. > > > > > > > > Chiming in, and kinda late at that

Re: [PATCH weston v2 1/2] editor: Use parse_options() from shared for command line options

2016-11-21 Thread Silvan Jegen
Hi One comment below. On Mon, Nov 21, 2016 at 10:34:33AM -0800, Bryce Harrington wrote: > Also add a basic --help option > > Signed-off-by: Bryce Harrington > --- > clients/editor.c | 78 > +--- > 1 file changed, 57 insertions(+), 21 deletio

Re: [PATCH] weston-editor: Don't copy the preedit string before inserting it

2016-11-18 Thread Silvan Jegen
Hi Bryce And thanks for the review! On Fri, Nov 18, 2016 at 1:20 AM, Bryce Harrington wrote: > On Thu, Nov 17, 2016 at 09:43:05PM +0100, Silvan Jegen wrote: >> Signed-off-by: Silvan Jegen >> --- >> clients/editor.c | 8 +--- >> 1 file changed, 1 insertion(+)

[PATCH] weston-editor: Don't copy the preedit string before inserting it

2016-11-17 Thread Silvan Jegen
Signed-off-by: Silvan Jegen --- clients/editor.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/clients/editor.c b/clients/editor.c index 6805d8a..1ed3eec 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -944,16 +944,10 @@ text_entry_reset_preedit(struct

[PATCH] weston-editor: Free preferred_language in text_entry_destroy

2016-11-17 Thread Silvan Jegen
Signed-off-by: Silvan Jegen --- clients/editor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/clients/editor.c b/clients/editor.c index 1ed3eec..a0d66d1 100644 --- a/clients/editor.c +++ b/clients/editor.c @@ -719,6 +719,7 @@ text_entry_destroy(struct text_entry *entry

Re: Kinetic scroll in libinput Xorg driver

2016-10-27 Thread Silvan Jegen
On Wed, Oct 26, 2016 at 8:57 AM, Alexis BRENON @Wayland wrote: > Finally, do you know some tiling DE/WM Wayland compliant ? The two that come to mind are: https://github.com/michaelforney/velox Velox: a Wayland port of dwm with minimal dependencies http://swaywm.org/ Sway: which is a port of i3

Re: [PATCH weston 04/14 v3] weston: Port DRM backend to new output handling API

2016-09-13 Thread Silvan Jegen
Hi Found a few typos mentioned below. On Thu, Aug 18, 2016 at 6:42 PM, Armin Krezović wrote: > This is a complete port of the DRM backend that uses > recently added output handling API for output *the* recently added [...] > configuration. > > Output can be configured at runtime by passing the

Re: [RFC wayland-web] docs, web site, logo

2016-08-22 Thread Silvan Jegen
Hi On Mon, Aug 22, 2016 at 11:37 AM, Pekka Paalanen wrote: > On Sat, 20 Aug 2016 11:54:29 +0100 > Daniel Stone wrote: > > [...] > >> I think this is easily the lowest-priority issue here. It's not the >> best, but it certainly works, and it's not really holding us back from >> progress. It's als

Re: [PATCH v3 wayland-protocols] text: Create second version of text input protocol

2016-02-02 Thread Silvan Jegen
Hi Please find some comments and spelling corrections below. > There were some shortcomings in the first version of the protocol which > makes it not really useful in real world applications. It is not really > possible to fix them in a compatible way so introduce a new v2 of the > protocol. > >

Re: [PATCH v1] rephrasing the index.html to match the current shape of the project

2015-11-27 Thread Silvan Jegen
Hi Found a few typos that I point out below. On Fri, Nov 27, 2015 at 03:35:11PM +0100, Benoit Gschwind wrote: > I added bryce comments, my comments and my favorite capitalization. > > Best regards > > --- > index.html | 39 --- > 1 file changed, 24 insertion

Re: [RFC wayland 2/2] Add a wayland protocol dumper wayland-tracer

2014-07-20 Thread Silvan Jegen
Hi and thanks for this! I hope to learn more about the protocol by using this tool. I encountered two simple issues when applying your patches (see below). On Sun, Jul 20, 2014 at 10:18:03AM +0800, Boyan Ding wrote: > Signed-off-by: Boyan Ding > --- > .gitignore | 1 + > Makefile.am | 10

Re: [ANNOUNCE] libinput 0.4.0

2014-06-25 Thread Silvan Jegen
On Wed, Jun 25, 2014 at 9:02 AM, Lyude wrote: > Ah, something else I forgot to mention: > > git-am requires that the patches be in .mbox format, otherwise it won't > work properly. I don't think there's a way to do this in gmail since the > last time I checked, it can't save e-mails in that format

[PATCH] protocol: remove redundant 'the' in description

2014-05-22 Thread Silvan Jegen
Signed-off-by: Silvan Jegen --- protocol/wayland.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 22eb6e7..113c7b7 100644 --- a/protocol/wayland.xml +++ b/protocol/wayland.xml @@ -550,8 +550,8 @@ The current and

Re: [PATCH weston] compositor-rpi: Fix input initialization

2014-02-04 Thread Silvan Jegen
On Tue, Feb 04, 2014 at 09:42:55AM +0100, Yann E. MORIN wrote: > > From: Emilio Pozuelo Monfort > > > > The input initialization code assumes the outputs have already > > been initialized; thus create the outputs first. This fixes a > > segfault upon startup. It is also what the drm and fbdev bac

Re: weston-1.4.0: rpi-backend is broken

2014-01-31 Thread Silvan Jegen
Hi everyone On Sun, Jan 26, 2014 at 09:15:50PM +0100, Yann E. MORIN wrote: > [...] > Here's the complete log of 'weston >weston.log 2>&1' : > > ---8<--- > Date: 2014-01-26 UTC > [20:03:09.606] weston 1.4.0 >http://wayland.freedesktop.org/ >Bug r

[PATCH v2] Building: update the Raspberry Pi weston section

2013-09-17 Thread Silvan Jegen
Update the Weston autogen.sh flags and make the accompanying text less confusing. --- raspberrypi.html | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/raspberrypi.html b/raspberrypi.html index 44d9ce4..153b8a2 100644 --- a/raspberrypi.html +++ b/raspberr

Re: Problems building Weston/demo applications on the Raspberry Pi

2013-09-17 Thread Silvan Jegen
> thanks for the patch! :-) You are very welcome! > One minor correction: it is not exactly the flag, but removing > wayland-egl.pc that makes sure that toytoolkit does not use cairo-egl. > Otherwise looks good, and the patch is an improvement even as is. You see, I TOLD you the text is confusi

Re: Problems building Weston/demo applications on the Raspberry Pi

2013-09-16 Thread Silvan Jegen
hould simply be removed from the configure line. Sadly, that fix was not obvious to me. Removing the flag solved the problem, thanks a lot! In the attached patch I removed the flag and tried to make the text less confusing. Kind regards, Silvan >From 72a2436d1876267d8516a40b3e7efb2f158695e6

Problems building Weston/demo applications on the Raspberry Pi

2013-09-15 Thread Silvan Jegen
Hi everyone I am trying to build libwayland, Weston and the demo programs on my Raspberry Pi following the guide at http://wayland.freedesktop.org/raspberrypi.html When compiling Weston and the demo programs however, I get the attached error and no Makefile is being created. What confuses me is