Re: [PATCH v1] Added touch support to wayland backend

2015-01-10 Thread Imran Zaman
Can anyone please comment on it? :) BR imran On Wed, Dec 17, 2014 at 4:11 PM, Imran Zaman wrote: > Nested westons (with wayland backend as child weston) is one possible > use case for the needed touch support. > > Signed-off-by: Imran Zaman > --- > src/composi

Re: [PATCH] fullscreen-shell: Fix modeset on transformed outputs

2015-01-08 Thread Imran Zaman
Hi Ekstrand! I have tested it in nested compositors case; unfortunately it is not enough and doesn't work :-) The reason is that drm compositor (choose_mode) function rejects the mode if width and height are swapped so similar patch is needed for choose_mode in drm compositor based on transform.

[PATCH v1] Added touch support to wayland backend

2014-12-17 Thread Imran Zaman
Nested westons (with wayland backend as child weston) is one possible use case for the needed touch support. Signed-off-by: Imran Zaman --- src/compositor-wayland.c | 59 1 file changed, 59 insertions(+) diff --git a/src/compositor-wayland.c b

Re: [PATCH v1] Added string conversion utility functions

2014-12-02 Thread Imran Zaman
Interesting read.. have some arguments about the raised points.. but lets not go in that direction.. Can you guys suggest to do some changes or shall i drop the patch altogether? if you are happy with current implementation lets live with it.. I noticed bug when weston was not working properly due

Re: [PATCH v1] Added string conversion utility functions

2014-11-25 Thread Imran Zaman
Thanks Bill for your comments. Plz see my comments inline. On Tue, Nov 25, 2014 at 9:26 PM, Bill Spitzak wrote: > > > On 11/24/2014 11:12 PM, Imran Zaman wrote: >> >> On Tue, Nov 25, 2014 at 1:15 AM, Bill Spitzak wrote: >>> >>> >>> >>>

Re: [PATCH v1] Added string conversion utility functions

2014-11-24 Thread Imran Zaman
On Tue, Nov 25, 2014 at 1:15 AM, Bill Spitzak wrote: > > > On 11/24/2014 11:32 AM, Imran Zaman wrote: > >> [IZ2] This is the case where endptr is used in patch. I can remove >> endptr but it seems its used so i have to keep the existing >> functionality in place. >

Re: [PATCH v1] Added string conversion utility functions

2014-11-24 Thread Imran Zaman
Hi Please see the comments below. BR imran On Mon, Nov 24, 2014 at 8:58 PM, Bill Spitzak wrote: > > > On 11/24/2014 05:08 AM, Imran Zaman wrote: >> >> Thanks Bill for your comments. Please see my comments inline. >> >> On Fri, Nov 21, 2014 at 9:31 PM, Bill Sp

[PATCH v2] Increase listen queue to 128

2014-11-24 Thread Imran Zaman
This will allow more than 1 simultaneous client connections to the server without the possibility of connection refused error. Signed-off-by: Imran Zaman --- src/wayland-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wayland-server.c b/src/wayland-server.c

Re: Wayland and Weston in Patchwork

2014-11-24 Thread Imran Zaman
Exactly git send-email did ask for utf-8 and i guess i entered y.. shall I not? and no idea why git is making it multipart.. Shall i try to resend the patch with utf-8 question as 'no'? BR imran On Mon, Nov 24, 2014 at 3:50 PM, Pekka Paalanen wrote: > On Mon, 24 Nov 2014 15:33:51

Re: [PATCH wayland] increase server listen queue to 8

2014-11-24 Thread Imran Zaman
at 12:22 PM, Pekka Paalanen wrote: > On Wed, 15 Oct 2014 16:43:34 +0300 > Imran Zaman wrote: > >> Hi >> >> This will allow more than 1 simultaneous client connections to the server >> without the possibility of connection refused error. possible use case >> is

Re: Wayland and Weston in Patchwork

2014-11-24 Thread Imran Zaman
Hi Somehow I dont see the patch below in patch work: http://lists.freedesktop.org/archives/wayland-devel/2014-November/018410.html Any idea what is wrong with it or there is some sort of filtering or ? BR imran On Thu, Nov 20, 2014 at 12:47 AM, Bill Spitzak wrote: > On 11/19/2014 07:30 AM, Dan

Re: [PATCH v1] Added string conversion utility functions

2014-11-24 Thread Imran Zaman
ognized value for "largest number possible". May be ok to > not allow other negative numbers however. > [IZ] IMO its good to keep the APIs simple and homogeneous with appropriate data structures needed for the input BR imran > On 11/21/2014 07:38 AM, Imran Zaman wrote: > >>

[PATCH v1] Added string conversion utility functions

2014-11-21 Thread Imran Zaman
Change-Id: I50900852311604a8c31313bbfb1d137c495d2269 Signed-off-by: Imran Zaman --- Makefile.am | 14 +- clients/multi-resource.c| 8 +- clients/terminal.c | 8 +- clients/wscreensaver-glue.c | 6 +- shared/config-parser.c | 10 +- shared/option-parser.c

Re: [PATCH wayland 2/2] support specifying custom directories for the client and server

2014-11-19 Thread Imran Zaman
... corrected jussi email address.. BR irman On Wed, Nov 19, 2014 at 12:56 PM, Pekka Paalanen wrote: > On Wed, 15 Oct 2014 17:36:27 +0300 > Imran Zaman wrote: > >> Hi >> >> support for adjusting socket access rights to allow group of users to >> connect to t

Re: [PATCH v1] wayland-api: added name/seatname properties to the wl_output

2014-11-05 Thread Imran Zaman
Pekka, thanks a lot for the detailed explanation. Lets see which way we go. BR imran On Wed, Nov 5, 2014 at 6:32 PM, Pekka Paalanen wrote: > On Fri, 17 Oct 2014 12:37:37 +0300 > Imran Zaman wrote: > > > In a multi-seat configuration, clients may need to filter > > out the

Re: [PATCH v1] Added more error checks when strtol function is used

2014-11-05 Thread Imran Zaman
pushed v3 to patchwork with the change mentioned and marked the older versions as superceeded http://patchwork.freedesktop.org/patch/36297/ BR imran On Wed, Nov 5, 2014 at 5:27 PM, Pekka Paalanen wrote: > On Tue, 4 Nov 2014 15:55:06 +0200 > Imran Zaman wrote: > > > Signe

[PATCH v3] Added more error checks when strtol function is used

2014-11-05 Thread Imran Zaman
Signed-off-by: Imran Zaman --- src/scanner.c| 4 +++- src/wayland-client.c | 5 - 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index 5e5152b..fa8e0c0 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -405,11 +405,13 @@ start_element

[PATCH v2] Added more error checks when strtol function is used

2014-11-05 Thread Imran Zaman
Signed-off-by: Imran Zaman --- src/scanner.c| 5 - src/wayland-client.c | 6 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index 5e5152b..9ba34e8 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -405,9 +405,12 @@ start_element

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added

2014-11-05 Thread Imran Zaman
I have already taken off that patch from the patchwork list... and pushed a simpler version... http://lists.freedesktop.org/archives/wayland-devel/2014-November/018030.html BR imran On Wed, Nov 5, 2014 at 5:08 PM, Pekka Paalanen wrote: > On Wed, 15 Oct 2014 22:04:46 +0300 > Imran Zaman

[PATCH v1] Added more error checks when strtol function is used

2014-11-04 Thread Imran Zaman
Signed-off-by: Imran Zaman --- src/scanner.c| 2 +- src/wayland-client.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/scanner.c b/src/scanner.c index 5e5152b..2ed9775 100644 --- a/src/scanner.c +++ b/src/scanner.c @@ -407,7 +407,7 @@ start_element(void

Re: [PATCH v3] wayland-util: added wl_strtol/wl_strtoul utility functions

2014-11-04 Thread Imran Zaman
I will push new patch with minor fix to the strtol function in wayland and move this old patch (after segfault fix) to weston so that it does not end up in libwayland APIs. Consequently I changed its property in patchwork BR imran On Wed, Oct 29, 2014 at 10:27 AM, Imran Zaman wrote: > >

Re: Wayland and Weston in Patchwork

2014-11-04 Thread Imran Zaman
Thats really good initiative Pekka/Daniel. Thanks. BR imran On Tue, Nov 4, 2014 at 1:14 PM, Pekka Paalanen wrote: > Hi all, > > some of you already know that we now have > http://patchwork.freedesktop.org/project/wayland/list/ > to keep track of the patches sent to wayland-devel mailing list. >

Re: [PATCH v3] wayland-util: added wl_strtol/wl_strtoul utility functions

2014-10-29 Thread Imran Zaman
On Wed, Oct 29, 2014 at 10:09 AM, Giulio Camuffo wrote: > 2014-10-29 8:45 GMT+02:00 Imran Zaman : > > Daniel! > > > > As per your logic, I see wl_list APIs exposed etc, which shouldn't be > part > > of libwayland as well. > > similarly, wl_fixed_to_dou

Re: [PATCH v3] wayland-util: added wl_strtol/wl_strtoul utility functions

2014-10-28 Thread Imran Zaman
e reviewed till now. http://lists.freedesktop.org/archives/wayland-devel/2014-October/017833.html BR imran On Tue, Oct 28, 2014 at 6:36 PM, Daniel Stone wrote: > Hi, > > On 28 October 2014 15:40, Imran Zaman wrote: > >> You guys should check the reason why the patch is there

Re: [PATCH v3] wayland-util: added wl_strtol/wl_strtoul utility functions

2014-10-28 Thread Imran Zaman
You guys should check the reason why the patch is there rather than throwing out random thoughts or blunt comments. I did this patch mainly because weston/wayland has been using strtol/strtoul functions in number of places with buggy error checks, and duplicate code everywhere. Weston and wayland

[PATCH wayland] increase server listen queue to 8

2014-10-24 Thread Imran Zaman
Hi This will allow more than 1 simultaneous client connections to the server without the possibility of connection refused error. possible use case is multiple session compositors can connect to the system compositor simultaneously. diff --git a/src/wayland-server.c b/src/wayland-server.c i

Re: [PATCH v2] wayland-util: added wl_strtol/wl_strtoul utility functions

2014-10-22 Thread Imran Zaman
t; mentioned that), > but I understand there are reasons for them to be public and maybe in the > end it will have more pros.. > Anyway, I have few nitpicks and a questions - see below. > > On 16 October 2014 18:11, Imran Zaman wrote: >> >> strtol/strtoul utility functions ar

[PATCH v3] wayland-util: added wl_strtol/wl_strtoul utility functions

2014-10-22 Thread Imran Zaman
strtol/strtoul utility functions are used extensively in weston/wayland, and are not bug-free in their current form. To avoid definition in weston and wayland, its wrapped in functions with appropriate input and output checks. Test cases are also updated. Signed-off-by: Imran Zaman --- src

[PATCH v1] wayland-api: added name/seatname properties to the wl_output

2014-10-17 Thread Imran Zaman
of the output (e.g. its very similar that input which has the name property attached to it). Signed-off-by: Imran Zaman --- protocol/wayland.xml | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 762482e

[PATCH 2/2] Support for adjusting socket access rights to allow group of users to connect to the socket.

2014-10-16 Thread Imran Zaman
This is used for nested compositor architectures. Signed-off-by: Imran Zaman --- src/wayland-server.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index 09e8903..721fabe 100644 --- a/src/wayland-server.c +++ b/src

[PATCH 1/2] Support specifying custom directories for the client and server sockets through environment variables.

2014-10-16 Thread Imran Zaman
This is in order to support nested compositor architectures where system compositor using drm-backend is shared among multiple child compositors using wayland-backend. Signed-off-by: Imran Zaman --- src/wayland-client.c | 5 - src/wayland-server.c | 5 - 2 files changed, 8 insertions

[PATCH v2] wayland-util: added wl_strtol/wl_strtoul utility functions

2014-10-16 Thread Imran Zaman
strtol/strtoul utility functions are used extensively in weston/wayland, and are not bug-free in their current form. To avoid definition in weston and wayland, its wrapped in functions with appropriate input and output checks. Test cases are also updated. Signed-off-by: Imran Zaman --- src

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added (inlined patch)

2014-10-16 Thread Imran Zaman
updated patch after the changes.. On Thu, Oct 16, 2014 at 4:05 AM, Bryce Harrington wrote: > On Wed, Oct 15, 2014 at 04:18:59PM +0300, Imran Zaman wrote: >> Hi >> >> The patch is used to replace strtol and strtoul with wl_strtol and >> wl_strtoul with inputs and resul

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added

2014-10-15 Thread Imran Zaman
Rémi Denis-Courmont > wrote: >> >> Le 2014-10-15 16:14, Imran Zaman a écrit : >>> >>> Hi >>> >>> The patch is used to replace strtol and strtoul with wl_strtol and >>> wl_strtoul with inputs and result checks. >> >> >> I don&

Re: [PATCH wayland] wl_strtol and wl_strtoul utility functions are added (inlined patch)

2014-10-15 Thread Imran Zaman
t; On Wed, Oct 15, 2014 at 6:18 AM, Imran Zaman wrote: >> >> Hi >> >> The patch is used to replace strtol and strtoul with wl_strtol and >> wl_strtoul with inputs and result checks. >> >> The utility functions are used extensively in wayland and weston so add

[PATCH wayland 2/2] support specifying custom directories for the client and server

2014-10-15 Thread Imran Zaman
Hi support for adjusting socket access rights to allow group of users to connect to the socket. This is used for nested compositor architectures. - diff --git a/src/wayland-server.c b/src/wayland-server.c index ce1eca8..b1ca5e6 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@

[PATCH wayland 1/2] support specifying custom directories for the client and server

2014-10-15 Thread Imran Zaman
Hi support specifying custom directories for the client and server sockets through environment variables. This is in order to support nested compositor architectures where system compositor using drm-backend is shared among multiple child compositors using wayland-backend. --- diff --

[PATCH wayland] wl_strtol and wl_strtoul utility functions are added (inlined patch)

2014-10-15 Thread Imran Zaman
Hi The patch is used to replace strtol and strtoul with wl_strtol and wl_strtoul with inputs and result checks. The utility functions are used extensively in wayland and weston so added appropriate input and output checks; test cases are also updated; will push the patch for weston as well.

[PATCH wayland] wl_strtol and wl_strtoul utility functions are added

2014-10-15 Thread Imran Zaman
imran commit 6be79948c9d408bb4f61cec5fff391f7ed7beb7b Author: Imran Zaman Date: Wed Oct 15 16:02:16 2014 +0300 wayland-util: added wl_strtol/wl_strtoul utility functions The utility functions are used extensively so added appropriate checks and test cases. Signed-off-by