The reason is that strtol is used at many places in weston/wayland.. and its not covering all the error cases everywhere (i.e. its buggy).. so its better to encapsulate it in a function with all the input and output checks... it can be moved to weston if its sound such a big deal...
On Wed, Oct 15, 2014 at 9:42 PM, Jason Ekstrand <[email protected]> wrote: > I don't see how this belongs in libwayland. Sure, we use strtol twice, but > I don't think that warrants adding 100 lines of wrapper functions and test > cases. > --Jason Ekstrand > > On Wed, Oct 15, 2014 at 6:16 AM, Rémi Denis-Courmont <[email protected]> > wrote: >> >> Le 2014-10-15 16:14, Imran Zaman a écrit : >>> >>> Hi >>> >>> The patch is used to replace strtol and strtoul with wl_strtol and >>> wl_strtoul with inputs and result checks. >> >> >> I don't know where Wayland developers stand on this, but I would rather >> the client library function calls not clobber errno to zero. >> >> >> -- >> Rémi Denis-Courmont >> _______________________________________________ >> wayland-devel mailing list >> [email protected] >> http://lists.freedesktop.org/mailman/listinfo/wayland-devel > > _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
