Re: race between (say) wl_display_sync and wl_callback_add_listener?

2023-09-26 Thread Alexandros Frantzis
On Tue, Sep 26, 2023 at 10:08:55AM +0100, John Cox wrote: > Hi > > Many thanks for your comprehensive answer > > >On Mon, Sep 25, 2023 at 05:10:30PM +0100, John Cox wrote: > >> Hi > > > >Hi, > > > >> Assuming I have a separate poll/read_events/dispatch_queue thread to my > >> main thread. If I go

Re: race between (say) wl_display_sync and wl_callback_add_listener?

2023-09-26 Thread Alexandros Frantzis
On Mon, Sep 25, 2023 at 05:10:30PM +0100, John Cox wrote: > Hi Hi, > Assuming I have a separate poll/read_events/dispatch_queue thread to my > main thread. If I go wl_display_sync/wl_callback_add_listener on the > main thread is there a race condition between those two calls where the > other thr

Re: Weston 8: kiosk-shell background is black but should be grey

2022-10-04 Thread Alexandros Frantzis
On Tue, Oct 04, 2022 at 08:55:22AM +0100, Terry Barnaby wrote: > From what I can see the kiosk-shell in Weston 9.0 should draw a grey (0.5, > 0.5, 0.5) solid colour background. However on my NXP embedded system it > shows as black. > > Should the kiosk-shell in Weston 9.0 actually draw grey ? > >

Re: Weston window move to second monitor

2022-10-03 Thread Alexandros Frantzis
On Sun, Oct 02, 2022 at 09:13:27AM +0100, Terry Barnaby wrote: > Hi, > > I am developing software for an instrument embedded system using NXP CPU's > and the Wayland/Weston GUI system. > > The hardware platform has a main LCD panel and an optional plug-in HDMI > monitor. The GUI is currently runn

Re: Questions about wl_pointer.set_cursor

2020-11-18 Thread Alexandros Frantzis
On Wed, Nov 18, 2020 at 12:10:45PM +0200, Pekka Paalanen wrote: > On Tue, 17 Nov 2020 17:38:32 +0200 > Alexandros Frantzis wrote: > > > Hi everyone! > > Hi Alf > Hi Pekka, > > I have some questions about the expected behavior of > > wl_pointer.set_cur

Questions about wl_pointer.set_cursor

2020-11-17 Thread Alexandros Frantzis
Hi everyone! I have some questions about the expected behavior of wl_pointer.set_cursor: 1. Is setting the same surface as the cursor for multiple pointers allowed? I don't see anything disallowing this in the spec (but see (2)). If this is allowed, are there any useful scenarios for this?

Re: Upcoming release

2019-01-30 Thread Alexandros Frantzis
On Fri, Jan 25, 2019 at 10:05:47AM -0600, Derek Foreman wrote: > On 1/18/19 4:20 PM, Derek Foreman wrote: > > Hi all, > > > > It's been quite some time since our last weston release, and there's > > been some discussion of getting the next one out in the January to March > > timeframe (this would

Re: [PATCH wayland-protocols v7] Add zwp_linux_explicit_synchronization_v1

2018-12-17 Thread Alexandros Frantzis
On Monday, December 17, 2018 12:44 GMT, Tomek Bury wrote: > On Wed, 28 Nov 2018 at 14:35, Tomek Bury wrote: > > Hi Pekka, > > > > > I suppose the compositor-side copy of buffers you mentioned is for the > > > lack of release fences, not acquire fences? > > Yes, the lack of release fences is the

[PATCH wayland-protocols 3/3] linux-explicit-synchronization: Clarify implicit synchronization guarantees of release events

2018-11-29 Thread Alexandros Frantzis
nt is received. Signed-off-by: Alexandros Frantzis --- .../linux-explicit-synchronization-unstable-v1.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/unstable/linux-explicit-synchronization/linux-explicit-synchronization-unstable-v1.xml b/unstable/linux-explicit-synchroniz

[PATCH wayland-protocols 0/3] Updates to linux-explicit-synchronization

2018-11-29 Thread Alexandros Frantzis
A series of assorted updates and clarifications for the linux-explicit-synchronization protocol. Alexandros Frantzis (3): linux-explicit-synchronization: Allow fences with opaque EGL buffers linux-explicit-synchronization: Warn about using the protocol while using graphics APIs linux

[PATCH wayland-protocols 2/3] linux-explicit-synchronization: Warn about using the protocol while using graphics APIs

2018-11-29 Thread Alexandros Frantzis
Graphics APIs are expected to use this protocol under the hood, and since there can only be one user of explicit synchronization per surface, warn about using the protocol directly in such cases. Signed-off-by: Alexandros Frantzis --- .../linux-explicit-synchronization-unstable-v1.xml

[PATCH wayland-protocols 1/3] linux-explicit-synchronization: Allow fences with opaque EGL buffers

2018-11-29 Thread Alexandros Frantzis
. Also make it clearer that implementations are free to support other buffer types beyond the required ones. Signed-off-by: Alexandros Frantzis --- .../linux-explicit-synchronization-unstable-v1.xml | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/unstable/linux

Re: [PATCH wayland-protocols v7] Add zwp_linux_explicit_synchronization_v1

2018-11-27 Thread Alexandros Frantzis
On Tue, Nov 27, 2018 at 05:17:40PM +0200, Alexandros Frantzis wrote: > On Tue, Nov 27, 2018 at 10:53:45AM +0200, Pekka Paalanen wrote: > > Yes, we probably should have some wording that if a client is letting > > something like EGL to commit the buffers, it must not attempt to us

Re: [PATCH wayland-protocols v7] Add zwp_linux_explicit_synchronization_v1

2018-11-27 Thread Alexandros Frantzis
On Tue, Nov 27, 2018 at 10:53:45AM +0200, Pekka Paalanen wrote: > Yes, we probably should have some wording that if a client is letting > something like EGL to commit the buffers, it must not attempt to use > the fence extension on that wl_surface itself because EGL will probably > be using the ext

Re: [PATCH wayland-protocols v7] Add zwp_linux_explicit_synchronization_v1

2018-11-13 Thread Alexandros Frantzis
On Mon, Nov 12, 2018 at 12:39:58PM +, Tomek Bury wrote: > On Mon, Nov 12, 2018 at 11:15 AM Daniel Stone wrote: > > > On Fri, 9 Nov 2018 at 10:48, Pekka Paalanen wrote: > > > I can add that while pushing upstream, if there are no other changes > > > coming. > > > > > > Reviewed-by: Pekka Paal

Re: [PATCH wayland-protocols v7] Add zwp_linux_explicit_synchronization_v1

2018-11-12 Thread Alexandros Frantzis
On Fri, Nov 09, 2018 at 04:24:56PM +0200, Alexandros Frantzis wrote: > On Fri, Nov 09, 2018 at 12:48:09PM +0200, Pekka Paalanen wrote: > > On Fri, 9 Nov 2018 09:46:36 +0200 > > Alexandros Frantzis wrote: > > > > > Signed-off-by: Alexandros Frantzis > > &g

Re: [PATCH wayland-protocols v7] Add zwp_linux_explicit_synchronization_v1

2018-11-09 Thread Alexandros Frantzis
On Fri, Nov 09, 2018 at 12:48:09PM +0200, Pekka Paalanen wrote: > On Fri, 9 Nov 2018 09:46:36 +0200 > Alexandros Frantzis wrote: > > > Signed-off-by: Alexandros Frantzis > > Hi Alf, Hi Pekka, thanks for the review! > could you come up with some rationale to put

[PATCH wayland-protocols v7] Add zwp_linux_explicit_synchronization_v1

2018-11-08 Thread Alexandros Frantzis
Signed-off-by: Alexandros Frantzis --- Changes in patch v7: - Added linux_ prefix to interface names. Changes in patch v6: - Fixed wl_buffer.attach -> wl_surface.attach typos. - Added NO_BUFFER error and update request descriptions. - Consistently used "error is raised&q

Re: [PATCH wayland-protocols v6] Add zwp_linux_explicit_synchronization_v1

2018-11-08 Thread Alexandros Frantzis
On Thu, Nov 08, 2018 at 05:43:42PM +0200, Pekka Paalanen wrote: > On Thu, 8 Nov 2018 16:34:52 +0200 > Alexandros Frantzis wrote: > > > On Thu, Nov 08, 2018 at 03:00:58PM +0200, Pekka Paalanen wrote: > > > On Wed, 07 Nov 2018 20:22:38 + > > > Simon Ser wro

Re: [PATCH wayland-protocols v6] Add zwp_linux_explicit_synchronization_v1

2018-11-08 Thread Alexandros Frantzis
On Thu, Nov 08, 2018 at 03:00:58PM +0200, Pekka Paalanen wrote: > On Wed, 07 Nov 2018 20:22:38 + > Simon Ser wrote: > > > Thanks! With these fixes, this is now > > > > Reviewed-by: Simon Ser > > > > Below is a small comment, I don't know if it's relevant or not, I just > > wanted to > > p

[PATCH wayland-protocols v6] Add zwp_linux_explicit_synchronization_v1

2018-11-07 Thread Alexandros Frantzis
Signed-off-by: Alexandros Frantzis --- Changes in patch v6: - Fixed wl_buffer.attach -> wl_surface.attach typos. - Added NO_BUFFER error and updated request descriptions. - Consistently used "error is raised" phrasing. - Added comment about buffer_release object destruc

[PATCH wayland-protocols v5] Add zwp_linux_explicit_synchronization_v1

2018-11-06 Thread Alexandros Frantzis
Signed-off-by: Alexandros Frantzis --- Changes in patch v5: - Further clarified the per-commit nature of buffer_release. - Used the wp_linux_dmabuf name to refer to all versions of that protocol. - Fixed wl_buffer.attach typo. - Clarified when an INVALID_FENCE error is raised

Re: [PATCH wayland-protocols v4] Add zwp_linux_explicit_synchronization_v1

2018-11-06 Thread Alexandros Frantzis
On Mon, Nov 05, 2018 at 06:07:56PM +, Simon Ser wrote: > On Monday, November 5, 2018 10:50 AM, Alexandros Frantzis > wrote: > > On Sat, Nov 03, 2018 at 02:44:53PM +, Simon Ser wrote: > > > > Hi Simon, > > > > > > > > + Explicit sy

Re: [PATCH wayland-protocols v4] Add zwp_linux_explicit_synchronization_v1

2018-11-05 Thread Alexandros Frantzis
On Sat, Nov 03, 2018 at 02:44:53PM +, Simon Ser wrote: Hi Simon, > > > > + Explicit synchronization is guaranteed to be supported only for > > > > buffers > > > > + created with any version of the zwp_linux_dmabuf buffer factory. > > > > > > I think we can drop the "z" prefix here.

Re: [PATCH wayland-protocols v4] Add zwp_linux_explicit_synchronization_v1

2018-11-02 Thread Alexandros Frantzis
On Thu, Nov 01, 2018 at 10:10:40PM +, Simon Ser wrote: > Hi Alexandros, > > Here are a few comments about someone who doesn't know a lot about > explicit synchronization. Let me know if I got something wrong. :) > > Overall this looks pretty good. Hi Simon, thanks for the review. My comment

Re: [PATCH wayland-protocols v2] Add zwp_linux_explicit_synchronization_v1

2018-10-31 Thread Alexandros Frantzis
On Wed, Oct 31, 2018 at 11:59:34AM +0200, Pekka Paalanen wrote: > On Mon, 15 Oct 2018 17:16:59 +0300 > Alexandros Frantzis wrote: ... > > > > The main scenario is an early exit from some code using this > > object, in which case it will be easier to correctly synchroniz

[PATCH wayland-protocols v4] Add zwp_linux_explicit_synchronization_v1

2018-10-18 Thread Alexandros Frantzis
Signed-off-by: Alexandros Frantzis --- Changes in patch v4: - Guarantee protocol compatibility only with zwp_linux_dmabuf buffers. - Add the UNSUPPORTED_BUFFER error. Changes in patch v3: - Reworded implicit/explicit synchronization intro in zwp_surface_synchronization_v1 description

Re: [PATCH wayland-protocols v2] Add zwp_linux_explicit_synchronization_v1

2018-10-15 Thread Alexandros Frantzis
version (v3) of this proposal based on this discussion. > On Tue, 9 Oct 2018 18:11:22 +0300 > Alexandros Frantzis wrote: > > > Signed-off-by: Alexandros Frantzis > > --- > > > > patch v1 here: https://patchwork.freedesktop.org/patch/177866/ > > Chang

[PATCH wayland-protocols v3] Add zwp_linux_explicit_synchronization_v1

2018-10-15 Thread Alexandros Frantzis
Signed-off-by: Alexandros Frantzis --- Changes in patch v3: - Reworded implicit/explicit synchronization intro in zwp_surface_synchronization_v1 description. - Removed confusing mention of wl_buffer.release in zwp_surface_synchronization_v1 description. - Clarified which fences are

[PATCH wayland-protocols v2] Add zwp_linux_explicit_synchronization_v1

2018-10-09 Thread Alexandros Frantzis
Signed-off-by: Alexandros Frantzis --- patch v1 here: https://patchwork.freedesktop.org/patch/177866/ Changes since patch v1: - Add NO_SURFACE error for zwp_surface_synchronization_v1 requests. - Remove restriction to destroy a zwp_surface_synchronization_v1 object after the associated

Re: [RFC,wayland-protocols] Add alpha-compositing protocol

2018-09-10 Thread Alexandros Frantzis
On Fri, Sep 07, 2018 at 04:02:24PM +0200, Gary Bisson wrote: > Hi Alexandros, All, > > On Tue, Aug 08, 2017 at 05:24:58PM +0300, Alexandros Frantzis wrote: > > This protocol specifies a set of interfaces used to control the alpha > > compositing and blending of surface co

[PATCH weston v3 6/6] libweston: Implement touch timestamps for input_timestamps_unstable_v1

2018-02-20 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_manager_v1.get_touch_timestamps request to subscribe to timestamp events for wl_touch resources. Ensure that the request handling code can gracefully handle inert touch resources. Signed-off-by: Alexandros Frantzis --- Changes in v3: - In

[PATCH weston v3 5/6] libweston: Implement pointer timestamps for input_timestamps_unstable_v1

2018-02-20 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_manager_v1.get_pointer_timestamps request to subscribe to timestamp events for wl_pointer resources. Ensure that the request handling code can gracefully handle inert pointer resources. Signed-off-by: Alexandros Frantzis --- Changes in v3: - In

[PATCH weston v3 4/6] libweston: Implement keyboard timestamps for input_timestamps_unstable_v1

2018-02-20 Thread Alexandros Frantzis
useful in the implementation of the remaining zwp_input_timestamps_manager_v1 requests. Signed-off-by: Alexandros Frantzis --- Changes in v3: - In keyboard_timestamps_stop_after_client_releases_wl_keyboard test check for changes to keyboard->input_timestamp instead of keybo

Re: [PATCH weston v2 6/6] libweston: Implement touch timestamps for input_timestamps_unstable_v1

2018-02-16 Thread Alexandros Frantzis
On Fri, Feb 16, 2018 at 06:44:19PM +0200, Alexandros Frantzis wrote: > Implement the zwp_input_timestamps_manager_v1.get_touch_timestamps > request to subscribe to timestamp events for wl_touch resources. Ensure > that the request handling code can gracefully handle inert touch &g

[PATCH weston v2 6/6] libweston: Implement touch timestamps for input_timestamps_unstable_v1

2018-02-16 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_manager_v1.get_touch_timestamps request to subscribe to timestamp events for wl_touch resources. Ensure that the request handling code can gracefully handle inert touch resources. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Remove the head of

[PATCH weston v2 5/6] libweston: Implement pointer timestamps for input_timestamps_unstable_v1

2018-02-16 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_manager_v1.get_pointer_timestamps request to subscribe to timestamp events for wl_pointer resources. Ensure that the request handling code can gracefully handle inert pointer resources. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Remove the head of

[PATCH weston v2 3/6] libweston: Introduce input-timestamps support

2018-02-16 Thread Alexandros Frantzis
foundation for timestamp subscriptions for keyboard/pointer/touch to be added cleanly in upcoming commits. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Move unused helper functions to next patch to avoid warnings, keep only zwp_input_timestamps_manager_v1 code in this patch

[PATCH weston v2 4/6] libweston: Implement keyboard timestamps for input_timestamps_unstable_v1

2018-02-16 Thread Alexandros Frantzis
useful in the implementation of the remaining zwp_input_timestamps_manager_v1 requests. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Merge helper functions from v1 3/6 commit in this one to avoid warnings in 3/6 commit. - Remove the head of timestamps_list in

[PATCH weston v2 1/6] shared: Add timespec_eq helper function

2018-02-16 Thread Alexandros Frantzis
Add a helper function to check if two struct timespec values are equal. This helper function will be used in upcoming commits that implement the input_timestamps_unstable_v1 protocol. Signed-off-by: Alexandros Frantzis Reviewed-by: Pekka Paalanen --- Changes in v2: - No changes. shared

[PATCH weston v2 0/6] libweston: Support input_timestamps_unstable_v1

2018-02-16 Thread Alexandros Frantzis
/archives/wayland-devel/2017-December/036320.html Alexandros Frantzis (6): shared: Add timespec_eq helper function tests: Introduce input timestamps helper libweston: Introduce input-timestamps support libweston: Implement keyboard timestamps for input_timestamps_unstable_v1 libweston

[PATCH weston v2 2/6] tests: Introduce input timestamps helper

2018-02-16 Thread Alexandros Frantzis
wayland-protocols, so this commit updates the version dependency in configure.ac accordingly. Signed-off-by: Alexandros Frantzis Reviewed-by: Pekka Paalanen --- Changes in v2: - Update wayland-protocols version dependency to 1.13. Makefile.am | 16 ++-- configure.ac

[PATCH weston v4 3/7] libweston: Make weston_seat release safe

2018-02-15 Thread Alexandros Frantzis
] xdg_toplevel.show_window_menu [FIXED] xdg_toplevel.move [FIXED] xdg_toplevel.resize [FIXED] xdg_popup.grab == xdg_shell_unstable_v5 == [FIXED] xdg_shell.get_xdg_popup [FIXED] xdg_surface.show_window_menu [FIXED] xdg_surface.move [FIXED] xdg_surface.resize Signed-off-by: Alexandros Frantzis

[PATCH weston v3 3/7] libweston: Make weston_seat release safe

2018-02-14 Thread Alexandros Frantzis
] xdg_toplevel.show_window_menu [FIXED] xdg_toplevel.move [FIXED] xdg_toplevel.resize [FIXED] xdg_popup.grab == xdg_shell_unstable_v5 == [FIXED] xdg_shell.get_xdg_popup [FIXED] xdg_surface.show_window_menu [FIXED] xdg_surface.move [FIXED] xdg_surface.resize Signed-off-by: Alexandros Frantzis

[PATCH weston] libweston-desktop/xdg-shell-v5: Drop xdg-shell v5 support

2018-02-13 Thread Alexandros Frantzis
d-off-by: Alexandros Frantzis --- Makefile.am | 6 +- libweston-desktop/internal.h | 3 - libweston-desktop/libweston-desktop.c | 10 - libweston-desktop/xdg-shell-v5.c | 911 -- 4 files changed, 1 insertion(+), 929 dele

[PATCH weston v2 7/7] tests: Add test for seat destruction and creation

2018-02-08 Thread Alexandros Frantzis
Add a test to check that we can destroy and create the test seat. Since after test seat destruction the test client releases any associated input resources, this test also checks that libweston properly handles release requests for inert input resources. Signed-off-by: Alexandros Frantzis

[PATCH weston v2 5/7] tests: Support setting the test client input dynamically

2018-02-08 Thread Alexandros Frantzis
was previously the case. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Add explicit test for seat names. - Don't destroy input objects for non-test seats unconditionally. - Simplify devices handling in seat name handler. tests/devices-test.c | 10 ++

[PATCH weston v2 4/7] tests: Handle removal of seat global in test clients

2018-02-08 Thread Alexandros Frantzis
accordingly. This update will be used by upcoming tests to check that seat removal and re-addition is working properly. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Simplify input_destroy, no need to check for validity of wl_* objects. tests/weston-test-client-helper.c | 83

[PATCH weston v2 2/7] libweston: Make weston_pointer destruction safe

2018-02-08 Thread Alexandros Frantzis
weston_pointer (e.g. in init_pointer_constraint), so there is no need for additional updates there. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Removed NULL check before calling init_pointer_constraint, since init_pointer_constraint now handles this case. - Handle NULL weston_pointer in

[PATCH weston v2 0/7] libweston: Make input object destruction safe

2018-02-08 Thread Alexandros Frantzis
ed by this race. More detailed changes introduced in v2 are provided in each patch. Alexandros Frantzis (7): libweston: Support NULL weston_pointer in init_pointer_constraint libweston: Make weston_pointer destruction safe libweston: Make weston_seat release safe tests: Handle removal of

[PATCH weston v2 1/7] libweston: Support NULL weston_pointer in init_pointer_constraint

2018-02-08 Thread Alexandros Frantzis
: Alexandros Frantzis --- Changes in v2: - New patch libweston/input.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/libweston/input.c b/libweston/input.c index 96cded47..390698c7 100644 --- a/libweston/input.c +++ b/libweston/input.c @@ -3572,7 +3572,7

[PATCH weston v2 6/7] tests: Run devices tests using the test desktop shell

2018-02-08 Thread Alexandros Frantzis
afely add tests which add/remove such globals in upcoming commits. Signed-off-by: Alexandros Frantzis --- Changes in v2: - New in v2. tests/devices-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/devices-test.c b/tests/devices-test.c index ce1cea3b..a6ec6eaf 100644 --- a/

[PATCH weston v2 3/7] libweston: Make weston_seat release safe

2018-02-08 Thread Alexandros Frantzis
] xdg_toplevel.show_window_menu [FIXED] xdg_toplevel.move [FIXED] xdg_toplevel.resize [FIXED] xdg_popup.grab == xdg_shell_unstable_v5 == [FIXED] xdg_shell.get_xdg_popup [FIXED] xdg_surface.show_window_menu [FIXED] xdg_surface.move [FIXED] xdg_surface.resize Signed-off-by: Alexandros Frantzis

Re: [PATCH weston 5/8] tests: Support setting the test client input dynamically

2018-02-01 Thread Alexandros Frantzis
On Thu, Feb 01, 2018 at 02:09:32PM +0200, Pekka Paalanen wrote: > On Thu, 1 Feb 2018 13:30:25 +0200 > Alexandros Frantzis wrote: > > > On Thu, Feb 01, 2018 at 12:20:44PM +0200, Pekka Paalanen wrote: > > > On Fri, 26 Jan 2018 18:47:59 +0200 > > > Alexandros Fran

Re: [PATCH weston 5/8] tests: Support setting the test client input dynamically

2018-02-01 Thread Alexandros Frantzis
On Thu, Feb 01, 2018 at 12:20:44PM +0200, Pekka Paalanen wrote: > On Fri, 26 Jan 2018 18:47:59 +0200 > Alexandros Frantzis wrote: > > > The current test client code waits for all wl_seat globals to arrive > > before checking them and deciding which one is the test seat glob

Re: [PATCH weston 8/8] tests: Add test for seat destruction and creation

2018-02-01 Thread Alexandros Frantzis
On Thu, Feb 01, 2018 at 12:46:13PM +0200, Pekka Paalanen wrote: > On Fri, 26 Jan 2018 18:48:02 +0200 > Alexandros Frantzis wrote: > > > Add a test to check that we can destroy and create the test seat. Since > > after test seat destruction the test client releases any

Re: [PATCH weston 5/8] tests: Support setting the test client input dynamically

2018-02-01 Thread Alexandros Frantzis
On Thu, Feb 01, 2018 at 12:00:44PM +0200, Pekka Paalanen wrote: > On Wed, 31 Jan 2018 17:14:49 +0200 > Alexandros Frantzis wrote: > > > On Wed, Jan 31, 2018 at 04:25:15PM +0200, Pekka Paalanen wrote: > > > On Fri, 26 Jan 2018 18:47:59 +0200 > > > Alexandros Fran

Re: [PATCH weston 5/8] tests: Support setting the test client input dynamically

2018-01-31 Thread Alexandros Frantzis
On Wed, Jan 31, 2018 at 04:25:15PM +0200, Pekka Paalanen wrote: > On Fri, 26 Jan 2018 18:47:59 +0200 > Alexandros Frantzis wrote: > > > The current test client code waits for all wl_seat globals to arrive > > before checking them and deciding which one is the test seat glob

Re: [PATCH weston 4/8] libweston: Make weston_seat release safe

2018-01-31 Thread Alexandros Frantzis
On Wed, Jan 31, 2018 at 03:21:07PM +0200, Pekka Paalanen wrote: > On Fri, 26 Jan 2018 18:47:58 +0200 > Alexandros Frantzis wrote: > > > Ensure the server can safely handle client requests for wl_seat resource > > that have become inert due to weston_seat object r

Re: [PATCH weston 6/6] libweston: Implement touch timestamps for input_timestamps_unstable_v1

2018-01-26 Thread Alexandros Frantzis
On Fri, Jan 19, 2018 at 12:18:38PM +0200, Pekka Paalanen wrote: > On Wed, 20 Dec 2017 16:18:01 +0200 > Alexandros Frantzis wrote: > > > Implement the zwp_input_timestamps_v1.get_touch_timestamps request to > > subscribe to timestamp events for wl_touch resources. &

[PATCH weston 6/8] tests: Support weston_test request for adding a test seat

2018-01-26 Thread Alexandros Frantzis
ry to create multiple test seats or try to remove an already removed test seat. Signed-off-by: Alexandros Frantzis --- tests/weston-test.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/tests/weston-test.c b/tests/weston-test.c index 80b

[PATCH weston 8/8] tests: Add test for seat destruction and creation

2018-01-26 Thread Alexandros Frantzis
d-off-by: Alexandros Frantzis --- Makefile.am | 5 + tests/devices-seat-test.c | 53 +++ 2 files changed, 58 insertions(+) create mode 100644 tests/devices-seat-test.c diff --git a/Makefile.am b/Makefile.am index e224d606..f0370973 1

[PATCH weston 7/8] tests: Handle removal of seat global in test clients

2018-01-26 Thread Alexandros Frantzis
accordingly. This update will be used by upcoming tests to check that seat removal and re-addition is working properly. Signed-off-by: Alexandros Frantzis --- tests/weston-test-client-helper.c | 71 +-- tests/weston-test-client-helper.h | 1 + 2 files changed, 70

[PATCH weston 0/8] libweston: Make input object destruction safe

2018-01-26 Thread Alexandros Frantzis
but I will investigate further and hopefully we can remove this workaround. 2. Even without some of the fixes in the patches 1-4, the test may seem to pass. However, running with a memory debugger reveals a different story, since without the fixes we encounter various memory errors. Alexandros F

[PATCH weston 5/8] tests: Support setting the test client input dynamically

2018-01-26 Thread Alexandros Frantzis
oming commits. This commit changes the code to check for the test seat and set up the input object while handling the wl_seat information events. Signed-off-by: Alexandros Frantzis --- tests/weston-test-client-helper.c | 78 ++- tests/weston-test-client-hel

[PATCH weston 1/8] libweston: Make weston_pointer destruction safe

2018-01-26 Thread Alexandros Frantzis
become inert. The clean-up involves, among other things, unsetting the destroyed weston_pointer object from the user data of pointer resources, and handling this NULL user data case where required. Signed-off-by: Alexandros Frantzis --- libweston/input.c | 41

[PATCH weston 3/8] libweston: Make weston_touch destruction safe

2018-01-26 Thread Alexandros Frantzis
other code can check whether the resource is inert. Signed-off-by: Alexandros Frantzis --- libweston/input.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/libweston/input.c b/libweston/input.c index 96cabf25..48bcc55c 100644 --- a/libweston/input.c +++ b

[PATCH weston 4/8] libweston: Make weston_seat release safe

2018-01-26 Thread Alexandros Frantzis
this NULL user data case where required. Signed-off-by: Alexandros Frantzis --- libweston/input.c | 45 +++-- 1 file changed, 35 insertions(+), 10 deletions(-) diff --git a/libweston/input.c b/libweston/input.c index 48bcc55c..e4daa56b 100644 --- a

[PATCH weston 2/8] libweston: Make weston_keyboard destruction safe

2018-01-26 Thread Alexandros Frantzis
destruction, so other code can check whether the resource is inert. Signed-off-by: Alexandros Frantzis --- libweston/input.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libweston/input.c b/libweston/input.c index 01f0d568..96cabf25 100644 --- a

Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

2017-12-20 Thread Alexandros Frantzis
On Tue, Dec 19, 2017 at 01:06:11PM +0200, Alexandros Frantzis wrote: > On Tue, Dec 19, 2017 at 10:15:06AM +0200, Pekka Paalanen wrote: > > On Mon, 18 Dec 2017 14:55:00 +0200 > > Alexandros Frantzis wrote: > > > > > wl_pointer, wl_keyboard and wl_touch

[PATCH weston 4/6] libweston: Implement keyboard timestamps for input_timestamps_unstable_v1

2017-12-20 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_v1.get_keyboard_timestamps request to subscribe to timestamp events for wl_keyboard resources. Signed-off-by: Alexandros Frantzis --- libweston/compositor.h | 2 ++ libweston/input.c | 38 +++--- tests/keyboard-test.c

[PATCH weston 6/6] libweston: Implement touch timestamps for input_timestamps_unstable_v1

2017-12-20 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_v1.get_touch_timestamps request to subscribe to timestamp events for wl_touch resources. Signed-off-by: Alexandros Frantzis --- libweston/compositor.h | 2 ++ libweston/input.c | 53 +++--- tests/touch-test.c

[PATCH weston 2/6] tests: Introduce input timestamps helper

2017-12-20 Thread Alexandros Frantzis
Introduce helper test code to implement the client side of the input_timestamps_unstable_v1 protocol. This helper will be used in upcoming commits to test the server side implementation of the protocol in libweston. Signed-off-by: Alexandros Frantzis --- Makefile.am | 16

[PATCH weston 1/6] shared: Add timespec_eq helper function

2017-12-20 Thread Alexandros Frantzis
Add a helper function to check if two struct timespec values are equal. This helper function will be used in upcoming commits that implement the input_timestamps_unstable_v1 protocol. Signed-off-by: Alexandros Frantzis --- shared/timespec-util.h | 13 + tests/timespec-test.c | 12

[PATCH weston 5/6] libweston: Implement pointer timestamps for input_timestamps_unstable_v1

2017-12-20 Thread Alexandros Frantzis
Implement the zwp_input_timestamps_v1.get_pointer_timestamps request to subscribe to timestamp events for wl_pointer resources. Signed-off-by: Alexandros Frantzis --- libweston/compositor.h | 2 ++ libweston/input.c | 50 +- tests/pointer-test.c | 66

[PATCH weston 3/6] libweston: Introduce input-timestamps support code

2017-12-20 Thread Alexandros Frantzis
-off-by: Alexandros Frantzis --- Makefile.am | 4 +- libweston/input.c | 115 ++ 2 files changed, 118 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 0b616c11..823e9845 100644 --- a/Makefile.am +++ b/Makefile.am

[PATCH weston 0/6] libweston: Support input_timestamps_unstable_v1

2017-12-20 Thread Alexandros Frantzis
://lists.freedesktop.org/archives/wayland-devel/2017-December/036320.html Alexandros Frantzis (6): shared: Add timespec_eq helper function tests: Introduce input timestamps helper libweston: Introduce input-timestamps support libweston: Implement keyboard timestamps for

Re: [PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

2017-12-19 Thread Alexandros Frantzis
On Tue, Dec 19, 2017 at 10:15:06AM +0200, Pekka Paalanen wrote: > On Mon, 18 Dec 2017 14:55:00 +0200 > Alexandros Frantzis wrote: > > > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit > > timestamp with millisecond resolution. In some cases, notably lat

[PATCH wayland-protocols v2] unstable: Add input-timestamps protocol

2017-12-18 Thread Alexandros Frantzis
eceive and associate it with the next supported input event that arrives. Signed-off-by: Alexandros Frantzis Reviewed-by: Pekka Paalanen Acked-by: Jonas Ã…dahl --- Changes in v2: - Add '...carrying a timestamp...' to better describe the set of subsequent input events in the timesta

Re: [PATCH wayland-protocols] unstable: Add input-timestamps protocol

2017-12-18 Thread Alexandros Frantzis
On Mon, Dec 18, 2017 at 12:50:30PM +0200, Pekka Paalanen wrote: > On Wed, 13 Dec 2017 16:48:28 +0200 > Alexandros Frantzis wrote: > > > On Mon, Dec 11, 2017 at 03:25:28PM +0200, Pekka Paalanen wrote: > > > On Tue, 5 Dec 2017 18:07:02 +0200 > >

Re: [PATCH weston v2 4/6] tests: Add test for pointer axis events

2017-12-18 Thread Alexandros Frantzis
On Mon, Dec 18, 2017 at 11:53:24AM +0200, Pekka Paalanen wrote: > On Wed, 13 Dec 2017 13:27:56 +0200 > Alexandros Frantzis wrote: > > > Add test to verify the server correctly emits pointer axis events. This > > requires updating the weston-test protocol with a new request

[PATCH weston v3] tests: Add test for pointer axis events

2017-12-18 Thread Alexandros Frantzis
Add test to verify the server correctly emits pointer axis events. This requires updating the weston-test protocol with a new request for pointer axis events. Signed-off-by: Alexandros Frantzis --- Changes in v3: - Use uint32_t, not double, for event time variables. Changes in v2: - Add

Re: [PATCH wayland-protocols] unstable: Add input-timestamps protocol

2017-12-13 Thread Alexandros Frantzis
On Mon, Dec 11, 2017 at 03:25:28PM +0200, Pekka Paalanen wrote: > On Tue, 5 Dec 2017 18:07:02 +0200 > Alexandros Frantzis wrote: > > > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit > > timestamp with millisecond resolution. In some cases, notably lat

[PATCH weston v2 6/6] tests: Add test for touch event timestamps

2017-12-13 Thread Alexandros Frantzis
Add test to verify that the server correctly sets the timestamps of touch events. This requires updating the weston-test protocol with a new request for touch events. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Add unit suffix "msec" to variables that hold event time. M

[PATCH weston v2 5/6] tests: Add test for keyboard key event timestamps

2017-12-13 Thread Alexandros Frantzis
performs a roundtrip internally. To account for this, the client_roundtrip() function is now directly called in the loop only when it is still required, i.e., when deactivating the surface. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Add unit suffix "msec" to variables

[PATCH weston v2 4/6] tests: Add test for pointer axis events

2017-12-13 Thread Alexandros Frantzis
Add test to verify the server correctly emits pointer axis events. This requires updating the weston-test protocol with a new request for pointer axis events. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Add unit suffix "msec" to variables that hold event time. proto

[PATCH weston v2 3/6] tests: Add checks for pointer motion and button event timestamps

2017-12-13 Thread Alexandros Frantzis
Enhance the existing pointer motion and button event tests to additionally verify the event timestamps. This requires updating the weston-test protocol to support passing motion and button event timestamps. Signed-off-by: Alexandros Frantzis --- Changes in v2: - Add unit suffix "mse

[PATCH weston v2 0/6] tests: Add input event timestamp tests

2017-12-13 Thread Alexandros Frantzis
timespec functions already produce normalized representations. We can reintroduce it if required, e.g., if we need to normalize timespecs from untrusted sources. Patch-specific changes are listed in each individual patch. Alexandros Frantzis (6): shared: Add timespec_from_proto helper function

[PATCH weston v2 1/6] shared: Add timespec_from_proto helper function

2017-12-13 Thread Alexandros Frantzis
Add helper function to convert tv_sec_hi, tv_sec_lo, tv_nsec triplets, used for sending high-resolution timestamp data over the wayland protocol, to struct timespec values. Replace existing conversion code with the helper function. Signed-off-by: Alexandros Frantzis --- Changes in v2: - New

[PATCH weston v2 2/6] shared: Add timespec_to_proto helper function

2017-12-13 Thread Alexandros Frantzis
Add helper function to convert from struct timespec values to tv_sec_hi, tv_sec_lo, tv_nsec triplets used for sending high-resolution timestamp data over the wayland protocol. Replace existing conversion code with the helper function. Signed-off-by: Alexandros Frantzis --- Changes in v2: - New

Re: [PATCH weston 2/8] shared: Add helpers to convert between protocol data and timespec

2017-12-12 Thread Alexandros Frantzis
On Tue, Dec 12, 2017 at 03:09:56PM +0200, Pekka Paalanen wrote: > On Tue, 12 Dec 2017 14:43:11 +0200 > Alexandros Frantzis wrote: > > > On Tue, Dec 12, 2017 at 12:09:59PM +0200, Pekka Paalanen wrote: > > > On Mon, 4 Dec 2017 15:34:02 +0200 > > > Alexandros Fran

Re: [PATCH weston 5/8] tests: Add checks for pointer motion and button event timestamps

2017-12-12 Thread Alexandros Frantzis
On Tue, Dec 12, 2017 at 02:13:26PM +0200, Pekka Paalanen wrote: > On Mon, 4 Dec 2017 15:34:05 +0200 > Alexandros Frantzis wrote: > > > Enhance the existing pointer motion and button event tests to > > additionally verify the event timestamps. This requires updating the >

Re: [PATCH weston 1/8] shared: Add timespec_normalize helper

2017-12-12 Thread Alexandros Frantzis
On Tue, Dec 12, 2017 at 12:55:27PM +0200, Pekka Paalanen wrote: > On Tue, 12 Dec 2017 12:36:39 +0200 > Alexandros Frantzis wrote: > > > On Tue, Dec 12, 2017 at 11:50:49AM +0200, Pekka Paalanen wrote: > > > On Mon, 4 Dec 2017 15:34:01 +0200 > > > Alexandros Fran

Re: [PATCH weston 2/8] shared: Add helpers to convert between protocol data and timespec

2017-12-12 Thread Alexandros Frantzis
On Tue, Dec 12, 2017 at 12:09:59PM +0200, Pekka Paalanen wrote: > On Mon, 4 Dec 2017 15:34:02 +0200 > Alexandros Frantzis wrote: > > > Add helpers to safely convert between struct timespec values and > > tv_sec_hi, tv_sec_lo, tv_nsec triplets used for sending high-resoluti

Re: [PATCH weston 1/8] shared: Add timespec_normalize helper

2017-12-12 Thread Alexandros Frantzis
On Tue, Dec 12, 2017 at 11:50:49AM +0200, Pekka Paalanen wrote: > On Mon, 4 Dec 2017 15:34:01 +0200 > Alexandros Frantzis wrote: > > > Add a helper function to normalize struct timespec values so that the > > nanoseconds part is less than 1 second and has the same sign as

Re: [PATCH wayland-protocols] unstable: Add input-timestamps protocol

2017-12-05 Thread Alexandros Frantzis
On Tue, Dec 05, 2017 at 06:07:02PM +0200, Alexandros Frantzis wrote: > wl_pointer, wl_keyboard and wl_touch events currently use a 32-bit > timestamp with millisecond resolution. In some cases, notably latency > measurements, this resolution is too coarse to be useful. > > This pr

[PATCH wayland-protocols] unstable: Add input-timestamps protocol

2017-12-05 Thread Alexandros Frantzis
eceive and associate it with the next supported input event that arrives. Signed-off-by: Alexandros Frantzis --- Makefile.am| 1 + unstable/input-timestamps/README | 4 + .../input-timestamps-unstable-v1.xml

[PATCH weston 8/8] tests: Add test for touch event timestamps

2017-12-04 Thread Alexandros Frantzis
Add test to verify that the server correctly sets the timestamps of touch events. This requires updating the weston-test protocol with a new request for touch events. Signed-off-by: Alexandros Frantzis --- Makefile.am | 7 +++- protocol/weston-test.xml | 9

[PATCH weston 7/8] tests: Add test for keyboard key event timestamps

2017-12-04 Thread Alexandros Frantzis
Add test to verify that the server correctly sets the timestamps of keyboard key events. This requires updating the weston-test protocol to support passing key event timestamps. Signed-off-by: Alexandros Frantzis --- protocol/weston-test.xml | 3 ++ tests/keyboard-test.c

[PATCH weston 6/8] tests: Add test for pointer axis events

2017-12-04 Thread Alexandros Frantzis
Add test to verify the server correctly emits pointer axis events. This requires updating the weston-test protocol with a new request for pointer axis events. Signed-off-by: Alexandros Frantzis --- protocol/weston-test.xml | 7 +++ tests/pointer-test.c | 28

  1   2   >