On Fri, Nov 09, 2018 at 12:48:09PM +0200, Pekka Paalanen wrote: > On Fri, 9 Nov 2018 09:46:36 +0200 > Alexandros Frantzis <[email protected]> wrote: > > > Signed-off-by: Alexandros Frantzis <[email protected]> > > Hi Alf,
Hi Pekka, thanks for the review! > could you come up with some rationale to put in the commit message on > why this extension is being added? > > I can add that while pushing upstream, if there are no other changes > coming. How about: This protocol enables explicit synchronization of asynchronous graphics operations on buffers on a per-commit basis. Support is currently limited to dmabuf buffers and dma_fence fence FDs. Explicit synchronization provides a more versatile notification mechanism for buffer readiness and availability, and can be used to improve efficiency by integrating with related functionality in display and graphics APIs. Finally, the per-commit nature of the release events provided by this protocol offer a solution to a deficiency of the wl_buffer.release event (see https://gitlab.freedesktop.org/wayland/wayland/issues/46). > Reviewed-by: Pekka Paalanen <[email protected]> > > You have ensured that the C files generated from this revision build > fine in Weston, right? Yes, I have been working locally with this revision in Weston, and everything builds and runs fine. Thanks, Alexandros _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
