Re: [PATCH libinput 00/12] button-scrolling fixes

2017-02-20 Thread Hans de Goede
Hi, On 20-02-17 21:53, Peter Hutterer wrote: The core bits here are 05/12 and 11/12, the rest is restructuring and various fixes to enable those two. 05/12 enables button-scrolling on the left/right mouse button when middle button emulation is also active. This currently works but generates a

[ANNOUNCE] libinput 1.6.2

2017-02-20 Thread Peter Hutterer
libinput 1.6.2 is now available. Nothing too exciting. The top middle button on the Lenovo *40 series touchpad was extended by 4mm to match the markings better. The Apple onebutton touchpad (yes, they are still used in the wild, apparently) default to clickfinger behavior. A user-visible change: l

Re: Student project

2017-02-20 Thread Sergi Granell
Hi, exactly, helping to get Daniel's atomic modesetting patches landed is my first priority. Maybe it would be a good idea to write some kind of Weston client demo that makes extensive use of subsurfarces in some way, in order to make Weston use and change plane configurations in atomic commits to

[PATCH libinput 09/12] test: add tests for middle button + button scrolling on BTN_LEFT

2017-02-20 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- test/test-pointer.c | 130 1 file changed, 130 insertions(+) diff --git a/test/test-pointer.c b/test/test-pointer.c index 8929a0d..f6dae75 100644 --- a/test/test-pointer.c +++ b/test/test-pointer.c @@ -1903,6

[PATCH libinput 12/12] evdev: don't provide button scrolling on absolute pointer devices

2017-02-20 Thread Peter Hutterer
This may be a feature for the future but for now be honest and don't claim that button-based scrolling is available, it's not hooked up in the absolute code path. https://bugs.freedesktop.org/show_bug.cgi?id=99865 Signed-off-by: Peter Hutterer --- src/evdev.c | 4 +++- test/test-pointer

[PATCH libinput 11/12] evdev: add "READY" state to button scrolling

2017-02-20 Thread Peter Hutterer
Before, our states were idle, button down and scrolling. This adds a state where the button is down and the timeout has expired (i.e. we're ready to send scroll events) but we haven't actually sent any events anymore. If the button is released in this state, we generate a normal click event. http

[PATCH libinput 10/12] evdev: convert button scrolling into a state machine

2017-02-20 Thread Peter Hutterer
No functional changes, preparation work for adding another state. Signed-off-by: Peter Hutterer --- src/evdev.c | 49 +++-- src/evdev.h | 9 +++-- 2 files changed, 38 insertions(+), 20 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index bf3

[PATCH libinput 08/12] evdev: add state debugging to button scrolling

2017-02-20 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/evdev.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 1af29a4..bf35acb 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -250,13 +250,19 @@ evdev_button_scroll_button(struct evdev_device *device

[PATCH libinput 06/12] evdev: add quirk for Logitech Marble Mouse

2017-02-20 Thread Peter Hutterer
Device needs BTN_MIDDLE disabled, this way middle button emulation is present by default. Signed-off-by: Peter Hutterer --- src/evdev.c| 5 + src/evdev.h| 1 + test/test-device.c | 13 + test/test-pointer.c

[PATCH libinput 07/12] evdev: rename define for button scroll timeout

2017-02-20 Thread Peter Hutterer
This is merely 'button scrolling' now, only the original implementation was middle button only. And to avoid confusing with the middle button emulation, drop "MIDDLE" from the define. Signed-off-by: Peter Hutterer --- src/evdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH libinput 05/12] evdev: allow button scrolling on the L/R button with middle emulation active

2017-02-20 Thread Peter Hutterer
This worked before, but triggered a negative timer bug. When one of the physical L/R buttons is pressed with middle button emulation enabled, the flow is: 1) phys left button down 2) middle button state machine discards events, sets timer 3) timer expires or button is released 4) middle button stat

[PATCH libinput 02/12] test: fix middle button defaults test

2017-02-20 Thread Peter Hutterer
This failed on devices without a middle button, we just didn't have a test device to trigger this. Signed-off-by: Peter Hutterer --- test/test-pointer.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/test/test-pointer.c b/test/test-pointer.c index 986ec8b..ab

[PATCH libinput 03/12] test: skip two tests when middle button is missing

2017-02-20 Thread Peter Hutterer
And disable middle button emulation for this test, it would mess with the test results. Signed-off-by: Peter Hutterer --- test/test-pointer.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/test-pointer.c b/test/test-pointer.c index abc8a11..d4d2607 100644 --- a/test/test-po

[PATCH libinput 04/12] test: fix the pointer scroll-defaults test

2017-02-20 Thread Peter Hutterer
The button-scroll by default behavior is only true on devices with a middle button. Signed-off-by: Peter Hutterer --- test/test-pointer.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/test/test-pointer.c b/test/test-pointer.c index d4d2607..27978a9

[PATCH libinput 00/12] button-scrolling fixes

2017-02-20 Thread Peter Hutterer
The core bits here are 05/12 and 11/12, the rest is restructuring and various fixes to enable those two. 05/12 enables button-scrolling on the left/right mouse button when middle button emulation is also active. This currently works but generates a log_bug_libinput() because of a negative timer o

[PATCH libinput 01/12] test: check the libinput device for BTN_MIDDLE, not the libevdev device

2017-02-20 Thread Peter Hutterer
We don't have the same libevdev context that libinput has so if libinput disables/enables event codes we don't see that and may get unexpected behavior in the test. Signed-off-by: Peter Hutterer --- test/test-pointer.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-)

Re: [PATCH weston] clients: Fix build without Cairo/GLES2

2017-02-20 Thread Emil Velikov
On 16 February 2017 at 21:52, Daniel Stone wrote: > If we're building with EGL support generally, but without Cairo/GLESv2, > building the clients fail, because window.c defines the EGL native > types, however platform.h also brings these in. > > Signed-off-by: Daniel Stone > Cc: Emil Velikov >

Re: [PATCH weston 1/3] tests: add a create_test_surface function

2017-02-20 Thread Pekka Paalanen
On Fri, 3 Feb 2017 16:10:37 +0100 Emilio Pozuelo Monfort wrote: > This doesn't attach a buffer to the surface. This is needed for the > next commit, where we have a test case with a surface that doesn't > have a buffer attached. > > Signed-off-by: Emilio Pozuelo Monfort > --- > tests/weston-t

Re: weston-simple-egl fullscreen broken?

2017-02-20 Thread Pekka Paalanen
On Mon, 6 Feb 2017 16:56:03 + Fabien DESSENNE wrote: > Hi > > I remember I used to get < weston-simple-egl -f > working fine. > But it does not work anymore : nothing is displayed. From the logs I > can see (among others) zxdg_toplevel_v6.configure and > wl_surface.commit Testing with anothe

[PATCH weston] clients/simple-egl: add -d option

2017-02-20 Thread Pekka Paalanen
From: Eero Tamminen This emulates extra drawing work by usleep(). This is an enhancement to reproduce the problem in the bug report. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=98833 Signed-off-by: Pekka Paalanen --- clients/simple-egl.c | 10 -- 1 file changed, 8 insertions(+),

Re: [PATCH weston] clients: Fix build without Cairo/GLES2

2017-02-20 Thread Pekka Paalanen
On Mon, 20 Feb 2017 13:58:40 +0200 Pekka Paalanen wrote: > And a second time with the correct email address for Bryce, sorry. > > Daniel, looks like there is typo in the commit with the email address. > > > Thanks, > pq > > On Mon, 20 Feb 2017 13:50:35 +0200 > Pekka Paalanen wrote: > > > On

[PATCH weston] clients/weston-info: print unknown formats better

2017-02-20 Thread Pekka Paalanen
From: Pekka Paalanen Don't just dump the raw 32-bit values, try to interpret it as a DRM fourcc too. This prints properly the formats YUYV, NV12 and YU12 supported by Weston. Signed-off-by: Pekka Paalanen --- clients/weston-info.c | 29 - 1 file changed, 28 inserti

Re: [PATCH weston 2/2] screen-share: Use wl_list_for_each_safe on destroy

2017-02-20 Thread Pekka Paalanen
On Thu, 16 Feb 2017 19:59:51 + Daniel Stone wrote: > Destroying the shared seat removes the link from so->seat_list. > > Signed-off-by: Daniel Stone > --- > compositor/screen-share.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/compositor/screen-share.c b/c

Re: [PATCH weston] clients: Fix build without Cairo/GLES2

2017-02-20 Thread Pekka Paalanen
And a second time with the correct email address for Bryce, sorry. Daniel, looks like there is typo in the commit with the email address. Thanks, pq On Mon, 20 Feb 2017 13:50:35 +0200 Pekka Paalanen wrote: > On Thu, 16 Feb 2017 21:52:23 + > Daniel Stone wrote: > > > If we're building wi

Re: [PATCH weston] clients: Fix build without Cairo/GLES2

2017-02-20 Thread Pekka Paalanen
On Thu, 16 Feb 2017 21:52:23 + Daniel Stone wrote: > If we're building with EGL support generally, but without Cairo/GLESv2, > building the clients fail, because window.c defines the EGL native > types, however platform.h also brings these in. > > Signed-off-by: Daniel Stone > Cc: Emil Veli

Re: Student project

2017-02-20 Thread Pekka Paalanen
On Fri, 17 Feb 2017 19:06:09 +0100 Sergi Granell wrote: > Hi everyone! > > My name is Sergi Granell and I am a last year student at the > Facultat d'Informàtica de Barcelona in the Universitat Politècnica de > Catalunya [1]. > As this is my last semester there, I have to do my end of degree > pr

Re: [PATCH weston 1/7] timespec: Add timespec_add_nsec helper

2017-02-20 Thread Pekka Paalanen
On Fri, 17 Feb 2017 15:56:47 + Daniel Stone wrote: > Hi, > > On 14 February 2017 at 14:09, Pekka Paalanen wrote: > > On Tue, 14 Feb 2017 13:18:01 + > > Daniel Stone wrote: > >> +ZUC_TEST(timespec_test, timespec_add_nsec) > >> +{ > >> + struct timespec a, r; > > > > An array and