[ANNOUNCE] libinput 1.3.901

2016-07-11 Thread Peter Hutterer
The first RC for libinput 1.4 is now available. The main feature merged in this cycle is mode support for graphics tablets. On many tablets, buttons, rings and strips can be used in virtualised modes, reflected by physical LEDs on the touchpad. For example, a ring may send scroll events when in mo

Re: Weston versioning (Re: [PATCH weston 6/6] libweston: do not use weston version in libweston.pc)

2016-07-11 Thread Jan Engelhardt
On Monday 2016-07-11 16:44, Emil Velikov wrote: >> Without pkgconfig supporting some new alias tag (hint, hint) to cover >> such a case, >No idea what such a "alias tag" is supposed to do/look like. Do you >have examples ? Proposed concept would be to make pkgconfig recognize a new Alias directiv

[PATCH weston] config-parser: Catch negative numbers assigned to unsigned config values

2016-07-11 Thread Bryce Harrington
strtoul() has a side effect that when given a string representing a negative number, it returns a negated version as the value, and does not flag an error. IOW, strtoul("-42", &val) sets val to 42. This could potentially result in unintended surprise behaviors, such as if one were to inadvertantl

[PATCH weston] rdp: Check for non-digits and errno in strtol call

2016-07-11 Thread Bryce Harrington
Improve error checking for situations like RDP_FD=42foo, or where the provided number is out of range. Suggestion by Yong Bakos. Signed-off-by: Bryce Harrington --- libweston/compositor-rdp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libweston/compositor-rdp.c b/libw

Re: [PATCH weston] config-parser: Improve error checks for strtol/strtoul calls

2016-07-11 Thread Peter Hutterer
On Mon, Jul 11, 2016 at 01:19:54PM -0700, Bryce Harrington wrote: > On Mon, Jul 11, 2016 at 09:39:00AM -0700, Bill Spitzak wrote: > > On Sun, Jul 10, 2016 at 4:28 PM, Peter Hutterer > > wrote: > > > > > On Thu, Jul 07, 2016 at 02:24:39PM -0700, Bryce Harrington wrote: > > > > On Thu, Jul 07, 2016

Re: [PATCH weston] config-parser: Improve error checks for strtol/strtoul calls

2016-07-11 Thread Peter Hutterer
On Mon, Jul 11, 2016 at 09:39:00AM -0700, Bill Spitzak wrote: > On Sun, Jul 10, 2016 at 4:28 PM, Peter Hutterer > wrote: > > > On Thu, Jul 07, 2016 at 02:24:39PM -0700, Bryce Harrington wrote: > > > On Thu, Jul 07, 2016 at 02:08:28PM -0700, Bryce Harrington wrote: > > > > Check errno, which is se

Re: [PATCH weston v2 8/8] terminal: Silence maybe-uninitialized warning

2016-07-11 Thread Emil Velikov
On 10 July 2016 at 10:00, Quentin Glidic wrote: > From: Quentin Glidic > > clients/terminal.c: In function 'redraw_handler': > clients/terminal.c:213:28: warning: 'machine.unicode' may be used > uninitialized in this function [-Wmaybe-uninitialized] > struct utf8_state_machine machine; >

Re: [PATCH weston] gl-renderer: Silence silly warning

2016-07-11 Thread Emil Velikov
On 4 July 2016 at 15:00, Quentin Glidic wrote: > From: Quentin Glidic > > Signed-off-by: Quentin Glidic > --- > libweston/gl-renderer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libweston/gl-renderer.c b/libweston/gl-renderer.c > index 28c0b50..73b6ccc 100644 > --

Re: Weston versioning (Re: [PATCH weston 6/6] libweston: do not use weston version in libweston.pc)

2016-07-11 Thread Emil Velikov
On 11 July 2016 at 17:58, Jan Engelhardt wrote: > > On Monday 2016-07-11 16:44, Emil Velikov wrote: http://ometer.com/parallel.html. I would strongly recommend giving it a look. >>> >>> I read it now, and I do not buy it - at least not for 2016 standards. >>> According to the page, it was

Re: [PATCH] scanner: Improve documentation for strtouint()

2016-07-11 Thread Bryce Harrington
On Fri, Jul 08, 2016 at 07:38:13PM -0700, Yong Bakos wrote: > On Jul 8, 2016, at 4:51 PM, Bryce Harrington wrote: > > > > From: Bryce Harrington > > > > Signed-off-by: Bryce Harrington > > Signed-off-by: Bryce Harrington > > A definite improvement. However, a couple questions inline below. >

Re: [PATCH] tests: Require base 10 for the string specifying the number of open fd's

2016-07-11 Thread Bryce Harrington
On Fri, Jul 08, 2016 at 07:39:33PM -0700, Yong Bakos wrote: > On Jul 8, 2016, at 7:00 PM, Bryce Harrington wrote: > > > > The third arg to strtol() specifies the base to assume for the number. > > When 0 is passed, as is currently done in wayland-client.c, hexadecimal > > and octal numbers are pe

Re: [PATCH weston] rdp: Check for non-numeric value in RDP_FD env var

2016-07-11 Thread Bryce Harrington
On Fri, Jul 08, 2016 at 08:11:26PM -0700, Yong Bakos wrote: > On Jul 8, 2016, at 6:54 PM, Bryce Harrington wrote: > > > > strtoul(nptr, endptr, ...) will set *endptr to nptr in the case of where > > no digits were read from the string, and return 0. Running with > > RDP_FD=foo would thus result

Re: [PATCH weston] config-parser: Improve error checks for strtol/strtoul calls

2016-07-11 Thread Bryce Harrington
On Mon, Jul 11, 2016 at 09:28:16AM +1000, Peter Hutterer wrote: > On Thu, Jul 07, 2016 at 02:24:39PM -0700, Bryce Harrington wrote: > > On Thu, Jul 07, 2016 at 02:08:28PM -0700, Bryce Harrington wrote: > > > Check errno, which is set of over/underflow, out of range, etc. Also > > > check for empty

Re: [PATCH weston] Remove a wrong closing “extern "C"” in shared/xalloc.c

2016-07-11 Thread Bryce Harrington
On Mon, Jul 11, 2016 at 05:31:59PM +0100, Emmanuel Gil Peyrot wrote: > Signed-off-by: Emmanuel Gil Peyrot Thanks, pushed: cbc0537..7fc000c master -> master > --- > shared/xalloc.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/shared/xalloc.c b/shared/xalloc.c > index 4bf8a3e

Re: [PATCH weston] Remove a wrong closing “extern "C"” in shared/xalloc.c

2016-07-11 Thread Bryce Harrington
On Mon, Jul 11, 2016 at 05:31:59PM +0100, Emmanuel Gil Peyrot wrote: > Signed-off-by: Emmanuel Gil Peyrot Reviewed-by: Bryce Harrington > --- > shared/xalloc.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/shared/xalloc.c b/shared/xalloc.c > index 4bf8a3e..9bf5245 100644 > ---

Re: [PATCH weston] config-parser: Improve error checks for strtol/strtoul calls

2016-07-11 Thread Bryce Harrington
On Mon, Jul 11, 2016 at 09:39:00AM -0700, Bill Spitzak wrote: > On Sun, Jul 10, 2016 at 4:28 PM, Peter Hutterer > wrote: > > > On Thu, Jul 07, 2016 at 02:24:39PM -0700, Bryce Harrington wrote: > > > On Thu, Jul 07, 2016 at 02:08:28PM -0700, Bryce Harrington wrote: > > > > Check errno, which is se

Re: [PATCH wayland-protocols v5 4/4] tablet: Add pad support to the tablet protocol

2016-07-11 Thread Jason Gerecke
On 07/11/2016 08:13 AM, Carlos Garnacho wrote: > The pad's interface is similar to the tool interface, a client is notified of > the pad after the tablet_added event. > > The pad has three functionalities: buttons, rings and strips. > Buttons are fairly straightforward, rings and strips are separa

Re: Weston versioning (Re: [PATCH weston 6/6] libweston: do not use weston version in libweston.pc)

2016-07-11 Thread Jan Engelhardt
On Monday 2016-07-11 16:44, Emil Velikov wrote: >>>http://ometer.com/parallel.html. I would strongly recommend giving it >>>a look. >> >> I read it now, and I do not buy it - at least not for 2016 standards. >> According to the page, it was written in 2002, and I can confirm that >> the situation

[PATCH weston] Remove a wrong closing “extern "C"” in shared/xalloc.c

2016-07-11 Thread Emmanuel Gil Peyrot
Signed-off-by: Emmanuel Gil Peyrot --- shared/xalloc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/shared/xalloc.c b/shared/xalloc.c index 4bf8a3e..9bf5245 100644 --- a/shared/xalloc.c +++ b/shared/xalloc.c @@ -47,8 +47,3 @@ fail_on_null(void *p, size_t size, char *file, int32_t line)

[PATCH wayland-protocols v5 4/4] tablet: Add pad support to the tablet protocol

2016-07-11 Thread Carlos Garnacho
The pad's interface is similar to the tool interface, a client is notified of the pad after the tablet_added event. The pad has three functionalities: buttons, rings and strips. Buttons are fairly straightforward, rings and strips are separate interfaces with a pointer-axis-like source/value/frame

Re: Weston versioning (Re: [PATCH weston 6/6] libweston: do not use weston version in libweston.pc)

2016-07-11 Thread Emil Velikov
On 9 July 2016 at 17:26, Pekka Paalanen wrote: > On Thu, 7 Jul 2016 17:45:24 +0100 > Emil Velikov wrote: > >> On 7 July 2016 at 10:46, Pekka Paalanen wrote: >> > On Mon, 4 Jul 2016 16:25:54 +0100 >> > Emil Velikov wrote: >> > >> >> On 4 July 2016 at 15:35, Quentin Glidic >> >> wrote: >> >> >

[PATCH wayland-protocols v5 1/4] tablet: add v2 of the tablet protocol

2016-07-11 Thread Carlos Garnacho
From: Peter Hutterer This is a straightforward copy/paste with a _v1 -> _v2 rename. No functional changes otherwise. Signed-off-by: Peter Hutterer Reviewed-by: Jason Gerecke Reviewed-by: Carlos Garnacho --- Makefile.am| 1 + unstable/tablet/tablet-unstable-v2.xm

[PATCH wayland-protocols v5 3/4] tablet: restrict the cursor surface to one per tool

2016-07-11 Thread Carlos Garnacho
From: Peter Hutterer The initial approach was to allow one surface to be re-used between tools, seats and even used together as wl_pointer cursor surface. This has a few drawbacks, most of which are related to managing the surface correctly in the compositor. For example, the same cursor surface

[PATCH wayland-protocols v5 2/4] tablet: change all degree values from int to wl_fixed

2016-07-11 Thread Carlos Garnacho
From: Peter Hutterer Signed-off-by: Peter Hutterer Reviewed-by: Jason Gerecke Reviewed-by: Carlos Garnacho --- unstable/tablet/tablet-unstable-v2.xml | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/unstable/tablet/tablet-unstable-v2.xml b/unstable/t

Re: [PATCH v4 wayland-protocols 4/4] tablet: Add pad support to the tablet protocol

2016-07-11 Thread Carlos Garnacho
Hi!, On Thu, Jul 7, 2016 at 11:30 PM, Jason Gerecke wrote: > On 06/30/2016 05:16 AM, Jonas Ådahl wrote: >> On Thu, Jun 30, 2016 at 01:10:33PM +0200, Carlos Garnacho wrote: >>> Hi!, >>> >>> On Thu, Jun 30, 2016 at 6:27 AM, Jonas Ådahl wrote: On Tue, Jun 28, 2016 at 11:21:50PM +0200, Carlos G

Re: [PATCH weston 3/6] README: Document versioning scheme, forward compatibility

2016-07-11 Thread Emil Velikov
On 9 July 2016 at 16:32, Pekka Paalanen wrote: > On Thu, 7 Jul 2016 20:08:40 +0200 > Quentin Glidic wrote: > >> On 07/07/2016 18:11, Emil Velikov wrote: >> > On 7 July 2016 at 10:05, Pekka Paalanen wrote: >> >> >> >> [snip] >> >> >> >> Now that you mentioned the semantics could be of upper or l

Re: Weston versioning (Re: [PATCH weston 6/6] libweston: do not use weston version in libweston.pc)

2016-07-11 Thread Emil Velikov
On 10 July 2016 at 13:23, Jan Engelhardt wrote: > > On Sunday 2016-07-10 12:46, Emil Velikov wrote: >>> PKG_CHECK_EXISTS([gtk-3.0], [PKG_CHECK_MODULES([gtk], [gtk-3.0])], [ >>> ...repeat the fun... >>> ])] >>> >>Yes, it's one line of fun for each version that you want to be >>compatible with. It's

[PATCH weston v3] libweston: Position layers in an absolute way

2016-07-11 Thread Quentin Glidic
From: Quentin Glidic Currently, layers’ order depends on the module loading order and it does not survive runtime modifications (like shell locking/unlocking). With this patch, modules can safely add their own layer at the expected position in the stack, with runtime persistence. Signed-off-by:

Re: [PATCH weston v2] libweston: Position layers in an absolute way

2016-07-11 Thread Quentin Glidic
On 11/07/2016 10:23, Giulio Camuffo wrote: 2016-07-09 20:45 GMT+02:00 Quentin Glidic : From: Quentin Glidic Currently, layers’ order depends on the module loading order and it does not survive runtime modifications (like shell locking/unlocking). With this patch, modules can safely add their o

Re: [PATCH weston 2/3] modules: Drop module_init as a shared init function

2016-07-11 Thread Giulio Camuffo
2016-07-04 15:58 GMT+02:00 Quentin Glidic : > From: Quentin Glidic > > Use different functions so we cannot load a libweston module in weston > or the other way around. > > Also properly namespace backend_init and use a different name for weston > shells. > > Signed-off-by: Quentin Glidic > --- >

Re: [PATCH weston 1/3] weston: Add a specific option to load XWayland

2016-07-11 Thread Giulio Camuffo
Hi, This looks good to me but i wonder, since it's a behavior change, it should be mentioned in the changelog. I think we should start using a [Changelog] tag or something in the commit message to make fishing them out of the git history easier. With that, Reviewed-by: Giulio Camuffo 2016-07-04

Re: [PATCH weston v2] libweston: Position layers in an absolute way

2016-07-11 Thread Giulio Camuffo
2016-07-09 20:45 GMT+02:00 Quentin Glidic : > From: Quentin Glidic > > Currently, layers’ order depends on the module loading order and it does > not survive runtime modifications (like shell locking/unlocking). > With this patch, modules can safely add their own layer at the expected > position i