Hi, This looks good to me but i wonder, since it's a behavior change, it should be mentioned in the changelog. I think we should start using a [Changelog] tag or something in the commit message to make fishing them out of the git history easier.
With that, Reviewed-by: Giulio Camuffo <[email protected]> 2016-07-04 16:04 GMT+02:00 Quentin Glidic <[email protected]>: > On 04/07/2016 16:02, Michael Schellenberger Costa wrote: >> >> Hi Quentin, >> >> Am 04.07.2016 um 15:58 schrieb Quentin Glidic: >>> >>> From: Quentin Glidic <[email protected]> >>> >>> Signed-off-by: Quentin Glidic <[email protected]> >>> --- >>> compositor/main.c | 25 +++++++++++++++---------- >>> man/weston.ini.man | 7 +++++-- >>> man/weston.man | 7 +++++-- >>> tests/weston-tests-env | 7 ++++--- >>> weston.ini.in | 3 ++- >>> 5 files changed, 31 insertions(+), 18 deletions(-) >>> >>> diff --git a/compositor/main.c b/compositor/main.c >>> index 6cf9194..4e6b7ae 100644 >>> --- a/compositor/main.c >>> +++ b/compositor/main.c >>> [snip] >>> + if (!xwayland) >>> + weston_config_section_get_bool(section, "xwayland", >>> &xwayland, >>> + false); >>> + if (xwayland) { >> >> Can you make that the else clause? > > > No, this pattern is there so we get the config file value as fallback. > > >> --Michael >> >>> [snip] > > > > -- > > Quentin “Sardem FF7” Glidic > > _______________________________________________ > wayland-devel mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/wayland-devel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
