[PATCH weston] desktop-shell: fix minimization of fullscreen surfaces

2015-03-30 Thread Manuel Bachmann
From: Manuel Bachmann If a fullscreen surface was minimized, the shell would keep its fullscreen mode activated, and only a black background would be visible. Signed-off-by: Manuel Bachmann --- desktop-shell/shell.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff -

Re: [PATCH weston 2/2] desktop-shell: fix minimization of fullscreen surfaces, pointer focus

2015-03-30 Thread Manuel Bachmann
Now re-sending this patch, modified, under the new name "desktop-shell: fix minimization of fullscreen surfaces". 2015-03-30 18:26 GMT+02:00 Manuel Bachmann < manuel.bachm...@open.eurogiciel.org>: > Hi Pekka, > > "It is the wrong way to fix it. > > Not wl_pointer nor wl_keyboard foci are intercha

Re: [PATCH weston v2] xwm: don't let X windows steal the focus

2015-03-30 Thread Jasper St. Pierre
It's because there are multiple windows, and "window" is ambiguous. First of all, there's the actual window that the event was generated on. That isn't actually sent to you. When the event bubbles up, you get three windows: "root", which is the root window of the source window. Used for finding th

Re: [PATCH weston v2] xwm: don't let X windows steal the focus

2015-03-30 Thread Bill Spitzak
Interesting. A bit odd because looking in xproto.h I can see that the same offset in the structure is called "window" or "drawable" in many other events. I guess this is because it is generated from xprotocol descriptions and the terminology cannot be changed there? But kind of unclear why such

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-03-30 Thread Manuel Bachmann
OK. Found it, thanks to your hint, Daniel. This version of Mesa (10.1.3) does not feature these extensions. They were added here : http://cgit.freedesktop.org/mesa/mesa/commit/src/egl/main/eglglobals.c?id=468cc866b4b308cee40470f06b31002c6c56da96 Considering that recent distributions, such as Ubu

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-03-30 Thread Manuel Bachmann
Hi Daniel, and thanks, "What is the complete client extension string on that platform?" It is simply "EGL_EXT_client_extensions". Here are the details : kernel 3.13.0 - Mesa 10.1.3 (built with "with-egl-platforms=wayland,x11,drm") - kernel module is "i915" - EGL is : 1.4 (DRI2) - GL vendor is :

Re: [PATCH libinput] evdev: Do not mark tablet touchscreens as tablets

2015-03-30 Thread Benjamin Tissoires
On Fri, Mar 27, 2015 at 6:34 PM, Jason Gerecke wrote: > Devices like the Cintiq 24HDT are marked with both ID_INPUT_TABLET and > ID_INPUT_TOUCHSCREEN in udev. Be sure that we don't try to use such a > device as a tablet. > > Signed-off-by: Jason Gerecke > --- Reviewed-by: Benjamin Tissoires Ch

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-03-30 Thread Daniel Stone
Hi, On 30 March 2015 at 17:38, Manuel Bachmann wrote: > "You removed the early return here... > ...which means this check may be accessing NULL extensions, no?" > > You are right ! Sorry for that, did not even look at the #ifdef, will rework > this part. Apart from the configless_context damage,

Re: [PATCH weston v2] xwm: don't let X windows steal the focus

2015-03-30 Thread Daniel Stone
Hi, On 30 March 2015 at 19:05, Bill Spitzak wrote: > On 03/29/2015 04:20 AM, Giulio Camuffo wrote: >> +static void >> +weston_wm_handle_focus_in(struct weston_wm *wm, xcb_generic_event_t >> *event) >> +{ >> + xcb_focus_in_event_t *focus = (xcb_focus_in_event_t *) event; >> + /* Do not

Re: [PATCH weston v2] xwm: don't let X windows steal the focus

2015-03-30 Thread Bill Spitzak
On 03/29/2015 04:20 AM, Giulio Camuffo wrote: +static void +weston_wm_handle_focus_in(struct weston_wm *wm, xcb_generic_event_t *event) +{ + xcb_focus_in_event_t *focus = (xcb_focus_in_event_t *) event; + /* Do not let X clients change the focus behind the compositor's +* bac

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-03-30 Thread Manuel Bachmann
"You removed the early return here... ...which means this check may be accessing NULL extensions, no?" You are right ! Sorry for that, did not even look at the #ifdef, will rework this part. "You do want to keep the -1 return as fatal here. gl_renderer_supports() should already return 0 meaning "

Re: [PATCH weston 2/2] desktop-shell: fix minimization of fullscreen surfaces, pointer focus

2015-03-30 Thread Manuel Bachmann
Hi Pekka, "It is the wrong way to fix it. Not wl_pointer nor wl_keyboard foci are interchangeable with the concept of "active". It simply just happens that an active window will usually have the kbd focus if a kbd exists, because users expect that. From a purely protocol-mechanical point of view

[PATCH weston v3] tests: add tests for devices handling

2015-03-30 Thread Marek Chalupa
Test misc races when adding/releasing devices v2.: use one roundtrip after releasing devices add touch support v3.: remove useless checks add few comments repeat tests 30 times instead of 100 times (it took too long, 30 is enough) Signed-off-by: Marek Chalupa --- Makefile.a

[PATCH weston v2] tests: implement touch in test-helpers

2015-03-30 Thread Marek Chalupa
Let the client bind to wl_touch. Since we have our own seat, we know that the compositor will have wl_touch capability. v2: rebased due to changes in previous commit Signed-off-by: Marek Chalupa --- tests/weston-test-client-helper.c | 79 +++ tests/weston-tes

[PATCH weston v2] tests: use special seat

2015-03-30 Thread Marek Chalupa
When running on different backends, we don't know what devices the backend provides. Create new seat for tests that contains everything what we need. This is also first step in adding touch support for tests. v2: do not add devices in wl_seat.name event. Collect first all wl_seats and then pic

Re: [PATCH weston v2 5/5] tests: add tests for devices handling

2015-03-30 Thread Marek Chalupa
On Mon, Mar 30, 2015 at 8:22 AM, Pekka Paalanen wrote: > On Mon, 30 Mar 2015 06:37:59 -0400 > Marek Chalupa wrote: > > > Test misc races when adding/releasing devices > > > > v2.: use one roundtrip after releasing devices > > add touch support > > > > Signed-off-by: Marek Chalupa > > --- >

Re: [PATCH weston v5] xwm: tell the shell the pid of the X clients

2015-03-30 Thread Pekka Paalanen
On Tue, 27 Jan 2015 22:05:53 +0200 Giulio Camuffo wrote: > 2015-01-27 22:00 GMT+02:00 Jasper St. Pierre : > > The only existing use I see for the PID is for killing the client. > > There is already a mechanism for that anyway, so nothing needs to be added. > > > > > I'd also argue that using th

Re: [PATCH weston] toytoolkit: fix EGL surface creation for lazy drivers

2015-03-30 Thread Pekka Paalanen
On Sun, 29 Mar 2015 08:17:01 +0200 Manuel Bachmann wrote: > From: Manuel Bachmann > > Some DRI drivers, including VMware vmwgfx, do not support > calling eglQueryString() with a EGL_NO_DISPLAY parameter. > > Allow toytoolkit to create EGL surfaces with them, by > falling back to the old creati

Re: [PATCH weston] gl-renderer: fix EGL initialization steps

2015-03-30 Thread Pekka Paalanen
On Sun, 29 Mar 2015 05:03:09 +0200 Manuel Bachmann wrote: > From: Manuel Bachmann > > We should not prevent gl-renderer to initalize if client > extensions were not found. Practically, this prevented > Weston from running with GL on i915 DRI platforms. > > Some DRI drivers, including VMware vm

Re: [PATCH weston] nested-client: fix typo

2015-03-30 Thread Pekka Paalanen
On Sat, 28 Mar 2015 07:06:40 +0100 Manuel Bachmann wrote: > From: Manuel Bachmann > > Should be "client" instead of "nclient". > > Signed-off-by: Manuel Bachmann > --- > clients/nested-client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/clients/nested-client.c

Re: [PATCH weston] toytoolkit: fix new EGL extensions fallback typedefs

2015-03-30 Thread Pekka Paalanen
On Sat, 28 Mar 2015 07:05:48 +0100 Manuel Bachmann wrote: > From: Manuel Bachmann > > The dummy typedefs for "get_platform_display()" and > "create_platform_window()" were badly defined, which > prevented building Weston on older systems. > > Signed-off-by: Manuel Bachmann > --- > shared/pla

Re: [PATCH weston v2 5/5] tests: add tests for devices handling

2015-03-30 Thread Pekka Paalanen
On Mon, 30 Mar 2015 06:37:59 -0400 Marek Chalupa wrote: > Test misc races when adding/releasing devices > > v2.: use one roundtrip after releasing devices > add touch support > > Signed-off-by: Marek Chalupa > --- > Makefile.am | 7 +- > tests/devices-test.c | 299 > +

Re: [PATCH wayland] protocol: add better description of wl_pointer.release

2015-03-30 Thread Pekka Paalanen
On Mon, 30 Mar 2015 06:10:22 -0400 Marek Chalupa wrote: > Add note about what all wl_pointer.release does. Mainly that > it destroys the proxy object, so programmer must not call > wl_pointer_destroy() on the pointer any further. > > Signed-off-by: Marek Chalupa > --- > protocol/wayland.xml |

Re: [PATCH weston 2/9] tests: rename client_create to create_client_and_test_surface

2015-03-30 Thread Marek Chalupa
Hehe, race in sending patches (I will have to rebase my patches I just sent if this series will get merged before main :) Anyway, for this and the previous patch: Reviewed-by: Marek Chalupa On Mon, Mar 30, 2015 at 5:20 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > A more descriptive na

Re: [PATCH weston 0/9] Test infrastructure for ivi-shell, sponsored by ADIT

2015-03-30 Thread Pekka Paalanen
On Mon, 30 Mar 2015 12:20:03 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > Hi, > > this patch series sets up a test infrastructure for the needs of ivi-shell. > Also a few tests are included to show how the infrastructure works. Later, the > intention is to add a lot more tests that f

[PATCH weston v2 4/5] tests: implement touch in test-helpers

2015-03-30 Thread Marek Chalupa
Let the client bind to wl_touch. Since we have our own seat, we know that the compositor will have wl_touch capability. Signed-off-by: Marek Chalupa --- tests/weston-test-client-helper.c | 79 +++ tests/weston-test-client-helper.h | 13 +++ 2 files changed

[PATCH weston v2 2/5] tests: fix handling globals

2015-03-30 Thread Marek Chalupa
We used hard-coded version 1 for all globals. For testing newer methods and events we need use the current version of global. This patch fixes this and adds missing event handlers (for the events that were added in versions > 1) Signed-off-by: Marek Chalupa --- tests/weston-test-client-helper.c

[PATCH weston v2 5/5] tests: add tests for devices handling

2015-03-30 Thread Marek Chalupa
Test misc races when adding/releasing devices v2.: use one roundtrip after releasing devices add touch support Signed-off-by: Marek Chalupa --- Makefile.am | 7 +- tests/devices-test.c | 299 +++ 2 files changed, 305 insertions(+),

[PATCH weston v2 1/5] weston-test: add device_{release/add} into protocol

2015-03-30 Thread Marek Chalupa
This request simulates device creation/destruction from evdev (libinput) v2: added support for touch. Touch is not supported yet, but better be prepared Signed-off-by: Marek Chalupa --- protocol/weston-test.xml | 6 ++ tests/weston-test.c | 41 +

[PATCH weston v2 3/5] tests: use special seat

2015-03-30 Thread Marek Chalupa
When running on different backends, we don't know what devices the backend provides. Create new seat for tests that contains everything what we need. This is also first step in adding touch support for tests. Signed-off-by: Marek Chalupa --- tests/weston-test-client-helper.c | 60 +++

[PATCH wayland] protocol: add better description of wl_pointer.release

2015-03-30 Thread Marek Chalupa
Add note about what all wl_pointer.release does. Mainly that it destroys the proxy object, so programmer must not call wl_pointer_destroy() on the pointer any further. Signed-off-by: Marek Chalupa --- protocol/wayland.xml | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a

[PATCH weston 8/9] tests: ivi_layout test infrastructure

2015-03-30 Thread Pekka Paalanen
From: Pekka Paalanen Testing the ivi_layout API requires two things: - the tests must be written as a controller module to access the API - the tests need a helper client to create some objects that can then be managed via the API This patch adds all the infrastructure and two different kinds

[PATCH weston 1/9] tests: introduce create_client()

2015-03-30 Thread Pekka Paalanen
From: Pekka Paalanen Introduce a new helper create_client(), which literally only creates the client struct, and does not require the test extension to be present. This will be useful for ivi-shell tests. Signed-off-by: Pekka Paalanen --- tests/weston-test-client-helper.c | 23

[PATCH weston 3/9] ivi-shell: add cmdline option for controller module

2015-03-30 Thread Pekka Paalanen
From: Pekka Paalanen This will be useful for tests, where we use --no-config, but ivi-shell needs load the controller module from somewhere. We are not making hmi-controller.so the default, because this patch should allow running the tests also with another controller. Signed-off-by: Pekka Paal

[PATCH weston 5/9] build: generate weston-ivi.ini for tests

2015-03-30 Thread Pekka Paalanen
From: Pekka Paalanen The ivi-shell / hmi-controller cannot run without a properly populated config file. Generate a config file especially for tests, which includes paths to the build dirs. The generated file will be used by following patches adding ivi-shell tests. Signed-off-by: Pekka Paalane

[PATCH weston 6/9] ivi-shell/weston.ini: fix paths

2015-03-30 Thread Pekka Paalanen
From: Pekka Paalanen If you do an out-of-tree build, all the images will be left in the srcdir. Fix their paths. Signed-off-by: Pekka Paalanen --- Makefile.am | 2 ++ ivi-shell/weston.ini.in | 34 +- 2 files changed, 19 insertions(+), 17 deletions(-

[PATCH weston 0/9] Test infrastructure for ivi-shell, sponsored by ADIT

2015-03-30 Thread Pekka Paalanen
From: Pekka Paalanen Hi, this patch series sets up a test infrastructure for the needs of ivi-shell. Also a few tests are included to show how the infrastructure works. Later, the intention is to add a lot more tests that fall into the categories enabled by this series. Patches 1-4 are just pre

[PATCH weston 2/9] tests: rename client_create to create_client_and_test_surface

2015-03-30 Thread Pekka Paalanen
From: Pekka Paalanen A more descriptive name to not be confused with create_client(). Signed-off-by: Pekka Paalanen --- tests/bad-buffer-test.c | 2 +- tests/buffer-count-test.c | 2 +- tests/button-test.c | 2 +- tests/event-test.c| 22 ++

[PATCH weston 7/9] tests: add a basic ivi-shell test

2015-03-30 Thread Pekka Paalanen
From: Pekka Paalanen This simply tests that Weston starts with ivi-shell, and ivi_application is present. Signed-off-by: Pekka Paalanen --- Makefile.am| 12 tests/ivi-shell-app-test.c | 72 ++ tests/weston-tests-env | 14

[PATCH weston 4/9] ivi-layout: abort without controller_module_init

2015-03-30 Thread Pekka Paalanen
From: Pekka Paalanen When loading a controller module, if we do not find a controller_module_init symbol, return failure to the caller instead of ignoring the failure. Signed-off-by: Pekka Paalanen --- ivi-shell/ivi-layout.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-)

[PATCH weston 9/9] tests: add ivi_layout stand-alone test module

2015-03-30 Thread Pekka Paalanen
From: Pekka Paalanen This is the ivi_layout stand-alone test controller module that does not require any clients to run. Therefore it is much simpler than ivi_layout-test-plugin.c and does not need a matching part in ivi_layout-test.c. Signed-off-by: Pekka Paalanen --- Makefile.am