On Tue, 27 Jan 2015 22:05:53 +0200 Giulio Camuffo <[email protected]> wrote:
> 2015-01-27 22:00 GMT+02:00 Jasper St. Pierre <[email protected]>: > > The only existing use I see for the PID is for killing the client. > > There is already a mechanism for that anyway, so nothing needs to be added. > > > > > I'd also argue that using the PID for application tracking is bound to go > > awry for a variety of reasons, and you should use WM_CLASS or > > _GTK_APPLICATION_ID for more complete tracking. > > My plan for this is to use the pid to associate a surface to a DBus > (mpris) service. I don't see how i could use either of those for this. > Not pretty, i know, but the only way i see without additional > protocols. > > > > > On Tue, Jan 27, 2015 at 12:29 PM, Giulio Camuffo <[email protected]> > > wrote: > >> > >> 2015-01-27 19:23 GMT+02:00 Jasper St. Pierre <[email protected]>: > >> > Are you still not using XKillClient for some reason? > >> > >> This patch is not about killing X clients, it's about passing the pid > >> to the shell, so not sure what relevance it has. > >> > >> > > >> > On Tue, Jan 27, 2015 at 12:10 PM, Giulio Camuffo > >> > <[email protected]> > >> > wrote: > >> >> > >> >> All the surfaces from all the X clients share the same wl_client so > >> >> wl_client_get_credentials can't be used to get the pid of the X > >> >> clients. > >> >> The shell may need to know the pid to be able to associate a surface > >> >> with e.g. a DBus service. > >> >> --- > >> >> > >> >> v5: added the check on the hostname > >> >> > >> >> desktop-shell/shell.c | 7 +++++++ > >> >> src/compositor.h | 1 + > >> >> xwayland/window-manager.c | 30 ++++++++++++++++++++++-------- > >> >> 3 files changed, 30 insertions(+), 8 deletions(-) Hi, this patch seems fine to me. Fixing XWM to use XKillClient is a matter of another patch. If you use the pid of an X11 app, you'd better know the caveats. *shrug* Pushed. 5d1d2ca..a8e9b41 master -> master Thanks, pq _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
