Re: [RFC : xdg_surface_present() - take 2

Manuel, Thanks for keeping this going. I don't have a whole lot of comments at the moment as it's a pretty small protocol change. I would like to hear some commentary from Jasper and some of the other desktop devs though. The one comment I will make about the protocol is that you may want to cha

Re: Possibilities for a VR compositor

On Mar 6, 2015 9:18 PM, "Max Jensen" wrote: > > Hi Jim, > > Thank you for your response, I am glad someone is working on this and I will keep an eye on your blog. Sadly I can't help right now, because I am still working on my bachelor thesis in games engineering (not VR related). And while I am ve

Re: [PATCH 3/3] Introduce WAYLAND_SERVER_SOCKET_DIR to change socket directory without changing XDG_RUNTIME_DIR. This might be useful to change socket directory in case wl_display_add_socket_auto is u

More likely the problem is in the git commit message. There should be a short one-liner followed by a blank line and then by a paragraph giving more detail. Git uses the first paragraph as a brief patch description in many places, including titling patch emails. On 03/06/2015 12:29 PM, Lyude w

Re: [PATCH 3/3] Introduce WAYLAND_SERVER_SOCKET_DIR to change socket directory without changing XDG_RUNTIME_DIR. This might be useful to change socket directory in case wl_display_add_socket_auto is u

Just a nit-pick here, generally it's a good idea to keep the subject line short, and have the majority of the description in the body of the patch. Saw this while I was going through my e-mails and figured I might as well point that out :). Cheers, Lyude On Tue, 2015-03-03 at 13:49 +0100,

Re: [PATCH weston 0/8] Fix pixman-renderer cropping

On 06/03/15 05:03 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Hi, > > this is a series of relatively small changes to the Pixman-renderer, with the > major goals of a) clean up the draw_view/repaint_region machinery, and b) > properly implement source clipping. This is a follow-up to >

Re: [PATCH weston 7/8] pixman-renderer: implement source clipping

On 06/03/15 05:04 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Implement a way to do composition clipping with a region32 given in > source image space. > > Pixman does not directly support this kind of operation at all. If you > pixman_image_set_clip_region32() on a source image, it wil

Re: [PATCH weston 6/8] pixman-renderer: move code to draw_view_translated()

On 06/03/15 05:04 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Move code from draw_view() into a new function draw_view_translated(). > This new function is correct only if > view_transformation_is_translation(). > > The functional change in this is that if view->alpha is not 1.0, we do

Re: [PATCH weston 5/8] pixman-renderer: change repaint_region() arguments

On 06/03/15 05:04 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Change the region argument types in repaint_region(), moving the > final_region computation to the caller. The caller is in a better > position deciding if source_clip is needed or if it can be intersected > into the final_reg

Re: [PATCH weston 2/8] pixman-renderer: put transformation computation into function

On 06/03/15 05:03 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Move the long piece of code computing the end-to-end transformation from > repaint_region() into a new function > pixman_renderer_compute_transform(). > > The code itself it not modified. > Nice refactor, but the transform

Re: [PATCH weston 1/8] compositor: add weston_surface_to_buffer_region()

On 06/03/15 05:03 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > This will be used by pixman-renderer. > > Signed-off-by: Pekka Paalanen > --- > src/compositor.c | 36 > src/compositor.h | 5 + > 2 files changed, 41 insertions(+) > > diff --git

[PATCH weston 3/8] pixman-renderer: refactor into region_intersect_only_translation()

From: Pekka Paalanen Move code into a new helper function. No changes. Signed-off-by: Pekka Paalanen --- src/pixman-renderer.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c index 2769168..459b

[PATCH weston 2/8] pixman-renderer: put transformation computation into function

From: Pekka Paalanen Move the long piece of code computing the end-to-end transformation from repaint_region() into a new function pixman_renderer_compute_transform(). The code itself it not modified. Because the number of moved lines is so big, git-diff will show the changes in the context ins

[PATCH weston 0/8] Fix pixman-renderer cropping

From: Pekka Paalanen Hi, this is a series of relatively small changes to the Pixman-renderer, with the major goals of a) clean up the draw_view/repaint_region machinery, and b) properly implement source clipping. This is a follow-up to http://lists.freedesktop.org/archives/wayland-devel/2015-Mar

[PATCH weston 1/8] compositor: add weston_surface_to_buffer_region()

From: Pekka Paalanen This will be used by pixman-renderer. Signed-off-by: Pekka Paalanen --- src/compositor.c | 36 src/compositor.h | 5 + 2 files changed, 41 insertions(+) diff --git a/src/compositor.c b/src/compositor.c index 45e8f5c..1747c6f 10064

[PATCH weston 6/8] pixman-renderer: move code to draw_view_translated()

From: Pekka Paalanen Move code from draw_view() into a new function draw_view_translated(). This new function is correct only if view_transformation_is_translation(). The functional change in this is that if view->alpha is not 1.0, we do not bother computing and painting the non-opaque and opaqu

[PATCH weston 8/8] pixman-renderer: implement view scissor

From: Pekka Paalanen Only needed in the source-clipped case, otherwise the boundingbox is already doing the necessary clipping. Signed-off-by: Pekka Paalanen --- src/pixman-renderer.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c index

[PATCH weston 4/8] pixman-renderer: add view_transformation_is_translation()

From: Pekka Paalanen A simple refactoring just to help readability. Signed-off-by: Pekka Paalanen --- src/pixman-renderer.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c index 459b20a..ecb4109 100644 --- a/sr

[PATCH weston 7/8] pixman-renderer: implement source clipping

From: Pekka Paalanen Implement a way to do composition clipping with a region32 given in source image space. Pixman does not directly support this kind of operation at all. If you pixman_image_set_clip_region32() on a source image, it will be ignored unless you also pixman_image_set_sour

[PATCH weston 5/8] pixman-renderer: change repaint_region() arguments

From: Pekka Paalanen Change the region argument types in repaint_region(), moving the final_region computation to the caller. The caller is in a better position deciding if source_clip is needed or if it can be intersected into the final_region via a simple translation. This avoids surf_region/so

Re: [PATCH libinput 5/3] touchpad: accumulate the initial scroll edge delta

Hi, On 06-03-15 06:44, Peter Hutterer wrote: The previous setting of 10 wasn't 10 mm, it was used against the deltas normalized to a 1000DPI mouse, i.e. closer to 4mm. It was also also per-event, so a slow movement or a high-frequency touchpad can struggle to meet the threshold. Change the trig

Re: [PATCH libinput 4/3] touchpad: annotate all coordinates that are in device coordinates

Hi, On 06-03-15 06:43, Peter Hutterer wrote: Signed-off-by: Peter Hutterer Looks good: Reviewed-by: Hans de Goede Regards, Hans --- src/evdev-mt-touchpad.h | 39 --- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/src/evdev-mt-touch

Re: [PATCH libinput 2.5/3] Move DEFAULT_MOUSE_DPI to evdev.h, provide a conversion macro

Hi, On 06-03-15 11:38, Hans de Goede wrote: Hi, On 06-03-15 06:41, Peter Hutterer wrote: Ideally we want to specify various thresholds in mm, but not all touchpads set the hardware resolutions. Rather than conditions to check for resolutions everywhere, use a macro to give us a normalized valu

Re: [PATCH v2 libinput 3/3] touchpad: change tap motion threshold to 3 mm

Hi, On 06-03-15 06:42, Peter Hutterer wrote: Previous code used a device coordinate threshold of 300 which won't work on Elantech touchpads (1280 vs the ~4000 that synaptics has). Convert to normalized DPI and reduce the threshold to 3mm. https://bugs.freedesktop.org/show_bug.cgi?id=89206 [not

Re: [PATCH libinput 2.5/3] Move DEFAULT_MOUSE_DPI to evdev.h, provide a conversion macro

Hi, On 06-03-15 06:41, Peter Hutterer wrote: Ideally we want to specify various thresholds in mm, but not all touchpads set the hardware resolutions. Rather than conditions to check for resolutions everywhere, use a macro to give us a normalized value that we use for motion as well. Signed-off-

Re: [PATCH libinput 1/3] test: fix/disable two tap test for semi-mt devices

Hi Peter, Thanks for working on this. You're timing wrt MM_TO_DPI_NORMALIZED introduction is excellent as I need something similar for my pinch gesture work. I've a couple of remarks, so I'm going to reply to each patch separately. On 05-03-15 22:45, Peter Hutterer wrote: On a semi-mt device l

Re: [PATCH libinput 2/3] touchpad: return normalized deltas from tp_get_delta

Hi, On 05-03-15 22:45, Peter Hutterer wrote: All callers except the tap motion threshold call tp_get_delta() followed by tp_filter_motion() - the latter normalized it before calling into the accleration code. Move the normalization into tp_get_delta() so we don't deal with device-specific coord