[Bug 942590] Re: update-manager misguiding text

2012-03-02 Thread John Napster
My last patch that fixes a missing dot. ** Patch added: "patch5.diff" https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2800711/+files/patch5.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. http

[Bug 942590] Re: update-manager misguiding text

2012-03-02 Thread Matthew Paul Thomas
The primary text for an alert should be complete sentences, regardless of whether it is bold. The software on this computer is up to date. It's easy to understand this when considering that sometimes the primary text is a question. Are you sure you want to close all programs and log out

[Bug 942590] Re: update-manager misguiding text

2012-03-02 Thread Fitoschido
** Changed in: update-manager (Ubuntu) Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications a

[Bug 942590] Re: update-manager misguiding text

2012-03-01 Thread John Napster
patch4.diff labeled "This is it" was commited by mvo... Thanks for that. I only need Matthew to tell me about the previous question I was asking. So what's up with that string in question Matthew? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed t

[Bug 942590] Re: update-manager misguiding text

2012-03-01 Thread John Napster
** Patch removed: "This is it" https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2796829/+files/patch4.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Titl

[Bug 942590] Re: update-manager misguiding text

2012-03-01 Thread John Napster
Matthew, I have a question for you. In UpdateManager/UpdateManager.py there's this code: if num_updates == 0: text_header= "%s" % _("The software on this computer is up to date.") Since this string is going to be displayed as a title in bold and not as a normal text label -- should

[Bug 942590] Re: update-manager misguiding text

2012-03-01 Thread Launchpad Bug Tracker
** Branch linked: lp:update-manager -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: update-manager misguiding text To manage notifications about this bug go to: https://bugs.launchpad.n

[Bug 942590] Re: update-manager misguiding text

2012-03-01 Thread John Napster
Matthew, you're absolutely right. I fixed my patch now and am uploading it for your another revision. If you now see it fit, then please apply it and commit it. ;) ** Patch removed: "3rd time's a charm :)" https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2794573

[Bug 942590] Re: update-manager misguiding text

2012-03-01 Thread Matthew Paul Thomas
Thanks again John. You're right to change "Ubuntu Linux" to "Ubuntu". I just have one niggle: - text_header= "%s" % _("The software on this computer is up to date.") + text_header= "%s" % _("The software on this computer is up-to-date.") This should stay as it is. Compound a

[Bug 942590] Re: update-manager misguiding text

2012-02-29 Thread John Napster
Michael, you have asked me on IRC to review my patch again if everything looks good. I have done that and I assure you that the patch is now, finally, perfected and ready to be commited. So, if you please, go ahead and commit. ;) -- You received this bug notification because you are a member of U

[Bug 942590] Re: update-manager misguiding text

2012-02-29 Thread John Napster
Matthew, I like the idea of removing the second sentence altogether, so I made a new patch and removed those second sentences. I also removed the whole "is_unity_running()" thing. Some minor changes were also made, like there was an occurence of "Ubuntu Linux" which I found totally unnecessary as a

[Bug 942590] Re: update-manager misguiding text

2012-02-29 Thread John Napster
** Patch removed: "Apply and commit ;)" https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2792609/+files/patch2.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942

[Bug 942590] Re: update-manager misguiding text

2012-02-29 Thread Matthew Paul Thomas
Hi John. Thank you for your patch. I have three small suggestions and one big suggestion. Small suggestions: 1. For readability, instructional text -- whether it appears in a UI or in help -- should not include any ellipses in labels that it is referring to. So "Updates Available..." should inste

[Bug 942590] Re: update-manager misguiding text

2012-02-28 Thread John Napster
I removed my first patch because I made a mistake in it. My second patch is now okay. I have fixed only those strings under the statement "if is_unity_running()" because the fixed text applies only in the situation when the user has the Unity desktop environment installed. Michael, I must inform y

[Bug 942590] Re: update-manager misguiding text

2012-02-28 Thread John Napster
** Patch removed: "My solution to the problem..." https://bugs.launchpad.net/ubuntu/+source/update-manager/+bug/942590/+attachment/2792348/+files/patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs

[Bug 942590] Re: update-manager misguiding text

2012-02-28 Thread Ubuntu Foundation's Bug Bot
The attachment "My solution to the problem..." of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the t

[Bug 942590] Re: update-manager misguiding text

2012-02-28 Thread John Napster
I chatted with Michael Vogt a.k.a. mvo on irc.freenode.net, the creator of update-manager package, and he instruct me to make a patch for update-manager and was perfectly happy that I make this changes. I did create a patch and so now I am giving it to the world. :) I hope you like my little contr

[Bug 942590] Re: update-manager misguiding text

2012-02-28 Thread Brian Murray
Notice that is says "Applications later" not menu. In the dash it is possible to view installed applications and find update-manager. In precise the text displayed is also conditional now and changes depending on whether or not unity is running. ** Changed in: update-manager (Ubuntu) Importan

[Bug 942590] Re: update-manager misguiding text

2012-02-28 Thread John Napster
Please fix this now that Ubuntu 12.04 is still in alpha stage. ** Changed in: update-manager (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: upd

[Bug 942590] Re: update-manager misguiding text

2012-02-28 Thread John Napster
Additional note: The ''menu that has a "power" icon in the top-right of the screen'' that I was referring to is called a session menu. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/942590 Title: upd