On Tue, Jul 06, 2021 at 02:37:34PM +0100, Ricardo Mestre wrote:
> You got the order wrong on my diff :)
>
> Before, the certs were loaded by root in memory and then set by _spamd, with
> my
> diff they are still loaded by root but now also set, everything else
> still has the same order so it sho
:58 Tue 06 Jul , Klemens Nanni wrote:
> On Wed, Jun 30, 2021 at 01:11:38PM +0100, Ricardo Mestre wrote:
> > Hi,
> >
> > I may have seen it elsewhere, or probably not, but after checking on kn's
> > commit
> > to tls_load_file(3) it seems it's now po
On Tue, Jul 06, 2021 at 12:58:37PM +, Klemens Nanni wrote:
> On Wed, Jun 30, 2021 at 01:11:38PM +0100, Ricardo Mestre wrote:
> > Hi,
> >
> > I may have seen it elsewhere, or probably not, but after checking on kn's
> > commit
> > to tls_load_file(3) it
On Wed, Jun 30, 2021 at 01:11:38PM +0100, Ricardo Mestre wrote:
> Hi,
>
> I may have seen it elsewhere, or probably not, but after checking on kn's
> commit
> to tls_load_file(3) it seems it's now possible to set the ca/cert/key directly
> without having to load them
Hi,
I may have seen it elsewhere, or probably not, but after checking on kn's commit
to tls_load_file(3) it seems it's now possible to set the ca/cert/key directly
without having to load them first from disk and set them afterwards from memory.
That being said the below applies this
On Tue, Jun 22, 2021 at 01:29:59PM +, Klemens Nanni wrote:
> On Tue, Jun 22, 2021 at 06:35:44AM +0100, Jason McIntyre wrote:
> > > -sets the files from which the public certificate, and private key will
> > > be read.
> > > +loads two files from which the public certificate, and private key wi
On Tue, Jun 22, 2021 at 06:35:44AM +0100, Jason McIntyre wrote:
> > -sets the files from which the public certificate, and private key will be
> > read.
> > +loads two files from which the public certificate, and private key will be
> > read.
>
> this is a weird place for a comma. i would remove
On Tue, Jun 22, 2021 at 04:48:39AM +0200, Theo Buehler wrote:
> >
> > Feedback? OK?
>
> You have two overlong lines as indicated below. I would have thought
> that mandoc -Tlint complains about that, but apparently it doesn't have
> such a warning... With those wrapped,
>
yes, there is no feedb
nge those as
> well, I think.
>
> This should be the complete diff.
>
> Feedback? OK?
>
>
> Index: man/tls_load_file.3
> ===
> RCS file: /cvs/src/lib/libtls/man/tls_load_file.3,v
> retrieving revi
onfig_set_ocsp_staple_file
>
> Thanks. tls_config_add_*_file also load files into memory, but given
> this patch I think their usage of "add" in the manual is enough to infer
> that files will also be loaded and added, so no need to change those as
> well, I think.
Agreed.
; tls_config_set_ocsp_staple_file
Thanks. tls_config_add_*_file also load files into memory, but given
this patch I think their usage of "add" in the manual is enough to infer
that files will also be loaded and added, so no need to change those as
well, I think.
This should be the complete dif
re right. This was changed in tls_config.c r1.26 (Aug 2016) and the
documentation wasn't updated. However, the diff is incomplete as this
concerns all tls_config_set_*_file functions:
tls_config_set_ca_file
tls_config_set_cert_fil
e()
>
>
> So clarify this in the manual.
>
> Feedback? Objections? OK?
Ping.
Index: man/tls_load_file.3
=======
RCS file: /cvs/src/lib/libtls/man/tls_load_file.3,v
retrieving revision 1.11
diff -u -p -r1.11 tls_load_file
tls_load_file()
tls_config_set_ca_mem()
tls_unload_file()
While in fact the following does the same (in my case):
tls_config_set_ca_file()
So clarify this in the manual.
Feedback? Objections? OK?
Index: man/tls_load_file.3
uot; are used
> > inconsistent. I went with "file" since "filename" to my
> > eyes/ears implies the filename without path, however that
> > maybe wrong.
> >
> > Alf
> >
> > Index: lib/libtls/man/tls_load_file.3
> > =
uot; to my
> eyes/ears implies the filename without path, however that
> maybe wrong.
>
> Alf
>
> Index: lib/libtls/man/tls_load_file.3
> =======
> RCS file: /cvs/src/lib/libtls/man/tls_load_file.3,v
> retrieving
Hello,
while adding a missing "the" for tls_config_set_cert_file
it appeared to me that "file" and "filename" are used
inconsistent. I went with "file" since "filename" to my
eyes/ears implies the filename without path, however that
maybe
On Sat, Jul 29, 2017 at 03:15:56PM -0700, Carlos Cardenas wrote:
> Missing 'ocsp' in the function name.
>
fixed, thanks.
jmc
> +--+
> Carlos
>
> diff --git lib/libtls/man/tls_load_file.3 lib/libtls/man/tls_load_file.3
> index fcaa5eef029..b83f55e0fe4 100644
>
Missing 'ocsp' in the function name.
+--+
Carlos
diff --git lib/libtls/man/tls_load_file.3 lib/libtls/man/tls_load_file.3
index fcaa5eef029..b83f55e0fe4 100644
--- lib/libtls/man/tls_load_file.3
+++ lib/libtls/man/tls_load_file.3
@@ -254,7 +254,7 @@ sets the files from which
19 matches
Mail list logo
