On Mon, Jun 17, 2019 at 10:12:52AM +0200, alf wrote: > Hello, > > while adding a missing "the" for tls_config_set_cert_file > it appeared to me that "file" and "filename" are used > inconsistent. I went with "file" since "filename" to my > eyes/ears implies the filename without path, however that > maybe wrong. > > Alf > > Index: lib/libtls/man/tls_load_file.3 > =================================================================== > RCS file: /cvs/src/lib/libtls/man/tls_load_file.3,v > retrieving revision 1.11 > diff -u -p -r1.11 tls_load_file.3 > --- lib/libtls/man/tls_load_file.3 29 Nov 2018 14:24:23 -0000 1.11 > +++ lib/libtls/man/tls_load_file.3 17 Jun 2019 08:07:53 -0000 > @@ -217,7 +217,7 @@ call, ensuring that the memory contents > returns the path of the file that contains the default root certificates. > .Pp > .Fn tls_config_set_ca_file > -sets the filename used to load a file > +sets the file used to load a file
IMO "set the file used to load a file" reads very weird > containing the root certificates. > .Pp > .Fn tls_config_set_ca_path > @@ -228,13 +228,13 @@ certificates. > sets the root certificates directly from memory. > .Pp > .Fn tls_config_set_cert_file > -sets file from which the public certificate will be read. > +sets the file from which the public certificate will be read. I don't see what was wrong here :-/ > .Pp > .Fn tls_config_set_cert_mem > sets the public certificate directly from memory. > .Pp > .Fn tls_config_set_crl_file > -sets the filename used to load a file containing the > +sets the file used to load a file containing the same > Certificate Revocation List (CRL). > .Pp > .Fn tls_config_set_crl_mem > -- Gilles Chehade @poolpOrg https://www.poolp.org patreon: https://www.patreon.com/gilles
