Re: sed: better error message

2015-10-26 Thread Theo de Raadt
> Jérémie Courrèges-Anglas wrote: > > Michael McConville writes: > > > It looks like it can be pretty easily replaced with calls to err(3), > > > errx(3), warn(3), warnx(3), etc. > > > > Not sure about this, you'd have to repeat the same code over and over to > > print the line number and file

Re: sed: better error message

2015-10-25 Thread Michael McConville
Jérémie Courrèges-Anglas wrote: > Michael McConville writes: > > It looks like it can be pretty easily replaced with calls to err(3), > > errx(3), warn(3), warnx(3), etc. > > Not sure about this, you'd have to repeat the same code over and over to > print the line number and file name. Good poin

Re: sed: better error message

2015-10-25 Thread Jérémie Courrèges-Anglas
Michael McConville writes: > Jérémie Courrèges-Anglas wrote: >> Tobias Stoeckmann writes: >> >> > $ sed s/a/b/ /nofile >> > sed: 0: /nofile: /nofile >> > >> > That message doesn't tell me a lot, let's better write >> > strerror(errno) if fopen returns NULL: >> > >> > $ ./sed s/a/b/ /nofile >> >

Re: sed: better error message

2015-10-25 Thread Michael McConville
Jérémie Courrèges-Anglas wrote: > Tobias Stoeckmann writes: > > > $ sed s/a/b/ /nofile > > sed: 0: /nofile: /nofile > > > > That message doesn't tell me a lot, let's better write > > strerror(errno) if fopen returns NULL: > > > > $ ./sed s/a/b/ /nofile > > sed: 0: /nofile: No such file or directo

Re: sed: better error message

2015-10-25 Thread Jérémie Courrèges-Anglas
Tobias Stoeckmann writes: > $ sed s/a/b/ /nofile > sed: 0: /nofile: /nofile > > That message doesn't tell me a lot, let's better write > strerror(errno) if fopen returns NULL: > > $ ./sed s/a/b/ /nofile > sed: 0: /nofile: No such file or directory That's much nicer, ok jca@ (misc.c:err() alread

sed: better error message

2015-10-25 Thread Tobias Stoeckmann
$ sed s/a/b/ /nofile sed: 0: /nofile: /nofile That message doesn't tell me a lot, let's better write strerror(errno) if fopen returns NULL: $ ./sed s/a/b/ /nofile sed: 0: /nofile: No such file or directory Index: main.c === RCS file