> Jérémie Courrèges-Anglas wrote:
> > Michael McConville <mm...@mykolab.com> writes:
> > > It looks like it can be pretty easily replaced with calls to err(3),
> > > errx(3), warn(3), warnx(3), etc.
> > 
> > Not sure about this, you'd have to repeat the same code over and over to
> > print the line number and file name.
> 
> Good point. I'll look at the code more.
> 
> > > However, it'd be easiest to rename the function to error() first.
> > >
> > > Thoughts?
> > 
> > Makes sense to me.
> > 
> > However, using "error" instead of "sed_err" would save you two
> > characters and avoid some of the >80 chars long lines introduced by your
> > diff.  Those should be fixed.
> 
> 'error' seemed a little too general. ok for s_err?

hundreds of programs use error() just fine because it isn't available
in the system namespace.

Reply via email to