mention U-Boot file and offset for Rockchip RK356x

2023-10-17 Thread Kevin Lo
ok? Index: distrib/notes/arm64/prep === RCS file: /cvs/src/distrib/notes/arm64/prep,v retrieving revision 1.18 diff -u -p -u -p -r1.18 prep --- distrib/notes/arm64/prep10 Apr 2023 12:57:15 - 1.18 +++ distrib/notes/arm64/p

Re: Correct TP-LINK bluetooth ID

2023-09-09 Thread Kevin Lo
On Sat, Sep 09, 2023 at 03:16:08PM +0800, Kevin Lo wrote: > > On Sep 7 Douglas Silva reported this bug: > > https://marc.info/?l=openbsd-bugs&m=169407574511323&w=2 > > The product id of the tp-link ub500 is 0x0604 which uses the RTL8761BUV chip. > The diff below

Correct TP-LINK bluetooth ID

2023-09-09 Thread Kevin Lo
On Sep 7 Douglas Silva reported this bug: https://marc.info/?l=openbsd-bugs&m=169407574511323&w=2 The product id of the tp-link ub500 is 0x0604 which uses the RTL8761BUV chip. The diff below corrects TP-LINK bluetooth ID. ok? Index: sys/dev/usb/usbdevs ===

Add Phison PS5021 ID

2023-08-29 Thread Kevin Lo
nvme0 at pci3 dev 0 function 0 vendor "Phison", unknown product 0x5021 rev 0x01: intx, NVMe 1.4 nvme0: TEAM TM8FPK500G, firmware ELFMB0.6, serial TPBF2210110040500017 The diff below adds another Phison NVMe device id. ok? Index: sys/dev/pci/pcidevs ===

Re: JH7110 PCIe device tree binding update

2023-08-29 Thread Kevin Lo
On Tue, Aug 29, 2023 at 09:15:41PM +0200, Mark Kettenis wrote: > > > Date: Tue, 29 Aug 2023 11:58:23 +0200 > > From: Mark Kettenis > > > > Upstreaming of the JH7110 PCIe device tree bindings isn't finished > > yet, but it seems some progress has been made and things have been > > reviewed by som

Re: all platforms: separate cpu_initclocks() from cpu_startclock()

2023-08-21 Thread Kevin Lo
On Mon, Aug 21, 2023 at 10:34:53PM -0500, Scott Cheloha wrote: > > On Tue, Aug 22, 2023 at 11:28:25AM +0800, Kevin Lo wrote: > > On Mon, Aug 21, 2023 at 09:53:53PM -0500, Scott Cheloha wrote: > > > On Tue, Aug 22, 2023 at 02:36:31AM +, Mike Larkin wrote: > > > &

rtwn: R92C_RXDW0_OWN -> R92C_TXDW0_OWN

2023-07-13 Thread Kevin Lo
In rtwn_tx(), check if the OWN bit of Tx instead of Rx is set. Luckily, definitions of R92C_TXDW0_OWN and R92C_RXDW0_OWN are the same. ok? Index: sys/dev/pci/if_rtwn.c === RCS file: /cvs/src/sys/dev/pci/if_rtwn.c,v retrieving revisio

ure(4): add support for RTL8153D

2023-05-03 Thread Kevin Lo
Hi, This diff adds initial support for RTL8153D to ure(4). The RTL8153D chipset shares many similarities with the already supported RTL8156B chip but additionally requires a few semi-unique configurations. Tested: ure0 at uhub0 port 3 configuration 1 interface 0 "Realtek USB 10/100/1000 LAN" r

Re: Add another Lenovo NVMe device id

2023-05-03 Thread Kevin Lo
May I commit this diff? Thanks. On Thu, Apr 27, 2023 at 02:44:12PM +0800, Kevin Lo wrote: > > Found in my x1 extreme gen 1: > nvme0 at pci4 dev 0 function 0 vendor "Lenovo", unknown product 0x0006 rev > 0x00: msix, NVMe 1.2 > > ok? >

Add another Lenovo NVMe device id

2023-04-26 Thread Kevin Lo
Found in my x1 extreme gen 1: nvme0 at pci4 dev 0 function 0 vendor "Lenovo", unknown product 0x0006 rev 0x00: msix, NVMe 1.2 ok? Index: sys/dev/pci/pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.2032 dif

Re: atactl(8): 'readattr' subcommand quits silently.

2023-04-26 Thread Kevin Lo
On Thu, Apr 27, 2023 at 08:37:23AM +0900, YASUOKA Masahiko wrote: > > Hello, > > On Wed, 26 Apr 2023 16:32:28 +0900 > Yuichiro NAITO wrote: > > These 2 revisions of 'attr_val' and 'attr_thr' are different on this > > disk. > > The comment says that it's wrong vendor implementation but I can see

Re: pass M_CANFAIL to malloc() which use M_WAITOK but are tested for failure

2023-04-26 Thread Kevin Lo
On Wed, Apr 26, 2023 at 08:19:10PM +0200, Alexander Bluhm wrote: > > On Sat, Apr 15, 2023 at 10:44:15PM +0800, Kevin Lo wrote: > > On Fri, Apr 14, 2023 at 02:01:29PM +0200, Alexander Bluhm wrote: > > > I think you are trying to change the kernel in the wrong direction. >

Re: pass M_CANFAIL to malloc() which use M_WAITOK but are tested for failure

2023-04-15 Thread Kevin Lo
On Fri, Apr 14, 2023 at 02:01:29PM +0200, Alexander Bluhm wrote: > > On Thu, Apr 13, 2023 at 10:43:30AM +0800, Kevin Lo wrote: > > M_CANFAIL > > In the M_WAITOK case, if not enough memory is available, > > return NULL instead of calling panic(9). If mallocarray

Re: em(4) multiqueue

2023-04-13 Thread Kevin Lo
On Thu, Apr 13, 2023 at 01:30:36PM -0500, Brian Conway wrote: > > Reviving this thread, apologies for discontinuity in mail readers: > https://marc.info/?t=16564219358 > > After rebasing on 7.3, my results have mirrored Hrvoje's testing at the end > of that thread. No issues with throughput

Re: pass M_CANFAIL to malloc() which use M_WAITOK but are tested for failure

2023-04-12 Thread Kevin Lo
On Thu, Apr 06, 2023 at 02:09:23PM +0200, Alexander Bluhm wrote: > > On Thu, Apr 06, 2023 at 02:58:56PM +0800, Kevin Lo wrote: > > The diff below adds M_CANFAIL to the flag passed to malloc() since we are > > able > > to fail gracefully. > > I would not call a

pass M_CANFAIL to malloc() which use M_WAITOK but are tested for failure

2023-04-05 Thread Kevin Lo
Hi, The diff below adds M_CANFAIL to the flag passed to malloc() since we are able to fail gracefully. ok? Index: sys/dev/pci/if_igc.c === RCS file: /cvs/src/sys/dev/pci/if_igc.c,v retrieving revision 1.12 diff -u -p -u -p -r1.12 if_

Re: better support for Quectel EC25

2023-03-31 Thread Kevin Lo
On Fri, Mar 31, 2023 at 06:28:14PM +1000, David Gwynne wrote: > > i got a quectel ec25 to play with recently, and got side tracked > thinking the usb controller was not talking to the modem correctly > because when it attached it looked like this: > > umb0 at uhub2 port 1 "Android Android" rev 2.

txphy: update comment: RTL8139 -> TNETE2101

2023-03-29 Thread Kevin Lo
ok? Index: sys/dev/mii/txphy.c === RCS file: /cvs/src/sys/dev/mii/txphy.c,v retrieving revision 1.12 diff -u -p -u -p -r1.12 txphy.c --- sys/dev/mii/txphy.c 6 Apr 2022 18:59:29 - 1.12 +++ sys/dev/mii/txphy.c 29 Mar 2023 08:0

Add ASMedia ASM2142 xhci

2023-02-06 Thread Kevin Lo
Hi, I have a machine with the ASMedia USB 3.1 controller: xhci1 at pci3 dev 0 function 0 vendor "ASMedia", unknown product 0x2142 rev 0x00: msi, xHCI 1.10 ok? Index: sys/dev/pci/pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v

Re: igc(4) remove unnecessary PHY ID checks

2023-01-26 Thread Kevin Lo
On Wed, Jan 25, 2023 at 03:17:48PM +0100, Moritz Buhl wrote: > > Dear tech, > > Looking into various reports on errors with mini routers that use > igc(4), I found the following diff in FreeBSD: > https://github.com/freebsd/freebsd-src/commit/29d7f1ff579579711dd5a3325480728b8ed45f8c > > I additi

Supprt FTDI FT232R

2022-12-28 Thread Kevin Lo
The diff below makes the serial interface of the Genio 1200 demo board (FT232R) work. The upper 2 bits encode the fractional component of the FT232R is either 0 or 0.125. uftdi0 at uhub0 port 3 configuration 1 interface 0 "FTDI FT232R USB UART" rev 2.00/6.00 addr 2 ucom0 at uftdi0 portno 1 Test

Re: is this rge crash known? - fixed

2022-12-20 Thread Kevin Lo
On Tue, Dec 20, 2022 at 01:02:23AM -0500, Geoff Steckel wrote: > > On 12/19/22 21:07, Kevin Lo wrote: > > On Mon, Dec 19, 2022 at 03:50:45PM -0500, Geoff Steckel wrote: > > > Thanks for all the suggestions: > > > > > > sysctl kern.pool_debug=1 = no change

Re: is this rge crash known? - test results

2022-12-19 Thread Kevin Lo
On Mon, Dec 19, 2022 at 03:50:45PM -0500, Geoff Steckel wrote: > > Thanks for all the suggestions: > > sysctl kern.pool_debug=1 = no change > known working board in same slot = no change > > hardware version is indeed 0609 > em(4) in same slot = works > test using old rge(4) board between tw

Re: is this rge crash known?

2022-12-19 Thread Kevin Lo
On Sun, Dec 18, 2022 at 08:53:26PM -0500, Geoff Steckel wrote: > nc of 0's from one rge to another at full speed crashes > in the input interrupt path with corruption of the memory > pool used for the mbufs

Fix typo in debug messages

2022-10-08 Thread Kevin Lo
OK? Index: sys/dev/pci/if_bge.c === RCS file: /cvs/src/sys/dev/pci/if_bge.c,v retrieving revision 1.398 diff -u -p -u -p -r1.398 if_bge.c --- sys/dev/pci/if_bge.c11 Mar 2022 18:00:45 - 1.398 +++ sys/dev/pci/if_bge.c

List SIMCom SIM8262E-M2 as supported for umb(4)

2022-10-08 Thread Kevin Lo
The diff below adds SIMCom SIM8262E-M2 to umb man page. Tested: umb0 at uhub0 port 18 "SIMCOM SDXLEMUR-LITE-MTP _SN:59A7F2D2" rev 3.20/5.04 addr 7 Using 'AT+CUSBCFG=usbid,1e0e,9003' AT command to switch to MBIM mode. ok? Index: share/man/man4/umb.4 ==

Re: ure(4): add support for RTL8156B

2022-04-02 Thread Kevin Lo
On Sat, Apr 02, 2022 at 04:04:24PM +0100, Stuart Henderson wrote: > On 2022/04/02 15:47, Stuart Henderson wrote: > > It doesn't, but this fixes it: > > > > Index: if_ure.c > > === > > RCS file: /cvs/src/sys/dev/usb/if_ure.c,v > > retr

Re: ure(4): add support for RTL8156B

2022-04-02 Thread Kevin Lo
On Fri, Apr 01, 2022 at 06:09:26PM +0100, Stuart Henderson wrote: > > On 2022/04/01 17:13, Stuart Henderson wrote: > > On 2022/04/01 10:26, Gerhard Roth wrote: > > > On 4/1/22 07:41, Kevin Lo wrote: > > > > > > > > ure0: RTL8153 (0x5c10), address 00

Re: ure(4): add support for RTL8156B

2022-03-31 Thread Kevin Lo
On Fri, Apr 01, 2022 at 12:06:02PM +1000, Jonathan Matthew wrote: > > On Thu, Mar 31, 2022 at 09:41:09PM +0800, Kevin Lo wrote:

Re: ure(4): add support for RTL8156B

2022-03-31 Thread Kevin Lo
On Thu, Mar 31, 2022 at 08:07:02PM +0200, Stefan Sperling wrote: > > On Thu, Mar 31, 2022 at 09:41:09PM +0800, Kevin Lo wrote: > > This diff adds preliminary support for RTL8156B to ure(4) and > > bug fixes for RTL8153/RTL8156. > > > > Tested: > > ure0 at uhu

ure(4): add support for RTL8156B

2022-03-31 Thread Kevin Lo
Hi, This diff adds preliminary support for RTL8156B to ure(4) and bug fixes for RTL8153/RTL8156. Tested: ure0 at uhub0 port 12 configuration

Re: initial iwx(4) 11ac patch for testing

2022-03-10 Thread Kevin Lo
On Thu, Mar 10, 2022 at 12:35:20PM +0100, Stefan Sperling wrote: > > On Thu, Mar 10, 2022 at 12:25:17PM +0100, Stefan Sperling wrote: > > Unless anyone else finds a problem, this patch can be considered ready > > for review and commit. > > Of course, I forgot to apply my sysassert fix to the seco

Re: uchcom(4): fix Rx jammed

2022-01-25 Thread Kevin Lo
On Mon, Jan 17, 2022 at 10:01:17PM +0900, SASANO Takayoshi wrote: > > Hi, > > Sometimes uchcom(4) looks Rx jammed. > Here is the movie (at Mastodon) that the problem has occured: > https://social.tchncs.de/@uaa/107637913051446044 > > Receiving an exact wMaxPacketSize bytes bulk packet from CH34x

Makefile.riscv64: remove -target riscv64-unknown-openbsd from CMACHFLAGS

2022-01-11 Thread Kevin Lo
ok? Index: sys/arch/riscv64/conf/Makefile.riscv64 === RCS file: /cvs/src/sys/arch/riscv64/conf/Makefile.riscv64,v retrieving revision 1.14 diff -u -p -u -p -r1.14 Makefile.riscv64 --- sys/arch/riscv64/conf/Makefile.riscv64 17 Dec

Re: iwx(4) 40MHz channel support

2021-10-13 Thread Kevin Lo
On Tue, Oct 12, 2021 at 02:47:54PM +0200, Stefan Sperling wrote: > > This patch adds support for 40MHz channels to iwx(4). > > Please sync your source tree before attempting to apply this patch. > I have committed some changes to this driver today which this patch > is based on. > > Works for me

umb(4) supports for SIMCom SIM7600

2021-09-23 Thread Kevin Lo
Hi, The diff below enables umb(4) support for SIMCom SIM7600. The SIM7600 is a mbim compatible chip, you'll need to switch it into mbim mode via specific AT-commands (AT+CUSBPIDSWITCH=9003,1,1 and AT+CLANMODE=1) over the serial port. umb0 at uhub1 port 2 "SIMCOM INCORPORATED SimTech, Incorporate

Re: updated patch for iwx(4) Tx aggregation

2021-09-11 Thread Kevin Lo
On Sat, Sep 11, 2021 at 02:04:32PM +0200, Stefan Sperling wrote: > > On Fri, Sep 10, 2021 at 06:49:49PM +0200, Stefan Sperling wrote: > > Here is another attempt at adding Tx aggregation to iwx(4). > > This patch is based on the latest state in CVS (if_iwx.c r1.107, which > > I have committed a mi

Re: iwm/iwx suspend/resume improvement

2021-09-02 Thread Kevin Lo
On Thu, Sep 02, 2021 at 03:26:03PM +0200, Stefan Sperling wrote: > > This patch fixes suspend/resume with an AX201 device for gnezdo@. > Tests on any iwm/iwx device would be apreciated. > > Before testing this make sure to update your tree to -current which contains > a very recent fix for a doub

Re: iwx(4): fix xtal latency values

2021-09-02 Thread Kevin Lo
On Thu, Sep 02, 2021 at 02:24:17PM +0200, Stefan Sperling wrote: > While review device-specific quirks in this driver I noticed that > the xtal latency values we send to the chip do no match those used > by the Linux driver. > > ok? One small nit below. With that fixed, ok kevlo@ > diff b81ef55

Re: uaq(4): aquantia usb ethernet driver

2021-08-31 Thread Kevin Lo
On Wed, Sep 01, 2021 at 10:46:01AM +1000, Jonathan Matthew wrote: > > Here's a driver for the Aquantia USB ethernet devices I just added > to usbdevs. These are somewhat interesting because they theoretically > go up to 5GbE and support jumbo frames (not implemented yet). > > While working on th

Re: Unplugging ure(4) during attach

2021-08-19 Thread Kevin Lo
On Wed, Aug 18, 2021 at 04:12:03PM +, Christian Ludwig wrote: > Hi, > > when plugging and unplugging an ure(4) adapter continuously, I came > across the following error with URE_DEBUG set: > > ure0 at uhub0 port 21 configuration 1 interface 0 "Realtek USB 10/100/1000 > LAN" rev 3.00/30.00 a

ix(4): fix Rx hash type

2021-07-13 Thread Kevin Lo
Hi, The diff below fixes Rx desc RSS type. This matches what Linux and FreeBSD do. ok? Index: sys/dev/pci/if_ix.c === RCS file: /cvs/src/sys/dev/pci/if_ix.c,v retrieving revision 1.178 diff -u -p -u -p -r1.178 if_ix.c --- sys/dev/pc

Re: iwm(4): use new firmware images with fragattack fixes

2021-05-25 Thread Kevin Lo
On Tue, May 25, 2021 at 03:48:16PM +0200, Stefan Sperling wrote: > > This patch allows iwm(4) to use new firmware images which are part > of the iwm-20210512 firmware package, available via fw_update (you > need to run fw_update *before* booting with this patch). > > The new firmware images were

umsm(4)/umb(4) supports for Quectel EC25

2021-05-15 Thread Kevin Lo
Hi, Attached is a diff for umsm(4)/umb(4) which enables support for Quectel EC25. umsm0 at uhub0 port 2 configuration 1 interface 0 "Android Android" rev 2.00/3.18 addr 2 ucom0 at umsm0 umsm1 at uhub0 port 2 configuration 1 interface 1 "Android Android" rev 2.00/3.18 addr 2 ucom1 at umsm1 umsm2

ure(4): correct the rx early size

2021-04-11 Thread Kevin Lo
The rx early size is used to reduce the loading of CPU by letting a transfer contain more data to reduce the number of transfers. The algorithm should be (ure_rxbufsz - packet size) / 8 This matches Linux path in r8153_set_rx_early_size(). ok? Index: sys/dev/usb/if_ure.c ==

Re: veb(4) exceeds 1514 byte frame size while bridge(4) doesn't?

2021-03-25 Thread Kevin Lo
On Tue, Mar 23, 2021 at 08:24:56PM +1000, David Gwynne wrote: > > On Sun, Mar 21, 2021 at 04:24:24PM +0100, Jurjen Oskam wrote: > > Hi, > > > > When trying out veb(4), I ran into a situation where TCP sessions across a > > veb(4) bridge stalled while the exact same config using bridge(4) worked

rge(4): move tx/rx descriptors into their own structs

2021-03-25 Thread Kevin Lo
Hi, The diff below moves tx/rx descriptors into their own structs. This is a first step toward making rge work with multiple queues and interrupts. Only one queue is currently used. While here, update the RTL8125B microcode. Index: sys/dev/pci/if_rge.c ===

Re: athn(4): switch Tx rate control to RA

2021-03-23 Thread Kevin Lo
On Tue, Mar 23, 2021 at 06:01:27PM +0100, Stefan Sperling wrote: > > This switches athn(4) to the new RA Tx rate adaptation module. > Tests on athn(4) PCI devices are welcome. > USB devices don't need to be tested in this case Tx rate adaptation > is taken care of by firmware. > > I could only te

Re: Add missing break statement on if_rge.c

2021-02-11 Thread Kevin Lo
On Thu, Feb 11, 2021 at 12:24:37PM +, Ricardo Mestre wrote: > > Hi, > > Add missing break statement. OK? ok kevlo@. stsp@ has informed me earlier and has the same diff, I think he will be committing it later today. > CID 1501710 > > Index: if_rge.c > ===

Document IFM_2500_T media type

2021-01-20 Thread Kevin Lo
The diff below documents IFM_2500_T media type. ok? Index: share/man/man4/ifmedia.4 === RCS file: /cvs/src/share/man/man4/ifmedia.4,v retrieving revision 1.27 diff -u -p -u -p -r1.27 ifmedia.4 --- share/man/man4/ifmedia.416 May 20

Wake on LAN support for rge(4)

2020-12-22 Thread Kevin Lo
Hi, This diff implements WoL support in rge(4). I can wakeup the machine with WoL after suspending it through `zzz` or powering off it through `halt -p`. Index: share/man/man4/rge.4 === RCS file: /cvs/src/share/man/man4/rge.4,v retr

Re: Un-const pci_attach_args var

2020-11-29 Thread Kevin Lo
On Sun, Nov 29, 2020 at 07:00:53PM -0800, Greg Steuck wrote: > > Kevin Lo writes: > > > ok? > > I guess your goal was consistency (though I'd prefer the opposite > direction). There's one more case: > > ./dev/pci/if_de.c:4401:struct pci_attach_args

Un-const pci_attach_args var

2020-11-26 Thread Kevin Lo
ok? Index: sys/dev/pci/berkwdt.c === RCS file: /cvs/src/sys/dev/pci/berkwdt.c,v retrieving revision 1.9 diff -u -p -u -p -r1.9 berkwdt.c --- sys/dev/pci/berkwdt.c 8 Sep 2017 05:36:52 - 1.9 +++ sys/dev/pci/berkwdt.c

myx(4): add initialization of sc_sff_lock rwlock

2020-11-25 Thread Kevin Lo
Ok? Index: sys/dev/pci/if_myx.c === RCS file: /cvs/src/sys/dev/pci/if_myx.c,v retrieving revision 1.111 diff -u -p -u -p -r1.111 if_myx.c --- sys/dev/pci/if_myx.c17 Jul 2020 03:37:36 - 1.111 +++ sys/dev/pci/if_myx.c

Add PCI ids for Intel 2.5Gb adapters

2020-11-15 Thread Kevin Lo
ok? Index: sys/dev/pci/pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.1942 diff -u -p -u -p -r1.1942 pcidevs --- sys/dev/pci/pcidevs 28 Oct 2020 18:49:03 - 1.1942 +++ sys/dev/pci/pcidevs 16 Nov 202

cap_mkdb: remove igetnext prototype for the function does not exist

2020-09-14 Thread Kevin Lo
ok? Index: usr.bin/cap_mkdb/cap_mkdb.c === RCS file: /cvs/src/usr.bin/cap_mkdb/cap_mkdb.c,v retrieving revision 1.24 diff -u -p -u -p -r1.24 cap_mkdb.c --- usr.bin/cap_mkdb/cap_mkdb.c 28 Jun 2019 14:20:40 - 1.24 +++ usr.bin/c

Re: sdmmc(4): add UHS-I support

2020-08-18 Thread Kevin Lo
On Mon, Aug 17, 2020 at 12:57:58PM +0200, Mark Kettenis wrote: > > > Date: Sun, 16 Aug 2020 19:32:03 +0200 (CEST) > > From: Mark Kettenis > > > > The diff below adds support for higher speeds as supported by UHS-I SD > > cards to the generic sdmmc(4) layer. The diff in itself does not > > enabl

Improve ure(4) performance

2020-07-20 Thread Kevin Lo
Hi, Jonathon Fletcher has been helping get the better performance out of ure(4). I ran the tcpbench with ure (RTL8156) for 5 minutes: 71538432760 bytes sent over 300.999 seconds bandwidth min/avg/max/std-dev = 12.071/1901.448/1947.873/135.283 Mbps A big thanks to Jonathon for his hard work. ok?

rge(4): support for Realtek RTL8125B

2020-07-17 Thread Kevin Lo
2019/11/18 22:09:59 jmc Exp $ .\" -.\" Copyright (c) 2019 Kevin Lo +.\" Copyright (c) 2019, 2020 Kevin Lo .\" .\" Permission to use, copy, modify, and distribute this software for any .\" purpose with or without fee is hereby granted, provided that the above @@ -

Initialize sis_ring_init() 'sis_rx_prod' and 'sis_rx_cons' to 0

2020-07-15 Thread Kevin Lo
ok? Index: sys/dev/pci/if_sis.c === RCS file: /cvs/src/sys/dev/pci/if_sis.c,v retrieving revision 1.137 diff -u -p -u -p -r1.137 if_sis.c --- sys/dev/pci/if_sis.c10 Jul 2020 13:26:38 - 1.137 +++ sys/dev/pci/if_sis.c

Re: fix ifconfig joinlist width bug

2020-02-23 Thread Kevin Lo
On Sat, Feb 22, 2020 at 06:38:36PM +0100, Stefan Sperling wrote: > > This fixes display of hex SSIDs in 'ifconfig joinlist' and prevents a > negative number being passed to printf on the following line when 'maxlen' > ends up being capped below the maximum value returned from len_string(): > >

Re: ifconfig man page fix

2020-02-23 Thread Kevin Lo
On Sat, Feb 22, 2020 at 06:40:39PM +0100, Stefan Sperling wrote: > > SSIDs are required to contain printable ASCII only. > Otherwise, they must be specified in hex. > > Let's document this explicitly. ok kevlo@ > diff c20bd74017ceeadb2db0f78a352ed1f1e2b77c2b /usr/src > blob - 3fb0780ba7cf133389

Enable rge(4) on arm64

2020-02-02 Thread Kevin Lo
Hi, I'd like to enable rge(4) on arm64. Tested on rockpro64: https://0x0.st/iztI.txt ok? Index: sys/arch/arm64/conf/GENERIC === RCS file: /cvs/src/sys/arch/arm64/conf/GENERIC,v retrieving revision 1.140 diff -u -p -u -p -r1.140 GENE

Re: ublink(4), led(4) and ledctl(1)

2019-12-15 Thread Kevin Lo
On Fri, Dec 13, 2019 at 10:34:59PM +0100, Patrick Wildt wrote: > > Hi, > > I have a ThingM blink(1) USB RGB device that shows up as uhid(4). > The tooling is "interesting", especially with all those libusb and > HID libraries doing the abstraction. This introduces ublink(4), a > dedicated kernel

ure(4): add preliminary support for RTL8156

2019-12-03 Thread Kevin Lo
Hi, This diff adds preliminary support for RTL8156 to ure(4). Tested with the Planex USB-LAN2500R. Index: share/man/man4/ure.4 === RCS file: /cvs/src/share/man/man4/ure.4,v retrieving revision 1.6 diff -u -p -u -p -r1.6 ure.4 --- sha

Re: sdhc(4): no 0V one some Intel

2019-11-19 Thread Kevin Lo
On Tue, Nov 19, 2019 at 10:44:54AM +0100, Patrick Wildt wrote: > > Hi, Hi Patrick, > on some GPD Pocket mlarkin@ has the eMMC doesn't come up. One issue > is that we shouldn't go to 0V on some/most(?) Intel controllers. This > only adds it for his machine, but I know that the Appollo Lake vers

re(4): set isr to the correct value

2019-11-17 Thread Kevin Lo
Hi, This diff sets isr to the correct value (sc->rl_intrs). While here don't assign ifp twice in the same function. Tested with: re0 at pci2 dev 0 function 0 "Realtek 8168" rev 0x15: RTL8168H/8111H (0x5400), msi, address d8:cb:8a:xx:xx:xx re0 at pci3 dev 0 function 0 "Realtek 8168" rev 0x0c: RT

Re: Support for Realtek RTL8125 2.5Gb Ethernet controller

2019-11-17 Thread Kevin Lo
On Mon, Nov 18, 2019 at 07:08:33AM +1000, Jonathan Matthew wrote: > > On Fri, Nov 15, 2019 at 03:44:24PM +0800, Kevin Lo wrote: > > Hi, > > > > The following diff adds support for Realtek RTL8125 chip. > > Tested with Syba SD-PEX24065. > > > > Test repo

Re: iwm: support 9260 devices

2019-11-17 Thread Kevin Lo
On Sat, Nov 16, 2019 at 10:01:44PM -0800, Philip Guenther wrote: > > On Sat, Nov 16, 2019 at 8:19 AM Stefan Sperling wrote: > > > On Sat, Nov 16, 2019 at 04:51:44PM +0100, Stefan Sperling wrote: > > > This diff adds support for iwm(4) 9260 devices and hopefully 9560 > > > devices as well but I h

Support for Realtek RTL8125 2.5Gb Ethernet controller

2019-11-14 Thread Kevin Lo
:00:00 - +++ share/man/man4/rge.415 Nov 2019 07:24:51 - @@ -0,0 +1,55 @@ +.\" $OpenBSD$ +.\" +.\" Copyright (c) 2019 Kevin Lo +.\" +.\" Permission to use, copy, modify, and distribute this software for any +.\" purpose with or without fee is hereby gr

Re: iwm: fix support for 3168 devices

2019-11-11 Thread Kevin Lo
On Mon, Nov 11, 2019 at 06:33:39PM +0200, Stefan Sperling wrote: > > On Mon, Nov 11, 2019 at 10:19:12AM +0800, Kevin Lo wrote: > > On Sat, Nov 09, 2019 at 01:01:39PM +0200, Stefan Sperling wrote: > > > > > > This diff makes 3168 devices actually work with iwm(4).

Re: iwm: fix support for 3168 devices

2019-11-10 Thread Kevin Lo
On Sat, Nov 09, 2019 at 01:01:39PM +0200, Stefan Sperling wrote: > > This diff makes 3168 devices actually work with iwm(4). > These devices have never worked right since the driver just threw > errors when trying to load firmware. Indeed. The 3168 device didn't work for me (for example, ifconfi

Re: iwm: support dynamic queue allocation (DQA)

2019-10-15 Thread Kevin Lo
On Mon, Oct 14, 2019 at 01:51:02PM +0200, Stefan Sperling wrote: > > Newer iwm firmware requires the driver to use a feature known as > dynamic queue allocation (DQA). What matters is that the command queue > index was changed. Newer firmware images have stopped responding to > commands sent with

Argument order fix for MCLGETI

2019-09-25 Thread Kevin Lo
ok? Index: sys/dev/ic/ti.c === RCS file: /cvs/src/sys/dev/ic/ti.c,v retrieving revision 1.25 diff -u -p -u -p -r1.25 ti.c --- sys/dev/ic/ti.c 22 Jan 2017 10:17:38 - 1.25 +++ sys/dev/ic/ti.c 25 Sep 2019 08:06:26 -

Re: ure(4): add support for rtl8153b

2019-08-27 Thread Kevin Lo
On Tue, Aug 27, 2019 at 06:48:43AM +0100, Jason McIntyre wrote: > > On Tue, Aug 27, 2019 at 10:50:05AM +0800, Kevin Lo wrote: > > Hi, > > > > The diff below adds support for RTL8153B to ure(4). > > Tested on Totolink u1003. > > > > morning. the chan

Re: ure(4): add support for rtl8153b

2019-08-26 Thread Kevin Lo
On Tue, Aug 27, 2019 at 12:34:55PM +0800, Kevin Lo wrote: > On Tue, Aug 27, 2019 at 10:50:05AM +0800, Kevin Lo wrote: > > > > Hi, > > > > The diff below adds support for RTL8153B to ure(4). > > Tested on Totolink u1003. > > I should mentio

Re: ure(4): add support for rtl8153b

2019-08-26 Thread Kevin Lo
On Tue, Aug 27, 2019 at 10:50:05AM +0800, Kevin Lo wrote: > > Hi, > > The diff below adds support for RTL8153B to ure(4). > Tested on Totolink u1003. I should mention that it's based on Linux r8152 driver.

ure(4): add support for rtl8153b

2019-08-26 Thread Kevin Lo
2 Nov 2018 21:32:30 - 1.10 +++ sys/dev/usb/if_ure.c27 Aug 2019 02:36:48 - @@ -1,6 +1,6 @@ /* $OpenBSD: if_ure.c,v 1.10 2018/11/02 21:32:30 jcs Exp $ */ /*- - * Copyright (c) 2015-2016 Kevin Lo + * Copyright (c) 2015, 2016, 2019 Kevin Lo * All rights reserved.

Re: net80211: remove redundant assignment to ic_curmode

2019-08-25 Thread Kevin Lo
On Sun, Aug 25, 2019 at 03:11:52PM +0200, Stefan Sperling wrote: > > This assigment to ic_curmode is redundant because it already occurs > inside ieee80211_setmode(), and channel information in selbs and ni > is equivalent after node_copy(). > > ok? ok kevlo@

remove duplicate definitions of LAPIC_ID_MASK and LAPIC_ID_SHIFT

2019-07-25 Thread Kevin Lo
ok? Index: sys/arch/amd64/include/i82489reg.h === RCS file: /cvs/src/sys/arch/amd64/include/i82489reg.h,v retrieving revision 1.4 diff -u -p -u -p -r1.4 i82489reg.h --- sys/arch/amd64/include/i82489reg.h 21 Jul 2015 04:48:33 -

ure and url need ifmedia attribute

2019-07-08 Thread Kevin Lo
ok? Index: sys/dev/usb/files.usb === RCS file: /cvs/src/sys/dev/usb/files.usb,v retrieving revision 1.139 diff -u -p -u -p -r1.139 files.usb --- sys/dev/usb/files.usb 7 Jun 2019 16:06:59 - 1.139 +++ sys/dev/usb/files.u

remove duplicate code

2019-07-05 Thread Kevin Lo
ok? Index: sys/dev/usb/if_axe.c === RCS file: /cvs/src/sys/dev/usb/if_axe.c,v retrieving revision 1.138 diff -u -p -u -p -r1.138 if_axe.c --- sys/dev/usb/if_axe.c22 Jan 2017 10:17:39 - 1.138 +++ sys/dev/usb/if_axe.c

ext2fs: more verbose messages about unsupported ext2fs features

2019-06-27 Thread Kevin Lo
Hi, It may be useful for users to know which ext2fs features are not supported. This patch adds more verbose messages mostly based on FreeBSD's r320578. w/o patch: ext2fs: unsupported incompat features 0x2c2 w/ patch: ext2fs: unsupported incompat features: 64bit Index: sys/ufs/ext2fs/ext2fs.h =

Re: elf(5): mention the ELF machine type EM_AARCH64

2019-06-17 Thread Kevin Lo
On Mon, Jun 17, 2019 at 06:15:16PM +1000, Jonathan Gray wrote: > > On Mon, Jun 17, 2019 at 02:45:28PM +0800, Kevin Lo wrote: > > ok? > > The header also includes EM_PPC64 which isn't documented > (and EM_X86_64 which should probably be kept not documented). Documented EM_PPC64, thanks.

elf(5): mention the ELF machine type EM_AARCH64

2019-06-16 Thread Kevin Lo
ok? Index: share/man/man5/elf.5 === RCS file: /cvs/src/share/man/man5/elf.5,v retrieving revision 1.34 diff -u -p -u -p -r1.34 elf.5 --- share/man/man5/elf.527 Oct 2017 08:36:42 - 1.34 +++ share/man/man5/elf.5

Re: upgt: use timeout_add_msec(9)

2019-06-14 Thread Kevin Lo
On Thu, Jun 13, 2019 at 11:23:55PM +0200, Klemens Nanni wrote: > > Same as with urtw(4) but a tad more obvious: > > /usr/include/dev/usb/if_upgtvar.h > 312:#define UPGT_LED_ACTION_TMP_DUR 100 /* ms */ > > OK? I don't have upgt(4), but it looks good to me. > Index: sys/d

Re: urtw: use timeout_add_msec(9)

2019-06-14 Thread Kevin Lo
On Thu, Jun 13, 2019 at 11:12:23PM +0200, Klemens Nanni wrote: > > Simple sleeps for 100ms that currently use a timeval to specify > miliseconds, convert them to Hz with tvtohz(9) so they can be converted > back by timeout_add(9) - we can do better by now. > > I lack appropiate hardware, but the

Re: iwm: fix ADD_STA status check

2019-05-08 Thread Kevin Lo
On Wed, May 08, 2019 at 03:26:00PM -0400, Stefan Sperling wrote: > > Correctly mask status bits in ADD_STA command response; remaining > bits are used by firmware to return the baid for a BA session. > > Dragonfly 74d41163ddac72b0d7ea7b7873d53fe134723a12 > Linux 837c4da98481d4e504b2aba077c8528fee

Re: iwm: rx interrupt paranoia

2019-05-08 Thread Kevin Lo
On Wed, May 08, 2019 at 02:54:50PM -0400, Stefan Sperling wrote: > > Add two sanity checks to iwm's firmware notification interrupt handler: > > 1) Clamp the firmware-provided index into the rx ring to the size of the ring. > Linux started doing this, too, to work around HW bugs in the 9000 serie

Re: ifmedia_ioctl: ignore ENETRESET from ifm_change()

2019-04-21 Thread Kevin Lo
On Sun, Apr 21, 2019 at 01:02:39PM +1000, Jonathan Matthew wrote: > > On Mon, Apr 15, 2019 at 04:48:02PM +0200, Stefan Sperling wrote: > > ieee80211_media_change() will return ENETRESET if the interface is > > switched into 11a/b/g/n mode from any other mode. > > ifmedia_ioctl() considers this an

ure(4): fix URE_WDT6_SET_MODE register definition

2019-04-09 Thread Kevin Lo
Hi, Based on FreeBSD r346028, this fixes ure(4) not detected after a reboot. Tested: ure0 at uhub0 port 4 configuration 1 interface 0 "Realtek USB 10/100 LAN" rev 2.10/20.00 addr 3 ure0: ver 4c10, address 00:e0:4c:xx:xx:xx rlphy0 at ure0 phy 0: RTL8201E 10/100 PHY, rev. 2 ure0 at uhub0 port 4 c

fix the gpio pin for ar9287-based usb devices

2019-03-31 Thread Kevin Lo
Hi, AR9287-based usb devices use GPIO pin 10 for LED, not 8. Tested with TP-LINK TL-WN821N V3. ok? Index: sys/dev/ic/ar9287.c === RCS file: /cvs/src/sys/dev/ic/ar9287.c,v retrieving revision 1.27 diff -u -p -u -p -r1.27 ar9287.c ---

Re: cleanup FBSDID

2019-03-14 Thread Kevin Lo
Here's the revised diff that removes $FreeBSD$ IDs from my previous diff. Index: lib/libc/arch/amd64/sys/tfork_thread.S === RCS file: /cvs/src/lib/libc/arch/amd64/sys/tfork_thread.S,v retrieving revision 1.6 diff -u -p -u -p -r1.6 tfo

cleanup FBSDID

2019-03-12 Thread Kevin Lo
ok? Index: lib/libc/arch/amd64/sys/tfork_thread.S === RCS file: /cvs/src/lib/libc/arch/amd64/sys/tfork_thread.S,v retrieving revision 1.6 diff -u -p -u -p -r1.6 tfork_thread.S --- lib/libc/arch/amd64/sys/tfork_thread.S 7 May 2016

Re: athn(4): enable more calibration

2019-01-30 Thread Kevin Lo
On Tue, Jan 29, 2019 at 09:11:42PM +0100, Stefan Sperling wrote: > > The diff below enables periodic ADC/IQ calibration on athn(4) devices. > Without this calibration athn devices might perform suboptimally > as they warm up during operation. > > The code is already there, it was just not being c

Re: [patch] urtwn(4): accept control frames when in monitor mode

2019-01-24 Thread Kevin Lo
On Wed, Jan 23, 2019 at 09:50:18AM +0100, Jesper Wallin wrote: > > Hi, > > This patch will allow urtwn(4) to see control frames when monitor mode > is enabled. I've only tested this with my TP-LINK TL-WN821N v5 card, so > perhaps more checks are needed to avoid breaking other cards. > > If you

Add PCI IDs for Intel Apollo Lake SoC

2018-12-16 Thread Kevin Lo
Hi, Diff below adds PCI product IDs found on Intel Leaf Hill CRB, ok? Index: sys/dev/pci/pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.1871 diff -u -p -u -p -r1.1871 pcidevs --- sys/dev/pci/pcidevs 16 Dec

Re: ure(4): VLANs and Jumbo frames

2018-10-30 Thread Kevin Lo
On Tue, Oct 30, 2018 at 10:57:08AM +0100, Patrick Wildt wrote: > On Tue, Oct 30, 2018 at 05:30:55PM +0800, Kevin Lo wrote: > > On Tue, Oct 30, 2018 at 09:43:08AM +0100, Patrick Wildt wrote: > > > + if (sc->ure_flags & URE_FLAG_8152) > > > + ifp-&g

Re: ure(4): VLANs and Jumbo frames

2018-10-30 Thread Kevin Lo
On Tue, Oct 30, 2018 at 09:43:08AM +0100, Patrick Wildt wrote: > > Hi, > > I recently wanted to use VLANs on ure(4) but failed. As it turns out, > hardmtu is set to 1500 which apparently does not leave enough space > for the VLAN tag. It looks like the Gigabit Version does even support > Jumbo

Re: ral(4): add RT3290 support

2018-09-25 Thread Kevin Lo
On Mon, Sep 17, 2018 at 09:34:06PM -0400, James Hastings wrote: > > > Ported from original vendor driver. > RT3290 is similar to RT5390 but integrates WLAN + Bluetooth on single chip. > Bluetooth not supported. First off, thank you for working on this. I tested it on amd64, ifconfig ral0 up wil

  1   2   >