On Thu, Jun 13, 2019 at 11:23:55PM +0200, Klemens Nanni wrote:
> 
> Same as with urtw(4) but a tad more obvious:
> 
> /usr/include/dev/usb/if_upgtvar.h
> 312:#define UPGT_LED_ACTION_TMP_DUR             100             /* ms */
> 
> OK?

I don't have upgt(4), but it looks good to me.

> Index: sys/dev/usb/if_upgt.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/usb/if_upgt.c,v
> retrieving revision 1.83
> diff -u -p -r1.83 if_upgt.c
> --- sys/dev/usb/if_upgt.c     25 Apr 2019 01:52:14 -0000      1.83
> +++ sys/dev/usb/if_upgt.c     13 Jun 2019 21:18:37 -0000
> @@ -2014,7 +2014,6 @@ upgt_set_led(struct upgt_softc *sc, int 
>       struct upgt_data *data_cmd = &sc->cmd_data;
>       struct upgt_lmac_mem *mem;
>       struct upgt_lmac_led *led;
> -     struct timeval t;
>       int len;
>  
>       /*
> @@ -2063,9 +2062,7 @@ upgt_set_led(struct upgt_softc *sc, int 
>               led->action_tmp_dur = htole16(UPGT_LED_ACTION_TMP_DUR);
>               /* lock blink */
>               sc->sc_led_blink = 1;
> -             t.tv_sec = 0;
> -             t.tv_usec = UPGT_LED_ACTION_TMP_DUR * 1000L;
> -             timeout_add(&sc->led_to, tvtohz(&t));
> +             timeout_add_msec(&sc->led_to, UPGT_LED_ACTION_TMP_DUR);
>               break;
>       default:
>               return;
> 
> 

Reply via email to