Split `uipc_dgram_usrreqs' out from `uipc_usrreqs'

2022-11-05 Thread Vitaliy Makkoveev
guenther@ proposed to split out handlers for SOCK_DGRAM unix(4) sockets from SOCK_STREAM and SOCK_SEQPACKET. The diff below introduces `uipc_dgram_usrreqs' to store pointers to dgram specific handlers. The dgram pru_shutdown and pru_send handlers were splitted to uipc_dgram_shutdown() and uipc_dg

installer: MD post-install instructions on upgrades?

2022-11-05 Thread Klemens Nanni
Upgrades are noiser on macppc (and loongson and octeon) than on other architectures because boot firmware changes and/or tips to complete an OpenBSD installation are always printed, even though they are not needed after an upgrade: INSTALL.macppc describes how to configure Open Firmware to

Re: em(4) IPv4, TCP, UDP checksum offloading

2022-11-05 Thread Moritz Buhl
Looking for OKs. On Sat, Oct 15, 2022 at 10:01:53PM +0200, Moritz Buhl wrote: > With the previous diffs I am seeing sporadic connection problems in tcpbench > via IPv6 on Intel 82546GB. > The diff was too big anyways. Here is a smaller diff that introduces > checksum offloading for the controllers

Re: special case mpe(4) in in6_ifattach()

2022-11-05 Thread David Gwynne
On Fri, Nov 04, 2022 at 03:40:04PM +0100, Claudio Jeker wrote: > So mpe(4) is a special device. It is a point-to-multipoint interface that > does not do multicast. So setting IFF_MULTICAST on the interface is not > correct but IPv6 depends on it because neighbor discovery. > > Now there is no neig

Re: resolvd: write nameservers in expected order

2022-11-05 Thread Klemens Nanni
On Sat, Nov 05, 2022 at 05:40:49AM -0600, Theo de Raadt wrote: > + if (mergesort(learning, ASR_MAXNS, sizeof(learning[0]), cmp) == -1) > + lerr(1, "mergesort"); > > So at runtime if mergesort() fails to allocate memory, the program will > simply exit? Ah no, that should just s

Re: resolvd: write nameservers in expected order

2022-11-05 Thread Theo de Raadt
+ if (mergesort(learning, ASR_MAXNS, sizeof(learning[0]), cmp) == -1) + lerr(1, "mergesort"); So at runtime if mergesort() fails to allocate memory, the program will simply exit?

Re: resolvd: write nameservers in expected order

2022-11-05 Thread Klemens Nanni
On Thu, Nov 03, 2022 at 10:27:53PM +, Klemens Nanni wrote: > RFC 2132 "DHCP Options and BOOTP Vendor Extensions" > 3.8. Domain Name Server Option says: > >The domain name server option specifies a list of Domain Name System >(STD 13, RFC 1035 [8]) name servers available to the client.

Re: Questions about the code review process in OpenBSD

2022-11-05 Thread Theo de Raadt
That is not your responsibility. It is mine. You can stop asking. >I am trying to understand how the code review process is conducted in >OpenBSD. I can see all the OK's in the commit log, but not every commit >has the OK. > >On FreeBSD there where a serious problem with a developer who was hire