Re: snmpd(8): New application layer - step towards agentx support

2021-11-30 Thread Martijn van Duren
On Sun, 2021-11-21 at 14:58 +0100, Martijn van Duren wrote: > On Sun, 2021-11-14 at 14:35 +, Stuart Henderson wrote: > > On 2021/11/14 11:49, Martijn van Duren wrote: > > > sthen@ found an issue when using this diff with netsnmp tools. > > > > > > The problem was that I put the requestID in th

Re: Fix ipsp_spd_lookup() for transport mode

2021-11-30 Thread Alexander Bluhm
On Tue, Nov 30, 2021 at 05:53:34PM +0300, Vitaliy Makkoveev wrote: > Hi, > > This question is mostly for bluhm@. Should the gettdbbyflow() grab the > extra reference on returned `tdbp' like other other gettdb*() do? I'm > pointing this because we are going to not rely on the netlock when doing > `

Re: ifconfig description for wireguard peers

2021-11-30 Thread Stefan Sperling
On Tue, Nov 30, 2021 at 02:31:20PM -0500, Noah Meier wrote: > Hi Stefan, > > Richard Procter offered some kind advice on the ordering of options in the > man page > (to be done alphabetically) and commented on an unnecessary cast. > > I also believe that I goofed by failing to initalize the mute

ipsp_spd_lookup error

2021-11-30 Thread Alexander Bluhm
Hi, I want to ref count the TDB that is returned by ipsp_spd_lookup(). Sometimes the TDB returned by ipsp_spd_lookup() is not used. So refcounting that, does not make sense. As a first step I want to convert ipsp_spd_lookup() to return an error. - tdb = ipsp_spd_lookup(&error) + error = ipsp_s

Re: lib/Makefile: libfido2 requires libz

2021-11-30 Thread Patrick Wildt
On Tue, Nov 30, 2021 at 03:24:17PM -0700, Theo de Raadt wrote: > Todd C. Miller wrote: > > > On Tue, 30 Nov 2021 23:18:23 +0100, Mark Kettenis wrote: > > > > > Maybe add a comment here that libfido2 depends on libz? > > > > > > > +SUBDIR+=libfido2 > > > > Yes, please. With a comment this is OK

Re: lib/Makefile: libfido2 requires libz

2021-11-30 Thread Theo de Raadt
Todd C. Miller wrote: > On Tue, 30 Nov 2021 23:18:23 +0100, Mark Kettenis wrote: > > > Maybe add a comment here that libfido2 depends on libz? > > > > > +SUBDIR+=libfido2 > > Yes, please. With a comment this is OK millert@ Or just mark these as "phase 2", without saying why.

Re: lib/Makefile: libfido2 requires libz

2021-11-30 Thread Todd C . Miller
On Tue, 30 Nov 2021 23:18:23 +0100, Mark Kettenis wrote: > Maybe add a comment here that libfido2 depends on libz? > > > +SUBDIR+=libfido2 Yes, please. With a comment this is OK millert@ - todd

Re: lib/Makefile: libfido2 requires libz

2021-11-30 Thread Mark Kettenis
> Date: Tue, 30 Nov 2021 23:04:49 +0100 > From: Patrick Wildt > > On Thu, Nov 11, 2021 at 08:27:21PM +0900, SASANO Takayoshi wrote: > > Hi, > > > > Recently I tried to crossbuild for arm64 on amd64. > > I found "TARGET=arm64 make cross-tools" stops when building libfido2. > > > > libfido2 requi

Re: lib/Makefile: libfido2 requires libz

2021-11-30 Thread Patrick Wildt
On Thu, Nov 11, 2021 at 08:27:21PM +0900, SASANO Takayoshi wrote: > Hi, > > Recently I tried to crossbuild for arm64 on amd64. > I found "TARGET=arm64 make cross-tools" stops when building libfido2. > > libfido2 requires libz but this is not built yet at that time. > lib/Makefile needs to tweak l

Re: ifconfig description for wireguard peers

2021-11-30 Thread Noah Meier
Hi Stefan, Richard Procter offered some kind advice on the ordering of options in the man page (to be done alphabetically) and commented on an unnecessary cast. I also believe that I goofed by failing to initalize the mutex and zero the description upon peer creation (in wg_peer_create). I’ve

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-11-30 Thread Sebastien Marie
On Tue, Nov 30, 2021 at 07:17:14PM +0100, Jan Stary wrote: > > While here, I notice that sysctl.witness.watch is documented > in witness(4), but kern.witness.locktrace is not - is that intended? > It is documented on options(4) option WITNESS_LOCKTRACE Enable witness(4) lock stack tr

Re: dhcpleased - set ciaddr per RFC

2021-11-30 Thread Florian Obser
I'm making a fine mess off this :( On 2021-11-25 10:23 -07, Joel Knight wrote: > On Wed, Nov 24, 2021 at 4:46 AM Florian Obser wrote: > >> Thanks, I had indeed missed this. I went through the RFC and found that >> we MUST NOT send the server identifier in rebooting state. While here I >> also ma

[patch] urndis: uncomment watchdog

2021-11-30 Thread Mikhail
Currently watchdog functionality for urndis driver is disabled (commented), I've tested it and it works properly - reset messages are correctly sent and cmplt packets are received according to RNDIS spec (I patched the driver to forcedly send reset message and act on it with device reset every 5 se

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-11-30 Thread Jan Stary
On Nov 30 10:40:25, s...@spacehopper.org wrote: > On 2021/11/29 22:50, Martin Pieuchot wrote: > > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > > Diff below unlock the bottom part of the UVM fault handler. I'm > > > interested in squashing the remaining bugs. Please test with your usual > >

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-11-30 Thread Alexander Bluhm
On Mon, Nov 29, 2021 at 10:50:32PM +0100, Martin Pieuchot wrote: > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > Diff below unlock the bottom part of the UVM fault handler. I'm > > interested in squashing the remaining bugs. Please test with your usual > > setup & report back. > > Thanks to

Re: Rework UNIX sockets locking to be fine grained

2021-11-30 Thread Vitaliy Makkoveev
Include missing "sys/refcnt.h" header to unpcb.h to fix libkvm and netstat(1) build. No functional changes. Index: sys/kern/uipc_socket.c === RCS file: /cvs/src/sys/kern/uipc_socket.c,v retrieving revision 1.269 diff -u -p -r1.269 uip

Re: vmm(4): restore vmcs after sleep points [vmx 2/3]

2021-11-30 Thread Dave Voutila
Dave Voutila writes: > This diff removes instability from VMX-based hosts by either removing > the possibility of the process sleeping while the VMCS is active or > reloading it if we had no choice. > > A mutex is added to help guard the VMCS state so testing with witness > has helped verify th

Revised version of kqueue-based poll(2)

2021-11-30 Thread Visa Hankala
Here is a revised version of kqueue-based poll(2). The two most important changes to the previous version are: * Properly handle pollfd arrays where more than one entries refer to the same file descriptor. * Fix poll(2)'s return value. The first change would be somewhat tricky with plain kque

Re: Fix ipsp_spd_lookup() for transport mode

2021-11-30 Thread Vitaliy Makkoveev
Hi, This question is mostly for bluhm@. Should the gettdbbyflow() grab the extra reference on returned `tdbp' like other other gettdb*() do? I'm pointing this because we are going to not rely on the netlock when doing `tdbp' dereference. Also could this block be rewritten? It looks a little ugly.

Re: Please test: UVM fault unlocking (aka vmobjlock)

2021-11-30 Thread Stuart Henderson
On 2021/11/29 22:50, Martin Pieuchot wrote: > On 24/11/21(Wed) 11:16, Martin Pieuchot wrote: > > Diff below unlock the bottom part of the UVM fault handler. I'm > > interested in squashing the remaining bugs. Please test with your usual > > setup & report back. > > Thanks to all the testers, her